diff options
author | pilgrim@chromium.org <pilgrim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-11 14:30:09 +0000 |
---|---|---|
committer | pilgrim@chromium.org <pilgrim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-11 14:30:09 +0000 |
commit | 4851a0ead475dbe196e8acea60f8119abcaf32bb (patch) | |
tree | af45241478b1ce9e6424b4f293e81731ba7028ab | |
parent | dd945647c2889098726cd2327f79a7f3160f937b (diff) | |
download | chromium_src-4851a0ead475dbe196e8acea60f8119abcaf32bb.zip chromium_src-4851a0ead475dbe196e8acea60f8119abcaf32bb.tar.gz chromium_src-4851a0ead475dbe196e8acea60f8119abcaf32bb.tar.bz2 |
Remove MakeSqliteAppCacheDbTest
jam says this is obsolete/unused
Also breaks chrome->appcache_interfaces.h dependency
BUG=338338
Review URL: https://codereview.chromium.org/327823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276389 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/diagnostics/diagnostics_model.cc | 11 | ||||
-rw-r--r-- | chrome/browser/diagnostics/sqlite_diagnostics.cc | 10 | ||||
-rw-r--r-- | chrome/browser/diagnostics/sqlite_diagnostics.h | 1 |
3 files changed, 4 insertions, 18 deletions
diff --git a/chrome/browser/diagnostics/diagnostics_model.cc b/chrome/browser/diagnostics/diagnostics_model.cc index 1216bf0..ff28065 100644 --- a/chrome/browser/diagnostics/diagnostics_model.cc +++ b/chrome/browser/diagnostics/diagnostics_model.cc @@ -24,14 +24,14 @@ namespace diagnostics { // This is the count of diagnostic tests on each platform. This should // only be used by testing code. #if defined(OS_WIN) -const int DiagnosticsModel::kDiagnosticsTestCount = 19; +const int DiagnosticsModel::kDiagnosticsTestCount = 18; #elif defined(OS_MACOSX) -const int DiagnosticsModel::kDiagnosticsTestCount = 15; +const int DiagnosticsModel::kDiagnosticsTestCount = 14; #elif defined(OS_POSIX) #if defined(OS_CHROMEOS) -const int DiagnosticsModel::kDiagnosticsTestCount = 19; +const int DiagnosticsModel::kDiagnosticsTestCount = 18; #else -const int DiagnosticsModel::kDiagnosticsTestCount = 17; +const int DiagnosticsModel::kDiagnosticsTestCount = 16; #endif #endif @@ -166,7 +166,6 @@ class DiagnosticsModelWin : public DiagnosticsModelImpl { tests_.push_back(MakeSqliteHistoryDbTest()); tests_.push_back(MakeSqliteArchivedHistoryDbTest()); tests_.push_back(MakeSqliteThumbnailsDbTest()); - tests_.push_back(MakeSqliteAppCacheDbTest()); tests_.push_back(MakeSqliteWebDatabaseTrackerDbTest()); } @@ -191,7 +190,6 @@ class DiagnosticsModelMac : public DiagnosticsModelImpl { tests_.push_back(MakeSqliteHistoryDbTest()); tests_.push_back(MakeSqliteArchivedHistoryDbTest()); tests_.push_back(MakeSqliteThumbnailsDbTest()); - tests_.push_back(MakeSqliteAppCacheDbTest()); tests_.push_back(MakeSqliteWebDatabaseTrackerDbTest()); } @@ -218,7 +216,6 @@ class DiagnosticsModelPosix : public DiagnosticsModelImpl { tests_.push_back(MakeSqliteHistoryDbTest()); tests_.push_back(MakeSqliteArchivedHistoryDbTest()); tests_.push_back(MakeSqliteThumbnailsDbTest()); - tests_.push_back(MakeSqliteAppCacheDbTest()); tests_.push_back(MakeSqliteWebDatabaseTrackerDbTest()); #if defined(OS_CHROMEOS) tests_.push_back(MakeSqliteNssCertDbTest()); diff --git a/chrome/browser/diagnostics/sqlite_diagnostics.cc b/chrome/browser/diagnostics/sqlite_diagnostics.cc index 840d525..6a92c9d 100644 --- a/chrome/browser/diagnostics/sqlite_diagnostics.cc +++ b/chrome/browser/diagnostics/sqlite_diagnostics.cc @@ -24,7 +24,6 @@ #include "sql/statement.h" #include "third_party/sqlite/sqlite3.h" #include "webkit/browser/database/database_tracker.h" -#include "webkit/common/appcache/appcache_interfaces.h" namespace diagnostics { @@ -201,15 +200,6 @@ class SqliteIntegrityTest : public DiagnosticsTest { } // namespace -DiagnosticsTest* MakeSqliteAppCacheDbTest() { - base::FilePath appcache_dir(content::kAppCacheDirname); - base::FilePath appcache_db = - appcache_dir.Append(appcache::kAppCacheDatabaseName); - return new SqliteIntegrityTest(SqliteIntegrityTest::NO_FLAGS_SET, - DIAGNOSTICS_SQLITE_INTEGRITY_APP_CACHE_TEST, - appcache_db); -} - DiagnosticsTest* MakeSqliteArchivedHistoryDbTest() { return new SqliteIntegrityTest( SqliteIntegrityTest::NO_FLAGS_SET, diff --git a/chrome/browser/diagnostics/sqlite_diagnostics.h b/chrome/browser/diagnostics/sqlite_diagnostics.h index 5058ef0..7c09815 100644 --- a/chrome/browser/diagnostics/sqlite_diagnostics.h +++ b/chrome/browser/diagnostics/sqlite_diagnostics.h @@ -21,7 +21,6 @@ enum SQLiteIntegrityOutcomeCode { }; // Factories for the database integrity tests we run in diagnostic mode. -DiagnosticsTest* MakeSqliteAppCacheDbTest(); DiagnosticsTest* MakeSqliteArchivedHistoryDbTest(); DiagnosticsTest* MakeSqliteCookiesDbTest(); DiagnosticsTest* MakeSqliteHistoryDbTest(); |