diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-07 02:53:11 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-07 02:53:11 +0000 |
commit | 49aeab656a882c9da0fc2cc2be61df3bd223c16e (patch) | |
tree | f5e8d48e54c1a714177464f117eff5ea4b8e0dff | |
parent | 7dd589fdca699d6618228bffa6d3be23f4c4c5a2 (diff) | |
download | chromium_src-49aeab656a882c9da0fc2cc2be61df3bd223c16e.zip chromium_src-49aeab656a882c9da0fc2cc2be61df3bd223c16e.tar.gz chromium_src-49aeab656a882c9da0fc2cc2be61df3bd223c16e.tar.bz2 |
Linux/ChromeOS Chromium style checker cleanup, chrome/browser/extensions edition.
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/12212047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181160 0039d316-1c4b-4281-b951-d872f2087c98
91 files changed, 242 insertions, 226 deletions
diff --git a/chrome/browser/extensions/activity_log_unittest.cc b/chrome/browser/extensions/activity_log_unittest.cc index 0c37cda4..9fea99c 100644 --- a/chrome/browser/extensions/activity_log_unittest.cc +++ b/chrome/browser/extensions/activity_log_unittest.cc @@ -41,7 +41,7 @@ class ActivityLogTest : public ChromeRenderViewHostTestHarness { db_thread_.Start(); } - ~ActivityLogTest() { + virtual ~ActivityLogTest() { base::WaitableEvent done(false, false); BrowserThread::PostTask(BrowserThread::DB, FROM_HERE, base::Bind(&base::WaitableEvent::Signal, base::Unretained(&done))); diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.cc b/chrome/browser/extensions/api/alarms/alarm_manager.cc index a0bf73f..1f322c8 100644 --- a/chrome/browser/extensions/api/alarms/alarm_manager.cc +++ b/chrome/browser/extensions/api/alarms/alarm_manager.cc @@ -37,7 +37,7 @@ class DefaultAlarmDelegate : public AlarmManager::Delegate { virtual ~DefaultAlarmDelegate() {} virtual void OnAlarm(const std::string& extension_id, - const Alarm& alarm) { + const Alarm& alarm) OVERRIDE { scoped_ptr<ListValue> args(new ListValue()); args->Append(alarm.js_alarm->ToValue().release()); scoped_ptr<Event> event(new Event(kOnAlarmEvent, args.Pass())); diff --git a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc index f96a6d8..7470ed8 100644 --- a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc +++ b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc @@ -34,7 +34,7 @@ class AlarmDelegate : public AlarmManager::Delegate { public: virtual ~AlarmDelegate() {} virtual void OnAlarm(const std::string& extension_id, - const Alarm& alarm) { + const Alarm& alarm) OVERRIDE { alarms_seen.push_back(alarm.js_alarm->name); MessageLoop::current()->Quit(); } diff --git a/chrome/browser/extensions/api/api_resource_manager_unittest.cc b/chrome/browser/extensions/api/api_resource_manager_unittest.cc index 84ad0e7..7e75096 100644 --- a/chrome/browser/extensions/api/api_resource_manager_unittest.cc +++ b/chrome/browser/extensions/api/api_resource_manager_unittest.cc @@ -32,7 +32,7 @@ class FakeApiResource : public ApiResource { public: FakeApiResource(const std::string& owner_extension_id) : ApiResource(owner_extension_id) {} - ~FakeApiResource() {} + virtual ~FakeApiResource() {} }; TEST_F(ApiResourceManagerUnitTest, TwoAppsCannotShareResources) { diff --git a/chrome/browser/extensions/api/app/app_apitest.cc b/chrome/browser/extensions/api/app/app_apitest.cc index 6d5f07c..052e164 100644 --- a/chrome/browser/extensions/api/app/app_apitest.cc +++ b/chrome/browser/extensions/api/app/app_apitest.cc @@ -8,7 +8,7 @@ class ExperimentalApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc index 018446b..3f723cc 100644 --- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc +++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc @@ -33,11 +33,11 @@ class TestShellWindowRegistryObserver } // Overridden from ShellWindowRegistry::Observer: - virtual void OnShellWindowAdded(ShellWindow* shell_window) {} - virtual void OnShellWindowIconChanged(ShellWindow* shell_window) { + virtual void OnShellWindowAdded(ShellWindow* shell_window) OVERRIDE {} + virtual void OnShellWindowIconChanged(ShellWindow* shell_window) OVERRIDE { ++icon_updates_; } - virtual void OnShellWindowRemoved(ShellWindow* shell_window) { + virtual void OnShellWindowRemoved(ShellWindow* shell_window) OVERRIDE { } int icon_updates() { return icon_updates_; } diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc index 005ae33..f278e65 100644 --- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc +++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc @@ -723,7 +723,8 @@ class CreateBookmarkBucketMapper : public BookmarkBucketMapper<std::string> { explicit CreateBookmarkBucketMapper(Profile* profile) : profile_(profile) {} // TODO(tim): This should share code with BookmarksCreateFunction::RunImpl, // but I can't figure out a good way to do that with all the macros. - virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) { + virtual void GetBucketsForArgs(const ListValue* args, + BucketList* buckets) OVERRIDE { const DictionaryValue* json; if (!args->GetDictionary(0, &json)) return; @@ -761,7 +762,8 @@ class CreateBookmarkBucketMapper : public BookmarkBucketMapper<std::string> { class RemoveBookmarksBucketMapper : public BookmarkBucketMapper<std::string> { public: explicit RemoveBookmarksBucketMapper(Profile* profile) : profile_(profile) {} - virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) { + virtual void GetBucketsForArgs(const ListValue* args, + BucketList* buckets) OVERRIDE { typedef std::list<int64> IdList; IdList ids; bool invalid_id = false; diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc index 1475cfc..87aa262 100644 --- a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc +++ b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc @@ -65,7 +65,7 @@ class ExtensionBrowsingDataTest : public InProcessBrowserTest, } protected: - virtual void SetUpOnMainThread() { + virtual void SetUpOnMainThread() OVERRIDE { called_with_details_.reset(new BrowsingDataRemover::NotificationDetails()); registrar_.Add(this, chrome::NOTIFICATION_BROWSING_DATA_REMOVED, content::Source<Profile>(browser()->profile())); diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc index bb59d3e..00fabea 100644 --- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc +++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc @@ -22,14 +22,14 @@ using ::testing::_; // A base class for tests below. class ExtensionCloudPrintPrivateApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII(switches::kCloudPrintServiceURL, "http://www.cloudprintapp.com/files/extensions/api_test/" "cloud_print_private"); } - void SetUpInProcessBrowserTestFixture() OVERRIDE { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { // Start up the test server and get us ready for calling the install // API functions. host_resolver()->AddRule("www.cloudprintapp.com", "127.0.0.1"); diff --git a/chrome/browser/extensions/api/cookies/cookies_unittest.cc b/chrome/browser/extensions/api/cookies/cookies_unittest.cc index 6d4ca9c..b9e6ad5 100644 --- a/chrome/browser/extensions/api/cookies/cookies_unittest.cc +++ b/chrome/browser/extensions/api/cookies/cookies_unittest.cc @@ -37,21 +37,21 @@ struct DomainMatchCase { class OtrTestingProfile : public TestingProfile { public: OtrTestingProfile() : linked_profile_(NULL) {} - virtual Profile* GetOriginalProfile() { + virtual Profile* GetOriginalProfile() OVERRIDE { if (IsOffTheRecord()) return linked_profile_; else return this; } - virtual Profile* GetOffTheRecordProfile() { + virtual Profile* GetOffTheRecordProfile() OVERRIDE { if (IsOffTheRecord()) return this; else return linked_profile_; } - virtual bool HasOffTheRecordProfile() { + virtual bool HasOffTheRecordProfile() OVERRIDE { return (!IsOffTheRecord() && linked_profile_); } diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc index 7d4e703..24c13b8 100644 --- a/chrome/browser/extensions/api/debugger/debugger_api.cc +++ b/chrome/browser/extensions/api/debugger/debugger_api.cc @@ -100,7 +100,7 @@ class ExtensionDevToolsClientHost : public DevToolsClientHost, const std::string& extension_name, int tab_id); - ~ExtensionDevToolsClientHost(); + virtual ~ExtensionDevToolsClientHost(); bool MatchesContentsAndExtensionId(WebContents* web_contents, const std::string& extension_id); @@ -123,7 +123,7 @@ class ExtensionDevToolsClientHost : public DevToolsClientHost, // content::NotificationObserver implementation. virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details); + const content::NotificationDetails& details) OVERRIDE; WebContents* web_contents_; std::string extension_id_; diff --git a/chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc b/chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc index 3d57441..4e1ea28 100644 --- a/chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc +++ b/chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc @@ -65,7 +65,7 @@ class RulesRegistryStorageDelegate::Inner friend class base::RefCountedThreadSafe<Inner>; friend class RulesRegistryStorageDelegate; - ~Inner(); + virtual ~Inner(); // Initialization of the storage delegate if it is used in the context of // an incognito profile. diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc index 6677472..eb637cf 100644 --- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc +++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc @@ -60,7 +60,7 @@ class TestWebRequestRulesRegistry : public WebRequestRulesRegistry { virtual ~TestWebRequestRulesRegistry() {} virtual base::Time GetExtensionInstallationTime( - const std::string& extension_id) const { + const std::string& extension_id) const OVERRIDE { if (extension_id == kExtensionId) return base::Time() + base::TimeDelta::FromDays(1); else if (extension_id == kExtensionId2) @@ -69,7 +69,7 @@ class TestWebRequestRulesRegistry : public WebRequestRulesRegistry { return base::Time(); } - virtual void ClearCacheOnNavigation() { + virtual void ClearCacheOnNavigation() OVERRIDE { ++num_clear_cache_calls_; } diff --git a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc index 52ec426..687342a 100644 --- a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc +++ b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc @@ -12,7 +12,7 @@ using extensions::Manifest; class DeveloperPrivateApiTest : public ExtensionApiTest { public: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kAppsDebugger); } diff --git a/chrome/browser/extensions/api/dial/dial_apitest.cc b/chrome/browser/extensions/api/dial/dial_apitest.cc index f5535fe..29a5a0a 100644 --- a/chrome/browser/extensions/api/dial/dial_apitest.cc +++ b/chrome/browser/extensions/api/dial/dial_apitest.cc @@ -24,7 +24,7 @@ class DialAPITest : public ExtensionApiTest { public: DialAPITest() {} - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII( switches::kWhitelistedExtensionID, "ddchlicdkolnonkihahngkmmmjnjlkkf"); diff --git a/chrome/browser/extensions/api/dns/dns_apitest.cc b/chrome/browser/extensions/api/dns/dns_apitest.cc index a4c5ad0..ce8cbab 100644 --- a/chrome/browser/extensions/api/dns/dns_apitest.cc +++ b/chrome/browser/extensions/api/dns/dns_apitest.cc @@ -30,12 +30,12 @@ class DnsApiTest : public ExtensionApiTest { command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } - void SetUpOnMainThread() OVERRIDE { + virtual void SetUpOnMainThread() OVERRIDE { extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting( resolver_creator_->CreateMockHostResolver()); } - void CleanUpOnMainThread() OVERRIDE { + virtual void CleanUpOnMainThread() OVERRIDE { extensions::HostResolverWrapper::GetInstance()-> SetHostResolverForTesting(NULL); resolver_creator_->DeleteMockHostResolver(); diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc index 7308faf..823c894 100644 --- a/chrome/browser/extensions/api/downloads/downloads_api.cc +++ b/chrome/browser/extensions/api/downloads/downloads_api.cc @@ -243,7 +243,7 @@ class DownloadFileIconExtractorImpl : public DownloadFileIconExtractor { public: DownloadFileIconExtractorImpl() {} - ~DownloadFileIconExtractorImpl() {} + virtual ~DownloadFileIconExtractorImpl() {} virtual bool ExtractIconURLForPath(const FilePath& path, IconLoader::IconSize icon_size, diff --git a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc index e17d795..32c192c 100644 --- a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc +++ b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc @@ -158,8 +158,9 @@ class DownloadsEventsListener : public content::NotificationObserver { typedef ExtensionDownloadsEventRouter::DownloadsNotificationSource DownloadsNotificationSource; - void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + virtual void Observe(int type, + const content::NotificationSource& source, + const content::NotificationDetails& details) OVERRIDE { switch (type) { case chrome::NOTIFICATION_EXTENSION_DOWNLOADS_EVENT: { diff --git a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc index 49d9a04..4a25199 100644 --- a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc +++ b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc @@ -33,7 +33,7 @@ class PageAsBrowserActionApiTest : public ExtensionApiTest { PageAsBrowserActionApiTest() {} virtual ~PageAsBrowserActionApiTest() {} - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII(switches::kScriptBadges, "1"); } diff --git a/chrome/browser/extensions/api/history/history_apitest.cc b/chrome/browser/extensions/api/history/history_apitest.cc index 02a74b6..7c3b2dd 100644 --- a/chrome/browser/extensions/api/history/history_apitest.cc +++ b/chrome/browser/extensions/api/history/history_apitest.cc @@ -19,7 +19,7 @@ namespace extensions { class HistoryApiTest : public ExtensionApiTest { public: - virtual void SetUpInProcessBrowserTestFixture() { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { ExtensionApiTest::SetUpInProcessBrowserTestFixture(); host_resolver()->AddRule("www.a.com", "127.0.0.1"); @@ -28,7 +28,7 @@ class HistoryApiTest : public ExtensionApiTest { ASSERT_TRUE(StartTestServer()); } - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc index 6b9eb24..913aade 100644 --- a/chrome/browser/extensions/api/identity/identity_apitest.cc +++ b/chrome/browser/extensions/api/identity/identity_apitest.cc @@ -157,7 +157,7 @@ class GetAuthTokenFunctionTest : public ExtensionBrowserTest { SCOPES = 2 }; - ~GetAuthTokenFunctionTest() {} + virtual ~GetAuthTokenFunctionTest() {} // Helper to create an extension with specific OAuth2Info fields set. // |fields_to_set| should be computed by using fields of Oauth2Fields enum. diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc index b11f7a9..462e503 100644 --- a/chrome/browser/extensions/api/management/management_api.cc +++ b/chrome/browser/extensions/api/management/management_api.cc @@ -299,7 +299,7 @@ class SafeManifestJSONParser : public UtilityProcessHostClient { host->Send(new ChromeUtilityMsg_ParseJSON(manifest_)); } - virtual bool OnMessageReceived(const IPC::Message& message) { + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE { bool handled = true; IPC_BEGIN_MESSAGE_MAP(SafeManifestJSONParser, message) IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseJSON_Succeeded, @@ -345,7 +345,7 @@ class SafeManifestJSONParser : public UtilityProcessHostClient { } private: - ~SafeManifestJSONParser() {} + virtual ~SafeManifestJSONParser() {} // The client who we'll report results back to. ManagementGetPermissionWarningsByManifestFunction* client_; diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc index 581377d..6243f9a 100644 --- a/chrome/browser/extensions/api/management/management_apitest.cc +++ b/chrome/browser/extensions/api/management/management_apitest.cc @@ -42,7 +42,7 @@ Browser* FindOtherBrowser(Browser* browser) { class ExtensionManagementApiTest : public ExtensionApiTest { public: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnablePanels); } diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc index e0a870b..2fa3a91 100644 --- a/chrome/browser/extensions/api/management/management_browsertest.cc +++ b/chrome/browser/extensions/api/management/management_browsertest.cc @@ -180,7 +180,7 @@ class NotificationListener : public content::NotificationObserver { this, types[i], content::NotificationService::AllSources()); } } - ~NotificationListener() {} + virtual ~NotificationListener() {} bool started() { return started_; } @@ -197,7 +197,7 @@ class NotificationListener : public content::NotificationObserver { // Implements content::NotificationObserver interface. virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { switch (type) { case chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED: { EXPECT_FALSE(started_); diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc index 2952fdf..088715b 100644 --- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc +++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc @@ -62,7 +62,7 @@ class FakeLauncher : public NativeProcessLauncher { } virtual void Launch(const std::string& native_host_name, - LaunchedCallback callback) const { + LaunchedCallback callback) const OVERRIDE { callback.Run(base::GetCurrentProcessHandle(), read_file_, write_file_); } diff --git a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc index 33d450b..78bff7e 100644 --- a/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc +++ b/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc @@ -14,12 +14,12 @@ using extensions::PageCaptureSaveAsMHTMLFunction; class ExtensionPageCaptureApiTest : public ExtensionApiTest { public: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc"); } - virtual void SetUpInProcessBrowserTestFixture() { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { ExtensionApiTest::SetUpInProcessBrowserTestFixture(); host_resolver()->AddRule("www.a.com", "127.0.0.1"); diff --git a/chrome/browser/extensions/api/permissions/permissions_apitest.cc b/chrome/browser/extensions/api/permissions/permissions_apitest.cc index adfc624..5aea11a 100644 --- a/chrome/browser/extensions/api/permissions/permissions_apitest.cc +++ b/chrome/browser/extensions/api/permissions/permissions_apitest.cc @@ -28,7 +28,7 @@ static void AddPattern(URLPatternSet* extent, const std::string& pattern) { class ExperimentalApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc index 0b7b3b1..f56276e 100644 --- a/chrome/browser/extensions/api/preference/preference_api.cc +++ b/chrome/browser/extensions/api/preference/preference_api.cc @@ -118,11 +118,11 @@ class IdentityPrefTransformer : public PrefTransformerInterface { public: virtual Value* ExtensionToBrowserPref(const Value* extension_pref, std::string* error, - bool* bad_message) { + bool* bad_message) OVERRIDE { return extension_pref->DeepCopy(); } - virtual Value* BrowserToExtensionPref(const Value* browser_pref) { + virtual Value* BrowserToExtensionPref(const Value* browser_pref) OVERRIDE { return browser_pref->DeepCopy(); } }; @@ -131,11 +131,11 @@ class InvertBooleanTransformer : public PrefTransformerInterface { public: virtual Value* ExtensionToBrowserPref(const Value* extension_pref, std::string* error, - bool* bad_message) { + bool* bad_message) OVERRIDE { return InvertBooleanValue(extension_pref); } - virtual Value* BrowserToExtensionPref(const Value* browser_pref) { + virtual Value* BrowserToExtensionPref(const Value* browser_pref) OVERRIDE { return InvertBooleanValue(browser_pref); } diff --git a/chrome/browser/extensions/api/record/record_api_test.cc b/chrome/browser/extensions/api/record/record_api_test.cc index 50de96a..5af4b93 100644 --- a/chrome/browser/extensions/api/record/record_api_test.cc +++ b/chrome/browser/extensions/api/record/record_api_test.cc @@ -69,10 +69,10 @@ class TestProcessStrategy : public ProcessStrategy { explicit TestProcessStrategy(std::vector<FilePath>* temp_files) : command_line_(CommandLine::NO_PROGRAM), temp_files_(temp_files) {} - ~TestProcessStrategy() {} + virtual ~TestProcessStrategy() {} // Pump the blocking pool queue, since this is needed during test. - void PumpBlockingPool() OVERRIDE { + virtual void PumpBlockingPool() OVERRIDE { content::BrowserThread::GetBlockingPool()->FlushForTesting(); } @@ -86,8 +86,8 @@ class TestProcessStrategy : public ProcessStrategy { // visited. If there are any "bad" URLS, don't visit these, but // create a ".errors" file listing them. // 2. If record-stats, then create a mock stats file. - void RunProcess(const CommandLine& command_line, - std::vector<std::string>* errors) OVERRIDE { + virtual void RunProcess(const CommandLine& command_line, + std::vector<std::string>* errors) OVERRIDE { command_line_ = command_line; visited_urls_.clear(); @@ -195,7 +195,7 @@ class RecordApiTest : public InProcessBrowserTest { // Override SetUpCommandline to specify a dummy user_data_dir, which // should be replaced. Clear record-mode, playback-mode, visit-urls, // record-stats, and load-extension. - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { std::vector<std::string> remove_switches; remove_switches.push_back(switches::kUserDataDir); diff --git a/chrome/browser/extensions/api/serial/serial_apitest.cc b/chrome/browser/extensions/api/serial/serial_apitest.cc index 1b71f0a..9b1d8dd 100644 --- a/chrome/browser/extensions/api/serial/serial_apitest.cc +++ b/chrome/browser/extensions/api/serial/serial_apitest.cc @@ -35,7 +35,7 @@ namespace extensions { class FakeSerialGetPortsFunction : public AsyncExtensionFunction { public: - virtual bool RunImpl() { + virtual bool RunImpl() OVERRIDE { ListValue* ports = new ListValue(); ports->Append(Value::CreateStringValue("/dev/fakeserial")); ports->Append(Value::CreateStringValue("\\\\COM800\\")); diff --git a/chrome/browser/extensions/api/socket/socket_apitest.cc b/chrome/browser/extensions/api/socket/socket_apitest.cc index 19e1309..2bb65cb 100644 --- a/chrome/browser/extensions/api/socket/socket_apitest.cc +++ b/chrome/browser/extensions/api/socket/socket_apitest.cc @@ -42,12 +42,12 @@ class SocketApiTest : public ExtensionApiTest { command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } - void SetUpOnMainThread() OVERRIDE { + virtual void SetUpOnMainThread() OVERRIDE { extensions::HostResolverWrapper::GetInstance()->SetHostResolverForTesting( resolver_creator_->CreateMockHostResolver()); } - void CleanUpOnMainThread() OVERRIDE { + virtual void CleanUpOnMainThread() OVERRIDE { extensions::HostResolverWrapper::GetInstance()-> SetHostResolverForTesting(NULL); resolver_creator_->DeleteMockHostResolver(); diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc index 8a1e01a..6333589 100644 --- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc +++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc @@ -37,7 +37,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest { : current_channel_(VersionInfo::CHANNEL_UNKNOWN) { } - void SetUpInProcessBrowserTestFixture() OVERRIDE { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { mock_remote_service_ = new ::testing::NiceMock<MockRemoteFileSyncService>; SyncFileSystemServiceFactory::GetInstance()->set_mock_remote_file_service( scoped_ptr<RemoteFileSyncService>(mock_remote_service_)); @@ -49,7 +49,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest { quota::QuotaManager::kSyncableStorageDefaultHostQuota = 123456789; } - void TearDownInProcessBrowserTestFixture() { + virtual void TearDownInProcessBrowserTestFixture() OVERRIDE { quota::QuotaManager::kSyncableStorageDefaultHostQuota = real_default_quota_; } diff --git a/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc b/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc index daa8bc8..59a0354 100644 --- a/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc +++ b/chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc @@ -16,7 +16,7 @@ class SystemIndicatorApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); // Set shorter delays to prevent test timeouts in tests that need to wait // for the event page to unload. diff --git a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc index 10226a8..84911d4 100644 --- a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc +++ b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc @@ -31,7 +31,7 @@ class MockCpuInfoProviderImpl : public CpuInfoProvider { } private: - ~MockCpuInfoProviderImpl() {} + virtual ~MockCpuInfoProviderImpl() {} virtual bool QueryCpuTimePerProcessor(std::vector<CpuTime>* times) OVERRIDE { DCHECK(times); @@ -59,7 +59,7 @@ class MockCpuInfoProviderImpl : public CpuInfoProvider { class SystemInfoCpuApiTest: public ExtensionApiTest { public: SystemInfoCpuApiTest() {} - ~SystemInfoCpuApiTest() {} + virtual ~SystemInfoCpuApiTest() {} virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); diff --git a/chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc b/chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc index b80b519..b719fe6 100644 --- a/chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc +++ b/chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc @@ -46,14 +46,14 @@ class MockDisplayInfoProvider : public DisplayInfoProvider { class SystemInfoDisplayApiTest: public ExtensionApiTest { public: SystemInfoDisplayApiTest() {} - ~SystemInfoDisplayApiTest() {} + virtual ~SystemInfoDisplayApiTest() {} virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } - virtual void SetUpInProcessBrowserTestFixture() { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { ExtensionApiTest::SetUpInProcessBrowserTestFixture(); message_loop_.reset(new MessageLoop(MessageLoop::TYPE_UI)); } diff --git a/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc b/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc index 074ddf1..bfaf312 100644 --- a/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc +++ b/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc @@ -24,13 +24,13 @@ class MockMemoryInfoProviderImpl : public MemoryInfoProvider { return true; } private: - ~MockMemoryInfoProviderImpl() {} + virtual ~MockMemoryInfoProviderImpl() {} }; class SystemInfoMemoryApiTest: public ExtensionApiTest { public: SystemInfoMemoryApiTest() {} - ~SystemInfoMemoryApiTest() {} + virtual ~SystemInfoMemoryApiTest() {} virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); diff --git a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc index 3bc890a..0420775 100644 --- a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc +++ b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_unittest.cc @@ -115,7 +115,7 @@ class TestStorageInfoProvider : public StorageInfoProvider { StorageUnitInfo* info) OVERRIDE; // Called each time CheckWatchedStoragesOnBlockingPool is finished. - void OnCheckWatchedStoragesFinishedForTesting(); + virtual void OnCheckWatchedStoragesFinishedForTesting() OVERRIDE; // The testing data maintained on the blocking pool. std::vector<TestUnitInfo> testing_data_; diff --git a/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc b/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc index 6edf75b..4732a47 100644 --- a/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc +++ b/chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc @@ -71,14 +71,14 @@ class TestStorageInfoProvider : public StorageInfoProvider { class SystemInfoStorageApiTest: public ExtensionApiTest { public: SystemInfoStorageApiTest() {} - ~SystemInfoStorageApiTest() {} + virtual ~SystemInfoStorageApiTest() {} virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } - virtual void SetUpInProcessBrowserTestFixture() { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { ExtensionApiTest::SetUpInProcessBrowserTestFixture(); message_loop_.reset(new MessageLoop(MessageLoop::TYPE_UI)); } diff --git a/chrome/browser/extensions/api/terminal/terminal_private_apitest.cc b/chrome/browser/extensions/api/terminal/terminal_private_apitest.cc index 79eaadb..c8fe1e63 100644 --- a/chrome/browser/extensions/api/terminal/terminal_private_apitest.cc +++ b/chrome/browser/extensions/api/terminal/terminal_private_apitest.cc @@ -7,7 +7,7 @@ #include "chrome/common/chrome_switches.h" class ExtensionTerminalPrivateApiTest : public ExtensionApiTest { - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII( switches::kWhitelistedExtensionID, "kidcpjlbjdmcnmccjhjdckhbngnhnepk"); diff --git a/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc b/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc index 4d3b90b..036f6c4 100644 --- a/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc +++ b/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc @@ -22,7 +22,7 @@ class TopSitesExtensionTest : public InProcessBrowserTest { TopSitesExtensionTest() : top_sites_inited_(false), waiting_(false) { } - void SetUpOnMainThread() { + virtual void SetUpOnMainThread() OVERRIDE { history::TopSites* top_sites = browser()->profile()->GetTopSites(); // This may return async or sync. If sync, top_sites_inited_ will be true diff --git a/chrome/browser/extensions/api/usb/usb_apitest.cc b/chrome/browser/extensions/api/usb/usb_apitest.cc index 4835849..18ed3dd 100644 --- a/chrome/browser/extensions/api/usb/usb_apitest.cc +++ b/chrome/browser/extensions/api/usb/usb_apitest.cc @@ -68,7 +68,7 @@ class UsbApiTest : public ExtensionApiTest { command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } - void SetUpOnMainThread() OVERRIDE { + virtual void SetUpOnMainThread() OVERRIDE { mock_device_ = new MockUsbDevice(); extensions::UsbFindDevicesFunction::SetDeviceForTest(mock_device_.get()); } diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc index 7fcf7fb..86203b5 100644 --- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc +++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc @@ -57,9 +57,9 @@ class TestRenderViewContextMenu : public RenderViewContextMenu { virtual ~TestRenderViewContextMenu() {} private: - virtual void PlatformInit() {} - virtual void PlatformCancel() {} - virtual bool GetAcceleratorForCommandId(int, ui::Accelerator*) { + virtual void PlatformInit() OVERRIDE {} + virtual void PlatformCancel() OVERRIDE {} + virtual bool GetAcceleratorForCommandId(int, ui::Accelerator*) OVERRIDE { return false; } @@ -131,7 +131,7 @@ class TestNavigationListener } // content::ResourceThrottle implementation. - virtual void WillStartRequest(bool* defer) { + virtual void WillStartRequest(bool* defer) OVERRIDE { *defer = true; } }; diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc index e4ab896..eead84e 100644 --- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc +++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc @@ -153,7 +153,7 @@ class TestIPCSender : public IPC::Sender { private: // IPC::Sender - virtual bool Send(IPC::Message* message) { + virtual bool Send(IPC::Message* message) OVERRIDE { EXPECT_EQ(ExtensionMsg_MessageInvoke::ID, message->type()); EXPECT_FALSE(task_queue_.empty()); diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc index 4ca74d2..851aafc 100644 --- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc +++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc @@ -41,7 +41,7 @@ class CancelLoginDialog : public content::NotificationObserver { virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { LoginHandler* handler = content::Details<LoginNotificationDetails>(details).ptr()->handler(); handler->CancelAuth(); @@ -57,7 +57,7 @@ class CancelLoginDialog : public content::NotificationObserver { class ExtensionWebRequestApiTest : public ExtensionApiTest { public: - virtual void SetUpInProcessBrowserTestFixture() { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { // TODO(battre): remove this when declarative webRequest API becomes stable. CommandLine::ForCurrentProcess()->AppendSwitch( switches::kEnableExperimentalExtensionApis); diff --git a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_apitest.cc b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_apitest.cc index cff61c0..d75832c 100644 --- a/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_apitest.cc +++ b/chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_apitest.cc @@ -8,7 +8,7 @@ namespace extensions { class ExtensionWebSocketProxyPrivateApiTest : public ExtensionApiTest { - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII( switches::kWhitelistedExtensionID, "mknjjldhaihcdajjbihghhiehamnpcak"); diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc index dba4c16..5b1ba4a 100644 --- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc +++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc @@ -44,7 +44,7 @@ class WebstoreInstallListener : public WebstoreInstaller::Delegate { WebstoreInstallListener() : received_failure_(false), received_success_(false), waiting_(false) {} - void OnExtensionInstallSuccess(const std::string& id) OVERRIDE { + virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE { received_success_ = true; id_ = id; @@ -54,7 +54,7 @@ class WebstoreInstallListener : public WebstoreInstaller::Delegate { } } - void OnExtensionInstallFailure( + virtual void OnExtensionInstallFailure( const std::string& id, const std::string& error, WebstoreInstaller::FailureReason reason) OVERRIDE { @@ -91,7 +91,7 @@ class WebstoreInstallListener : public WebstoreInstaller::Delegate { // A base class for tests below. class ExtensionWebstorePrivateApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII( switches::kAppsGalleryURL, @@ -100,7 +100,7 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest { switches::kAppsGalleryInstallAutoConfirmForTests, "accept"); } - void SetUpInProcessBrowserTestFixture() OVERRIDE { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { // Start up the test server and get us ready for calling the install // API functions. host_resolver()->AddRule("www.example.com", "127.0.0.1"); @@ -156,7 +156,7 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest { class ExtensionWebstorePrivateBundleTest : public ExtensionWebstorePrivateApiTest { public: - void SetUpInProcessBrowserTestFixture() OVERRIDE { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { ExtensionWebstorePrivateApiTest::SetUpInProcessBrowserTestFixture(); // The test server needs to have already started, so setup the switch here @@ -166,7 +166,7 @@ class ExtensionWebstorePrivateBundleTest GetTestServerURL("bundle/%s.crx").spec()); } - void TearDownInProcessBrowserTestFixture() OVERRIDE { + virtual void TearDownInProcessBrowserTestFixture() OVERRIDE { ExtensionWebstorePrivateApiTest::TearDownInProcessBrowserTestFixture(); for (size_t i = 0; i < test_crx_.size(); ++i) ASSERT_TRUE(file_util::Delete(test_crx_[i], false)); @@ -224,7 +224,7 @@ class ExtensionWebstorePrivateBundleTest class ExtensionWebstoreGetWebGLStatusTest : public InProcessBrowserTest { public: - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { // In linux, we need to launch GPU process to decide if WebGL is allowed. // Run it on top of osmesa to avoid bot driver issues. #if defined(OS_LINUX) diff --git a/chrome/browser/extensions/app_background_page_apitest.cc b/chrome/browser/extensions/app_background_page_apitest.cc index fd245a5..7d32eda 100644 --- a/chrome/browser/extensions/app_background_page_apitest.cc +++ b/chrome/browser/extensions/app_background_page_apitest.cc @@ -24,7 +24,7 @@ using extensions::Extension; class AppBackgroundPageApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kDisablePopupBlocking); command_line->AppendSwitch(switches::kAllowHTTPBackgroundPage); diff --git a/chrome/browser/extensions/app_notification_manager_sync_unittest.cc b/chrome/browser/extensions/app_notification_manager_sync_unittest.cc index f1e79f1..bd6684e 100644 --- a/chrome/browser/extensions/app_notification_manager_sync_unittest.cc +++ b/chrome/browser/extensions/app_notification_manager_sync_unittest.cc @@ -37,7 +37,7 @@ class TestChangeProcessor : public syncer::SyncChangeProcessor { // Store a copy of all the changes passed in so we can examine them later. virtual syncer::SyncError ProcessSyncChanges( const tracked_objects::Location& from_here, - const syncer::SyncChangeList& change_list) { + const syncer::SyncChangeList& change_list) OVERRIDE { // change_map_.erase(change_map_.begin(), change_map_.end()); for (syncer::SyncChangeList::const_iterator iter = change_list.begin(); iter != change_list.end(); ++iter) { @@ -100,7 +100,7 @@ class AppNotificationManagerSyncTest : public testing::Test { sync_processor_delegate_(new SyncChangeProcessorDelegate( sync_processor_.get())) {} - ~AppNotificationManagerSyncTest() { + virtual ~AppNotificationManagerSyncTest() { model_ = NULL; } diff --git a/chrome/browser/extensions/app_notification_manager_unittest.cc b/chrome/browser/extensions/app_notification_manager_unittest.cc index 70ebfc9..0579aa8 100644 --- a/chrome/browser/extensions/app_notification_manager_unittest.cc +++ b/chrome/browser/extensions/app_notification_manager_unittest.cc @@ -29,7 +29,7 @@ class AppNotificationManagerTest : public testing::Test { : ui_thread_(BrowserThread::UI, &ui_loop_), file_thread_(BrowserThread::FILE) {} - ~AppNotificationManagerTest() {} + virtual ~AppNotificationManagerTest() {} virtual void SetUp() OVERRIDE { ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::UI)); diff --git a/chrome/browser/extensions/app_notify_channel_setup_unittest.cc b/chrome/browser/extensions/app_notify_channel_setup_unittest.cc index 730c2c1..e1c1b67 100644 --- a/chrome/browser/extensions/app_notify_channel_setup_unittest.cc +++ b/chrome/browser/extensions/app_notify_channel_setup_unittest.cc @@ -133,7 +133,7 @@ class TestDelegate : public AppNotifyChannelSetup::Delegate, class TestUI : public AppNotifyChannelUI { public: TestUI() : delegate_(NULL) {} - ~TestUI() {} + virtual ~TestUI() {} // AppNotifyChannelUI. virtual void PromptSyncSetup(Delegate* delegate) OVERRIDE { diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc index 3152b4e..61dbfb9 100644 --- a/chrome/browser/extensions/app_process_apitest.cc +++ b/chrome/browser/extensions/app_process_apitest.cc @@ -50,7 +50,7 @@ class AppApiTest : public ExtensionApiTest { } // Pass flags to make testing apps easier. - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); CommandLine::ForCurrentProcess()->AppendSwitch( switches::kDisablePopupBlocking); @@ -124,7 +124,7 @@ class AppApiTest : public ExtensionApiTest { // Omits the disable-popup-blocking flag so we can cover that case. class BlockedAppApiTest : public AppApiTest { protected: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); CommandLine::ForCurrentProcess()->AppendSwitch( switches::kAllowHTTPBackgroundPage); diff --git a/chrome/browser/extensions/blacklist.cc b/chrome/browser/extensions/blacklist.cc index 12e5a7a..03fac35 100644 --- a/chrome/browser/extensions/blacklist.cc +++ b/chrome/browser/extensions/blacklist.cc @@ -99,7 +99,8 @@ class SafeBrowsingClientImpl AddRef(); // Balanced in OnCheckExtensionsResult } - void OnCheckExtensionsResult(const std::set<std::string>& hits) { + virtual void OnCheckExtensionsResult( + const std::set<std::string>& hits) OVERRIDE { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); callback_message_loop_->PostTask(FROM_HERE, base::Bind(callback_, hits)); Release(); // Balanced in StartCheck. diff --git a/chrome/browser/extensions/chrome_app_api_browsertest.cc b/chrome/browser/extensions/chrome_app_api_browsertest.cc index 9e27d3b..55b0efd8 100644 --- a/chrome/browser/extensions/chrome_app_api_browsertest.cc +++ b/chrome/browser/extensions/chrome_app_api_browsertest.cc @@ -72,7 +72,7 @@ class ChromeAppAPITest : public ExtensionBrowserTest { } private: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionBrowserTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII(switches::kAppsCheckoutURL, "http://checkout.com:"); diff --git a/chrome/browser/extensions/component_loader_unittest.cc b/chrome/browser/extensions/component_loader_unittest.cc index 9c1b3e5..09612ac6 100644 --- a/chrome/browser/extensions/component_loader_unittest.cc +++ b/chrome/browser/extensions/component_loader_unittest.cc @@ -79,7 +79,7 @@ class ComponentLoaderTest : public testing::Test { component_loader_(&extension_service_, &prefs_, &local_state_) { } - void SetUp() { + virtual void SetUp() { extension_path_ = GetBasePath().AppendASCII("good") .AppendASCII("Extensions") diff --git a/chrome/browser/extensions/convert_web_app_browsertest.cc b/chrome/browser/extensions/convert_web_app_browsertest.cc index b773a18..7857972 100644 --- a/chrome/browser/extensions/convert_web_app_browsertest.cc +++ b/chrome/browser/extensions/convert_web_app_browsertest.cc @@ -32,14 +32,14 @@ class ExtensionFromWebAppTest private: // InProcessBrowserTest - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { command_line->AppendSwitch(switches::kEnableCrxlessWebApps); } // content::NotificationObserver virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { if (type == chrome::NOTIFICATION_EXTENSION_INSTALLED) { const Extension* extension = content::Details<const Extension>(details).ptr(); diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc index d8bc458..7278736 100644 --- a/chrome/browser/extensions/crx_installer_browsertest.cc +++ b/chrome/browser/extensions/crx_installer_browsertest.cc @@ -46,18 +46,19 @@ class MockInstallPrompt : public ExtensionInstallPrompt { void set_record_oauth2_grant(bool record) { record_oauth2_grant_ = record; } // Overriding some of the ExtensionInstallUI API. - void ConfirmInstall(Delegate* delegate, - const Extension* extension, - const ShowDialogCallback& show_dialog_callback) { + virtual void ConfirmInstall( + Delegate* delegate, + const Extension* extension, + const ShowDialogCallback& show_dialog_callback) OVERRIDE { confirmation_requested_ = true; delegate->InstallUIProceed(); } - void OnInstallSuccess(const Extension* extension, - SkBitmap* icon) { + virtual void OnInstallSuccess(const Extension* extension, + SkBitmap* icon) OVERRIDE { extension_ = extension; MessageLoopForUI::current()->Quit(); } - void OnInstallFailure(const CrxInstallerError& error) { + virtual void OnInstallFailure(const CrxInstallerError& error) OVERRIDE { error_ = error.message(); MessageLoopForUI::current()->Quit(); } diff --git a/chrome/browser/extensions/default_apps_unittest.cc b/chrome/browser/extensions/default_apps_unittest.cc index a909d6c..2141f75 100644 --- a/chrome/browser/extensions/default_apps_unittest.cc +++ b/chrome/browser/extensions/default_apps_unittest.cc @@ -21,7 +21,7 @@ class MockExternalLoader : public ExternalLoader { public: MockExternalLoader() {} - void StartLoading() {} + virtual void StartLoading() OVERRIDE {} private: virtual ~MockExternalLoader() {} }; diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc index 160071e..e9881a4 100644 --- a/chrome/browser/extensions/extension_browsertest.cc +++ b/chrome/browser/extensions/extension_browsertest.cc @@ -267,16 +267,19 @@ class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt { } // Simulate a user abort on an extension installation. - virtual void ConfirmInstall(Delegate* delegate, - const Extension* extension, - const ShowDialogCallback& show_dialog_callback) { + virtual void ConfirmInstall( + Delegate* delegate, + const Extension* extension, + const ShowDialogCallback& show_dialog_callback) OVERRIDE { delegate->InstallUIAbort(true); MessageLoopForUI::current()->Quit(); } - virtual void OnInstallSuccess(const Extension* extension, SkBitmap* icon) {} + virtual void OnInstallSuccess(const Extension* extension, + SkBitmap* icon) OVERRIDE {} - virtual void OnInstallFailure(const extensions::CrxInstallerError& error) {} + virtual void OnInstallFailure( + const extensions::CrxInstallerError& error) OVERRIDE {} }; class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt { @@ -286,9 +289,10 @@ class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt { : ExtensionInstallPrompt(web_contents) {} // Proceed without confirmation prompt. - virtual void ConfirmInstall(Delegate* delegate, - const Extension* extension, - const ShowDialogCallback& show_dialog_callback) { + virtual void ConfirmInstall( + Delegate* delegate, + const Extension* extension, + const ShowDialogCallback& show_dialog_callback) OVERRIDE { delegate->InstallUIProceed(); } }; diff --git a/chrome/browser/extensions/extension_context_menu_browsertest.cc b/chrome/browser/extensions/extension_context_menu_browsertest.cc index 4fd7451..3108636 100644 --- a/chrome/browser/extensions/extension_context_menu_browsertest.cc +++ b/chrome/browser/extensions/extension_context_menu_browsertest.cc @@ -71,13 +71,14 @@ class TestRenderViewContextMenu : public RenderViewContextMenu { protected: // These two functions implement pure virtual methods of // RenderViewContextMenu. - virtual bool GetAcceleratorForCommandId(int command_id, - ui::Accelerator* accelerator) { + virtual bool GetAcceleratorForCommandId( + int command_id, + ui::Accelerator* accelerator) OVERRIDE { // None of our commands have accelerators, so always return false. return false; } - virtual void PlatformInit() {} - virtual void PlatformCancel() {} + virtual void PlatformInit() OVERRIDE {} + virtual void PlatformCancel() OVERRIDE {} }; } // namespace @@ -527,7 +528,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionContextMenuBrowserTest, Enabled) { class ExtensionContextMenuBrowserLazyTest : public ExtensionContextMenuBrowserTest { - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionContextMenuBrowserTest::SetUpCommandLine(command_line); // Set shorter delays to prevent test timeouts. command_line->AppendSwitchASCII(switches::kEventPageIdleTime, "0"); diff --git a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc index 5033c65..3aa3ced 100644 --- a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc +++ b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc @@ -23,13 +23,13 @@ using extensions::Extension; class ExtensionDisabledGlobalErrorTest : public ExtensionBrowserTest { protected: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionBrowserTest::SetUpCommandLine(command_line); command_line->AppendSwitchASCII(switches::kAppsGalleryUpdateURL, "http://localhost/autoupdate/updates.xml"); } - void SetUpOnMainThread() { + virtual void SetUpOnMainThread() OVERRIDE { EXPECT_TRUE(scoped_temp_dir_.CreateUniqueTempDir()); service_ = browser()->profile()->GetExtensionService(); FilePath pem_path = test_data_dir_. diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc index 157600b..af7f44e 100644 --- a/chrome/browser/extensions/extension_function_test_utils.cc +++ b/chrome/browser/extensions/extension_function_test_utils.cc @@ -222,7 +222,7 @@ class SendResponseDelegate virtual void OnSendResponse(UIThreadExtensionFunction* function, bool success, - bool bad_message) { + bool bad_message) OVERRIDE { ASSERT_FALSE(bad_message); ASSERT_FALSE(HasResponse()); response_.reset(new bool); diff --git a/chrome/browser/extensions/extension_geolocation_apitest.cc b/chrome/browser/extensions/extension_geolocation_apitest.cc index 2bf832d..a8a26de 100644 --- a/chrome/browser/extensions/extension_geolocation_apitest.cc +++ b/chrome/browser/extensions/extension_geolocation_apitest.cc @@ -11,7 +11,7 @@ class GeolocationApiTest : public ExtensionApiTest { } // InProcessBrowserTest - virtual void SetUpOnMainThread() { + virtual void SetUpOnMainThread() OVERRIDE { ui_test_utils::OverrideGeolocation(0, 0); } }; diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc index 75833a3..e8de072 100644 --- a/chrome/browser/extensions/extension_messages_apitest.cc +++ b/chrome/browser/extensions/extension_messages_apitest.cc @@ -46,7 +46,7 @@ class MessageSender : public content::NotificationObserver { virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { extensions::EventRouter* event_router = extensions::ExtensionSystem::Get( content::Source<Profile>(source).ptr())->event_router(); @@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MessagingEventURL) { // Tests connecting from a panel to its extension. class PanelMessagingTest : public ExtensionApiTest { - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnablePanels); } diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc index c2bfc86..e680906 100644 --- a/chrome/browser/extensions/extension_prefs_unittest.cc +++ b/chrome/browser/extensions/extension_prefs_unittest.cc @@ -84,14 +84,14 @@ class ExtensionPrefsLastPingDay : public ExtensionPrefsTest { : extension_time_(Time::Now() - TimeDelta::FromHours(4)), blacklist_time_(Time::Now() - TimeDelta::FromHours(2)) {} - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension_id_ = prefs_.AddExtensionAndReturnId("last_ping_day"); EXPECT_TRUE(prefs()->LastPingDay(extension_id_).is_null()); prefs()->SetLastPingDay(extension_id_, extension_time_); prefs()->SetBlacklistLastPingDay(blacklist_time_); } - virtual void Verify() { + virtual void Verify() OVERRIDE { Time result = prefs()->LastPingDay(extension_id_); EXPECT_FALSE(result.is_null()); EXPECT_TRUE(result == extension_time_); @@ -122,7 +122,7 @@ void AddGalleryPermission(chrome::MediaGalleryPrefId gallery, bool has_access, // Test the MediaGalleries permissions functions. class MediaGalleriesPermissions : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension1_id_ = prefs_.AddExtensionAndReturnId("test1"); extension2_id_ = prefs_.AddExtensionAndReturnId("test2"); extension3_id_ = prefs_.AddExtensionAndReturnId("test3"); @@ -164,7 +164,7 @@ class MediaGalleriesPermissions : public ExtensionPrefsTest { Verify(); } - virtual void Verify() { + virtual void Verify() OVERRIDE { struct TestData { std::string* id; std::vector<chrome::MediaGalleryPermission>* expectation; @@ -206,7 +206,7 @@ TEST_F(MediaGalleriesPermissions, MediaGalleries) {} // Tests the GetToolbarOrder/SetToolbarOrder functions. class ExtensionPrefsToolbarOrder : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { list_.push_back(prefs_.AddExtensionAndReturnId("1")); list_.push_back(prefs_.AddExtensionAndReturnId("2")); list_.push_back(prefs_.AddExtensionAndReturnId("3")); @@ -215,7 +215,7 @@ class ExtensionPrefsToolbarOrder : public ExtensionPrefsTest { prefs()->SetToolbarOrder(list_); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::vector<std::string> result = prefs()->GetToolbarOrder(); ASSERT_EQ(list_.size(), result.size()); for (size_t i = 0; i < list_.size(); i++) { @@ -232,12 +232,12 @@ TEST_F(ExtensionPrefsToolbarOrder, ToolbarOrder) {} // Tests the IsExtensionDisabled/SetExtensionState functions. class ExtensionPrefsExtensionState : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension = prefs_.AddExtension("test"); prefs()->SetExtensionState(extension->id(), Extension::DISABLED); } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_TRUE(prefs()->IsExtensionDisabled(extension->id())); } @@ -248,12 +248,12 @@ TEST_F(ExtensionPrefsExtensionState, ExtensionState) {} class ExtensionPrefsEscalatePermissions : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension = prefs_.AddExtension("test"); prefs()->SetDidExtensionEscalatePermissions(extension.get(), true); } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_TRUE(prefs()->DidExtensionEscalatePermissions(extension->id())); } @@ -265,7 +265,7 @@ TEST_F(ExtensionPrefsEscalatePermissions, EscalatePermissions) {} // Tests the AddGrantedPermissions / GetGrantedPermissions functions. class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { const APIPermissionInfo* permission_info = PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket); @@ -385,7 +385,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest { EXPECT_EQ(effective_permissions_, granted_permissions->effective_hosts()); } - virtual void Verify() { + virtual void Verify() OVERRIDE { scoped_refptr<PermissionSet> permissions( prefs()->GetGrantedPermissions(extension_id_)); EXPECT_TRUE(permissions.get()); @@ -416,7 +416,7 @@ TEST_F(ExtensionPrefsGrantedPermissions, GrantedPermissions) {} // Tests the SetActivePermissions / GetActivePermissions functions. class ExtensionPrefsActivePermissions : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension_id_ = prefs_.AddExtensionAndReturnId("test"); APIPermissionSet api_perms; @@ -449,7 +449,7 @@ class ExtensionPrefsActivePermissions : public ExtensionPrefsTest { EXPECT_EQ(*active_perms_, *active); } - virtual void Verify() { + virtual void Verify() OVERRIDE { scoped_refptr<PermissionSet> permissions( prefs()->GetActivePermissions(extension_id_)); EXPECT_EQ(*active_perms_, *permissions); @@ -464,14 +464,14 @@ TEST_F(ExtensionPrefsActivePermissions, SetAndGetActivePermissions) {} // Tests the GetVersionString function. class ExtensionPrefsVersionString : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension = prefs_.AddExtension("test"); EXPECT_EQ("0.1", prefs()->GetVersionString(extension->id())); prefs()->OnExtensionUninstalled(extension->id(), Manifest::INTERNAL, false); } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_EQ("", prefs()->GetVersionString(extension->id())); } @@ -482,7 +482,7 @@ TEST_F(ExtensionPrefsVersionString, VersionString) {} class ExtensionPrefsAcknowledgment : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { not_installed_id_ = "pghjnghklobnfoidcldiidjjjhkeeaoi"; // Install some extensions. @@ -515,7 +515,7 @@ class ExtensionPrefsAcknowledgment : public ExtensionPrefsTest { prefs()->AcknowledgeBlacklistedExtension(not_installed_id_); } - virtual void Verify() { + virtual void Verify() OVERRIDE { ExtensionList::const_iterator iter; for (iter = extensions_.begin(); iter != extensions_.end(); ++iter) { std::string id = (*iter)->id(); @@ -546,7 +546,7 @@ TEST_F(ExtensionPrefsAcknowledgment, Acknowledgment) {} // Tests force hiding browser actions. class ExtensionPrefsHidingBrowserActions : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { // Install 5 extensions. for (int i = 0; i < 5; i++) { std::string name = "test" + base::IntToString(i); @@ -561,7 +561,7 @@ class ExtensionPrefsHidingBrowserActions : public ExtensionPrefsTest { prefs()->SetBrowserActionVisibility(extensions_[1], true); } - virtual void Verify() { + virtual void Verify() OVERRIDE { // Make sure the one we hid is hidden. EXPECT_FALSE(prefs()->GetBrowserActionVisibility(extensions_[0])); @@ -619,7 +619,7 @@ class ExtensionPrefsDelayedInstallInfo : public ExtensionPrefsTest { return false; } - virtual void Initialize() { + virtual void Initialize() OVERRIDE { PathService::Get(chrome::DIR_TEST_DATA, &basedir_); now_ = Time::Now(); id1_ = prefs_.AddExtensionAndReturnId("1"); @@ -662,7 +662,7 @@ class ExtensionPrefsDelayedInstallInfo : public ExtensionPrefsTest { prefs()->RemoveDelayedInstallInfo(id3_); } - virtual void Verify() { + virtual void Verify() OVERRIDE { // Make sure the info for the 3 extensions we expect is present. scoped_ptr<extensions::ExtensionPrefs::ExtensionsInfo> info( prefs()->GetAllDelayedInstallInfo()); @@ -690,7 +690,7 @@ TEST_F(ExtensionPrefsDelayedInstallInfo, DelayedInstallInfo) {} class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension_ = prefs_.AddExtension("on_extension_installed"); EXPECT_FALSE(prefs()->IsExtensionDisabled(extension_->id())); prefs()->OnExtensionInstalled( @@ -698,7 +698,7 @@ class ExtensionPrefsOnExtensionInstalled : public ExtensionPrefsTest { syncer::StringOrdinal()); } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_TRUE(prefs()->IsExtensionDisabled(extension_->id())); } @@ -710,14 +710,14 @@ TEST_F(ExtensionPrefsOnExtensionInstalled, class ExtensionPrefsAppDraggedByUser : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { extension_ = prefs_.AddExtension("on_extension_installed"); EXPECT_FALSE(prefs()->WasAppDraggedByUser(extension_->id())); prefs()->OnExtensionInstalled(extension_.get(), Extension::ENABLED, syncer::StringOrdinal()); } - virtual void Verify() { + virtual void Verify() OVERRIDE { // Set the flag and see if it persisted. prefs()->SetAppDraggedByUser(extension_->id()); EXPECT_TRUE(prefs()->WasAppDraggedByUser(extension_->id())); @@ -734,7 +734,7 @@ TEST_F(ExtensionPrefsAppDraggedByUser, ExtensionPrefsAppDraggedByUser) {} class ExtensionPrefsFlags : public ExtensionPrefsTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { { base::DictionaryValue dictionary; dictionary.SetString(extension_manifest_keys::kName, "from_webstore"); @@ -763,7 +763,7 @@ class ExtensionPrefsFlags : public ExtensionPrefsTest { } } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_TRUE(prefs()->IsFromWebStore(webstore_extension_->id())); EXPECT_FALSE(prefs()->IsFromBookmark(webstore_extension_->id())); @@ -893,10 +893,10 @@ void ExtensionPrefsPrepopulatedTest::EnsureExtensionUninstalled( class ExtensionPrefsInstallOneExtension : public ExtensionPrefsPrepopulatedTest { - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ("val1", actual); } @@ -907,7 +907,7 @@ TEST_F(ExtensionPrefsInstallOneExtension, ExtensionPrefsInstallOneExtension) {} class ExtensionPrefsInstallIncognitoPersistent : public ExtensionPrefsPrepopulatedTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); InstallExtControlledPrefIncognito(ext1_, kPref1, Value::CreateStringValue("val2")); @@ -915,7 +915,7 @@ class ExtensionPrefsInstallIncognitoPersistent std::string actual = incog_prefs->GetString(kPref1); EXPECT_EQ("val2", actual); } - virtual void Verify() { + virtual void Verify() OVERRIDE { // Main pref service shall see only non-incognito settings. std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ("val1", actual); @@ -934,7 +934,7 @@ class ExtensionPrefsInstallIncognitoSessionOnly public: ExtensionPrefsInstallIncognitoSessionOnly() : iteration_(0) {} - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); InstallExtControlledPrefIncognitoSessionOnly( ext1_, kPref1, Value::CreateStringValue("val2")); @@ -942,7 +942,7 @@ class ExtensionPrefsInstallIncognitoSessionOnly std::string actual = incog_prefs->GetString(kPref1); EXPECT_EQ("val2", actual); } - virtual void Verify() { + virtual void Verify() OVERRIDE { // Main pref service shall see only non-incognito settings. std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ("val1", actual); @@ -964,7 +964,7 @@ TEST_F(ExtensionPrefsInstallIncognitoSessionOnly, ExtensionPrefsInstallOneExtension) {} class ExtensionPrefsUninstallExtension : public ExtensionPrefsPrepopulatedTest { - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); InstallExtControlledPref(ext1_, kPref2, Value::CreateStringValue("val2")); ContentSettingsStore* store = prefs()->content_settings_store(); @@ -979,7 +979,7 @@ class ExtensionPrefsUninstallExtension : public ExtensionPrefsPrepopulatedTest { UninstallExtension(ext1_->id()); } - virtual void Verify() { + virtual void Verify() OVERRIDE { EXPECT_EQ(NULL, prefs()->GetExtensionPref(ext1_->id())); std::string actual; @@ -994,7 +994,7 @@ TEST_F(ExtensionPrefsUninstallExtension, // Tests triggering of notifications to registered observers. class ExtensionPrefsNotifyWhenNeeded : public ExtensionPrefsPrepopulatedTest { - virtual void Initialize() { + virtual void Initialize() OVERRIDE { using testing::_; using testing::Mock; using testing::StrEq; @@ -1060,7 +1060,7 @@ class ExtensionPrefsNotifyWhenNeeded : public ExtensionPrefsPrepopulatedTest { registrar.Remove(kPref1); incognito_registrar.Remove(kPref1); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ(kDefaultPref1, actual); } @@ -1070,13 +1070,13 @@ TEST_F(ExtensionPrefsNotifyWhenNeeded, // Tests disabling an extension. class ExtensionPrefsDisableExt : public ExtensionPrefsPrepopulatedTest { - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ("val1", actual); prefs()->SetExtensionState(ext1_->id(), Extension::DISABLED); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ(kDefaultPref1, actual); } @@ -1085,12 +1085,12 @@ TEST_F(ExtensionPrefsDisableExt, ExtensionPrefsDisableExt) {} // Tests disabling and reenabling an extension. class ExtensionPrefsReenableExt : public ExtensionPrefsPrepopulatedTest { - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); prefs()->SetExtensionState(ext1_->id(), Extension::DISABLED); prefs()->SetExtensionState(ext1_->id(), Extension::ENABLED); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::string actual = prefs()->pref_service()->GetString(kPref1); EXPECT_EQ("val1", actual); } @@ -1112,7 +1112,7 @@ class MockStringValue : public StringValue { class ExtensionPrefsSetExtensionControlledPref : public ExtensionPrefsPrepopulatedTest { public: - virtual void Initialize() { + virtual void Initialize() OVERRIDE { MockStringValue* v1 = new MockStringValue("https://www.chromium.org"); MockStringValue* v2 = new MockStringValue("https://www.chromium.org"); MockStringValue* v1i = new MockStringValue("https://www.chromium.org"); @@ -1138,7 +1138,7 @@ class ExtensionPrefsSetExtensionControlledPref testing::Mock::VerifyAndClearExpectations(v2i); } - virtual void Verify() { + virtual void Verify() OVERRIDE { } }; TEST_F(ExtensionPrefsSetExtensionControlledPref, @@ -1151,12 +1151,12 @@ class ExtensionPrefsDisableExtensions : public ExtensionPrefsPrepopulatedTest { ExtensionPrefsDisableExtensions() : iteration_(0) {} virtual ~ExtensionPrefsDisableExtensions() {} - virtual void Initialize() { + virtual void Initialize() OVERRIDE { InstallExtControlledPref(ext1_, kPref1, Value::CreateStringValue("val1")); // This becomes only active in the second verification phase. prefs_.set_extensions_disabled(true); } - virtual void Verify() { + virtual void Verify() OVERRIDE { std::string actual = prefs()->pref_service()->GetString(kPref1); if (iteration_ == 0) { EXPECT_EQ("val1", actual); diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc index 0163e79..2e8325f 100644 --- a/chrome/browser/extensions/extension_process_manager.cc +++ b/chrome/browser/extensions/extension_process_manager.cc @@ -75,14 +75,14 @@ class IncognitoExtensionProcessManager : public ExtensionProcessManager { Browser* browser, chrome::ViewType view_type) OVERRIDE; virtual void CreateBackgroundHost(const Extension* extension, - const GURL& url); - virtual SiteInstance* GetSiteInstanceForURL(const GURL& url); + const GURL& url) OVERRIDE; + virtual SiteInstance* GetSiteInstanceForURL(const GURL& url) OVERRIDE; private: // content::NotificationObserver: virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details); + const content::NotificationDetails& details) OVERRIDE; // Returns true if the extension is allowed to run in incognito mode. bool IsIncognitoEnabled(const Extension* extension); diff --git a/chrome/browser/extensions/extension_protocols.cc b/chrome/browser/extensions/extension_protocols.cc index c26d7c0..0b55cd1 100644 --- a/chrome/browser/extensions/extension_protocols.cc +++ b/chrome/browser/extensions/extension_protocols.cc @@ -111,7 +111,7 @@ class URLRequestResourceBundleJob : public net::URLRequestSimpleJob { return net::ERR_IO_PENDING; } - virtual void GetResponseInfo(net::HttpResponseInfo* info) { + virtual void GetResponseInfo(net::HttpResponseInfo* info) OVERRIDE { *info = response_info_; } @@ -177,7 +177,7 @@ class GeneratedBackgroundPageJob : public net::URLRequestSimpleJob { return net::OK; } - virtual void GetResponseInfo(net::HttpResponseInfo* info) { + virtual void GetResponseInfo(net::HttpResponseInfo* info) OVERRIDE { *info = response_info_; } diff --git a/chrome/browser/extensions/extension_renderer_state.cc b/chrome/browser/extensions/extension_renderer_state.cc index db1c4df..f3ef4866 100644 --- a/chrome/browser/extensions/extension_renderer_state.cc +++ b/chrome/browser/extensions/extension_renderer_state.cc @@ -35,13 +35,13 @@ class ExtensionRendererState::TabObserver : public content::NotificationObserver { public: TabObserver(); - ~TabObserver(); + virtual ~TabObserver(); private: // content::NotificationObserver interface. virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details); + const content::NotificationDetails& details) OVERRIDE; content::NotificationRegistrar registrar_; }; diff --git a/chrome/browser/extensions/extension_resource_protocols.cc b/chrome/browser/extensions/extension_resource_protocols.cc index cb3d2cc..b7fbf137 100644 --- a/chrome/browser/extensions/extension_resource_protocols.cc +++ b/chrome/browser/extensions/extension_resource_protocols.cc @@ -24,7 +24,7 @@ class ExtensionResourcesJob : public net::URLRequestFileJob { virtual void Start() OVERRIDE; protected: - ~ExtensionResourcesJob() {} + virtual ~ExtensionResourcesJob() {} void ResolvePath(); void ResolvePathDone(); diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc index 9bc21be..b2e5b96 100644 --- a/chrome/browser/extensions/extension_service_unittest.cc +++ b/chrome/browser/extensions/extension_service_unittest.cc @@ -318,7 +318,7 @@ class MockProviderVisitor const FilePath& path, Manifest::Location unused, int creation_flags, - bool mark_acknowledged) { + bool mark_acknowledged) OVERRIDE { EXPECT_EQ(expected_creation_flags_, creation_flags); ++ids_found_; @@ -358,7 +358,7 @@ class MockProviderVisitor virtual bool OnExternalExtensionUpdateUrlFound( const std::string& id, const GURL& update_url, - Manifest::Location location) { + Manifest::Location location) OVERRIDE { ++ids_found_; DictionaryValue* pref; // This tests is to make sure that the provider only notifies us of the @@ -385,7 +385,7 @@ class MockProviderVisitor } virtual void OnExternalProviderReady( - const extensions::ExternalProviderInterface* provider) { + const extensions::ExternalProviderInterface* provider) OVERRIDE { EXPECT_EQ(provider, provider_.get()); EXPECT_TRUE(provider->IsReady()); } @@ -562,7 +562,7 @@ class ExtensionServiceTest virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { switch (type) { case chrome::NOTIFICATION_EXTENSION_LOADED: { const Extension* extension = @@ -1063,9 +1063,9 @@ class PackExtensionTestClient : public extensions::PackExtensionJob::Client { PackExtensionTestClient(const FilePath& expected_crx_path, const FilePath& expected_private_key_path); virtual void OnPackSuccess(const FilePath& crx_path, - const FilePath& private_key_path); + const FilePath& private_key_path) OVERRIDE; virtual void OnPackFailure(const std::string& error_message, - ExtensionCreator::ErrorType type); + ExtensionCreator::ErrorType type) OVERRIDE; private: const FilePath expected_crx_path_; @@ -4527,7 +4527,7 @@ class ExtensionsReadyRecorder : public content::NotificationObserver { private: virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { switch (type) { case chrome::NOTIFICATION_EXTENSIONS_READY: ready_ = true; @@ -5566,7 +5566,7 @@ TEST_F(ExtensionServiceTest, InstallWhitelistedExtension) { // are provided. class ExtensionSourcePriorityTest : public ExtensionServiceTest { public: - void SetUp() { + virtual void SetUp() { ExtensionServiceTest::SetUp(); // All tests use a single extension. Put the id and path in member vars diff --git a/chrome/browser/extensions/extension_sorting_unittest.cc b/chrome/browser/extensions/extension_sorting_unittest.cc index d12a854..8b4aa41 100644 --- a/chrome/browser/extensions/extension_sorting_unittest.cc +++ b/chrome/browser/extensions/extension_sorting_unittest.cc @@ -534,10 +534,10 @@ class ExtensionSortingEnsureValidOrdinals : public extensions::ExtensionPrefsPrepopulatedTest { public : ExtensionSortingEnsureValidOrdinals() {} - ~ExtensionSortingEnsureValidOrdinals() {} + virtual ~ExtensionSortingEnsureValidOrdinals() {} - virtual void Initialize() {} - virtual void Verify() { + virtual void Initialize() OVERRIDE {} + virtual void Verify() OVERRIDE { ExtensionSorting* extension_sorting = prefs()->extension_sorting(); // Give ext1 invalid ordinals and then check that EnsureValidOrdinals fixes @@ -895,7 +895,7 @@ class ExtensionSortingDefaultOrdinalOverriddenByUserValue } protected: - virtual void SetupUserOrdinals() { + virtual void SetupUserOrdinals() OVERRIDE { user_page_ordinal_ = default_page_ordinal_.CreateAfter(); user_app_launch_ordinal_ = default_app_launch_ordinal_.CreateBefore(); @@ -931,7 +931,7 @@ class ExtensionSortingDefaultOrdinalNoCollision } protected: - virtual void SetupUserOrdinals() { + virtual void SetupUserOrdinals() OVERRIDE { other_app_ = prefs_.AddApp("other_app"); // Creates a collision. ExtensionSorting* extension_sorting = prefs()->extension_sorting(); diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc index 81921da..8fa8b9e 100644 --- a/chrome/browser/extensions/extension_startup_browsertest.cc +++ b/chrome/browser/extensions/extension_startup_browsertest.cc @@ -44,7 +44,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest { protected: // InProcessBrowserTest - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { if (!enable_extensions_) command_line->AppendSwitch(switches::kDisableExtensions); @@ -56,7 +56,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest { } } - virtual bool SetUpUserDataDirectory() { + virtual bool SetUpUserDataDirectory() OVERRIDE { FilePath profile_dir; PathService::Get(chrome::DIR_USER_DATA, &profile_dir); profile_dir = profile_dir.AppendASCII(TestingProfile::kTestUserProfileDir); diff --git a/chrome/browser/extensions/extension_toolbar_model_browsertest.cc b/chrome/browser/extensions/extension_toolbar_model_browsertest.cc index f38a4c7..934121c 100644 --- a/chrome/browser/extensions/extension_toolbar_model_browsertest.cc +++ b/chrome/browser/extensions/extension_toolbar_model_browsertest.cc @@ -35,19 +35,21 @@ class ExtensionToolbarModelTest : public ExtensionBrowserTest, model_->AddObserver(this); } - virtual void CleanUpOnMainThread() { + virtual void CleanUpOnMainThread() OVERRIDE { model_->RemoveObserver(this); } - virtual void BrowserActionAdded(const Extension* extension, int index) { + virtual void BrowserActionAdded(const Extension* extension, + int index) OVERRIDE { inserted_count_++; } - virtual void BrowserActionRemoved(const Extension* extension) { + virtual void BrowserActionRemoved(const Extension* extension) OVERRIDE { removed_count_++; } - virtual void BrowserActionMoved(const Extension* extension, int index) { + virtual void BrowserActionMoved(const Extension* extension, + int index) OVERRIDE { moved_count_++; } diff --git a/chrome/browser/extensions/extension_warning_badge_service_unittest.cc b/chrome/browser/extensions/extension_warning_badge_service_unittest.cc index 5d7a54d..273c016 100644 --- a/chrome/browser/extensions/extension_warning_badge_service_unittest.cc +++ b/chrome/browser/extensions/extension_warning_badge_service_unittest.cc @@ -38,7 +38,8 @@ class TestExtensionWarningBadgeService : public ExtensionWarningBadgeService { warning_service_(warning_service) {} virtual ~TestExtensionWarningBadgeService() {} - virtual const std::set<ExtensionWarning>& GetCurrentWarnings() const { + virtual const std::set<ExtensionWarning>& + GetCurrentWarnings() const OVERRIDE { return warning_service_->warnings(); } diff --git a/chrome/browser/extensions/extensions_quota_service_unittest.cc b/chrome/browser/extensions/extensions_quota_service_unittest.cc index d5927d4..2d02bfc 100644 --- a/chrome/browser/extensions/extensions_quota_service_unittest.cc +++ b/chrome/browser/extensions/extensions_quota_service_unittest.cc @@ -34,7 +34,8 @@ class Mapper : public QuotaLimitHeuristic::BucketMapper { public: Mapper() {} virtual ~Mapper() { STLDeleteValues(&buckets_); } - virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) { + virtual void GetBucketsForArgs(const ListValue* args, + BucketList* buckets) OVERRIDE { for (size_t i = 0; i < args->GetSize(); i++) { int id; ASSERT_TRUE(args->GetInteger(i, &id)); @@ -51,7 +52,9 @@ class Mapper : public QuotaLimitHeuristic::BucketMapper { class MockMapper : public QuotaLimitHeuristic::BucketMapper { public: - virtual void GetBucketsForArgs(const ListValue* args, BucketList* buckets) {} + virtual void GetBucketsForArgs(const ListValue* args, + BucketList* buckets) OVERRIDE { + } }; class MockFunction : public ExtensionFunction { @@ -75,7 +78,7 @@ class TimedLimitMockFunction : public MockFunction { explicit TimedLimitMockFunction(const std::string& name) : MockFunction(name) {} virtual void GetQuotaLimitHeuristics( - QuotaLimitHeuristics* heuristics) const { + QuotaLimitHeuristics* heuristics) const OVERRIDE { heuristics->push_back( new TimedLimit(k2PerMinute, new Mapper(), kGenericName)); } @@ -89,7 +92,7 @@ class ChainedLimitsMockFunction : public MockFunction { explicit ChainedLimitsMockFunction(const std::string& name) : MockFunction(name) {} virtual void GetQuotaLimitHeuristics( - QuotaLimitHeuristics* heuristics) const { + QuotaLimitHeuristics* heuristics) const OVERRIDE { // No more than 2 per minute sustained over 5 minutes. heuristics->push_back(new SustainedLimit( TimeDelta::FromMinutes(5), k2PerMinute, new Mapper(), kGenericName)); @@ -106,7 +109,7 @@ class FrozenMockFunction : public MockFunction { public: explicit FrozenMockFunction(const std::string& name) : MockFunction(name) {} virtual void GetQuotaLimitHeuristics( - QuotaLimitHeuristics* heuristics) const { + QuotaLimitHeuristics* heuristics) const OVERRIDE { heuristics->push_back( new TimedLimit(kFrozenConfig, new Mapper(), kGenericName)); } diff --git a/chrome/browser/extensions/external_policy_loader_unittest.cc b/chrome/browser/extensions/external_policy_loader_unittest.cc index ad3fb6d..edc11ee 100644 --- a/chrome/browser/extensions/external_policy_loader_unittest.cc +++ b/chrome/browser/extensions/external_policy_loader_unittest.cc @@ -73,14 +73,14 @@ class MockExternalPolicyProviderVisitor const FilePath& path, Manifest::Location unused, int unused2, - bool unused3) { + bool unused3) OVERRIDE { ADD_FAILURE() << "There should be no external extensions from files."; return false; } virtual bool OnExternalExtensionUpdateUrlFound( const std::string& id, const GURL& update_url, - Manifest::Location location) { + Manifest::Location location) OVERRIDE { // Extension has the correct location. EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location); @@ -97,7 +97,7 @@ class MockExternalPolicyProviderVisitor } virtual void OnExternalProviderReady( - const ExternalProviderInterface* provider) { + const ExternalProviderInterface* provider) OVERRIDE { EXPECT_EQ(provider, provider_.get()); EXPECT_TRUE(provider->IsReady()); } diff --git a/chrome/browser/extensions/isolated_app_browsertest.cc b/chrome/browser/extensions/isolated_app_browsertest.cc index ef70a88..1c1ae7a 100644 --- a/chrome/browser/extensions/isolated_app_browsertest.cc +++ b/chrome/browser/extensions/isolated_app_browsertest.cc @@ -66,7 +66,7 @@ class IsolatedAppTest : public ExtensionBrowserTest { } private: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionBrowserTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc index a74c184..eeba1dd 100644 --- a/chrome/browser/extensions/lazy_background_page_apitest.cc +++ b/chrome/browser/extensions/lazy_background_page_apitest.cc @@ -59,7 +59,7 @@ class LoadedIncognitoObserver : public content::NotificationObserver { virtual void Observe( int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { original_complete_.reset(new LazyBackgroundObserver(profile_)); incognito_complete_.reset( new LazyBackgroundObserver(profile_->GetOffTheRecordProfile())); @@ -75,7 +75,7 @@ class LoadedIncognitoObserver : public content::NotificationObserver { class LazyBackgroundPageApiTest : public ExtensionApiTest { public: - void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); // Set shorter delays to prevent test timeouts. diff --git a/chrome/browser/extensions/management_policy_unittest.cc b/chrome/browser/extensions/management_policy_unittest.cc index e80b4e4..c9dd846 100644 --- a/chrome/browser/extensions/management_policy_unittest.cc +++ b/chrome/browser/extensions/management_policy_unittest.cc @@ -12,7 +12,7 @@ using extensions::Extension; class ManagementPolicyTest : public testing::Test { public: - void SetUp() { + virtual void SetUp() { allow_all_.SetProhibitedActions(TestProvider::ALLOW_ALL); no_modify_status_.SetProhibitedActions( TestProvider::PROHIBIT_MODIFY_STATUS); diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc index 1478925..6f4bae3 100644 --- a/chrome/browser/extensions/menu_manager_unittest.cc +++ b/chrome/browser/extensions/menu_manager_unittest.cc @@ -476,7 +476,7 @@ class MockExtensionSystem : public TestExtensionSystem { explicit MockExtensionSystem(Profile* profile) : TestExtensionSystem(profile) {} - virtual EventRouter* event_router() { + virtual EventRouter* event_router() OVERRIDE { if (!mock_event_router_.get()) mock_event_router_.reset(new MockEventRouter(profile_)); return mock_event_router_.get(); diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc index 8e73b6c..8c0e8be 100644 --- a/chrome/browser/extensions/permissions_updater.cc +++ b/chrome/browser/extensions/permissions_updater.cc @@ -62,7 +62,7 @@ class OAuth2GrantRecorder : public OAuth2MintTokenFlow::Delegate, } // content::NotificationObserver: - void Observe(int type, + virtual void Observe(int type, const content::NotificationSource& source, const content::NotificationDetails& details) OVERRIDE { DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_DESTROYED); diff --git a/chrome/browser/extensions/process_management_browsertest.cc b/chrome/browser/extensions/process_management_browsertest.cc index 0d1cb5d..a807a72 100644 --- a/chrome/browser/extensions/process_management_browsertest.cc +++ b/chrome/browser/extensions/process_management_browsertest.cc @@ -30,7 +30,7 @@ namespace { class ProcessManagementTest : public ExtensionBrowserTest { private: // This is needed for testing isolated apps, which are still experimental. - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionBrowserTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis); } diff --git a/chrome/browser/extensions/requirements_checker_browsertest.cc b/chrome/browser/extensions/requirements_checker_browsertest.cc index 4d79d65..d840f83 100644 --- a/chrome/browser/extensions/requirements_checker_browsertest.cc +++ b/chrome/browser/extensions/requirements_checker_browsertest.cc @@ -29,7 +29,7 @@ namespace extensions { class RequirementsCheckerBrowserTest : public ExtensionBrowserTest { public: - void SetUpCommandLine(CommandLine* command_line) OVERRIDE { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { // In linux, we need to launch GPU process to decide if WebGL is allowed. // Run it on top of osmesa to avoid bot driver issues. #if defined(OS_LINUX) diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc index dceca42..712a37a 100644 --- a/chrome/browser/extensions/unpacked_installer.cc +++ b/chrome/browser/extensions/unpacked_installer.cc @@ -35,7 +35,7 @@ class SimpleExtensionLoadPrompt : public ExtensionInstallPrompt::Delegate { SimpleExtensionLoadPrompt(Profile* profile, base::WeakPtr<ExtensionService> extension_service, const Extension* extension); - ~SimpleExtensionLoadPrompt(); + virtual ~SimpleExtensionLoadPrompt(); void ShowPrompt(); diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc index 98b5059..7b8e5d0 100644 --- a/chrome/browser/extensions/updater/extension_updater_unittest.cc +++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc @@ -371,7 +371,7 @@ class ServiceForDownloadTests : public MockService { fake_crx_installers_[id] = crx_installer; } - bool UpdateExtension( + virtual bool UpdateExtension( const std::string& id, const FilePath& extension_path, const GURL& download_url, diff --git a/chrome/browser/extensions/user_script_listener.cc b/chrome/browser/extensions/user_script_listener.cc index 1cb33d8..ec93cf7 100644 --- a/chrome/browser/extensions/user_script_listener.cc +++ b/chrome/browser/extensions/user_script_listener.cc @@ -37,7 +37,7 @@ class UserScriptListener::Throttle } // ResourceThrottle implementation: - virtual void WillStartRequest(bool* defer) { + virtual void WillStartRequest(bool* defer) OVERRIDE { // Only defer requests if Resume has not yet been called. if (should_defer_) { *defer = true; diff --git a/chrome/browser/extensions/user_script_listener_unittest.cc b/chrome/browser/extensions/user_script_listener_unittest.cc index ae227ef..a7fafe8 100644 --- a/chrome/browser/extensions/user_script_listener_unittest.cc +++ b/chrome/browser/extensions/user_script_listener_unittest.cc @@ -43,16 +43,16 @@ class ThrottleController : public base::SupportsUserData::Data, } // ResourceController implementation: - virtual void Resume() { + virtual void Resume() OVERRIDE { request_->Start(); } - virtual void Cancel() { + virtual void Cancel() OVERRIDE { NOTREACHED(); } - virtual void CancelAndIgnore() { + virtual void CancelAndIgnore() OVERRIDE { NOTREACHED(); } - virtual void CancelWithError(int error_code) { + virtual void CancelWithError(int error_code) OVERRIDE { NOTREACHED(); } @@ -73,7 +73,7 @@ class SimpleTestJob : public net::URLRequestTestJob { kTestData, true) {} private: - ~SimpleTestJob() {} + virtual ~SimpleTestJob() {} }; // Yoinked from extension_manifest_unittest.cc. @@ -130,7 +130,7 @@ class UserScriptListenerTest : public ExtensionServiceTestBase { new SimpleTestJobProtocolHandler())); } - ~UserScriptListenerTest() { + virtual ~UserScriptListenerTest() { net::URLRequestFilter::GetInstance()->RemoveHostnameHandler("http", "google.com"); net::URLRequestFilter::GetInstance()->RemoveHostnameHandler("http", diff --git a/chrome/browser/extensions/user_script_master_unittest.cc b/chrome/browser/extensions/user_script_master_unittest.cc index 133f523..8607652 100644 --- a/chrome/browser/extensions/user_script_master_unittest.cc +++ b/chrome/browser/extensions/user_script_master_unittest.cc @@ -66,7 +66,7 @@ class UserScriptMasterTest : public testing::Test, virtual void Observe(int type, const content::NotificationSource& source, - const content::NotificationDetails& details) { + const content::NotificationDetails& details) OVERRIDE { DCHECK(type == chrome::NOTIFICATION_USER_SCRIPTS_UPDATED); shared_memory_ = content::Details<base::SharedMemory>(details).ptr(); diff --git a/chrome/browser/extensions/web_view_browsertest.cc b/chrome/browser/extensions/web_view_browsertest.cc index 151fe5e..b3480af 100644 --- a/chrome/browser/extensions/web_view_browsertest.cc +++ b/chrome/browser/extensions/web_view_browsertest.cc @@ -24,7 +24,7 @@ using prerender::PrerenderLinkManagerFactory; class WebViewTest : public extensions::PlatformAppBrowserTest { protected: - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { extensions::PlatformAppBrowserTest::SetUpCommandLine(command_line); #if !defined(OS_MACOSX) CHECK(test_launcher_utils::OverrideGLImplementation( diff --git a/chrome/browser/extensions/webstore_standalone_install_browsertest.cc b/chrome/browser/extensions/webstore_standalone_install_browsertest.cc index ba0e2b4..d07d545 100644 --- a/chrome/browser/extensions/webstore_standalone_install_browsertest.cc +++ b/chrome/browser/extensions/webstore_standalone_install_browsertest.cc @@ -203,7 +203,7 @@ class WebstoreStandaloneInstallUnpackFailureTest switches::kAppsGalleryUpdateURL, crx_url.spec()); } - void SetUpInProcessBrowserTestFixture() OVERRIDE { + virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { WebstoreStandaloneInstallTest::SetUpInProcessBrowserTestFixture(); ExtensionInstallUI::DisableFailureUIForTests(); } diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc index ffb5fcd..244c0b9 100644 --- a/chrome/browser/extensions/window_open_apitest.cc +++ b/chrome/browser/extensions/window_open_apitest.cc @@ -189,7 +189,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) { } class WindowOpenPanelDisabledTest : public ExtensionApiTest { - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); // TODO(jennb): Re-enable when panels are enabled by default. // command_line->AppendSwitch(switches::kDisablePanels); @@ -202,7 +202,7 @@ IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest, } class WindowOpenPanelTest : public ExtensionApiTest { - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnablePanels); } diff --git a/chrome/browser/extensions/window_open_interactive_apitest.cc b/chrome/browser/extensions/window_open_interactive_apitest.cc index 331ff19..75384ab 100644 --- a/chrome/browser/extensions/window_open_interactive_apitest.cc +++ b/chrome/browser/extensions/window_open_interactive_apitest.cc @@ -7,7 +7,7 @@ #include "chrome/common/chrome_switches.h" class WindowOpenPanelTest : public ExtensionApiTest { - virtual void SetUpCommandLine(CommandLine* command_line) { + virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE { ExtensionApiTest::SetUpCommandLine(command_line); command_line->AppendSwitch(switches::kEnablePanels); } |