summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-09 22:53:19 +0000
committerrkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-12-09 22:53:19 +0000
commit4a21022ecd41318e0c9828bd21c601250ce141e4 (patch)
treebda15bdfbb5c2e8b802c54c628b5aea852f5a928
parent72233fdd79e63fbc6cb4822166da391d8b39d427 (diff)
downloadchromium_src-4a21022ecd41318e0c9828bd21c601250ce141e4.zip
chromium_src-4a21022ecd41318e0c9828bd21c601250ce141e4.tar.gz
chromium_src-4a21022ecd41318e0c9828bd21c601250ce141e4.tar.bz2
Add accessibility tags to Feedback.
Associate all the input fields with their respective labels by using the aria-labelledby attribute. Ensure that all the input id's pass the accessibility audit. R=xiyuan@chromium.org BUG=307538 Review URL: https://codereview.chromium.org/109143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239580 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/resources/feedback/html/default.html16
1 files changed, 8 insertions, 8 deletions
diff --git a/chrome/browser/resources/feedback/html/default.html b/chrome/browser/resources/feedback/html/default.html
index 5fd8f96..6f3c459 100644
--- a/chrome/browser/resources/feedback/html/default.html
+++ b/chrome/browser/resources/feedback/html/default.html
@@ -24,20 +24,20 @@
</span>
</div>
<div id="content-pane" class="content">
- <textarea id="description-text"></textarea>
+ <textarea id="description-text" aria-labelledby="title-bar"></textarea>
<div id="page-url" class="text-field-container">
<label id="page-url-label" i18n-content="page-url"></label>
- <input id="page-url-text" type="text">
+ <input id="page-url-text" aria-labelledby="page-url-label" type="text">
</div>
<!-- User e-mail -->
<div id="user-email" class="text-field-container">
<label id="user-email-label" i18n-content="user-email"></label>
- <input id="user-email-text" type="text">
+ <input id="user-email-text" aria-labelledby="user-email-label" type="text">
</div>
<!-- Attach a file -->
<div id="attach-file-container" class="text-field-container">
- <label i18n-content="attach-file-label"></label>
- <input id="attach-file" type="file">
+ <label id="attach-file-label" i18n-content="attach-file-label"></label>
+ <input id="attach-file" type="file" aria-labelledby="attach-file-label">
<div id="custom-file-container" hidden>
<label id="attached-filename-text"></label>
<button id="remove-attached-file" class="remove-file-button"></button>
@@ -48,14 +48,14 @@
<div id="attach-file-note" i18n-content="attach-file-note"></div>
<!-- Screenshot -->
<div id="screenshot-container" class="checkbox-field-container">
- <input id="screenshot-checkbox" type="checkbox" checked>
+ <input id="screenshot-checkbox" type="checkbox" aria-labelledby="screenshot-label" checked>
<label id="screenshot-label" i18n-content="screenshot"></label>
- <img id="screenshot-image">
+ <img id="screenshot-image" alt="screenshot">
</div>
<if expr="pp_ifdef('chromeos')">
<!-- System Information -->
<div class="checkbox-field-container">
- <input id="sys-info-checkbox" type="checkbox" checked>
+ <input id="sys-info-checkbox" type="checkbox" aria-labelledby="sys-info-label" checked>
<label id="sys-info-label" i18n-values=".innerHTML:sys-info"></label>
</span>
</div>