summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrobliao <robliao@chromium.org>2015-09-28 20:45:36 -0700
committerCommit bot <commit-bot@chromium.org>2015-09-29 03:46:22 +0000
commit4a5556ba027965f731844dd0f8093944fd6ab112 (patch)
tree685f604f5c8fd2118e2ccd65228adf7b9c96a8f3
parentbcf491b6751a352bda8d801907c05a9215f47007 (diff)
downloadchromium_src-4a5556ba027965f731844dd0f8093944fd6ab112.zip
chromium_src-4a5556ba027965f731844dd0f8093944fd6ab112.tar.gz
chromium_src-4a5556ba027965f731844dd0f8093944fd6ab112.tar.bz2
Remove all Windows Window Scoped Trackers and Associated Instrumentation
The jank dashboard shows that there is nothing actionable remaining to do here. The sampling profiler should be able to supersede any manual tracking should we need to investigate future jank. BUG=440919 Review URL: https://codereview.chromium.org/1370993003 Cr-Commit-Position: refs/heads/master@{#351254}
-rw-r--r--base/message_loop/message_pump_win.cc30
-rw-r--r--base/power_monitor/power_monitor_device_source_win.cc1
-rw-r--r--base/win/message_window.cc1
-rw-r--r--chrome/browser/ui/views/status_icons/status_tray_win.cc1
-rw-r--r--components/browser_watcher/endsession_watcher_window_win.cc1
-rw-r--r--components/omnibox/browser/omnibox_edit_model.cc5
-rw-r--r--components/storage_monitor/storage_monitor_win.cc1
-rw-r--r--content/browser/renderer_host/render_widget_host_view_base.cc1
-rw-r--r--content/browser/system_message_window_win.h1
-rw-r--r--ui/aura/window.cc5
-rw-r--r--ui/base/ime/input_method_win.cc33
-rw-r--r--ui/base/win/foreground_helper.cc5
-rw-r--r--ui/gfx/win/hwnd_util.cc6
-rw-r--r--ui/gfx/win/window_impl.cc5
-rw-r--r--ui/platform_window/win/win_window.cc37
-rw-r--r--ui/views/controls/menu/native_menu_win.cc1
-rw-r--r--ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc5
-rw-r--r--ui/views/win/hwnd_message_handler.cc345
-rw-r--r--win8/metro_driver/metro_driver_win7.cc1
19 files changed, 3 insertions, 482 deletions
diff --git a/base/message_loop/message_pump_win.cc b/base/message_loop/message_pump_win.cc
index 10e308a..14e4320 100644
--- a/base/message_loop/message_pump_win.cc
+++ b/base/message_loop/message_pump_win.cc
@@ -10,7 +10,6 @@
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/process/memory.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/stringprintf.h"
#include "base/trace_event/trace_event.h"
#include "base/win/wrapped_window_proc.h"
@@ -132,11 +131,6 @@ void MessagePumpForUI::ScheduleDelayedWork(const TimeTicks& delayed_work_time) {
// static
LRESULT CALLBACK MessagePumpForUI::WndProcThunk(
HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 MessagePumpForUI::WndProcThunk1"));
-
switch (message) {
case kMsgHaveWork:
reinterpret_cast<MessagePumpForUI*>(wparam)->HandleWorkMessage();
@@ -145,12 +139,6 @@ LRESULT CALLBACK MessagePumpForUI::WndProcThunk(
reinterpret_cast<MessagePumpForUI*>(wparam)->HandleTimerMessage();
break;
}
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 MessagePumpForUI::WndProcThunk2"));
-
return DefWindowProc(hwnd, message, wparam, lparam);
}
@@ -345,11 +333,6 @@ void MessagePumpForUI::RescheduleTimer() {
}
bool MessagePumpForUI::ProcessNextWindowsMessage() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 MessagePumpForUI::ProcessNextWindowsMessage1"));
-
// If there are sent messages in the queue then PeekMessage internally
// dispatches the message and returns false. We return true in this
// case to ensure that the message loop peeks again instead of calling
@@ -359,11 +342,6 @@ bool MessagePumpForUI::ProcessNextWindowsMessage() {
if (HIWORD(queue_status) & QS_SENDMESSAGE)
sent_messages_in_queue = true;
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 MessagePumpForUI::ProcessNextWindowsMessage2"));
-
MSG msg;
if (PeekMessage(&msg, NULL, 0, 0, PM_REMOVE) != FALSE)
return ProcessMessageHelper(msg);
@@ -390,14 +368,8 @@ bool MessagePumpForUI::ProcessMessageHelper(const MSG& msg) {
return true;
uint32_t action = MessagePumpDispatcher::POST_DISPATCH_PERFORM_DEFAULT;
- if (state_->dispatcher) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 MessagePumpForUI::ProcessMessageHelper4"));
-
+ if (state_->dispatcher)
action = state_->dispatcher->Dispatch(msg);
- }
if (action & MessagePumpDispatcher::POST_DISPATCH_QUIT_LOOP)
state_->should_quit = true;
if (action & MessagePumpDispatcher::POST_DISPATCH_PERFORM_DEFAULT) {
diff --git a/base/power_monitor/power_monitor_device_source_win.cc b/base/power_monitor/power_monitor_device_source_win.cc
index 69bc6aa..b8b16e1 100644
--- a/base/power_monitor/power_monitor_device_source_win.cc
+++ b/base/power_monitor/power_monitor_device_source_win.cc
@@ -5,7 +5,6 @@
#include "base/power_monitor/power_monitor.h"
#include "base/power_monitor/power_monitor_device_source.h"
#include "base/power_monitor/power_monitor_source.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/win/wrapped_window_proc.h"
namespace base {
diff --git a/base/win/message_window.cc b/base/win/message_window.cc
index 58010e4..57fe64c 100644
--- a/base/win/message_window.cc
+++ b/base/win/message_window.cc
@@ -7,7 +7,6 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/process/memory.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/win/wrapped_window_proc.h"
const wchar_t kMessageWindowClassName[] = L"Chrome_MessageWindow";
diff --git a/chrome/browser/ui/views/status_icons/status_tray_win.cc b/chrome/browser/ui/views/status_icons/status_tray_win.cc
index 0b560bd..a87eec1 100644
--- a/chrome/browser/ui/views/status_icons/status_tray_win.cc
+++ b/chrome/browser/ui/views/status_icons/status_tray_win.cc
@@ -8,7 +8,6 @@
#include "base/bind.h"
#include "base/location.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/non_thread_safe.h"
#include "base/threading/thread.h"
diff --git a/components/browser_watcher/endsession_watcher_window_win.cc b/components/browser_watcher/endsession_watcher_window_win.cc
index ddf9932..cf4bb82 100644
--- a/components/browser_watcher/endsession_watcher_window_win.cc
+++ b/components/browser_watcher/endsession_watcher_window_win.cc
@@ -5,7 +5,6 @@
#include "components/browser_watcher/endsession_watcher_window_win.h"
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/win/wrapped_window_proc.h"
namespace browser_watcher {
diff --git a/components/omnibox/browser/omnibox_edit_model.cc b/components/omnibox/browser/omnibox_edit_model.cc
index c6767dd..c33278f 100644
--- a/components/omnibox/browser/omnibox_edit_model.cc
+++ b/components/omnibox/browser/omnibox_edit_model.cc
@@ -11,7 +11,6 @@
#include "base/format_macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/user_metrics.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -477,10 +476,6 @@ void OmniboxEditModel::StartAutocomplete(
bool has_selected_text,
bool prevent_inline_autocomplete,
bool entering_keyword_mode) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 OmniboxEditModel::StartAutocomplete"));
size_t cursor_position;
if (inline_autocomplete_text_.empty()) {
// Cursor position is equivalent to the current selection's end.
diff --git a/components/storage_monitor/storage_monitor_win.cc b/components/storage_monitor/storage_monitor_win.cc
index dae08e8..95a6911 100644
--- a/components/storage_monitor/storage_monitor_win.cc
+++ b/components/storage_monitor/storage_monitor_win.cc
@@ -9,7 +9,6 @@
#include <fileapi.h>
#include <shlobj.h>
-#include "base/profiler/scoped_tracker.h"
#include "base/win/wrapped_window_proc.h"
#include "components/storage_monitor/portable_device_watcher_win.h"
#include "components/storage_monitor/removable_device_constants.h"
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 37fef07..1b40705 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -5,7 +5,6 @@
#include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/gpu/gpu_data_manager_impl.h"
#include "content/browser/renderer_host/input/synthetic_gesture_target_base.h"
diff --git a/content/browser/system_message_window_win.h b/content/browser/system_message_window_win.h
index 43527da..b29bad5 100644
--- a/content/browser/system_message_window_win.h
+++ b/content/browser/system_message_window_win.h
@@ -9,7 +9,6 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
-#include "base/profiler/scoped_tracker.h"
#include "content/common/content_export.h"
namespace content {
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index 6cde8c2..c67c0a8 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -10,7 +10,6 @@
#include "base/bind_helpers.h"
#include "base/callback.h"
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -714,10 +713,6 @@ void Window::SetBoundsInternal(const gfx::Rect& new_bounds) {
}
void Window::SetVisible(bool visible) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 Window::SetVisible"));
-
if (visible == layer()->GetTargetVisibility())
return; // No change.
diff --git a/ui/base/ime/input_method_win.cc b/ui/base/ime/input_method_win.cc
index 7db88b6..df75bb2 100644
--- a/ui/base/ime/input_method_win.cc
+++ b/ui/base/ime/input_method_win.cc
@@ -6,7 +6,6 @@
#include "base/auto_reset.h"
#include "base/basictypes.h"
-#include "base/profiler/scoped_tracker.h"
#include "ui/base/ime/text_input_client.h"
#include "ui/base/ime/win/tsf_input_scope.h"
#include "ui/events/event.h"
@@ -218,10 +217,6 @@ LRESULT InputMethodWin::OnChar(HWND window_handle,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 InputMethodWin::OnChar"));
-
*handled = TRUE;
if (suppress_next_char_) {
@@ -260,11 +255,6 @@ LRESULT InputMethodWin::OnImeSetContext(HWND window_handle,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 InputMethodWin::OnImeSetContext"));
-
if (!!wparam) {
imm32_manager_.CreateImeWindow(window_handle);
if (system_toplevel_window_focused()) {
@@ -288,11 +278,6 @@ LRESULT InputMethodWin::OnImeStartComposition(HWND window_handle,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 InputMethodWin::OnImeStartComposition"));
-
// We have to prevent WTL from calling ::DefWindowProc() because the function
// calls ::ImmSetCompositionWindow() and ::ImmSetCandidateWindow() to
// over-write the position of IME windows.
@@ -310,11 +295,6 @@ LRESULT InputMethodWin::OnImeComposition(HWND window_handle,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 InputMethodWin::OnImeComposition"));
-
// We have to prevent WTL from calling ::DefWindowProc() because we do not
// want for the IMM (Input Method Manager) to send WM_IME_CHAR messages.
*handled = TRUE;
@@ -348,11 +328,6 @@ LRESULT InputMethodWin::OnImeEndComposition(HWND window_handle,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 InputMethodWin::OnImeEndComposition"));
-
// Let WTL call ::DefWindowProc() and release its resources.
*handled = FALSE;
@@ -370,10 +345,6 @@ LRESULT InputMethodWin::OnImeNotify(UINT message,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 InputMethodWin::OnImeNotify"));
-
*handled = FALSE;
// Update |is_candidate_popup_open_|, whether a candidate window is open.
@@ -393,10 +364,6 @@ LRESULT InputMethodWin::OnImeRequest(UINT message,
WPARAM wparam,
LPARAM lparam,
BOOL* handled) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 InputMethodWin::OnImeRequest"));
-
*handled = FALSE;
// Should not receive WM_IME_REQUEST message, if IME is disabled.
diff --git a/ui/base/win/foreground_helper.cc b/ui/base/win/foreground_helper.cc
index 605deb0..7283012 100644
--- a/ui/base/win/foreground_helper.cc
+++ b/ui/base/win/foreground_helper.cc
@@ -5,7 +5,6 @@
#include "ui/base/win/foreground_helper.h"
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "ui/gfx/win/window_impl.h"
namespace ui {
@@ -75,10 +74,6 @@ HRESULT ForegroundHelper::ForegroundHotKey(HWND window) {
// Handle the registered Hotkey being pressed.
void ForegroundHelper::OnHotKey(int id, UINT vcode, UINT modifiers) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 ForegroundHelper::OnHotKey"));
-
SetForegroundWindow(window_);
}
diff --git a/ui/gfx/win/hwnd_util.cc b/ui/gfx/win/hwnd_util.cc
index 5700ccf..f02a312 100644
--- a/ui/gfx/win/hwnd_util.cc
+++ b/ui/gfx/win/hwnd_util.cc
@@ -6,7 +6,6 @@
#include "base/i18n/rtl.h"
#include "base/strings/string_util.h"
-#include "base/tracked_objects.h"
#include "base/win/metro.h"
#include "base/win/win_util.h"
#include "ui/gfx/geometry/point.h"
@@ -224,13 +223,8 @@ void ShowSystemMenuAtPoint(HWND window, const Point& point) {
flags |= TPM_RIGHTALIGN;
HMENU menu = GetSystemMenu(window, FALSE);
- // Use task stopwatch to exclude the time while the context menu is open from
- // the current task, if any.
- tracked_objects::TaskStopwatch stopwatch;
- stopwatch.Start();
const int command =
TrackPopupMenu(menu, flags, point.x(), point.y(), 0, window, NULL);
- stopwatch.Stop();
if (command)
SendMessage(window, WM_SYSCOMMAND, command, 0);
diff --git a/ui/gfx/win/window_impl.cc b/ui/gfx/win/window_impl.cc
index 375434f..bc0cb00 100644
--- a/ui/gfx/win/window_impl.cc
+++ b/ui/gfx/win/window_impl.cc
@@ -9,7 +9,6 @@
#include "base/bind.h"
#include "base/debug/alias.h"
#include "base/memory/singleton.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_number_conversions.h"
#include "base/synchronization/lock.h"
#include "base/win/wrapped_window_proc.h"
@@ -283,10 +282,6 @@ LRESULT CALLBACK WindowImpl::WndProc(HWND hwnd,
UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WindowImpl::WndProc"));
-
if (message == WM_NCCREATE) {
CREATESTRUCT* cs = reinterpret_cast<CREATESTRUCT*>(l_param);
WindowImpl* window = reinterpret_cast<WindowImpl*>(cs->lpCreateParams);
diff --git a/ui/platform_window/win/win_window.cc b/ui/platform_window/win/win_window.cc
index 8dd2c1c..718a409 100644
--- a/ui/platform_window/win/win_window.cc
+++ b/ui/platform_window/win/win_window.cc
@@ -4,7 +4,6 @@
#include "ui/platform_window/win/win_window.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string16.h"
#include "ui/events/event.h"
#include "ui/events/event_utils.h"
@@ -119,10 +118,6 @@ PlatformImeController* WinWindow::GetPlatformImeController() {
}
LRESULT WinWindow::OnMouseRange(UINT message, WPARAM w_param, LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnMouseRange"));
-
MSG msg = { hwnd(), message, w_param, l_param,
static_cast<DWORD>(GetMessageTime()),
{ CR_GET_X_LPARAM(l_param), CR_GET_Y_LPARAM(l_param) } };
@@ -138,19 +133,11 @@ LRESULT WinWindow::OnMouseRange(UINT message, WPARAM w_param, LPARAM l_param) {
LRESULT WinWindow::OnCaptureChanged(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnCaptureChanged"));
-
delegate_->OnLostCapture();
return 0;
}
LRESULT WinWindow::OnKeyEvent(UINT message, WPARAM w_param, LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnKeyEvent"));
-
MSG msg = { hwnd(), message, w_param, l_param };
KeyEvent event(msg);
delegate_->DispatchEvent(&event);
@@ -159,45 +146,25 @@ LRESULT WinWindow::OnKeyEvent(UINT message, WPARAM w_param, LPARAM l_param) {
}
LRESULT WinWindow::OnNCActivate(UINT message, WPARAM w_param, LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnNCActivate"));
-
delegate_->OnActivationChanged(!!w_param);
return DefWindowProc(hwnd(), message, w_param, l_param);
}
void WinWindow::OnClose() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnClose"));
-
delegate_->OnCloseRequest();
}
LRESULT WinWindow::OnCreate(CREATESTRUCT* create_struct) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnCreate"));
-
// TODO(sky): provide real scale factor.
delegate_->OnAcceleratedWidgetAvailable(hwnd(), 1.f);
return 0;
}
void WinWindow::OnDestroy() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnDestroy"));
-
delegate_->OnClosed();
}
void WinWindow::OnPaint(HDC) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnPaint"));
-
gfx::Rect damage_rect;
RECT update_rect = {0};
if (GetUpdateRect(hwnd(), &update_rect, FALSE))
@@ -207,10 +174,6 @@ void WinWindow::OnPaint(HDC) {
}
void WinWindow::OnWindowPosChanged(WINDOWPOS* window_pos) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 WinWindow::OnWindowPosChanged"));
-
if (!(window_pos->flags & SWP_NOSIZE) ||
!(window_pos->flags & SWP_NOMOVE)) {
RECT cr;
diff --git a/ui/views/controls/menu/native_menu_win.cc b/ui/views/controls/menu/native_menu_win.cc
index 6ca0b30..4d0a67a 100644
--- a/ui/views/controls/menu/native_menu_win.cc
+++ b/ui/views/controls/menu/native_menu_win.cc
@@ -9,7 +9,6 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/win/wrapped_window_proc.h"
diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc
index 8afa69b..1549b2e 100644
--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc
+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc
@@ -5,7 +5,6 @@
#include "ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h"
#include "base/metrics/histogram_macros.h"
-#include "base/tracked_objects.h"
#include "ui/base/dragdrop/drag_drop_types.h"
#include "ui/base/dragdrop/drag_source_win.h"
#include "ui/base/dragdrop/drop_target_event.h"
@@ -52,13 +51,9 @@ int DesktopDragDropClientWin::StartDragAndDrop(
UMA_HISTOGRAM_ENUMERATION("Event.DragDrop.Start", source,
ui::DragDropTypes::DRAG_EVENT_SOURCE_COUNT);
- // Use task stopwatch to exclude the drag-drop time current task, if any.
- tracked_objects::TaskStopwatch stopwatch;
- stopwatch.Start();
HRESULT result = DoDragDrop(
ui::OSExchangeDataProviderWin::GetIDataObject(data), drag_source_.Get(),
ui::DragDropTypes::DragOperationToDropEffect(operation), &effect);
- stopwatch.Stop();
drag_source_copy->set_data(nullptr);
if (alive)
diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc
index 5560aca..5348080 100644
--- a/ui/views/win/hwnd_message_handler.cc
+++ b/ui/views/win/hwnd_message_handler.cc
@@ -11,9 +11,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/debug/alias.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/trace_event/trace_event.h"
-#include "base/tracked_objects.h"
#include "base/win/scoped_gdi_object.h"
#include "base/win/win_util.h"
#include "base/win/windows_version.h"
@@ -884,22 +882,12 @@ HICON HWNDMessageHandler::GetSmallWindowIcon() const {
LRESULT HWNDMessageHandler::OnWndProc(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWndProc1"));
-
HWND window = hwnd();
LRESULT result = 0;
if (delegate_ && delegate_->PreHandleMSG(message, w_param, l_param, &result))
return result;
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWndProc2"));
-
// Otherwise we handle everything else.
// NOTE: We inline ProcessWindowMessage() as 'this' may be destroyed during
// dispatch and ProcessWindowMessage() doesn't deal with that well.
@@ -912,11 +900,6 @@ LRESULT HWNDMessageHandler::OnWndProc(UINT message,
msg_handled_ = old_msg_handled;
if (!processed) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWndProc3"));
-
result = DefWindowProc(window, message, w_param, l_param);
// DefWindowProc() may have destroyed the window and/or us in a nested
// message loop.
@@ -925,24 +908,13 @@ LRESULT HWNDMessageHandler::OnWndProc(UINT message,
}
if (delegate_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWndProc4"));
-
delegate_->PostHandleMSG(message, w_param, l_param);
if (message == WM_NCDESTROY)
delegate_->HandleDestroyed();
}
- if (message == WM_ACTIVATE && IsTopLevelWindow(window)) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWndProc5"));
-
+ if (message == WM_ACTIVATE && IsTopLevelWindow(window))
PostProcessActivateMessage(LOWORD(w_param), !!HIWORD(w_param));
- }
return result;
}
@@ -1024,11 +996,6 @@ int HWNDMessageHandler::GetAppbarAutohideEdges(HMONITOR monitor) {
}
void HWNDMessageHandler::OnAppbarAutohideEdgesChanged() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnAppbarAutohideEdgesChanged"));
-
// This triggers querying WM_NCCALCSIZE again.
RECT client;
GetWindowRect(hwnd(), &client);
@@ -1247,11 +1214,6 @@ void HWNDMessageHandler::ForceRedrawWindow(int attempts) {
// Message handlers ------------------------------------------------------------
void HWNDMessageHandler::OnActivateApp(BOOL active, DWORD thread_id) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnActivateApp"));
-
if (delegate_->IsWidgetWindow() && !active &&
thread_id != GetCurrentThreadId()) {
delegate_->HandleAppDeactivated();
@@ -1265,11 +1227,6 @@ BOOL HWNDMessageHandler::OnAppCommand(HWND window,
short command,
WORD device,
int keystate) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnAppCommand"));
-
BOOL handled = !!delegate_->HandleAppCommand(command);
SetMsgHandled(handled);
// Make sure to return TRUE if the event was handled or in some cases the
@@ -1279,40 +1236,22 @@ BOOL HWNDMessageHandler::OnAppCommand(HWND window,
}
void HWNDMessageHandler::OnCancelMode() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnCancelMode"));
-
delegate_->HandleCancelMode();
// Need default handling, otherwise capture and other things aren't canceled.
SetMsgHandled(FALSE);
}
void HWNDMessageHandler::OnCaptureChanged(HWND window) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnCaptureChanged"));
-
delegate_->HandleCaptureLost();
}
void HWNDMessageHandler::OnClose() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnClose"));
-
delegate_->HandleClose();
}
void HWNDMessageHandler::OnCommand(UINT notification_code,
int command,
HWND window) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCommand"));
-
// If the notification code is > 1 it means it is control specific and we
// should ignore it.
if (notification_code > 1 || delegate_->HandleAppCommand(command))
@@ -1320,16 +1259,7 @@ void HWNDMessageHandler::OnCommand(UINT notification_code,
}
LRESULT HWNDMessageHandler::OnCreate(CREATESTRUCT* create_struct) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate1"));
-
if (window_ex_style() & WS_EX_COMPOSITED) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnCreate2"));
-
if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
// This is part of the magic to emulate layered windows with Aura
// see the explanation elsewere when we set WS_EX_COMPOSITED style.
@@ -1340,10 +1270,6 @@ LRESULT HWNDMessageHandler::OnCreate(CREATESTRUCT* create_struct) {
fullscreen_handler_->set_hwnd(hwnd());
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate3"));
-
// This message initializes the window so that focus border are shown for
// windows.
SendMessage(hwnd(),
@@ -1352,20 +1278,11 @@ LRESULT HWNDMessageHandler::OnCreate(CREATESTRUCT* create_struct) {
0);
if (remove_standard_frame_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnCreate4"));
-
SetWindowLong(hwnd(), GWL_STYLE,
GetWindowLong(hwnd(), GWL_STYLE) & ~WS_CAPTION);
SendFrameChanged();
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate5"));
-
// Get access to a modifiable copy of the system menu.
GetSystemMenu(hwnd(), false);
@@ -1373,25 +1290,13 @@ LRESULT HWNDMessageHandler::OnCreate(CREATESTRUCT* create_struct) {
ui::AreTouchEventsEnabled())
RegisterTouchWindow(hwnd(), TWF_WANTPALM);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile6(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate6"));
-
// We need to allow the delegate to size its contents since the window may not
// receive a size notification when its initial bounds are specified at window
// creation time.
ClientAreaSizeChanged();
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile7(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate7"));
-
delegate_->HandleCreate();
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile8(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnCreate8"));
-
windows_session_change_observer_.reset(new WindowsSessionChangeObserver(
base::Bind(&HWNDMessageHandler::OnSessionChange,
base::Unretained(this))));
@@ -1401,32 +1306,18 @@ LRESULT HWNDMessageHandler::OnCreate(CREATESTRUCT* create_struct) {
}
void HWNDMessageHandler::OnDestroy() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnDestroy"));
-
windows_session_change_observer_.reset(nullptr);
delegate_->HandleDestroying();
}
void HWNDMessageHandler::OnDisplayChange(UINT bits_per_pixel,
const gfx::Size& screen_size) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnDisplayChange"));
-
delegate_->HandleDisplayChange();
}
LRESULT HWNDMessageHandler::OnDwmCompositionChanged(UINT msg,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnDwmCompositionChanged"));
-
if (!delegate_->IsWidgetWindow()) {
SetMsgHandled(FALSE);
return 0;
@@ -1437,21 +1328,11 @@ LRESULT HWNDMessageHandler::OnDwmCompositionChanged(UINT msg,
}
void HWNDMessageHandler::OnEnterMenuLoop(BOOL from_track_popup_menu) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnEnterMenuLoop"));
-
if (menu_depth_++ == 0)
delegate_->HandleMenuLoop(true);
}
void HWNDMessageHandler::OnEnterSizeMove() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnEnterSizeMove"));
-
// Please refer to the comments in the OnSize function about the scrollbar
// hack.
// Hide the Windows scrollbar if the scroll styles are present to ensure
@@ -1469,22 +1350,12 @@ LRESULT HWNDMessageHandler::OnEraseBkgnd(HDC dc) {
}
void HWNDMessageHandler::OnExitMenuLoop(BOOL is_shortcut_menu) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnExitMenuLoop"));
-
if (--menu_depth_ == 0)
delegate_->HandleMenuLoop(false);
DCHECK_GE(0, menu_depth_);
}
void HWNDMessageHandler::OnExitSizeMove() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnExitSizeMove"));
-
delegate_->HandleEndWMSizeMove();
SetMsgHandled(FALSE);
// Please refer to the notes in the OnSize function for information about
@@ -1497,11 +1368,6 @@ void HWNDMessageHandler::OnExitSizeMove() {
}
void HWNDMessageHandler::OnGetMinMaxInfo(MINMAXINFO* minmax_info) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnGetMinMaxInfo"));
-
gfx::Size min_window_size;
gfx::Size max_window_size;
delegate_->GetMinMaxSize(&min_window_size, &max_window_size);
@@ -1540,11 +1406,6 @@ void HWNDMessageHandler::OnGetMinMaxInfo(MINMAXINFO* minmax_info) {
LRESULT HWNDMessageHandler::OnGetObject(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnGetObject"));
-
LRESULT reference_result = static_cast<LRESULT>(0L);
// Only the lower 32 bits of l_param are valid when checking the object id
@@ -1568,11 +1429,6 @@ LRESULT HWNDMessageHandler::OnGetObject(UINT message,
LRESULT HWNDMessageHandler::OnImeMessages(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnImeMessages"));
-
LRESULT result = 0;
base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr());
const bool msg_handled =
@@ -1583,11 +1439,6 @@ LRESULT HWNDMessageHandler::OnImeMessages(UINT message,
}
void HWNDMessageHandler::OnInitMenu(HMENU menu) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnInitMenu"));
-
bool is_fullscreen = fullscreen_handler_->fullscreen();
bool is_minimized = IsMinimized();
bool is_maximized = IsMaximized();
@@ -1611,22 +1462,12 @@ void HWNDMessageHandler::OnInitMenu(HMENU menu) {
void HWNDMessageHandler::OnInputLangChange(DWORD character_set,
HKL input_language_id) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnInputLangChange"));
-
delegate_->HandleInputLanguageChange(character_set, input_language_id);
}
LRESULT HWNDMessageHandler::OnKeyEvent(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnKeyEvent"));
-
MSG msg = {
hwnd(), message, w_param, l_param, static_cast<DWORD>(GetMessageTime())};
ui::KeyEvent key(msg);
@@ -1637,11 +1478,6 @@ LRESULT HWNDMessageHandler::OnKeyEvent(UINT message,
}
void HWNDMessageHandler::OnKillFocus(HWND focused_window) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnKillFocus"));
-
delegate_->HandleNativeBlur(focused_window);
SetMsgHandled(FALSE);
}
@@ -1649,11 +1485,6 @@ void HWNDMessageHandler::OnKillFocus(HWND focused_window) {
LRESULT HWNDMessageHandler::OnMouseActivate(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnMouseActivate"));
-
// Please refer to the comments in the header for the touch_down_contexts_
// member for the if statement below.
if (touch_down_contexts_)
@@ -1698,39 +1529,21 @@ LRESULT HWNDMessageHandler::OnMouseActivate(UINT message,
LRESULT HWNDMessageHandler::OnMouseRange(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnMouseRange"));
-
return HandleMouseEventInternal(message, w_param, l_param, true);
}
void HWNDMessageHandler::OnMove(const gfx::Point& point) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnMove"));
-
delegate_->HandleMove();
SetMsgHandled(FALSE);
}
void HWNDMessageHandler::OnMoving(UINT param, const RECT* new_bounds) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnMoving"));
-
delegate_->HandleMove();
}
LRESULT HWNDMessageHandler::OnNCActivate(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnNCActivate"));
-
// Per MSDN, w_param is either TRUE or FALSE. However, MSDN also hints that:
// "If the window is minimized when this message is received, the application
// should pass the message to the DefWindowProc function."
@@ -1783,11 +1596,6 @@ LRESULT HWNDMessageHandler::OnNCActivate(UINT message,
}
LRESULT HWNDMessageHandler::OnNCCalcSize(BOOL mode, LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnNCCalcSize"));
-
// We only override the default handling if we need to specify a custom
// non-client edge width. Note that in most cases "no insets" means no
// custom width, but in fullscreen mode or when the NonClientFrameView
@@ -1886,11 +1694,6 @@ LRESULT HWNDMessageHandler::OnNCCalcSize(BOOL mode, LPARAM l_param) {
}
LRESULT HWNDMessageHandler::OnNCHitTest(const gfx::Point& point) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnNCHitTest"));
-
if (!delegate_->IsWidgetWindow()) {
SetMsgHandled(FALSE);
return 0;
@@ -1965,10 +1768,6 @@ LRESULT HWNDMessageHandler::OnNCHitTest(const gfx::Point& point) {
}
void HWNDMessageHandler::OnNCPaint(HRGN rgn) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnNCPaint"));
-
// We only do non-client painting if we're not using the native frame.
// It's required to avoid some native painting artifacts from appearing when
// the window is resized.
@@ -2022,11 +1821,6 @@ void HWNDMessageHandler::OnNCPaint(HRGN rgn) {
LRESULT HWNDMessageHandler::OnNCUAHDrawCaption(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnNCUAHDrawCaption"));
-
// See comment in widget_win.h at the definition of WM_NCUAHDRAWCAPTION for
// an explanation about why we need to handle this message.
SetMsgHandled(delegate_->IsUsingCustomFrame());
@@ -2036,11 +1830,6 @@ LRESULT HWNDMessageHandler::OnNCUAHDrawCaption(UINT message,
LRESULT HWNDMessageHandler::OnNCUAHDrawFrame(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnNCUAHDrawFrame"));
-
// See comment in widget_win.h at the definition of WM_NCUAHDRAWCAPTION for
// an explanation about why we need to handle this message.
SetMsgHandled(delegate_->IsUsingCustomFrame());
@@ -2048,20 +1837,12 @@ LRESULT HWNDMessageHandler::OnNCUAHDrawFrame(UINT message,
}
LRESULT HWNDMessageHandler::OnNotify(int w_param, NMHDR* l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnNotify"));
-
LRESULT l_result = 0;
SetMsgHandled(delegate_->HandleTooltipNotify(w_param, l_param, &l_result));
return l_result;
}
void HWNDMessageHandler::OnPaint(HDC dc) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnPaint"));
-
// Call BeginPaint()/EndPaint() around the paint handling, as that seems
// to do more to actually validate the window's drawing region. This only
// appears to matter for Windows that have the WS_EX_COMPOSITED style set
@@ -2104,11 +1885,6 @@ LRESULT HWNDMessageHandler::OnReflectedMessage(UINT message,
LRESULT HWNDMessageHandler::OnScrollMessage(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnScrollMessage"));
-
MSG msg = {
hwnd(), message, w_param, l_param, static_cast<DWORD>(GetMessageTime())};
ui::ScrollEvent event(msg);
@@ -2119,11 +1895,6 @@ LRESULT HWNDMessageHandler::OnScrollMessage(UINT message,
LRESULT HWNDMessageHandler::OnSetCursor(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnSetCursor"));
-
// Reimplement the necessary default behavior here. Calling DefWindowProc can
// trigger weird non-client painting for non-glass windows with custom frames.
// Using a ScopedRedrawLock to prevent caption rendering artifacts may allow
@@ -2165,41 +1936,23 @@ LRESULT HWNDMessageHandler::OnSetCursor(UINT message,
}
void HWNDMessageHandler::OnSetFocus(HWND last_focused_window) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnSetFocus"));
-
delegate_->HandleNativeFocus(last_focused_window);
SetMsgHandled(FALSE);
}
LRESULT HWNDMessageHandler::OnSetIcon(UINT size_type, HICON new_icon) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnSetIcon"));
-
// Use a ScopedRedrawLock to avoid weird non-client painting.
return DefWindowProcWithRedrawLock(WM_SETICON, size_type,
reinterpret_cast<LPARAM>(new_icon));
}
LRESULT HWNDMessageHandler::OnSetText(const wchar_t* text) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnSetText"));
-
// Use a ScopedRedrawLock to avoid weird non-client painting.
return DefWindowProcWithRedrawLock(WM_SETTEXT, NULL,
reinterpret_cast<LPARAM>(text));
}
void HWNDMessageHandler::OnSettingChange(UINT flags, const wchar_t* section) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnSettingChange"));
-
if (!GetParent(hwnd()) && (flags == SPI_SETWORKAREA) &&
!delegate_->WillProcessWorkAreaChange()) {
// Fire a dummy SetWindowPos() call, so we'll trip the code in
@@ -2215,10 +1968,6 @@ void HWNDMessageHandler::OnSettingChange(UINT flags, const wchar_t* section) {
}
void HWNDMessageHandler::OnSize(UINT param, const gfx::Size& size) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("440919 HWNDMessageHandler::OnSize"));
-
RedrawWindow(hwnd(), NULL, NULL, RDW_INVALIDATE | RDW_ALLCHILDREN);
// ResetWindowRegion is going to trigger WM_NCPAINT. By doing it after we've
// invoked OnSize we ensure the RootView has been laid out.
@@ -2240,11 +1989,6 @@ void HWNDMessageHandler::OnSize(UINT param, const gfx::Size& size) {
void HWNDMessageHandler::OnSysCommand(UINT notification_code,
const gfx::Point& point) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnSysCommand"));
-
if (!delegate_->ShouldHandleSystemCommands())
return;
@@ -2295,19 +2039,10 @@ void HWNDMessageHandler::OnSysCommand(UINT notification_code,
// with the mouse/touch/keyboard, we flag as being in a size loop.
if ((notification_code & sc_mask) == SC_SIZE)
in_size_loop_ = true;
- const bool runs_nested_loop = ((notification_code & sc_mask) == SC_SIZE) ||
- ((notification_code & sc_mask) == SC_MOVE);
base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr());
- // Use task stopwatch to exclude the time spend in the move/resize loop from
- // the current task, if any.
- tracked_objects::TaskStopwatch stopwatch;
- if (runs_nested_loop)
- stopwatch.Start();
DefWindowProc(hwnd(), WM_SYSCOMMAND, notification_code,
MAKELPARAM(point.x(), point.y()));
- if (runs_nested_loop)
- stopwatch.Stop();
if (!ref.get())
return;
@@ -2316,22 +2051,12 @@ void HWNDMessageHandler::OnSysCommand(UINT notification_code,
}
void HWNDMessageHandler::OnThemeChanged() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnThemeChanged"));
-
ui::NativeThemeWin::instance()->CloseHandles();
}
LRESULT HWNDMessageHandler::OnTouchEvent(UINT message,
WPARAM w_param,
LPARAM l_param) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnTouchEvent"));
-
// Handle touch events only on Aura for now.
int num_points = LOWORD(w_param);
scoped_ptr<TOUCHINPUT[]> input(new TOUCHINPUT[num_points]);
@@ -2404,11 +2129,6 @@ LRESULT HWNDMessageHandler::OnTouchEvent(UINT message,
}
void HWNDMessageHandler::OnWindowPosChanging(WINDOWPOS* window_pos) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWindowPosChanging"));
-
if (ignore_window_pos_changes_) {
// If somebody's trying to toggle our visibility, change the nonclient area,
// change our Z-order, or activate us, we should probably let it go through.
@@ -2500,11 +2220,6 @@ void HWNDMessageHandler::OnWindowPosChanging(WINDOWPOS* window_pos) {
}
void HWNDMessageHandler::OnWindowPosChanged(WINDOWPOS* window_pos) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnWindowPosChanged"));
-
if (DidClientAreaSizeChange(window_pos))
ClientAreaSizeChanged();
if (remove_standard_frame_ && window_pos->flags & SWP_FRAMECHANGED &&
@@ -2530,11 +2245,6 @@ void HWNDMessageHandler::OnWindowPosChanged(WINDOWPOS* window_pos) {
}
void HWNDMessageHandler::OnSessionChange(WPARAM status_code) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::OnSessionChange"));
-
// Direct3D presents are ignored while the screen is locked, so force the
// window to be redrawn on unlock.
if (status_code == WTS_SESSION_UNLOCK)
@@ -2558,22 +2268,12 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
if (!touch_ids_.empty())
return 0;
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal1"));
-
// We handle touch events on Windows Aura. Windows generates synthesized
// mouse messages in response to touch which we should ignore. However touch
// messages are only received for the client area. We need to ignore the
// synthesized mouse messages for all points in the client area and places
// which return HTNOWHERE.
if (ui::IsMouseEventFromTouch(message)) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal2"));
-
LPARAM l_param_ht = l_param;
// For mouse events (except wheel events), location is in window coordinates
// and should be converted to screen coordinates for WM_NCHITTEST.
@@ -2600,11 +2300,6 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
}
if (message == WM_RBUTTONUP && is_right_mouse_pressed_on_caption_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal3"));
-
is_right_mouse_pressed_on_caption_ = false;
ReleaseCapture();
// |point| is in window coordinates, but WM_NCHITTEST and TrackPopupMenu()
@@ -2648,11 +2343,6 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
SetCapture();
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal4"));
-
long message_time = GetMessageTime();
MSG msg = { hwnd(), message, w_param, l_param,
static_cast<DWORD>(message_time),
@@ -2662,11 +2352,6 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
event.set_flags(event.flags() | ui::EF_FROM_TOUCH);
if (event.type() == ui::ET_MOUSE_MOVED && !HasCapture() && track_mouse) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal5"));
-
// Windows only fires WM_MOUSELEAVE events if the application begins
// "tracking" mouse events for a given HWND during WM_MOUSEMOVE events.
// We need to call |TrackMouseEvents| to listen for WM_MOUSELEAVE.
@@ -2678,31 +2363,16 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
// OnMouseEvent.
active_mouse_tracking_flags_ = 0;
} else if (event.type() == ui::ET_MOUSEWHEEL) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile6(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal6"));
-
// Reroute the mouse wheel to the window under the pointer if applicable.
return (ui::RerouteMouseWheel(hwnd(), w_param, l_param) ||
delegate_->HandleMouseEvent(ui::MouseWheelEvent(msg))) ? 0 : 1;
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile7(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal7"));
-
// There are cases where the code handling the message destroys the window,
// so use the weak ptr to check if destruction occured or not.
base::WeakPtr<HWNDMessageHandler> ref(weak_factory_.GetWeakPtr());
bool handled = delegate_->HandleMouseEvent(event);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile8(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal8"));
-
if (!ref.get())
return 0;
@@ -2714,11 +2384,6 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
if (!handled && message == WM_NCLBUTTONDOWN && w_param != HTSYSMENU &&
delegate_->IsUsingCustomFrame()) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile9(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal9"));
-
// TODO(msw): Eliminate undesired painting, or re-evaluate this workaround.
// DefWindowProc for WM_NCLBUTTONDOWN does weird non-client painting, so we
// need to call it inside a ScopedRedrawLock. This may cause other negative
@@ -2727,14 +2392,8 @@ LRESULT HWNDMessageHandler::HandleMouseEventInternal(UINT message,
handled = true;
}
- if (ref.get()) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/440919 is fixed.
- tracked_objects::ScopedTracker tracking_profile10(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "440919 HWNDMessageHandler::HandleMouseEventInternal10"));
-
+ if (ref.get())
SetMsgHandled(handled);
- }
return 0;
}
diff --git a/win8/metro_driver/metro_driver_win7.cc b/win8/metro_driver/metro_driver_win7.cc
index 3ace04c..c88cd3f 100644
--- a/win8/metro_driver/metro_driver_win7.cc
+++ b/win8/metro_driver/metro_driver_win7.cc
@@ -7,7 +7,6 @@
#include <shobjidl.h>
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "ui/gfx/geometry/safe_integer_conversions.h"
#include "ui/gfx/win/msg_util.h"