diff options
| author | deepak.m1 <deepak.m1@samsung.com> | 2015-04-16 05:22:35 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-16 12:22:59 +0000 |
| commit | 4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5 (patch) | |
| tree | 820a7f9452c78273857ed8d666a406d3de71ec52 | |
| parent | 62b271de77990e9cb5c530c8a27ff41f21f9b1b3 (diff) | |
| download | chromium_src-4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5.zip chromium_src-4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5.tar.gz chromium_src-4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5.tar.bz2 | |
Bookmarked URL gets open in New tab, on pressing enter key for 'Folders' dropdown.
When we select enter key then open item is getting called and it opens last focused item.
This is due to 2 reasons:
1) getSelectedBookmarkNodes() returns bmm.list.selectedItems even when document.activeElement
is 'Folders' or 'Organize' button.
2) openItem() is for opening the item in the list, for that bmm.list should be currently active
Check have been added so that when we have bmm.list is active then only e.canExecute will become true.
BUG=452853
Review URL: https://codereview.chromium.org/1058533006
Cr-Commit-Position: refs/heads/master@{#325426}
| -rw-r--r-- | chrome/browser/resources/bookmark_manager/js/main.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/resources/bookmark_manager/js/main.js b/chrome/browser/resources/bookmark_manager/js/main.js index 6d24a33..1af8412 100644 --- a/chrome/browser/resources/bookmark_manager/js/main.js +++ b/chrome/browser/resources/bookmark_manager/js/main.js @@ -635,7 +635,7 @@ function canExecuteForList(e) { break; case 'open-in-same-window-command': - e.canExecute = hasSelected(); + e.canExecute = (e.target == bmm.list) && hasSelected(); break; default: |