summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkkania@chromium.org <kkania@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 18:07:18 +0000
committerkkania@chromium.org <kkania@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-29 18:07:18 +0000
commit4f986527deb2f031f851ea58f31f0804ccec95e2 (patch)
tree7e499c625118d1da0ae446e0ec171d8a65023386
parent0279a31c516dc365db3acba62b02aafdaa0276ff (diff)
downloadchromium_src-4f986527deb2f031f851ea58f31f0804ccec95e2.zip
chromium_src-4f986527deb2f031f851ea58f31f0804ccec95e2.tar.gz
chromium_src-4f986527deb2f031f851ea58f31f0804ccec95e2.tar.bz2
[chromedriver] Stop supporting chrome 26. Don't run tests against it.
BUG=none R=chrisgao@chromium.org Review URL: https://codereview.chromium.org/15859013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202912 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/chromedriver/archive.py1
-rw-r--r--chrome/test/chromedriver/chrome/version.cc2
-rw-r--r--chrome/test/chromedriver/element_commands.cc10
-rwxr-xr-xchrome/test/chromedriver/run_all_tests.py3
-rwxr-xr-xchrome/test/chromedriver/run_py_tests.py3
-rw-r--r--chrome/test/chromedriver/test_expectations9
6 files changed, 2 insertions, 26 deletions
diff --git a/chrome/test/chromedriver/archive.py b/chrome/test/chromedriver/archive.py
index 7f5385f..5835a80 100644
--- a/chrome/test/chromedriver/archive.py
+++ b/chrome/test/chromedriver/archive.py
@@ -14,7 +14,6 @@ sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, 'pylib'))
from common import util
-CHROME_26_REVISION = '181664'
CHROME_27_REVISION = '190466'
CHROME_28_REVISION = '198276'
diff --git a/chrome/test/chromedriver/chrome/version.cc b/chrome/test/chromedriver/chrome/version.cc
index 38c8b1c..abf9af8 100644
--- a/chrome/test/chromedriver/chrome/version.cc
+++ b/chrome/test/chromedriver/chrome/version.cc
@@ -8,7 +8,7 @@
namespace {
-const int kMinimumSupportedChromeVersion[] = {26, 0, 1395, 0};
+const int kMinimumSupportedChromeVersion[] = {27, 0, 1453, 0};
} // namespace
diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc
index d1620a8..b3e313c 100644
--- a/chrome/test/chromedriver/element_commands.cc
+++ b/chrome/test/chromedriver/element_commands.cc
@@ -217,16 +217,6 @@ Status ExecuteSendKeysToElement(
if (status.IsError())
return status;
if (is_input && is_file) {
- // File upload is only supported for chrome 27+.
- if (session->chrome->GetBuildNo() < 1420) {
- return Status(
- kUnknownError,
- base::StringPrintf(
- "file upload requires chrome 27+, build 1420+,"
- "while current one is %s",
- session->chrome->GetVersion().c_str()));
- }
-
// Compress array into a single string.
base::FilePath::StringType paths_string;
for (size_t i = 0; i < key_list->GetSize(); ++i) {
diff --git a/chrome/test/chromedriver/run_all_tests.py b/chrome/test/chromedriver/run_all_tests.py
index ab35b5a..d858f3ad 100755
--- a/chrome/test/chromedriver/run_all_tests.py
+++ b/chrome/test/chromedriver/run_all_tests.py
@@ -153,8 +153,7 @@ def main():
versions = [
['HEAD', latest_snapshot_revision],
['28', archive.CHROME_28_REVISION],
- ['27', archive.CHROME_27_REVISION],
- ['26', archive.CHROME_26_REVISION]
+ ['27', archive.CHROME_27_REVISION]
]
code = 0
for version in versions:
diff --git a/chrome/test/chromedriver/run_py_tests.py b/chrome/test/chromedriver/run_py_tests.py
index 0bcd954..e8a5f39 100755
--- a/chrome/test/chromedriver/run_py_tests.py
+++ b/chrome/test/chromedriver/run_py_tests.py
@@ -72,9 +72,6 @@ _DESKTOP_NEGATIVE_FILTER['28'] = (
_DESKTOP_NEGATIVE_FILTER['27'] = (
_DESKTOP_NEGATIVE_FILTER['HEAD'] + []
)
-_DESKTOP_NEGATIVE_FILTER['26'] = (
- _DESKTOP_NEGATIVE_FILTER['HEAD'] + []
-)
_ANDROID_NEGATIVE_FILTER = {}
diff --git a/chrome/test/chromedriver/test_expectations b/chrome/test/chromedriver/test_expectations
index 3e76063..1a04eac 100644
--- a/chrome/test/chromedriver/test_expectations
+++ b/chrome/test/chromedriver/test_expectations
@@ -89,15 +89,6 @@ _REVISION_NEGATIVE_FILTER['HEAD'] = [
]
_REVISION_NEGATIVE_FILTER['28'] = [] + _REVISION_NEGATIVE_FILTER['HEAD']
_REVISION_NEGATIVE_FILTER['27'] = [] + _REVISION_NEGATIVE_FILTER['HEAD']
-_REVISION_NEGATIVE_FILTER['26'] = [
- 'AlertsTest.testHandlesTwoAlertsFromOneInteraction',
- 'AlertsTest.testShouldAllowAUserToSetTheValueOfAPrompt',
- 'UploadTest.testFileUploading',
- 'CorrectEventFiringTest.testUploadingFileShouldFireOnChangeEvent',
- 'FormHandlingTest.testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement',
- 'FormHandlingTest.testShouldBeAbleToUploadTheSameFileTwice',
- 'FormHandlingTest.testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument',
-] + _REVISION_NEGATIVE_FILTER['HEAD']
_OS_NEGATIVE_FILTER = {}
_OS_NEGATIVE_FILTER['win'] = [