Enable TransferNavigationResourceHandler

This enables a fix for bug 79520 that was previously committed but not enabled http://src.chromium.org/viewvc/chrome?view=rev&revision=112847.

BUG=79520
TEST=no
TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8889007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113785 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 7 insertions, 21 deletions

diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc
index d6bf4d6..18fadc7 100644
--- a/chrome/browser/extensions/app_process_apitest.cc
+++ b/chrome/browser/extensions/app_process_apitest.cc
@@ -361,13 +361,8 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_AppProcessRedirectBack) {
   //    cancelled, and counts as a load stop
   // 8. Renderer navigates to empty.html, and finishes loading, counting as the
   //    third load stop
-#if defined(TRANSFER_REDIRECTS_BUG79520)
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
       browser(), base_url.Resolve("path1/redirect.html"), 3);
-#else
-  ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
-      browser(), base_url.Resolve("path1/redirect.html"), 2);
-#endif
 
   // 3 tabs, including the initial about:blank. The last 2 should be the same
   // process.
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index 58f8e1a..ab72c1b 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -183,12 +183,8 @@ ResourceHandler* ChromeResourceDispatcherHostDelegate::RequestBeginning(
       resource_context.appcache_service());
 #endif
 
-  // TODO(mpcomplete): Leaving disabled for now, since I'm checking this in
-  // close to the branch point.
-#if defined(TRANSFER_REDIRECTS_BUG79520)
   handler = new TransferNavigationResourceHandler(
       handler, resource_dispatcher_host_, request);
-#endif
 
   return handler;
 }
diff --git a/chrome/test/data/extensions/api_test/webrequest/test_blocking.js b/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
index 903978e..9c5925d 100644
--- a/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
+++ b/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
@@ -126,9 +126,6 @@ runTests([
 
   // Navigates to a page with a blocking handler that redirects to a different
   // page.
-  // TODO(mpcomplete): We should see an onBeforeRedirect as well, but our
-  // process switching logic cancels the original redirect request and
-  // starts a new one instead. See http://crbug.com/79520.
   function complexLoadRedirected() {
     expect(
       [  // events
@@ -140,13 +137,14 @@ runTests([
           },
           retval: {redirectUrl: getURL("simpleLoad/a.html")}
         },
-        { label: "onErrorOccurred-1",
-          event: "onErrorOccurred",
+        { label: "onBeforeRedirect",
+          event: "onBeforeRedirect",
           details: {
             url: getURL("complexLoad/a.html"),
+            redirectUrl: getURL("simpleLoad/a.html"),
+            statusLine: "",
+            statusCode: -1,
             fromCache: false,
-            error: "net::ERR_ABORTED"
-            // Request to chrome-extension:// url has no IP.
           }
         },
         { label: "onBeforeRequest-2",
@@ -178,7 +176,7 @@ runTests([
         },
       ],
       [  // event order
-        ["onBeforeRequest-1", "onErrorOccurred-1", "onBeforeRequest-2",
+        ["onBeforeRequest-1", "onBeforeRedirect", "onBeforeRequest-2",
          "onResponseStarted", "onCompleted"],
       ],
       {urls: ["<all_urls>"]}, // filter
@@ -459,7 +457,6 @@ runTests([
             responseHeadersExist: true,
           },
           retval_function: function(name, details) {
-            console.log(JSON.stringify(details));
             responseHeaders = details.responseHeaders;
             var found = false;
             var expectedValue = [
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index cb1a684..0f5be68 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2074,9 +2074,7 @@ WebNavigationPolicy RenderViewImpl::decidePolicyForNavigation(
   // issue a special POST navigation in WebKit (via
   // FrameLoader::loadFrameRequest). See ResourceDispatcher and WebURLLoaderImpl
   // for examples of how to send the httpBody data.
-  // TODO(mpcomplete): remove is_redirect clause when http://crbug.com/79520 is
-  // fixed.
-  if (!frame->parent() && (is_content_initiated || is_redirect) &&
+  if (!frame->parent() && is_content_initiated &&
       default_policy == WebKit::WebNavigationPolicyCurrentTab &&
       request.httpMethod() == "GET" && !url.SchemeIs(chrome::kAboutScheme)) {
     bool send_referrer = false;