diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-21 16:53:54 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-21 16:53:54 +0000 |
commit | 5341642d58dc4d97040f7017c8d681b8197311a9 (patch) | |
tree | 39ad2fa882a802d8a8fdd9aa0c13663ece8620ae | |
parent | dacbf2c3892c564026e85e1ccafd0bbdc95cc93b (diff) | |
download | chromium_src-5341642d58dc4d97040f7017c8d681b8197311a9.zip chromium_src-5341642d58dc4d97040f7017c8d681b8197311a9.tar.gz chromium_src-5341642d58dc4d97040f7017c8d681b8197311a9.tar.bz2 |
Add OVERRIDE to chrome/renderer.
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110942 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/renderer/autofill/password_autofill_manager.h | 10 | ||||
-rw-r--r-- | chrome/renderer/blocked_plugin.h | 6 | ||||
-rw-r--r-- | chrome/renderer/chrome_mock_render_thread.h | 2 | ||||
-rw-r--r-- | chrome/renderer/content_settings_observer.h | 4 | ||||
-rw-r--r-- | chrome/renderer/extensions/chrome_v8_extension.h | 2 | ||||
-rw-r--r-- | chrome/renderer/extensions/extension_dispatcher.h | 6 | ||||
-rw-r--r-- | chrome/renderer/extensions/extension_helper.h | 14 | ||||
-rw-r--r-- | chrome/renderer/print_web_view_helper.h | 4 | ||||
-rw-r--r-- | chrome/renderer/renderer_histogram_snapshots.h | 10 | ||||
-rw-r--r-- | chrome/renderer/renderer_tracking.h | 2 | ||||
-rw-r--r-- | chrome/renderer/searchbox.h | 2 | ||||
-rw-r--r-- | chrome/renderer/security_filter_peer.h | 24 | ||||
-rw-r--r-- | chrome/renderer/spellchecker/spellcheck.h | 2 | ||||
-rw-r--r-- | chrome/renderer/spellchecker/spellcheck_provider.h | 4 | ||||
-rw-r--r-- | chrome/renderer/translate_helper.h | 2 | ||||
-rw-r--r-- | chrome/renderer/visitedlink_slave.h | 5 |
16 files changed, 50 insertions, 49 deletions
diff --git a/chrome/renderer/autofill/password_autofill_manager.h b/chrome/renderer/autofill/password_autofill_manager.h index b7642c7..cd4cdd8 100644 --- a/chrome/renderer/autofill/password_autofill_manager.h +++ b/chrome/renderer/autofill/password_autofill_manager.h @@ -62,11 +62,11 @@ class PasswordAutofillManager : public content::RenderViewObserver, typedef std::map<WebKit::WebElement, PasswordInfo> LoginToPasswordInfoMap; // RenderViewObserver: - virtual bool OnMessageReceived(const IPC::Message& message); - virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame); - virtual void DidFinishLoad(WebKit::WebFrame* frame); - virtual void FrameDetached(WebKit::WebFrame* frame); - virtual void FrameWillClose(WebKit::WebFrame* frame); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; + virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE; + virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE; + virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE; + virtual void FrameWillClose(WebKit::WebFrame* frame) OVERRIDE; // PageClickListener: virtual bool InputElementClicked(const WebKit::WebInputElement& element, diff --git a/chrome/renderer/blocked_plugin.h b/chrome/renderer/blocked_plugin.h index 16c88de..abff76d 100644 --- a/chrome/renderer/blocked_plugin.h +++ b/chrome/renderer/blocked_plugin.h @@ -30,9 +30,9 @@ class BlockedPlugin : public content::RenderViewObserver, webkit::npapi::WebViewPlugin* plugin() { return plugin_; } // WebViewPlugin::Delegate methods: - virtual void BindWebFrame(WebKit::WebFrame* frame); - virtual void WillDestroyPlugin(); - virtual void ShowContextMenu(const WebKit::WebMouseEvent&); + virtual void BindWebFrame(WebKit::WebFrame* frame) OVERRIDE; + virtual void WillDestroyPlugin() OVERRIDE; + virtual void ShowContextMenu(const WebKit::WebMouseEvent&) OVERRIDE; private: virtual ~BlockedPlugin(); diff --git a/chrome/renderer/chrome_mock_render_thread.h b/chrome/renderer/chrome_mock_render_thread.h index 0ad4798..aca5597 100644 --- a/chrome/renderer/chrome_mock_render_thread.h +++ b/chrome/renderer/chrome_mock_render_thread.h @@ -49,7 +49,7 @@ class ChromeMockRenderThread : public content::MockRenderThread { private: // Overrides base class implementation to add custom handling for // print and extensions. - virtual bool OnMessageReceived(const IPC::Message& msg); + virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE; // The callee expects to be returned a valid channel_id. void OnMsgOpenChannelToExtension( diff --git a/chrome/renderer/content_settings_observer.h b/chrome/renderer/content_settings_observer.h index 947333e..a76e71c 100644 --- a/chrome/renderer/content_settings_observer.h +++ b/chrome/renderer/content_settings_observer.h @@ -67,9 +67,9 @@ class ContentSettingsObserver private: // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; virtual void DidCommitProvisionalLoad(WebKit::WebFrame* frame, - bool is_new_navigation); + bool is_new_navigation) OVERRIDE; // Message handlers. void OnLoadBlockedPlugins(); diff --git a/chrome/renderer/extensions/chrome_v8_extension.h b/chrome/renderer/extensions/chrome_v8_extension.h index 05d8a26..a8a0578 100644 --- a/chrome/renderer/extensions/chrome_v8_extension.h +++ b/chrome/renderer/extensions/chrome_v8_extension.h @@ -59,7 +59,7 @@ class ChromeV8Extension : public v8::Extension { // order to expose common native functions, like GetChromeHidden, to the // v8 extension. virtual v8::Handle<v8::FunctionTemplate> - GetNativeFunction(v8::Handle<v8::String> name); + GetNativeFunction(v8::Handle<v8::String> name) OVERRIDE; protected: template<class T> diff --git a/chrome/renderer/extensions/extension_dispatcher.h b/chrome/renderer/extensions/extension_dispatcher.h index f20e44a..9c51da2 100644 --- a/chrome/renderer/extensions/extension_dispatcher.h +++ b/chrome/renderer/extensions/extension_dispatcher.h @@ -88,9 +88,9 @@ class ExtensionDispatcher : public content::RenderProcessObserver { friend class RenderViewTest; // RenderProcessObserver implementation: - virtual bool OnControlMessageReceived(const IPC::Message& message); - virtual void WebKitInitialized(); - virtual void IdleNotification(); + virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE; + virtual void WebKitInitialized() OVERRIDE; + virtual void IdleNotification() OVERRIDE; void OnMessageInvoke(const std::string& extension_id, const std::string& function_name, diff --git a/chrome/renderer/extensions/extension_helper.h b/chrome/renderer/extensions/extension_helper.h index b136e73..3542587 100644 --- a/chrome/renderer/extensions/extension_helper.h +++ b/chrome/renderer/extensions/extension_helper.h @@ -56,14 +56,14 @@ class ExtensionHelper private: // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); - virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame); - virtual void DidFinishLoad(WebKit::WebFrame* frame); - virtual void DidCreateDocumentElement(WebKit::WebFrame* frame); - virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame); - virtual void FrameDetached(WebKit::WebFrame* frame); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; + virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE; + virtual void DidFinishLoad(WebKit::WebFrame* frame) OVERRIDE; + virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE; + virtual void DidStartProvisionalLoad(WebKit::WebFrame* frame) OVERRIDE; + virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE; virtual void DidCreateDataSource(WebKit::WebFrame* frame, - WebKit::WebDataSource* ds); + WebKit::WebDataSource* ds) OVERRIDE; void OnExtensionResponse(int request_id, bool success, const std::string& response, diff --git a/chrome/renderer/print_web_view_helper.h b/chrome/renderer/print_web_view_helper.h index f300dc2..fba9530 100644 --- a/chrome/renderer/print_web_view_helper.h +++ b/chrome/renderer/print_web_view_helper.h @@ -106,8 +106,8 @@ class PrintWebViewHelper #endif // defined(OS_WIN) || defined(OS_MACOSX) // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); - virtual void PrintPage(WebKit::WebFrame* frame); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; + virtual void PrintPage(WebKit::WebFrame* frame) OVERRIDE; // Message handlers --------------------------------------------------------- diff --git a/chrome/renderer/renderer_histogram_snapshots.h b/chrome/renderer/renderer_histogram_snapshots.h index 4572461..5fe8ad6 100644 --- a/chrome/renderer/renderer_histogram_snapshots.h +++ b/chrome/renderer/renderer_histogram_snapshots.h @@ -29,7 +29,7 @@ class RendererHistogramSnapshots : public HistogramSender, private: // RenderProcessObserver implementation. - virtual bool OnControlMessageReceived(const IPC::Message& message); + virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE; void OnGetRendererHistograms(int sequence_number); @@ -46,10 +46,10 @@ class RendererHistogramSnapshots : public HistogramSender, // HistogramSender interface (override) methods. virtual void TransmitHistogramDelta( const base::Histogram& histogram, - const base::Histogram::SampleSet& snapshot); - virtual void InconsistencyDetected(int problem); - virtual void UniqueInconsistencyDetected(int problem); - virtual void SnapshotProblemResolved(int amount); + const base::Histogram::SampleSet& snapshot) OVERRIDE; + virtual void InconsistencyDetected(int problem) OVERRIDE; + virtual void UniqueInconsistencyDetected(int problem) OVERRIDE; + virtual void SnapshotProblemResolved(int amount) OVERRIDE; // Collection of histograms to send to the browser. HistogramPickledList pickled_histograms_; diff --git a/chrome/renderer/renderer_tracking.h b/chrome/renderer/renderer_tracking.h index 9740d75..c8193bc 100644 --- a/chrome/renderer/renderer_tracking.h +++ b/chrome/renderer/renderer_tracking.h @@ -22,7 +22,7 @@ class RendererTracking : public content::RenderProcessObserver { private: // RenderProcessObserver implementation. - virtual bool OnControlMessageReceived(const IPC::Message& message); + virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE; void OnGetRendererTrackingData(int sequence_number); diff --git a/chrome/renderer/searchbox.h b/chrome/renderer/searchbox.h index fc2cc85..524b276 100644 --- a/chrome/renderer/searchbox.h +++ b/chrome/renderer/searchbox.h @@ -33,7 +33,7 @@ class SearchBox : public content::RenderViewObserver, private: // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; void OnChange(const string16& value, bool verbatim, diff --git a/chrome/renderer/security_filter_peer.h b/chrome/renderer/security_filter_peer.h index 7095d76..c54705d 100644 --- a/chrome/renderer/security_filter_peer.h +++ b/chrome/renderer/security_filter_peer.h @@ -29,21 +29,21 @@ class SecurityFilterPeer : public webkit_glue::ResourceLoaderBridge::Peer { int os_error); // ResourceLoaderBridge::Peer methods. - virtual void OnUploadProgress(uint64 position, uint64 size); + virtual void OnUploadProgress(uint64 position, uint64 size) OVERRIDE; virtual bool OnReceivedRedirect( const GURL& new_url, const webkit_glue::ResourceResponseInfo& info, bool* has_new_first_party_for_cookies, - GURL* new_first_party_for_cookies); + GURL* new_first_party_for_cookies) OVERRIDE; virtual void OnReceivedResponse( - const webkit_glue::ResourceResponseInfo& info); - virtual void OnDownloadedData(int len) {} + const webkit_glue::ResourceResponseInfo& info) OVERRIDE; + virtual void OnDownloadedData(int len) OVERRIDE {} virtual void OnReceivedData(const char* data, int data_length, - int encoded_data_length); + int encoded_data_length) OVERRIDE; virtual void OnCompletedRequest(const net::URLRequestStatus& status, const std::string& security_info, - const base::Time& completion_time); + const base::Time& completion_time) OVERRIDE; protected: SecurityFilterPeer(webkit_glue::ResourceLoaderBridge* resource_loader_bridge, @@ -67,13 +67,13 @@ class BufferedPeer : public SecurityFilterPeer { // ResourceLoaderBridge::Peer Implementation. virtual void OnReceivedResponse( - const webkit_glue::ResourceResponseInfo& info); + const webkit_glue::ResourceResponseInfo& info) OVERRIDE; virtual void OnReceivedData(const char* data, int data_length, - int encoded_data_length); + int encoded_data_length) OVERRIDE; virtual void OnCompletedRequest(const net::URLRequestStatus& status, const std::string& security_info, - const base::Time& completion_time); + const base::Time& completion_time) OVERRIDE; protected: // Invoked when the entire request has been processed before the data is sent @@ -109,13 +109,13 @@ class ReplaceContentPeer : public SecurityFilterPeer { // ResourceLoaderBridge::Peer Implementation. virtual void OnReceivedResponse( - const webkit_glue::ResourceResponseInfo& info); + const webkit_glue::ResourceResponseInfo& info) OVERRIDE; virtual void OnReceivedData(const char* data, int data_length, - int encoded_data_length); + int encoded_data_length) OVERRIDE; virtual void OnCompletedRequest(const net::URLRequestStatus& status, const std::string& security_info, - const base::Time& completion_time); + const base::Time& completion_time) OVERRIDE; private: webkit_glue::ResourceResponseInfo response_info_; diff --git a/chrome/renderer/spellchecker/spellcheck.h b/chrome/renderer/spellchecker/spellcheck.h index 6e28fbd..2c5e2b2 100644 --- a/chrome/renderer/spellchecker/spellcheck.h +++ b/chrome/renderer/spellchecker/spellcheck.h @@ -71,7 +71,7 @@ class SpellCheck : public content::RenderProcessObserver { FRIEND_TEST(SpellCheckTest, GetAutoCorrectionWord_EN_US); // RenderProcessObserver implementation: - virtual bool OnControlMessageReceived(const IPC::Message& message); + virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE; // Message handlers. void OnInit(IPC::PlatformFileForTransit bdict_file, diff --git a/chrome/renderer/spellchecker/spellcheck_provider.h b/chrome/renderer/spellchecker/spellcheck_provider.h index 7dc6384..62cb382 100644 --- a/chrome/renderer/spellchecker/spellcheck_provider.h +++ b/chrome/renderer/spellchecker/spellcheck_provider.h @@ -50,8 +50,8 @@ class SpellCheckProvider : public content::RenderViewObserver, int document_tag() const { return document_tag_; } // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); - virtual void FocusedNodeChanged(const WebKit::WebNode& node); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; + virtual void FocusedNodeChanged(const WebKit::WebNode& node) OVERRIDE; void SetSpellCheck(SpellCheck* spellcheck); diff --git a/chrome/renderer/translate_helper.h b/chrome/renderer/translate_helper.h index fa80378..56c19b37 100644 --- a/chrome/renderer/translate_helper.h +++ b/chrome/renderer/translate_helper.h @@ -83,7 +83,7 @@ class TranslateHelper : public content::RenderViewObserver { static std::string DetermineTextLanguage(const string16& text); // RenderViewObserver implementation. - virtual bool OnMessageReceived(const IPC::Message& message); + virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Cancels any translation that is currently being performed. This does not // revert existing translations. diff --git a/chrome/renderer/visitedlink_slave.h b/chrome/renderer/visitedlink_slave.h index 52110a1..6bae4fd 100644 --- a/chrome/renderer/visitedlink_slave.h +++ b/chrome/renderer/visitedlink_slave.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,6 +6,7 @@ #define CHROME_RENDERER_VISITEDLINK_SLAVE_H_ #pragma once +#include "base/compiler_specific.h" #include "base/shared_memory.h" #include "chrome/common/visitedlink_common.h" #include "content/public/renderer/render_process_observer.h" @@ -19,7 +20,7 @@ class VisitedLinkSlave : public VisitedLinkCommon, virtual ~VisitedLinkSlave(); // RenderProcessObserver implementation. - virtual bool OnControlMessageReceived(const IPC::Message& message); + virtual bool OnControlMessageReceived(const IPC::Message& message) OVERRIDE; // Message handlers. void OnUpdateVisitedLinks(base::SharedMemoryHandle table); |