diff options
author | nyquist <nyquist@chromium.org> | 2014-09-12 11:42:39 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-12 18:51:07 +0000 |
commit | 56f97b71a4a88d7d016fcf4b1b3d37bc56691e35 (patch) | |
tree | 29083db2c945d93c124872efba7d87f996816048 | |
parent | 003f9b2506660f6f60e3264d3d5c3c38650c7fd6 (diff) | |
download | chromium_src-56f97b71a4a88d7d016fcf4b1b3d37bc56691e35.zip chromium_src-56f97b71a4a88d7d016fcf4b1b3d37bc56691e35.tar.gz chromium_src-56f97b71a4a88d7d016fcf4b1b3d37bc56691e35.tar.bz2 |
Remove most usages of guava.
This CL removes most usages of the guava library.
TBR=thakis@chromium.org,brettw@chromium.org,yfriedman@chromium.org
BUG=412673
Review URL: https://codereview.chromium.org/565743002
Cr-Commit-Position: refs/heads/master@{#294620}
48 files changed, 56 insertions, 88 deletions
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java index 330cd07..ffa0d5e 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwContents.java +++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java @@ -37,12 +37,11 @@ import android.webkit.GeolocationPermissions; import android.webkit.ValueCallback; import android.widget.OverScroller; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.android_webview.permission.AwPermissionRequest; import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.components.navigation_interception.InterceptNavigationDelegate; import org.chromium.components.navigation_interception.NavigationParams; import org.chromium.content.browser.ContentSettings; diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java index f926bb8..0744eb4 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java +++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientCallbackHelper.java @@ -10,7 +10,7 @@ import android.os.Looper; import android.os.Message; import android.os.SystemClock; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; import java.util.concurrent.Callable; diff --git a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java index 61d0a3d..11c166d5 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java +++ b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java @@ -7,7 +7,7 @@ package org.chromium.android_webview; import android.graphics.Rect; import android.widget.OverScroller; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; /** * Takes care of syncing the scroll offset between the Android View system and the diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java index d87d57b..33f7163 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java +++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java @@ -14,11 +14,10 @@ import android.util.Log; import android.webkit.WebSettings; import android.webkit.WebSettings.PluginState; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; /** * Stores Android WebView specific settings that does not need to be synced to WebKit. diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java index 5c55fdf..9adc3bb 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java +++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java @@ -4,10 +4,9 @@ package org.chromium.android_webview; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; +import org.chromium.base.VisibleForTesting; import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid; /** diff --git a/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java b/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java index 7de5e3c..86f7580 100644 --- a/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java +++ b/android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java @@ -11,10 +11,9 @@ import android.view.SurfaceHolder; import android.view.SurfaceView; import android.view.ViewGroup; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; +import org.chromium.base.VisibleForTesting; import org.chromium.content.browser.ContentViewCore; import org.chromium.content.browser.RenderCoordinates; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java index 0519234..8a17069 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java @@ -29,11 +29,10 @@ import android.provider.Browser.SearchColumns; import android.text.TextUtils; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.CalledByNativeUnchecked; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.database.SQLiteCursor; import org.chromium.sync.notifier.SyncStatusHelper; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java index b6b495d..b75d267 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java @@ -16,9 +16,8 @@ import android.widget.CheckBox; import android.widget.EditText; import android.widget.TextView; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.R; import org.chromium.ui.base.WindowAndroid; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java index 4e2c465..2ac70df 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java @@ -15,8 +15,7 @@ import android.view.MenuItem; import android.view.View; import android.widget.PopupMenu; -import com.google.common.annotations.VisibleForTesting; - +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.UmaBridge; import java.util.ArrayList; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java index 347b355..e266d74 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerAndroid.java @@ -4,10 +4,9 @@ package org.chromium.chrome.browser.autofill; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; +import org.chromium.base.VisibleForTesting; import org.chromium.ui.base.WindowAndroid; /** diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java index 4749c88..6dc01c4 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java @@ -13,9 +13,8 @@ import android.view.MenuItem.OnMenuItemClickListener; import android.view.View; import android.view.View.OnCreateContextMenuListener; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; +import org.chromium.base.VisibleForTesting; import org.chromium.content.browser.ContentViewCore; /** diff --git a/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java b/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java index e5d9b54..04085c8 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/identity/SettingsSecureBasedIdentificationGenerator.java @@ -7,8 +7,7 @@ package org.chromium.chrome.browser.identity; import android.content.Context; import android.provider.Settings; -import com.google.common.annotations.VisibleForTesting; - +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.util.HashUtil; import javax.annotation.Nullable; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactory.java index e6cc4c0..451df98 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactory.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/identity/UniqueIdentificationGeneratorFactory.java @@ -4,7 +4,7 @@ package org.chromium.chrome.browser.identity; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; import java.util.HashMap; import java.util.Map; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java b/chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java index 0bea1ab..013c5e7 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java @@ -8,7 +8,7 @@ import android.content.Context; import android.content.SharedPreferences; import android.preference.PreferenceManager; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; import java.util.UUID; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java index 8e3cac3..19bcdab 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java @@ -8,12 +8,10 @@ import android.accounts.Account; import android.content.Context; import android.content.Intent; -import com.google.common.annotations.VisibleForTesting; -import com.google.common.base.Preconditions; - import org.chromium.base.ApplicationState; import org.chromium.base.ApplicationStatus; import org.chromium.base.CalledByNative; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.internal_api.pub.base.ModelType; import org.chromium.sync.notifier.InvalidationClientNameProvider; import org.chromium.sync.notifier.InvalidationIntentProtocol; @@ -119,7 +117,9 @@ public class InvalidationController implements ApplicationStatus.ApplicationStat */ @VisibleForTesting InvalidationController(Context context) { - mContext = Preconditions.checkNotNull(context.getApplicationContext()); + Context appContext = context.getApplicationContext(); + if (appContext == null) throw new NullPointerException("Unable to get application context"); + mContext = appContext; ApplicationStatus.registerApplicationStateListener(this); } diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java index 180944a..523e6dc 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java @@ -6,9 +6,8 @@ package org.chromium.chrome.browser.omnibox; import android.text.TextUtils; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.profiles.Profile; import org.chromium.content_public.browser.WebContents; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java index b716161..df24013 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java @@ -6,7 +6,7 @@ package org.chromium.chrome.browser.omnibox; import android.text.TextUtils; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; /** * Container class with information about each omnibox suggestion item. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java index 28d8a67..6e90ed8 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java @@ -10,11 +10,10 @@ import android.content.Context; import android.preference.PreferenceManager; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.ObserverList; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.profiles.Profile; import org.chromium.sync.signin.AccountManagerHelper; import org.chromium.sync.signin.ChromeSigninController; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java index c9f092c..b8507e6 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java @@ -14,10 +14,10 @@ import android.os.Bundle; import android.os.Handler; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; import com.google.protos.ipc.invalidation.Types; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.ProcessInitException; import org.chromium.content.browser.BrowserStartupController; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/DelayedSyncController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/DelayedSyncController.java index 2df5f06..c71d473 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/sync/DelayedSyncController.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/DelayedSyncController.java @@ -13,9 +13,8 @@ import android.os.Bundle; import android.preference.PreferenceManager; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ApplicationStatus; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.notifier.SyncStatusHelper; import org.chromium.sync.signin.AccountManagerHelper; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java index 2013fa5..a51629b 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java @@ -4,8 +4,7 @@ package org.chromium.chrome.browser.tabmodel; -import com.google.common.annotations.VisibleForTesting; - +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.browser.Tab; import org.chromium.chrome.browser.profiles.Profile; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java b/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java index 313538e..38bce66 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java @@ -15,9 +15,8 @@ import android.os.Bundle; import android.os.UserManager; import android.speech.RecognizerIntent; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.signin.AccountManagerHelper; import java.util.List; diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java index 479726a..271a2c2 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java @@ -25,8 +25,7 @@ import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.TextView; -import com.google.common.annotations.VisibleForTesting; - +import org.chromium.base.VisibleForTesting; import org.chromium.chrome.R; import org.chromium.chrome.browser.EmptyTabObserver; import org.chromium.chrome.browser.Tab; diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java index 371c520..7e36f1c 100644 --- a/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java @@ -12,17 +12,16 @@ import android.content.Intent; import android.os.Bundle; import android.test.suitebuilder.annotation.SmallTest; -import com.google.common.annotations.VisibleForTesting; - -import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout; - import org.chromium.base.ApplicationStatus; +import org.chromium.base.VisibleForTesting; import org.chromium.base.test.util.Feature; import org.chromium.chrome.shell.ChromeShellTestBase; import org.chromium.content.browser.test.util.Criteria; import org.chromium.content.browser.test.util.CriteriaHelper; import org.chromium.sync.signin.AccountManagerHelper; +import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout; + public class DelayedSyncControllerTest extends ChromeShellTestBase { private static final Account TEST_ACCOUNT = AccountManagerHelper.createAccountFromName("something@gmail.com"); diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java index ca5d03a..ab0f533 100644 --- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java +++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java @@ -15,13 +15,12 @@ import android.view.MenuItem; import android.view.View; import android.widget.Toast; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ApiCompatibilityUtils; import org.chromium.base.BaseSwitches; import org.chromium.base.CommandLine; import org.chromium.base.ContentUriUtils; import org.chromium.base.MemoryPressureListener; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.ProcessInitException; import org.chromium.chrome.browser.DevToolsServer; import org.chromium.chrome.browser.FileProviderHelper; diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index e97ccc3..d1f5f78 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -654,7 +654,6 @@ '../sync/sync.gyp:sync_java', '../third_party/android_tools/android_tools.gyp:android_support_v7_appcompat_javalib', '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib', - '../third_party/guava/guava.gyp:guava_javalib', '../ui/android/ui_android.gyp:ui_java', ], 'variables': { diff --git a/content/content.gyp b/content/content.gyp index 5cf6b6f..f14a9c6 100644 --- a/content/content.gyp +++ b/content/content.gyp @@ -447,7 +447,6 @@ ['android_webview_build == 0', { 'dependencies': [ '../third_party/eyesfree/eyesfree.gyp:eyesfree_java', - '../third_party/guava/guava.gyp:guava_javalib', ], }], ], diff --git a/content/public/android/BUILD.gn b/content/public/android/BUILD.gn index ef9a861..5184e54 100644 --- a/content/public/android/BUILD.gn +++ b/content/public/android/BUILD.gn @@ -35,7 +35,6 @@ android_library("content_java") { "//media/base/android:media_java", "//net/android:net_java", "//ui/android:ui_java", - "//third_party/guava:guava_javalib", "//third_party/jsr-305:jsr_305_javalib", #"//content:content_common", @@ -58,7 +57,6 @@ android_library("content_java") { if (!is_android_webview_build) { deps += [ "//third_party/eyesfree:eyesfree_java", - "//third_party/guava:guava_javalib", ] } } diff --git a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java index 8e586eb..c6f9136 100644 --- a/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java +++ b/content/public/android/java/src/org/chromium/content/browser/BatteryStatusManager.java @@ -12,10 +12,9 @@ import android.os.BatteryManager; import android.os.Build; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; +import org.chromium.base.VisibleForTesting; /** * Android implementation of the battery status APIs. diff --git a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java index 40dc2cb..2102d27 100644 --- a/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java +++ b/content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java @@ -7,10 +7,9 @@ package org.chromium.content.browser; import android.util.Log; import android.util.SparseArray; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.SysUtils; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; /** * Manages oom bindings used to bound child services. diff --git a/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java b/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java index 306212e..5a12ca6 100644 --- a/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java +++ b/content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java @@ -8,12 +8,11 @@ import android.content.Context; import android.os.Handler; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; import org.chromium.base.ResourceExtractor; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.LibraryLoader; import org.chromium.base.library_loader.LoaderErrors; import org.chromium.base.library_loader.ProcessInitException; diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java index f004e5e..d0025fc 100644 --- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java +++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java @@ -15,11 +15,10 @@ import android.os.ParcelFileDescriptor; import android.os.RemoteException; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CpuFeatures; import org.chromium.base.ThreadUtils; import org.chromium.base.TraceEvent; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.Linker; import org.chromium.content.app.ChildProcessService; import org.chromium.content.app.ChromiumLinkerParams; diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java index 1b653d0..286afbc 100644 --- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java +++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java @@ -11,12 +11,11 @@ import android.util.Log; import android.util.Pair; import android.view.Surface; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; import org.chromium.base.ThreadUtils; import org.chromium.base.TraceEvent; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.Linker; import org.chromium.content.app.ChildProcessService; import org.chromium.content.app.ChromiumLinkerParams; diff --git a/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java b/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java index bdb7741..ade4dfb0 100644 --- a/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java +++ b/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java @@ -13,12 +13,11 @@ import android.os.Handler; import android.os.HandlerThread; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.CollectionUtil; import org.chromium.base.JNINamespace; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import java.util.HashSet; import java.util.List; diff --git a/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java b/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java index 27f012a..2d79b4b 100644 --- a/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java +++ b/content/public/android/java/src/org/chromium/content/browser/LocationProviderAdapter.java @@ -6,10 +6,9 @@ package org.chromium.content.browser; import android.content.Context; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import java.util.concurrent.FutureTask; diff --git a/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java b/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java index 6954acb..5afec92 100644 --- a/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java +++ b/content/public/android/java/src/org/chromium/content/browser/LocationProviderFactory.java @@ -12,9 +12,8 @@ import android.location.LocationManager; import android.os.Bundle; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import java.util.List; diff --git a/content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java b/content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java index 5091868..582ddc1 100644 --- a/content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java +++ b/content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java @@ -13,11 +13,10 @@ import android.os.ParcelFileDescriptor; import android.text.TextUtils; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; import org.chromium.base.PathUtils; +import org.chromium.base.VisibleForTesting; import java.io.File; import java.io.IOException; diff --git a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java index 381f98b..5fd123a 100644 --- a/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java +++ b/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java @@ -15,10 +15,9 @@ import android.util.Log; import android.view.Surface; import android.view.WindowManager; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ObserverList; import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.ui.gfx.DeviceDisplayInfo; /** diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java index d185262..1eafc6afd 100644 --- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java +++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java @@ -17,7 +17,7 @@ import android.view.inputmethod.EditorInfo; import android.view.inputmethod.ExtractedText; import android.view.inputmethod.ExtractedTextRequest; -import com.google.common.annotations.VisibleForTesting; +import org.chromium.base.VisibleForTesting; /** * InputConnection is created by ContentView.onCreateInputConnection. diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java index 3697868..25fb337 100644 --- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java +++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java @@ -17,12 +17,11 @@ import android.view.KeyEvent; import android.view.View; import android.view.inputmethod.EditorInfo; -import com.google.common.annotations.VisibleForTesting; - import java.lang.CharSequence; import org.chromium.base.CalledByNative; import org.chromium.base.JNINamespace; +import org.chromium.base.VisibleForTesting; /** * Adapts and plumbs android IME service onto the chrome text input API. diff --git a/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java b/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java index 354b17d..abeac4d 100644 --- a/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java +++ b/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java @@ -6,11 +6,11 @@ package org.chromium.sync.internal_api.pub.base; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; import com.google.ipc.invalidation.external.client.types.ObjectId; import com.google.protos.ipc.invalidation.Types; import org.chromium.base.FieldTrialList; +import org.chromium.base.VisibleForTesting; import org.chromium.base.library_loader.LibraryLoader; import java.util.Collection; diff --git a/sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java b/sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java index 11cc4c4..3d96e03 100644 --- a/sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java +++ b/sync/android/java/src/org/chromium/sync/notifier/InvalidationIntentProtocol.java @@ -7,7 +7,6 @@ package org.chromium.sync.notifier; import android.accounts.Account; import android.content.Intent; -import com.google.common.base.Preconditions; import com.google.ipc.invalidation.external.client.types.ObjectId; import com.google.protos.ipc.invalidation.Types; @@ -87,8 +86,10 @@ public class InvalidationIntentProtocol { */ public static Intent createRegisterIntent(Account account, int[] objectSources, String[] objectNames) { - Preconditions.checkArgument(objectSources.length == objectNames.length, - "objectSources and objectNames must have the same length"); + if (objectSources.length != objectNames.length) { + throw new IllegalArgumentException( + "objectSources and objectNames must have the same length"); + } // Add all non-Sync objects to new lists. ArrayList<Integer> sources = new ArrayList<Integer>(); diff --git a/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java b/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java index 7917374..c3192ef2 100644 --- a/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java +++ b/sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java @@ -11,10 +11,11 @@ import android.preference.PreferenceManager; import android.util.Base64; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Preconditions; import com.google.ipc.invalidation.external.client.types.ObjectId; +import org.chromium.base.VisibleForTesting; + import java.util.Collection; import java.util.HashSet; import java.util.Set; @@ -79,7 +80,9 @@ public class InvalidationPreferences { private final Context mContext; public InvalidationPreferences(Context context) { - this.mContext = Preconditions.checkNotNull(context.getApplicationContext()); + Context appContext = context.getApplicationContext(); + if (appContext == null) throw new NullPointerException("Unable to get application context"); + mContext = appContext; } /** Returns a new {@link EditContext} to modify the preferences managed by this class. */ diff --git a/sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java b/sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java index f55f629..6986f5f 100644 --- a/sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java +++ b/sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java @@ -11,7 +11,6 @@ import android.content.Intent; import android.os.Bundle; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; import com.google.ipc.invalidation.external.client.InvalidationListener.RegistrationState; import com.google.ipc.invalidation.external.client.contrib.AndroidListener; import com.google.ipc.invalidation.external.client.types.ErrorInfo; @@ -21,6 +20,7 @@ import com.google.protos.ipc.invalidation.Types.ClientType; import org.chromium.base.ApplicationStatus; import org.chromium.base.CollectionUtil; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.internal_api.pub.base.ModelType; import org.chromium.sync.notifier.InvalidationPreferences.EditContext; import org.chromium.sync.signin.AccountManagerHelper; diff --git a/sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java b/sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java index 569848f..5178387 100644 --- a/sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java +++ b/sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java @@ -10,9 +10,8 @@ import android.content.Context; import android.content.SyncStatusObserver; import android.os.StrictMode; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ObserverList; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.signin.AccountManagerHelper; import org.chromium.sync.signin.ChromeSigninController; diff --git a/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java b/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java index e8d89d9..be76287 100644 --- a/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java +++ b/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java @@ -18,9 +18,8 @@ import android.os.AsyncTask; import android.os.Bundle; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; - import org.chromium.base.ThreadUtils; +import org.chromium.base.VisibleForTesting; import org.chromium.net.NetworkChangeNotifier; import java.io.IOException; diff --git a/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java b/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java index a1f6f85..771ce77 100644 --- a/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java +++ b/sync/android/java/src/org/chromium/sync/signin/ChromeSigninController.java @@ -10,11 +10,11 @@ import android.os.AsyncTask; import android.preference.PreferenceManager; import android.util.Log; -import com.google.common.annotations.VisibleForTesting; import com.google.ipc.invalidation.external.client.contrib.MultiplexingGcmListener; import org.chromium.base.CommandLine; import org.chromium.base.ObserverList; +import org.chromium.base.VisibleForTesting; import org.chromium.sync.SyncSwitches; public class ChromeSigninController { diff --git a/sync/sync_android.gypi b/sync/sync_android.gypi index 40e4be2..e707f0f 100644 --- a/sync/sync_android.gypi +++ b/sync/sync_android.gypi @@ -17,7 +17,6 @@ '../base/base.gyp:base_java_test_support', '../net/net.gyp:net_java', '../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation_javalib', - '../third_party/guava/guava.gyp:guava_javalib', '../third_party/jsr-305/jsr-305.gyp:jsr_305_javalib', ], 'includes': [ '../build/java.gypi' ], |