summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-31 00:13:50 +0000
committermpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-31 00:13:50 +0000
commit58149e368c83bd84d0d8710aa2c09eca3f1acfd0 (patch)
treecdb26c81af4345ff51bb5ab8ad69bef8d0095d1b
parentee57fd736bf621b7f31b0e02a7de2240996fad65 (diff)
downloadchromium_src-58149e368c83bd84d0d8710aa2c09eca3f1acfd0.zip
chromium_src-58149e368c83bd84d0d8710aa2c09eca3f1acfd0.tar.gz
chromium_src-58149e368c83bd84d0d8710aa2c09eca3f1acfd0.tar.bz2
Fix WebRequest browser_test flakiness, by filtering out system-level request
notifications. BUG=no TEST=no TBR=willchan Review URL: http://codereview.chromium.org/6670097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79926 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/data/extensions/api_test/webrequest/events/test.html7
1 files changed, 6 insertions, 1 deletions
diff --git a/chrome/test/data/extensions/api_test/webrequest/events/test.html b/chrome/test/data/extensions/api_test/webrequest/events/test.html
index 0f3a5c8..dadce3f 100644
--- a/chrome/test/data/extensions/api_test/webrequest/events/test.html
+++ b/chrome/test/data/extensions/api_test/webrequest/events/test.html
@@ -40,6 +40,11 @@ function checkExpectations() {
}
function captureEvent(name, details) {
+ // Ignore system-level requests like safebrowsing updates since they are
+ // unpredictable.
+ if (details.tabId == -1)
+ return;
+
delete details.requestId;
capturedEventData.push([name, details]);
checkExpectations();
@@ -135,7 +140,7 @@ runTests([
url: URL_HTTP_SIMPLE_LOAD
}
],
- ], {types: ["main_frame"]}, []);
+ ]);
chrome.tabs.update(tabId, { url: URL_HTTP_SIMPLE_LOAD });
},