diff options
| author | brucedawson <brucedawson@chromium.org> | 2016-03-09 18:28:47 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-10 02:29:53 +0000 |
| commit | 58552f9fcee335a8704f0c19472fde26ade8a7b9 (patch) | |
| tree | ce0d2643d2028b931cd50cee02564bc760c8eb2c | |
| parent | fb9ae22304e7322598f0d9518015f9b5508d1466 (diff) | |
| download | chromium_src-58552f9fcee335a8704f0c19472fde26ade8a7b9.zip chromium_src-58552f9fcee335a8704f0c19472fde26ade8a7b9.tar.gz chromium_src-58552f9fcee335a8704f0c19472fde26ade8a7b9.tar.bz2 | |
Suppress new C4334 and C4595 warnings
These two warnings are new in VS 2015 Update 2 (C4334 isn't necessarily
brand new, but it fires much more frequently now). Therefore they are
preventing a switch to VS 2015, without actually indicating any new
issues. The possible issues pointed to by C4334, in particular, have
been benign in every case that I have investigated. Therefore the
pragmatic thing to do is to suppress them for now, and resolve the
warnings individually after VS 2015 is the default.
The 4595 warning suppression is only needed in third_party\icu but it is
placed globally temporarily.
These warnings are also blocking PGO builds - another reason why a
timely fix is important.
BUG=440500,593448,591920
Review URL: https://codereview.chromium.org/1781593004
Cr-Commit-Position: refs/heads/master@{#380312}
| -rw-r--r-- | build/common.gypi | 5 | ||||
| -rw-r--r-- | build/config/compiler/BUILD.gn | 6 |
2 files changed, 11 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index c6958a8..3202296 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -5716,6 +5716,11 @@ # TODO(brucedawson): http://crbug.com/554200 4312 is a VS # 2015 64-bit warning for integer to larger pointer 4312, + + # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious + # shift' warning and 4595 is an 'illegal inline operator new' warning + # Both are new in VS 2015 Update 2 and can safely be deferred for now. + 4334, 4595, ], 'msvs_settings': { 'VCCLCompilerTool': { diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index 898b25f..3b125c2 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -783,6 +783,12 @@ config("default_warnings") { # C4312 is a VS 2015 64-bit warning for integer to larger pointer. # TODO(brucedawson): fix warnings, crbug.com/554200 "/wd4312", + + # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious + # shift' warning and 4595 is an 'illegal inline operator new' warning + # Both are new in VS 2015 Update 2 and can safely be deferred for now. + "/wd4334", + "/wd4595", ] } |