diff options
author | nasko@chromium.org <nasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 02:40:52 +0000 |
---|---|---|
committer | nasko@chromium.org <nasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 02:40:52 +0000 |
commit | 58d5cfe950eae22225d3c7e10c547a5a8944a557 (patch) | |
tree | 864117e7baeae0e593a4ee2e0e00177ac1d9ba6b | |
parent | 55f398244985990207b8861cde1da27039285adb (diff) | |
download | chromium_src-58d5cfe950eae22225d3c7e10c547a5a8944a557.zip chromium_src-58d5cfe950eae22225d3c7e10c547a5a8944a557.tar.gz chromium_src-58d5cfe950eae22225d3c7e10c547a5a8944a557.tar.bz2 |
Rename RenderViewGone IPC/methods to better reflect reality.
The RenderViewGone IPC and methods are incorrectly named, as those are used when a renderer process has died. Since we are passing in termination status around and usually iterating over all Render{Widget|View}Host in a specific process, it actually applies to the whole process. This CL renames all applicable instances of this method and the IPC message associated with it.
BUG=258087
Review URL: https://chromiumcodereview.appspot.com/18339006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210727 0039d316-1c4b-4281-b951-d872f2087c98
84 files changed, 125 insertions, 124 deletions
diff --git a/android_webview/browser/renderer_host/aw_render_view_host_ext.cc b/android_webview/browser/renderer_host/aw_render_view_host_ext.cc index 65641d7..2450092 100644 --- a/android_webview/browser/renderer_host/aw_render_view_host_ext.cc +++ b/android_webview/browser/renderer_host/aw_render_view_host_ext.cc @@ -85,7 +85,7 @@ void AwRenderViewHostExt::SetInitialPageScale(double page_scale_factor) { page_scale_factor)); } -void AwRenderViewHostExt::RenderViewGone(base::TerminationStatus status) { +void AwRenderViewHostExt::RenderProcessGone(base::TerminationStatus status) { DCHECK(CalledOnValidThread()); for (std::map<int, DocumentHasImagesResult>::iterator pending_req = pending_document_has_images_requests_.begin(); diff --git a/android_webview/browser/renderer_host/aw_render_view_host_ext.h b/android_webview/browser/renderer_host/aw_render_view_host_ext.h index 24e6a43..85ecfea 100644 --- a/android_webview/browser/renderer_host/aw_render_view_host_ext.h +++ b/android_webview/browser/renderer_host/aw_render_view_host_ext.h @@ -73,7 +73,7 @@ class AwRenderViewHostExt : public content::WebContentsObserver, private: // content::WebContentsObserver implementation. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void DidNavigateAnyFrame( const content::LoadCommittedDetails& details, const content::FrameNavigateParams& params) OVERRIDE; diff --git a/ash/screensaver/screensaver_view.cc b/ash/screensaver/screensaver_view.cc index d439e52..6c2c1e0 100644 --- a/ash/screensaver/screensaver_view.cc +++ b/ash/screensaver/screensaver_view.cc @@ -80,7 +80,7 @@ views::View* ScreensaverView::GetContentsView() { //////////////////////////////////////////////////////////////////////////////// // ScreensaverView, content::WebContentsObserver implementation. -void ScreensaverView::RenderViewGone( +void ScreensaverView::RenderProcessGone( base::TerminationStatus status) { LOG(ERROR) << "Screensaver terminated with status " << status; termination_count_++; diff --git a/ash/screensaver/screensaver_view.h b/ash/screensaver/screensaver_view.h index 0a0b777..610c8b0 100644 --- a/ash/screensaver/screensaver_view.h +++ b/ash/screensaver/screensaver_view.h @@ -55,7 +55,7 @@ class ScreensaverView : public views::WidgetDelegateView, virtual views::View* GetContentsView() OVERRIDE; // content::WebContentsObserver overrides. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; void Show(); void Close(); diff --git a/chrome/browser/chromeos/login/login_display_host_impl.cc b/chrome/browser/chromeos/login/login_display_host_impl.cc index 904a19b..47c539f 100644 --- a/chrome/browser/chromeos/login/login_display_host_impl.cc +++ b/chrome/browser/chromeos/login/login_display_host_impl.cc @@ -603,7 +603,7 @@ void LoginDisplayHostImpl::Observe( //////////////////////////////////////////////////////////////////////////////// // LoginDisplayHostImpl, WebContentsObserver implementation: -void LoginDisplayHostImpl::RenderViewGone(base::TerminationStatus status) { +void LoginDisplayHostImpl::RenderProcessGone(base::TerminationStatus status) { // Do not try to restore on shutdown if (browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID) return; diff --git a/chrome/browser/chromeos/login/login_display_host_impl.h b/chrome/browser/chromeos/login/login_display_host_impl.h index 42c279e..481001c 100644 --- a/chrome/browser/chromeos/login/login_display_host_impl.h +++ b/chrome/browser/chromeos/login/login_display_host_impl.h @@ -91,7 +91,7 @@ class LoginDisplayHostImpl : public LoginDisplayHost, const content::NotificationDetails& details) OVERRIDE; // Overridden from content::WebContentsObserver: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; private: // Marks display host for deletion. diff --git a/chrome/browser/chromeos/login/webui_screen_locker.cc b/chrome/browser/chromeos/login/webui_screen_locker.cc index b7ac13e..58baa1e 100644 --- a/chrome/browser/chromeos/login/webui_screen_locker.cc +++ b/chrome/browser/chromeos/login/webui_screen_locker.cc @@ -319,7 +319,7 @@ void WebUIScreenLocker::SystemResumed(const base::TimeDelta& sleep_duration) { base::Bind(&WebUIScreenLocker::FocusUserPod, weak_factory_.GetWeakPtr())); } -void WebUIScreenLocker::RenderViewGone(base::TerminationStatus status) { +void WebUIScreenLocker::RenderProcessGone(base::TerminationStatus status) { if (browser_shutdown::GetShutdownType() == browser_shutdown::NOT_VALID && status != base::TERMINATION_STATUS_NORMAL_TERMINATION) { LOG(ERROR) << "Renderer crash on lock screen"; diff --git a/chrome/browser/chromeos/login/webui_screen_locker.h b/chrome/browser/chromeos/login/webui_screen_locker.h index 8c52c81..4da5d304 100644 --- a/chrome/browser/chromeos/login/webui_screen_locker.h +++ b/chrome/browser/chromeos/login/webui_screen_locker.h @@ -107,7 +107,7 @@ class WebUIScreenLocker : public WebUILoginView, const base::TimeTicks& time) OVERRIDE; // Overridden from content::WebContentsObserver: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; private: friend class test::WebUIScreenLockerTester; diff --git a/chrome/browser/chromeos/ui/app_launch_view.cc b/chrome/browser/chromeos/ui/app_launch_view.cc index 9975b1c..3ea698d 100644 --- a/chrome/browser/chromeos/ui/app_launch_view.cc +++ b/chrome/browser/chromeos/ui/app_launch_view.cc @@ -98,7 +98,7 @@ views::View* AppLaunchView::GetContentsView() { //////////////////////////////////////////////////////////////////////////////// // AppLaunchView, content::WebContentsObserver implementation. -void AppLaunchView::RenderViewGone( +void AppLaunchView::RenderProcessGone( base::TerminationStatus status) { LOG(ERROR) << "Splash screen terminated with status " << status; AppLaunchView::CloseAppLaunchSplashScreen(); diff --git a/chrome/browser/chromeos/ui/app_launch_view.h b/chrome/browser/chromeos/ui/app_launch_view.h index 5ac78eb..838fd7e 100644 --- a/chrome/browser/chromeos/ui/app_launch_view.h +++ b/chrome/browser/chromeos/ui/app_launch_view.h @@ -54,7 +54,7 @@ class AppLaunchView : public views::WidgetDelegateView, virtual views::View* GetContentsView() OVERRIDE; // content::WebContentsObserver overrides. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; void Show(); void Close(); diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.cc b/chrome/browser/extensions/api/identity/web_auth_flow.cc index 2986b16..fa2e3cf 100644 --- a/chrome/browser/extensions/api/identity/web_auth_flow.cc +++ b/chrome/browser/extensions/api/identity/web_auth_flow.cc @@ -207,7 +207,7 @@ void WebAuthFlow::Observe(int type, } } -void WebAuthFlow::RenderViewGone(base::TerminationStatus status) { +void WebAuthFlow::RenderProcessGone(base::TerminationStatus status) { if (delegate_) delegate_->OnAuthFlowFailure(WebAuthFlow::WINDOW_CLOSED); } diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.h b/chrome/browser/extensions/api/identity/web_auth_flow.h index a3764ec..077b1f0 100644 --- a/chrome/browser/extensions/api/identity/web_auth_flow.h +++ b/chrome/browser/extensions/api/identity/web_auth_flow.h @@ -108,7 +108,7 @@ class WebAuthFlow : public content::NotificationObserver, virtual void DidNavigateMainFrame( const content::LoadCommittedDetails& details, const content::FrameNavigateParams& params) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void DidStartProvisionalLoadForFrame( int64 frame_id, int64 parent_frame_id, diff --git a/chrome/browser/extensions/extension_host.cc b/chrome/browser/extensions/extension_host.cc index 5668535..38d559c 100644 --- a/chrome/browser/extensions/extension_host.cc +++ b/chrome/browser/extensions/extension_host.cc @@ -324,7 +324,7 @@ void ExtensionHost::ResizeDueToAutoResize(WebContents* source, view()->ResizeDueToAutoResize(new_size); } -void ExtensionHost::RenderViewGone(base::TerminationStatus status) { +void ExtensionHost::RenderProcessGone(base::TerminationStatus status) { // During browser shutdown, we may use sudden termination on an extension // process, so it is expected to lose our connection to the render view. // Do nothing. diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h index b9a99723..f4e8886 100644 --- a/chrome/browser/extensions/extension_host.h +++ b/chrome/browser/extensions/extension_host.h @@ -143,7 +143,7 @@ class ExtensionHost : public content::WebContentsDelegate, virtual void RenderViewDeleted( content::RenderViewHost* render_view_host) OVERRIDE; virtual void RenderViewReady() OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void DocumentAvailableInMainFrame() OVERRIDE; virtual void DidStopLoading( content::RenderViewHost* render_view_host) OVERRIDE; diff --git a/chrome/browser/infobars/infobar_service.cc b/chrome/browser/infobars/infobar_service.cc index 34f99e6..90915ef 100644 --- a/chrome/browser/infobars/infobar_service.cc +++ b/chrome/browser/infobars/infobar_service.cc @@ -107,7 +107,7 @@ InfoBarService::~InfoBarService() { RemoveAllInfoBars(false); } -void InfoBarService::RenderViewGone(base::TerminationStatus status) { +void InfoBarService::RenderProcessGone(base::TerminationStatus status) { RemoveAllInfoBars(true); } diff --git a/chrome/browser/infobars/infobar_service.h b/chrome/browser/infobars/infobar_service.h index 5ea6ce0..e0f40aa 100644 --- a/chrome/browser/infobars/infobar_service.h +++ b/chrome/browser/infobars/infobar_service.h @@ -78,7 +78,7 @@ class InfoBarService : public content::WebContentsObserver, virtual ~InfoBarService(); // content::WebContentsObserver: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // content::NotificationObserver: diff --git a/chrome/browser/notifications/balloon_host.cc b/chrome/browser/notifications/balloon_host.cc index 24c39f2..5ee2ce6 100644 --- a/chrome/browser/notifications/balloon_host.cc +++ b/chrome/browser/notifications/balloon_host.cc @@ -116,7 +116,7 @@ void BalloonHost::RenderViewReady() { content::NotificationService::NoDetails()); } -void BalloonHost::RenderViewGone(base::TerminationStatus status) { +void BalloonHost::RenderProcessGone(base::TerminationStatus status) { CloseContents(web_contents_.get()); } diff --git a/chrome/browser/notifications/balloon_host.h b/chrome/browser/notifications/balloon_host.h index 83dc9cc..693b21b 100644 --- a/chrome/browser/notifications/balloon_host.h +++ b/chrome/browser/notifications/balloon_host.h @@ -74,7 +74,7 @@ class BalloonHost : public content::WebContentsDelegate, virtual void RenderViewCreated( content::RenderViewHost* render_view_host) OVERRIDE; virtual void RenderViewReady() OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Message handlers diff --git a/chrome/browser/page_cycler/page_cycler_unittest.cc b/chrome/browser/page_cycler/page_cycler_unittest.cc index 0f0e3ac..f46bf09 100644 --- a/chrome/browser/page_cycler/page_cycler_unittest.cc +++ b/chrome/browser/page_cycler/page_cycler_unittest.cc @@ -65,7 +65,7 @@ class MockPageCycler : public PageCycler { int error_code, const string16& error_description, RenderViewHost* render_view_host)); - MOCK_METHOD1(RenderViewGone, void(base::TerminationStatus status)); + MOCK_METHOD1(RenderProcessGone, void(base::TerminationStatus status)); void PageCyclerDidFailProvisionalLoad( int64 frame_id, diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc index 47117f1..d3af6ef 100644 --- a/chrome/browser/prerender/prerender_browsertest.cc +++ b/chrome/browser/prerender/prerender_browsertest.cc @@ -271,7 +271,7 @@ class TestPrerenderContents : public PrerenderContents { } } - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE { + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { // On quit, it's possible to end up here when render processes are closed // before the PrerenderManager is destroyed. As a result, it's possible to // get either FINAL_STATUS_APP_TERMINATING or FINAL_STATUS_RENDERER_CRASHED @@ -285,7 +285,7 @@ class TestPrerenderContents : public PrerenderContents { expected_final_status_ = FINAL_STATUS_RENDERER_CRASHED; } - PrerenderContents::RenderViewGone(status); + PrerenderContents::RenderProcessGone(status); } virtual bool AddAliasURL(const GURL& url) OVERRIDE { diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc index de1ec58..cf26921 100644 --- a/chrome/browser/prerender/prerender_contents.cc +++ b/chrome/browser/prerender/prerender_contents.cc @@ -559,7 +559,7 @@ bool PrerenderContents::Matches( std::bind2nd(std::equal_to<GURL>(), url)) != 0; } -void PrerenderContents::RenderViewGone(base::TerminationStatus status) { +void PrerenderContents::RenderProcessGone(base::TerminationStatus status) { Destroy(FINAL_STATUS_RENDERER_CRASHED); } diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h index fca0c8f..a3030f9 100644 --- a/chrome/browser/prerender/prerender_contents.h +++ b/chrome/browser/prerender/prerender_contents.h @@ -231,7 +231,7 @@ class PrerenderContents : public content::NotificationObserver, virtual void DidUpdateFaviconURL(int32 page_id, const std::vector<content::FaviconURL>& urls) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; // content::NotificationObserver virtual void Observe(int type, diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc index 17666df..69bce10 100644 --- a/chrome/browser/printing/print_view_manager.cc +++ b/chrome/browser/printing/print_view_manager.cc @@ -184,7 +184,7 @@ void PrintViewManager::StopNavigation() { TerminatePrintJob(true); } -void PrintViewManager::RenderViewGone(base::TerminationStatus status) { +void PrintViewManager::RenderProcessGone(base::TerminationStatus status) { print_preview_state_ = NOT_PREVIEWING; ReleasePrinterQuery(); diff --git a/chrome/browser/printing/print_view_manager.h b/chrome/browser/printing/print_view_manager.h index de950db..55b4708 100644 --- a/chrome/browser/printing/print_view_manager.h +++ b/chrome/browser/printing/print_view_manager.h @@ -93,7 +93,7 @@ class PrintViewManager : public content::NotificationObserver, virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // Terminates or cancels the print job if one was pending. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; // Cancels the print job. virtual void StopNavigation() OVERRIDE; diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc index cdc9e9ee..a388d97 100644 --- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc +++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc @@ -357,7 +357,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, } // This class's goal is to close the browser window when a renderer process has -// crashed. It does so by monitoring WebContents for RenderViewGone event and +// crashed. It does so by monitoring WebContents for RenderProcessGone event and // closing the passed in TabStripModel. This is used in the following test case. class WindowDestroyer : public content::WebContentsObserver { public: @@ -366,7 +366,7 @@ class WindowDestroyer : public content::WebContentsObserver { tab_strip_model_(model) { } - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE { + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { // Wait for the window to be destroyed, which will ensure all other // RenderViewHost objects are deleted before we return and proceed with // the next iteration of notifications. diff --git a/chrome/browser/tab_contents/background_contents.cc b/chrome/browser/tab_contents/background_contents.cc index 106351c..f37e1b8 100644 --- a/chrome/browser/tab_contents/background_contents.cc +++ b/chrome/browser/tab_contents/background_contents.cc @@ -110,7 +110,7 @@ void BackgroundContents::AddNewContents(WebContents* source, new_contents, disposition, initial_pos, user_gesture, was_blocked); } -void BackgroundContents::RenderViewGone(base::TerminationStatus status) { +void BackgroundContents::RenderProcessGone(base::TerminationStatus status) { content::NotificationService::current()->Notify( chrome::NOTIFICATION_BACKGROUND_CONTENTS_TERMINATED, content::Source<Profile>(profile_), diff --git a/chrome/browser/tab_contents/background_contents.h b/chrome/browser/tab_contents/background_contents.h index be2c71f..e6b817c 100644 --- a/chrome/browser/tab_contents/background_contents.h +++ b/chrome/browser/tab_contents/background_contents.h @@ -63,7 +63,7 @@ class BackgroundContents : public content::WebContentsDelegate, bool* was_blocked) OVERRIDE; // content::WebContentsObserver implementation: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; // content::NotificationObserver virtual void Observe(int type, diff --git a/chrome/browser/ui/cocoa/hung_renderer_controller.h b/chrome/browser/ui/cocoa/hung_renderer_controller.h index 1725726..282f218 100644 --- a/chrome/browser/ui/cocoa/hung_renderer_controller.h +++ b/chrome/browser/ui/cocoa/hung_renderer_controller.h @@ -73,7 +73,7 @@ class WebContents; // Called by |hungContentsObserver_| to indicate that |hungContents_| // has gone away. -- (void)renderViewGone; +- (void)renderProcessGone; @end // HungRendererController diff --git a/chrome/browser/ui/cocoa/hung_renderer_controller.mm b/chrome/browser/ui/cocoa/hung_renderer_controller.mm index b75da41..dc21d44 100644 --- a/chrome/browser/ui/cocoa/hung_renderer_controller.mm +++ b/chrome/browser/ui/cocoa/hung_renderer_controller.mm @@ -49,11 +49,11 @@ class WebContentsObserverBridge : public content::WebContentsObserver { protected: // WebContentsObserver overrides: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE { - [controller_ renderViewGone]; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { + [controller_ renderProcessGone]; } virtual void WebContentsDestroyed(WebContents* tab) OVERRIDE { - [controller_ renderViewGone]; + [controller_ renderProcessGone]; } private: @@ -205,7 +205,7 @@ class WebContentsObserverBridge : public content::WebContentsObserver { } } -- (void)renderViewGone { +- (void)renderProcessGone { // Cannot call performClose:, because the close button is disabled. [self close]; } diff --git a/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc b/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc index bf703d6..c0ea1ac 100644 --- a/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc +++ b/chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc @@ -52,7 +52,7 @@ class HungRendererDialogGtk { } // content::WebContentsObserver overrides: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE { + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { dialog_->Hide(); } virtual void WebContentsDestroyed(WebContents* tab) OVERRIDE { diff --git a/chrome/browser/ui/panels/panel_host.cc b/chrome/browser/ui/panels/panel_host.cc index 60658da..d40c5a4c 100644 --- a/chrome/browser/ui/panels/panel_host.cc +++ b/chrome/browser/ui/panels/panel_host.cc @@ -201,7 +201,7 @@ void PanelHost::RenderViewCreated(content::RenderViewHost* render_view_host) { render_view_host->GetRoutingID(), window->GetWindowId())); } -void PanelHost::RenderViewGone(base::TerminationStatus status) { +void PanelHost::RenderProcessGone(base::TerminationStatus status) { CloseContents(web_contents_.get()); } diff --git a/chrome/browser/ui/panels/panel_host.h b/chrome/browser/ui/panels/panel_host.h index e7344cf..3c94c0f 100644 --- a/chrome/browser/ui/panels/panel_host.h +++ b/chrome/browser/ui/panels/panel_host.h @@ -78,7 +78,7 @@ class PanelHost : public content::WebContentsDelegate, // content::WebContentsObserver overrides. virtual void RenderViewCreated( content::RenderViewHost* render_view_host) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void WebContentsDestroyed( content::WebContents* web_contents) OVERRIDE; virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc index 9d834a6..dfcb1cf 100644 --- a/chrome/browser/ui/sad_tab_helper.cc +++ b/chrome/browser/ui/sad_tab_helper.cc @@ -23,7 +23,7 @@ SadTabHelper::SadTabHelper(content::WebContents* web_contents) content::Source<content::WebContents>(web_contents)); } -void SadTabHelper::RenderViewGone(base::TerminationStatus status) { +void SadTabHelper::RenderProcessGone(base::TerminationStatus status) { // Only show the sad tab if we're not in browser shutdown, so that WebContents // objects that are not in a browser (e.g., HTML dialogs) and thus are // visible do not flash a sad tab page. diff --git a/chrome/browser/ui/sad_tab_helper.h b/chrome/browser/ui/sad_tab_helper.h index e375e8b..0ea35d0 100644 --- a/chrome/browser/ui/sad_tab_helper.h +++ b/chrome/browser/ui/sad_tab_helper.h @@ -34,7 +34,7 @@ class SadTabHelper : public content::WebContentsObserver, void InstallSadTab(base::TerminationStatus status); // Overridden from content::WebContentsObserver: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; // Overridden from content::NotificationObserver: virtual void Observe(int type, diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc index 6b40b04..55bb21f 100644 --- a/chrome/browser/ui/search/instant_controller.cc +++ b/chrome/browser/ui/search/instant_controller.cc @@ -449,7 +449,7 @@ void InstantController::InstantSupportDetermined( } } -void InstantController::InstantPageRenderViewGone( +void InstantController::InstantPageRenderProcessGone( const content::WebContents* contents) { if (IsContentsFrom(ntp(), contents)) { DeletePageSoon(ntp_.Pass()); diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h index 721c3b3..7964d87 100644 --- a/chrome/browser/ui/search/instant_controller.h +++ b/chrome/browser/ui/search/instant_controller.h @@ -167,7 +167,7 @@ class InstantController : public InstantPage::Delegate, FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInNewTab); FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInSameTab); FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPForWrongProvider); - FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPRenderViewGone); + FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPRenderProcessGone); FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPDoesntSupportInstant); FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ProcessIsolation); @@ -200,7 +200,7 @@ class InstantController : public InstantPage::Delegate, virtual void InstantSupportDetermined( const content::WebContents* contents, bool supports_instant) OVERRIDE; - virtual void InstantPageRenderViewGone( + virtual void InstantPageRenderProcessGone( const content::WebContents* contents) OVERRIDE; virtual void InstantPageAboutToNavigateMainFrame( const content::WebContents* contents, diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc index 344b7e4..3aa6851 100644 --- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc +++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc @@ -457,7 +457,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPForWrongProvider) { EXPECT_NE(ntp_url, active_tab->GetURL()); } -IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderViewGone) { +IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderProcessGone) { // Setup Instant. ASSERT_NO_FATAL_FAILURE(SetupInstant(browser())); FocusOmniboxAndWaitForInstantNTPSupport(); @@ -467,7 +467,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderViewGone) { EXPECT_FALSE(instant()->ntp()->IsLocal()); // NTP not reloaded after being killed. - instant()->InstantPageRenderViewGone(instant()->ntp()->contents()); + instant()->InstantPageRenderProcessGone(instant()->ntp()->contents()); EXPECT_EQ(NULL, instant()->ntp()); // Open new tab. Should use local NTP. diff --git a/chrome/browser/ui/search/instant_ntp.cc b/chrome/browser/ui/search/instant_ntp.cc index 23fad12..e02b659 100644 --- a/chrome/browser/ui/search/instant_ntp.cc +++ b/chrome/browser/ui/search/instant_ntp.cc @@ -104,8 +104,8 @@ void InstantNTP::RenderViewCreated(content::RenderViewHost* render_view_host) { delegate()->InstantPageRenderViewCreated(contents()); } -void InstantNTP::RenderViewGone(base::TerminationStatus /* status */) { - delegate()->InstantPageRenderViewGone(contents()); +void InstantNTP::RenderProcessGone(base::TerminationStatus /* status */) { + delegate()->InstantPageRenderProcessGone(contents()); } // static diff --git a/chrome/browser/ui/search/instant_ntp.h b/chrome/browser/ui/search/instant_ntp.h index 510fe08..d9382f5 100644 --- a/chrome/browser/ui/search/instant_ntp.h +++ b/chrome/browser/ui/search/instant_ntp.h @@ -52,7 +52,7 @@ class InstantNTP : public InstantPage, // Overridden from content::WebContentsObserver: virtual void RenderViewCreated( content::RenderViewHost* render_view_host) OVERRIDE; - virtual void RenderViewGone( + virtual void RenderProcessGone( base::TerminationStatus status) OVERRIDE; // Overriden from InstantLoader::Delegate: diff --git a/chrome/browser/ui/search/instant_page.h b/chrome/browser/ui/search/instant_page.h index b2de2bb..f26e940 100644 --- a/chrome/browser/ui/search/instant_page.h +++ b/chrome/browser/ui/search/instant_page.h @@ -52,8 +52,8 @@ class InstantPage : public content::WebContentsObserver, virtual void InstantSupportDetermined(const content::WebContents* contents, bool supports_instant) = 0; - // Called when the underlying RenderView crashed. - virtual void InstantPageRenderViewGone( + // Called when the underlying RenderView's process crashed. + virtual void InstantPageRenderProcessGone( const content::WebContents* contents) = 0; // Called when the page is about to navigate to |url|. diff --git a/chrome/browser/ui/search/instant_page_unittest.cc b/chrome/browser/ui/search/instant_page_unittest.cc index c751cfe..effa9c6 100644 --- a/chrome/browser/ui/search/instant_page_unittest.cc +++ b/chrome/browser/ui/search/instant_page_unittest.cc @@ -32,7 +32,7 @@ class FakePageDelegate : public InstantPage::Delegate { MOCK_METHOD2(InstantSupportDetermined, void(const content::WebContents* contents, bool supports_instant)); - MOCK_METHOD1(InstantPageRenderViewGone, + MOCK_METHOD1(InstantPageRenderProcessGone, void(const content::WebContents* contents)); MOCK_METHOD2(InstantPageAboutToNavigateMainFrame, void(const content::WebContents* contents, diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc index 5ff6306..665064b 100644 --- a/chrome/browser/ui/views/hung_renderer_view.cc +++ b/chrome/browser/ui/views/hung_renderer_view.cc @@ -158,7 +158,7 @@ HungPagesTableModel::WebContentsObserverImpl::WebContentsObserverImpl( model_(model) { } -void HungPagesTableModel::WebContentsObserverImpl::RenderViewGone( +void HungPagesTableModel::WebContentsObserverImpl::RenderProcessGone( base::TerminationStatus status) { model_->TabDestroyed(this); } diff --git a/chrome/browser/ui/views/hung_renderer_view.h b/chrome/browser/ui/views/hung_renderer_view.h index a657b44..0593f1f 100644 --- a/chrome/browser/ui/views/hung_renderer_view.h +++ b/chrome/browser/ui/views/hung_renderer_view.h @@ -74,7 +74,7 @@ class HungPagesTableModel : public ui::TableModel, public views::TableGrouper { } // WebContentsObserver overrides: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE; private: diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc index 8f4d3fd..5b7f5b1 100644 --- a/content/browser/browser_plugin/browser_plugin_embedder.cc +++ b/content/browser/browser_plugin/browser_plugin_embedder.cc @@ -89,7 +89,7 @@ bool BrowserPluginEmbedder::HandleKeyboardEvent( static_cast<WebContentsImpl*>(web_contents()), event); } -void BrowserPluginEmbedder::RenderViewGone(base::TerminationStatus status) { +void BrowserPluginEmbedder::RenderProcessGone(base::TerminationStatus status) { CleanUp(); } diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h index 73ae6b3..5261063 100644 --- a/content/browser/browser_plugin/browser_plugin_embedder.h +++ b/content/browser/browser_plugin/browser_plugin_embedder.h @@ -68,7 +68,7 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver { } // WebContentsObserver implementation. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; void DragSourceEndedAt(int client_x, int client_y, int screen_x, diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc index 67e30bd..3d21e7c 100644 --- a/content/browser/browser_plugin/browser_plugin_guest.cc +++ b/content/browser/browser_plugin/browser_plugin_guest.cc @@ -893,7 +893,7 @@ void BrowserPluginGuest::RenderViewReady() { set_hung_renderer_delay_ms(guest_hang_timeout_); } -void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) { +void BrowserPluginGuest::RenderProcessGone(base::TerminationStatus status) { int process_id = GetWebContents()->GetRenderProcessHost()->GetID(); SendMessageToEmbedder( new BrowserPluginMsg_GuestGone(instance_id(), process_id, status)); diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h index d7557db..668cbba 100644 --- a/content/browser/browser_plugin/browser_plugin_guest.h +++ b/content/browser/browser_plugin/browser_plugin_guest.h @@ -157,7 +157,7 @@ class CONTENT_EXPORT BrowserPluginGuest virtual void DidStopLoading(RenderViewHost* render_view_host) OVERRIDE; virtual void RenderViewReady() OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; // WebContentsDelegate implementation. diff --git a/content/browser/browser_plugin/test_browser_plugin_guest.cc b/content/browser/browser_plugin/test_browser_plugin_guest.cc index 5a8149f..4039ec8 100644 --- a/content/browser/browser_plugin/test_browser_plugin_guest.cc +++ b/content/browser/browser_plugin/test_browser_plugin_guest.cc @@ -104,14 +104,14 @@ void TestBrowserPluginGuest::WaitForDamageBufferWithSize( damage_buffer_message_loop_runner_->Run(); } -void TestBrowserPluginGuest::RenderViewGone(base::TerminationStatus status) { +void TestBrowserPluginGuest::RenderProcessGone(base::TerminationStatus status) { exit_observed_ = true; if (status != base::TERMINATION_STATUS_NORMAL_TERMINATION && status != base::TERMINATION_STATUS_STILL_RUNNING) LOG(INFO) << "Guest crashed status: " << status; if (crash_message_loop_runner_.get()) crash_message_loop_runner_->Quit(); - BrowserPluginGuest::RenderViewGone(status); + BrowserPluginGuest::RenderProcessGone(status); } void TestBrowserPluginGuest::OnHandleInputEvent( diff --git a/content/browser/browser_plugin/test_browser_plugin_guest.h b/content/browser/browser_plugin/test_browser_plugin_guest.h index 00139ea..7464f26 100644 --- a/content/browser/browser_plugin/test_browser_plugin_guest.h +++ b/content/browser/browser_plugin/test_browser_plugin_guest.h @@ -34,7 +34,7 @@ class TestBrowserPluginGuest : public BrowserPluginGuest { const NotificationDetails& details) OVERRIDE; // Overridden methods from BrowserPluginGuest to intercept in test objects. - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void OnHandleInputEvent(int instance_id, const gfx::Rect& guest_window_rect, const WebKit::WebInputEvent* event) OVERRIDE; diff --git a/content/browser/devtools/devtools_frontend_host.cc b/content/browser/devtools/devtools_frontend_host.cc index 5181c6b..4833075 100644 --- a/content/browser/devtools/devtools_frontend_host.cc +++ b/content/browser/devtools/devtools_frontend_host.cc @@ -82,7 +82,7 @@ bool DevToolsFrontendHost::OnMessageReceived( return handled; } -void DevToolsFrontendHost::RenderViewGone( +void DevToolsFrontendHost::RenderProcessGone( base::TerminationStatus status) { switch(status) { case base::TERMINATION_STATUS_ABNORMAL_TERMINATION: diff --git a/content/browser/devtools/devtools_frontend_host.h b/content/browser/devtools/devtools_frontend_host.h index 9332d73..aa973aa 100644 --- a/content/browser/devtools/devtools_frontend_host.h +++ b/content/browser/devtools/devtools_frontend_host.h @@ -37,7 +37,7 @@ class DevToolsFrontendHost : public DevToolsClientHost, // WebContentsObserver overrides. virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; void OnDispatchOnInspectorBackend(const std::string& message); void OnActivateWindow(); diff --git a/content/browser/devtools/render_view_devtools_agent_host.cc b/content/browser/devtools/render_view_devtools_agent_host.cc index e4812d3..2acdea4 100644 --- a/content/browser/devtools/render_view_devtools_agent_host.cc +++ b/content/browser/devtools/render_view_devtools_agent_host.cc @@ -247,7 +247,7 @@ void RenderViewDevToolsAgentHost::AboutToNavigateRenderView( ConnectRenderViewHost(dest_rvh, true); } -void RenderViewDevToolsAgentHost::RenderViewGone( +void RenderViewDevToolsAgentHost::RenderProcessGone( base::TerminationStatus status) { switch(status) { case base::TERMINATION_STATUS_ABNORMAL_TERMINATION: diff --git a/content/browser/devtools/render_view_devtools_agent_host.h b/content/browser/devtools/render_view_devtools_agent_host.h index fddd90e..8257663 100644 --- a/content/browser/devtools/render_view_devtools_agent_host.h +++ b/content/browser/devtools/render_view_devtools_agent_host.h @@ -48,7 +48,7 @@ class CONTENT_EXPORT RenderViewDevToolsAgentHost // WebContentsObserver overrides. virtual void AboutToNavigateRenderView(RenderViewHost* dest_rvh) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void DidAttachInterstitialPage() OVERRIDE; void ConnectRenderViewHost(RenderViewHost* rvh, bool reattach); diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc index f609530..2351593 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc @@ -1618,9 +1618,9 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead) { IDMap<IPC::Listener>::iterator iter(&listeners_); while (!iter.IsAtEnd()) { iter.GetCurrentValue()->OnMessageReceived( - ViewHostMsg_RenderViewGone(iter.GetCurrentKey(), - static_cast<int>(status), - exit_code)); + ViewHostMsg_RenderProcessGone(iter.GetCurrentKey(), + static_cast<int>(status), + exit_code)); iter.Advance(); } diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc index c2b0584..c7b5498 100644 --- a/content/browser/renderer_host/render_view_host_impl.cc +++ b/content/browser/renderer_host/render_view_host_impl.cc @@ -918,7 +918,7 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) { OnShowFullscreenWidget) IPC_MESSAGE_HANDLER_DELAY_REPLY(ViewHostMsg_RunModal, OnRunModal) IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewReady, OnRenderViewReady) - IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewGone, OnRenderViewGone) + IPC_MESSAGE_HANDLER(ViewHostMsg_RenderProcessGone, OnRenderProcessGone) IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame, OnDidStartProvisionalLoadForFrame) IPC_MESSAGE_HANDLER(ViewHostMsg_DidRedirectProvisionalLoad, @@ -1110,7 +1110,7 @@ void RenderViewHostImpl::OnRenderViewReady() { delegate_->RenderViewReady(this); } -void RenderViewHostImpl::OnRenderViewGone(int status, int exit_code) { +void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) { // Keep the termination status so we can get at it later when we // need to know why it died. render_view_termination_status_ = diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h index a248da38..79cf809 100644 --- a/content/browser/renderer_host/render_view_host_impl.h +++ b/content/browser/renderer_host/render_view_host_impl.h @@ -491,7 +491,7 @@ class CONTENT_EXPORT RenderViewHostImpl void OnShowFullscreenWidget(int route_id); void OnRunModal(int opener_id, IPC::Message* reply_msg); void OnRenderViewReady(); - void OnRenderViewGone(int status, int error_code); + void OnRenderProcessGone(int status, int error_code); void OnDidStartProvisionalLoadForFrame(int64 frame_id, int64 parent_frame_id, bool main_frame, @@ -648,8 +648,8 @@ class CONTENT_EXPORT RenderViewHostImpl bool is_subframe_; // The frame id of the main (top level) frame. This value is set on the - // initial navigation of a RenderView and reset when the RenderView is - // terminated (in RenderViewGone). + // initial navigation of a RenderView and reset when the RenderView's + // process is terminated (in RenderProcessGone). int64 main_frame_id_; // If we were asked to RunModal, then this will hold the reply_msg that we diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc index 5460b50..fd68f9e 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -442,7 +442,7 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) { bool msg_is_ok = true; IPC_BEGIN_MESSAGE_MAP_EX(RenderWidgetHostImpl, msg, msg_is_ok) IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewReady, OnRenderViewReady) - IPC_MESSAGE_HANDLER(ViewHostMsg_RenderViewGone, OnRenderViewGone) + IPC_MESSAGE_HANDLER(ViewHostMsg_RenderProcessGone, OnRenderProcessGone) IPC_MESSAGE_HANDLER(ViewHostMsg_Close, OnClose) IPC_MESSAGE_HANDLER(ViewHostMsg_UpdateScreenRects_ACK, OnUpdateScreenRectsAck) @@ -1546,8 +1546,8 @@ void RenderWidgetHostImpl::RendererExited(base::TerminationStatus status, if (view_) { GpuSurfaceTracker::Get()->SetSurfaceHandle(surface_id_, gfx::GLSurfaceHandle()); - view_->RenderViewGone(status, exit_code); - view_ = NULL; // The View should be deleted by RenderViewGone. + view_->RenderProcessGone(status, exit_code); + view_ = NULL; // The View should be deleted by RenderProcessGone. } BackingStoreManager::RemoveBackingStore(this); @@ -1698,7 +1698,7 @@ void RenderWidgetHostImpl::OnRenderViewReady() { WasResized(); } -void RenderWidgetHostImpl::OnRenderViewGone(int status, int exit_code) { +void RenderWidgetHostImpl::OnRenderProcessGone(int status, int exit_code) { // TODO(evanm): This synchronously ends up calling "delete this". // Is that really what we want in response to this message? I'm matching // previous behavior of the code here. diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h index 759114e..d76fa58 100644 --- a/content/browser/renderer_host/render_widget_host_impl.h +++ b/content/browser/renderer_host/render_widget_host_impl.h @@ -632,7 +632,7 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost, // IPC message handlers void OnRenderViewReady(); - void OnRenderViewGone(int status, int error_code); + void OnRenderProcessGone(int status, int error_code); void OnClose(); void OnUpdateScreenRectsAck(); void OnRequestMove(const gfx::Rect& pos); diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc index d7fe7d8..2d50108 100644 --- a/content/browser/renderer_host/render_widget_host_view_android.cc +++ b/content/browser/renderer_host/render_widget_host_view_android.cc @@ -456,7 +456,7 @@ void RenderWidgetHostViewAndroid::DidUpdateBackingStore( NOTIMPLEMENTED(); } -void RenderWidgetHostViewAndroid::RenderViewGone( +void RenderWidgetHostViewAndroid::RenderProcessGone( base::TerminationStatus status, int error_code) { Destroy(); } diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h index f8bbd59..51df8ed 100644 --- a/content/browser/renderer_host/render_widget_host_view_android.h +++ b/content/browser/renderer_host/render_widget_host_view_android.h @@ -104,8 +104,8 @@ class RenderWidgetHostViewAndroid const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void Destroy() OVERRIDE; virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE; virtual void SelectionChanged(const string16& text, diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc index b521087..3bce9af 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.cc +++ b/content/browser/renderer_host/render_widget_host_view_aura.cc @@ -1088,8 +1088,8 @@ void RenderWidgetHostViewAura::DidUpdateBackingStore( } } -void RenderWidgetHostViewAura::RenderViewGone(base::TerminationStatus status, - int error_code) { +void RenderWidgetHostViewAura::RenderProcessGone(base::TerminationStatus status, + int error_code) { UpdateCursorIfOverSelf(); Destroy(); } diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h index a6d45c7..f0a2867 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.h +++ b/content/browser/renderer_host/render_widget_host_view_aura.h @@ -184,8 +184,8 @@ class RenderWidgetHostViewAura const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void Destroy() OVERRIDE; virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE; virtual void SelectionChanged(const string16& text, diff --git a/content/browser/renderer_host/render_widget_host_view_gtk.cc b/content/browser/renderer_host/render_widget_host_view_gtk.cc index 146ec83..f7b5793 100644 --- a/content/browser/renderer_host/render_widget_host_view_gtk.cc +++ b/content/browser/renderer_host/render_widget_host_view_gtk.cc @@ -877,8 +877,8 @@ void RenderWidgetHostViewGtk::DidUpdateBackingStore( } } -void RenderWidgetHostViewGtk::RenderViewGone(base::TerminationStatus status, - int error_code) { +void RenderWidgetHostViewGtk::RenderProcessGone(base::TerminationStatus status, + int error_code) { Destroy(); plugin_container_manager_.set_host_widget(NULL); } diff --git a/content/browser/renderer_host/render_widget_host_view_gtk.h b/content/browser/renderer_host/render_widget_host_view_gtk.h index a7723ee..a810feb 100644 --- a/content/browser/renderer_host/render_widget_host_view_gtk.h +++ b/content/browser/renderer_host/render_widget_host_view_gtk.h @@ -90,8 +90,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGtk const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void Destroy() OVERRIDE; virtual void WillDestroyRenderWidget(RenderWidgetHost* rwh) {} virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE; diff --git a/content/browser/renderer_host/render_widget_host_view_guest.cc b/content/browser/renderer_host/render_widget_host_view_guest.cc index 86adae9..c540a81 100644 --- a/content/browser/renderer_host/render_widget_host_view_guest.cc +++ b/content/browser/renderer_host/render_widget_host_view_guest.cc @@ -137,9 +137,10 @@ gfx::Rect RenderWidgetHostViewGuest::GetViewBounds() const { return shifted_rect; } -void RenderWidgetHostViewGuest::RenderViewGone(base::TerminationStatus status, - int error_code) { - platform_view_->RenderViewGone(status, error_code); +void RenderWidgetHostViewGuest::RenderProcessGone( + base::TerminationStatus status, + int error_code) { + platform_view_->RenderProcessGone(status, error_code); // Destroy the guest view instance only, so we don't end up calling // platform_view_->Destroy(). DestroyGuestView(); diff --git a/content/browser/renderer_host/render_widget_host_view_guest.h b/content/browser/renderer_host/render_widget_host_view_guest.h index 29a3486..277f975 100644 --- a/content/browser/renderer_host/render_widget_host_view_guest.h +++ b/content/browser/renderer_host/render_widget_host_view_guest.h @@ -97,8 +97,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void Destroy() OVERRIDE; virtual void WillDestroyRenderWidget(RenderWidgetHost* rwh) {} virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE; diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h index cda36a8..3ac15af 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.h +++ b/content/browser/renderer_host/render_widget_host_view_mac.h @@ -255,8 +255,8 @@ class RenderWidgetHostViewMac : public RenderWidgetHostViewBase, const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void Destroy() OVERRIDE; virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE; virtual void SelectionChanged(const string16& text, diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm index d25339c..0a1aeaf 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -915,8 +915,8 @@ void RenderWidgetHostViewMac::DidUpdateBackingStore( } } -void RenderWidgetHostViewMac::RenderViewGone(base::TerminationStatus status, - int error_code) { +void RenderWidgetHostViewMac::RenderProcessGone(base::TerminationStatus status, + int error_code) { Destroy(); } diff --git a/content/browser/renderer_host/render_widget_host_view_win.cc b/content/browser/renderer_host/render_widget_host_view_win.cc index 7186313..1139ff6 100644 --- a/content/browser/renderer_host/render_widget_host_view_win.cc +++ b/content/browser/renderer_host/render_widget_host_view_win.cc @@ -802,8 +802,8 @@ void RenderWidgetHostViewWin::DidUpdateBackingStore( Redraw(); } -void RenderWidgetHostViewWin::RenderViewGone(base::TerminationStatus status, - int error_code) { +void RenderWidgetHostViewWin::RenderProcessGone(base::TerminationStatus status, + int error_code) { UpdateCursorIfOverSelf(); Destroy(); } diff --git a/content/browser/renderer_host/render_widget_host_view_win.h b/content/browser/renderer_host/render_widget_host_view_win.h index 2e900ae..c52cd4b 100644 --- a/content/browser/renderer_host/render_widget_host_view_win.h +++ b/content/browser/renderer_host/render_widget_host_view_win.h @@ -194,8 +194,8 @@ class RenderWidgetHostViewWin const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& copy_rects, const ui::LatencyInfo& latency_info) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual bool CanSubscribeFrame() const OVERRIDE; // called by WebContentsImpl before DestroyWindow diff --git a/content/browser/renderer_host/test_render_view_host.cc b/content/browser/renderer_host/test_render_view_host.cc index 09fb8bd..31507a9 100644 --- a/content/browser/renderer_host/test_render_view_host.cc +++ b/content/browser/renderer_host/test_render_view_host.cc @@ -107,8 +107,8 @@ bool TestRenderWidgetHostView::IsShowing() { return is_showing_; } -void TestRenderWidgetHostView::RenderViewGone(base::TerminationStatus status, - int error_code) { +void TestRenderWidgetHostView::RenderProcessGone(base::TerminationStatus status, + int error_code) { delete this; } diff --git a/content/browser/renderer_host/test_render_view_host.h b/content/browser/renderer_host/test_render_view_host.h index bdafb36..d8a3b7a 100644 --- a/content/browser/renderer_host/test_render_view_host.h +++ b/content/browser/renderer_host/test_render_view_host.h @@ -110,8 +110,8 @@ class TestRenderWidgetHostView : public RenderWidgetHostViewBase { const gfx::Vector2d& scroll_delta, const std::vector<gfx::Rect>& rects, const ui::LatencyInfo& latency_info) OVERRIDE {} - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) OVERRIDE; virtual void WillDestroyRenderWidget(RenderWidgetHost* rwh) { } virtual void Destroy() OVERRIDE; virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE {} diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc index 9e3acdb..ed674d5 100644 --- a/content/browser/web_contents/render_view_host_manager.cc +++ b/content/browser/web_contents/render_view_host_manager.cc @@ -736,12 +736,12 @@ void RenderViewHostManager::CommitPending() { render_view_host_->GetProcess()->RemovePendingView(); // If the view is gone, then this RenderViewHost died while it was hidden. - // We ignored the RenderViewGone call at the time, so we should send it now + // We ignored the RenderProcessGone call at the time, so we should send it now // to make sure the sad tab shows up, etc. if (render_view_host_->GetView()) render_view_host_->GetView()->Show(); else - delegate_->RenderViewGoneFromRenderManager(render_view_host_); + delegate_->RenderProcessGoneFromRenderManager(render_view_host_); // Hide the old view now that the new one is visible. if (old_render_view_host->GetView()) { diff --git a/content/browser/web_contents/render_view_host_manager.h b/content/browser/web_contents/render_view_host_manager.h index d653a74..78e3b38 100644 --- a/content/browser/web_contents/render_view_host_manager.h +++ b/content/browser/web_contents/render_view_host_manager.h @@ -61,7 +61,7 @@ class CONTENT_EXPORT RenderViewHostManager virtual void BeforeUnloadFiredFromRenderManager( bool proceed, const base::TimeTicks& proceed_time, bool* proceed_to_fire_unload) = 0; - virtual void RenderViewGoneFromRenderManager( + virtual void RenderProcessGoneFromRenderManager( RenderViewHost* render_view_host) = 0; virtual void UpdateRenderViewSizeForRenderManager() = 0; virtual void NotifySwappedFromRenderManager( diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc index 0bcd223..ea35c93 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc @@ -2884,7 +2884,7 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh, FOR_EACH_OBSERVER(WebContentsObserver, observers_, - RenderViewGone(GetCrashedStatus())); + RenderProcessGone(GetCrashedStatus())); } void WebContentsImpl::RenderViewDeleted(RenderViewHost* rvh) { @@ -3485,7 +3485,7 @@ void WebContentsImpl::BeforeUnloadFiredFromRenderManager( // Note: |this| might be deleted at this point. } -void WebContentsImpl::RenderViewGoneFromRenderManager( +void WebContentsImpl::RenderProcessGoneFromRenderManager( RenderViewHost* render_view_host) { DCHECK(crashed_status_ != base::TERMINATION_STATUS_STILL_RUNNING); RenderViewTerminated(render_view_host, crashed_status_, crashed_error_code_); diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h index 8f679dd..fdd333f 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h @@ -470,7 +470,7 @@ class CONTENT_EXPORT WebContentsImpl virtual void BeforeUnloadFiredFromRenderManager( bool proceed, const base::TimeTicks& proceed_time, bool* proceed_to_fire_unload) OVERRIDE; - virtual void RenderViewGoneFromRenderManager( + virtual void RenderProcessGoneFromRenderManager( RenderViewHost* render_view_host) OVERRIDE; virtual void UpdateRenderViewSizeForRenderManager() OVERRIDE; virtual void NotifySwappedFromRenderManager( diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc index f93e097..12b9365 100644 --- a/content/browser/web_contents/web_contents_impl_unittest.cc +++ b/content/browser/web_contents/web_contents_impl_unittest.cc @@ -1575,7 +1575,7 @@ TEST_F(WebContentsImplTest, ShowInterstitialCrashRendererThenGoBack) { // Crash the renderer test_rvh()->OnMessageReceived( - ViewHostMsg_RenderViewGone( + ViewHostMsg_RenderProcessGone( 0, base::TERMINATION_STATUS_PROCESS_CRASHED, -1)); // While the interstitial is showing, go back. @@ -1614,7 +1614,7 @@ TEST_F(WebContentsImplTest, ShowInterstitialCrashRendererThenNavigate) { // Crash the renderer test_rvh()->OnMessageReceived( - ViewHostMsg_RenderViewGone( + ViewHostMsg_RenderProcessGone( 0, base::TERMINATION_STATUS_PROCESS_CRASHED, -1)); interstitial->TestDidNavigate(2, interstitial_url); @@ -1666,7 +1666,7 @@ TEST_F(WebContentsImplTest, ShowInterstitialThenCloseAndShutdown) { // simulate quitting the browser. This goes through all processes and // tells them to destruct. rvh->OnMessageReceived( - ViewHostMsg_RenderViewGone(0, 0, 0)); + ViewHostMsg_RenderProcessGone(0, 0, 0)); RunAllPendingInMessageLoop(); EXPECT_TRUE(deleted); diff --git a/content/common/swapped_out_messages.cc b/content/common/swapped_out_messages.cc index 0a3e065..5048265 100644 --- a/content/common/swapped_out_messages.cc +++ b/content/common/swapped_out_messages.cc @@ -24,7 +24,7 @@ bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) { case ViewHostMsg_OpenURL::ID: case ViewHostMsg_Focus::ID: // Handled by RenderView. - case ViewHostMsg_RenderViewGone::ID: + case ViewHostMsg_RenderProcessGone::ID: case ViewHostMsg_ShouldClose_ACK::ID: case ViewHostMsg_SwapOut_ACK::ID: case ViewHostMsg_ClosePage_ACK::ID: diff --git a/content/common/view_messages.h b/content/common/view_messages.h index 6ebe1d8..3e4e81f 100644 --- a/content/common/view_messages.h +++ b/content/common/view_messages.h @@ -1408,7 +1408,7 @@ IPC_MESSAGE_ROUTED0(ViewHostMsg_RenderViewReady) // Indicates the renderer process is gone. This actually is sent by the // browser process to itself, but keeps the interface cleaner. -IPC_MESSAGE_ROUTED2(ViewHostMsg_RenderViewGone, +IPC_MESSAGE_ROUTED2(ViewHostMsg_RenderProcessGone, int, /* this really is base::TerminationStatus */ int /* exit_code */) diff --git a/content/port/browser/render_widget_host_view_port.h b/content/port/browser/render_widget_host_view_port.h index 6aa03de..29bc3ae 100644 --- a/content/port/browser/render_widget_host_view_port.h +++ b/content/port/browser/render_widget_host_view_port.h @@ -138,8 +138,8 @@ class CONTENT_EXPORT RenderWidgetHostViewPort : public RenderWidgetHostView, const ui::LatencyInfo& latency_info) = 0; // Notifies the View that the renderer has ceased to exist. - virtual void RenderViewGone(base::TerminationStatus status, - int error_code) = 0; + virtual void RenderProcessGone(base::TerminationStatus status, + int error_code) = 0; // Tells the View to destroy itself. virtual void Destroy() = 0; diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h index d7490e7..b6d2e9b 100644 --- a/content/public/browser/web_contents_observer.h +++ b/content/public/browser/web_contents_observer.h @@ -56,12 +56,12 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener, // just swapped out. virtual void RenderViewDeleted(RenderViewHost* render_view_host) {} - // This method is invoked when the current RenderView crashes. The WebContents - // continues to use the RenderViewHost, e.g. when the user reloads the current - // page. + // This method is invoked when the process for the current RenderView crashes. + // The WebContents continues to use the RenderViewHost, e.g. when the user + // reloads the current page. // When the RenderViewHost is deleted, the RenderViewDeleted method will be // invoked. - virtual void RenderViewGone(base::TerminationStatus status) {} + virtual void RenderProcessGone(base::TerminationStatus status) {} // This method is invoked after the WebContents decided which RenderViewHost // to use for the next navigation, but before the navigation starts. diff --git a/content/public/test/browser_test_utils.cc b/content/public/test/browser_test_utils.cc index bfa37ad..e64a7ab 100644 --- a/content/public/test/browser_test_utils.cc +++ b/content/public/test/browser_test_utils.cc @@ -58,7 +58,7 @@ class DOMOperationObserver : public NotificationObserver, } // Overridden from WebContentsObserver: - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE { + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE { message_loop_runner_->Quit(); } diff --git a/content/shell/webkit_test_controller.cc b/content/shell/webkit_test_controller.cc index 0058ce3..26b51b0 100644 --- a/content/shell/webkit_test_controller.cc +++ b/content/shell/webkit_test_controller.cc @@ -385,7 +385,7 @@ void WebKitTestController::RenderViewCreated(RenderViewHost* render_view_host) { SendTestConfiguration(); } -void WebKitTestController::RenderViewGone(base::TerminationStatus status) { +void WebKitTestController::RenderProcessGone(base::TerminationStatus status) { DCHECK(CalledOnValidThread()); if (current_pid_ != base::kNullProcessId) { printer_->AddErrorMessage(std::string("#CRASHED - renderer (pid ") + diff --git a/content/shell/webkit_test_controller.h b/content/shell/webkit_test_controller.h index 380f5e0..c87e157 100644 --- a/content/shell/webkit_test_controller.h +++ b/content/shell/webkit_test_controller.h @@ -131,7 +131,7 @@ class WebKitTestController : public base::NonThreadSafe, virtual void PluginCrashed(const base::FilePath& plugin_path, base::ProcessId plugin_pid) OVERRIDE; virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE; - virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE; + virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE; // NotificationObserver implementation. |