diff options
| author | thakis <thakis@chromium.org> | 2015-07-10 16:30:40 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-10 23:31:15 +0000 |
| commit | 5a503569600d998528568b06c297cbe2d0e9bcb4 (patch) | |
| tree | b9eb58762822c3fd717adc7ec62151890328e4c7 | |
| parent | 71232441f094202a478ee8380602ee045ec5403a (diff) | |
| download | chromium_src-5a503569600d998528568b06c297cbe2d0e9bcb4.zip chromium_src-5a503569600d998528568b06c297cbe2d0e9bcb4.tar.gz chromium_src-5a503569600d998528568b06c297cbe2d0e9bcb4.tar.bz2 | |
Revert of Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #1 id:1 of https://codereview.chromium.org/1228093005/)
Reason for revert:
might be better now?
Original issue's description:
> Revert of Clang on Windows: Remove -Wno-unused-variable. (patchset #3 id:40001 of https://codereview.chromium.org/1226573002/)
>
> Reason for revert:
> Broke Clang build on Windows according to http://crbug.com/505319#c30.
>
> Those warnings should be fixed before relanding.
>
> Original issue's description:
> > Clang on Windows: Remove -Wno-unused-variable.
> >
> > Unused variables are now errors. However, since lots of third-party code
> > has unused variables, added a blanket suppression to all third-party
> > code.
> >
> > BUG=505319
> >
> > Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
> > Cr-Commit-Position: refs/heads/master@{#338242}
>
> TBR=garykac@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=505319
>
> Committed: https://crrev.com/ff68a3ba6f2dc9b226047b3355c135f73352570e
> Cr-Commit-Position: refs/heads/master@{#338253}
TBR=garykac@chromium.org,mgiuca@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505319
Review URL: https://codereview.chromium.org/1232543005
Cr-Commit-Position: refs/heads/master@{#338395}
| -rw-r--r-- | build/common.gypi | 4 | ||||
| -rw-r--r-- | build/config/compiler/BUILD.gn | 5 | ||||
| -rw-r--r-- | remoting/remoting_host_win.gypi | 2 |
3 files changed, 9 insertions, 2 deletions
diff --git a/build/common.gypi b/build/common.gypi index a0ebbf3..84108fd 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -3111,6 +3111,9 @@ # TODO(mgiuca): Move this suppression into individual third-party # libraries as required. http://crbug.com/505301. '-Wno-overloaded-virtual', + # Lots of third-party libraries have unused variables. Instead of + # suppressing them individually, we just blanket suppress them here. + '-Wno-unused-variable', ], }, 'conditions': [ @@ -5733,7 +5736,6 @@ '-Wno-unknown-pragmas', # http://crbug.com/505314 '-Wno-unused-function', # http://crbug.com/505316 '-Wno-unused-value', # http://crbug.com/505318 - '-Wno-unused-variable', # http://crbug.com/505319 '-Wno-unused-local-typedef', # http://crbug.com/411648 ], }, diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index 2f9f558..6093518 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -806,7 +806,6 @@ if (is_win) { "-Wno-unknown-pragmas", # http://crbug.com/505314 "-Wno-unused-function", # http://crbug.com/505316 "-Wno-unused-value", # http://crbug.com/505318 - "-Wno-unused-variable", # http://crbug.com/505319 "-Wno-unused-local-typedef", # http://crbug.com/411648 ] } @@ -1003,6 +1002,10 @@ config("no_chromium_code") { # TODO(mgiuca): Move this suppression into individual third-party # libraries as required. http://crbug.com/505301. "-Wno-overloaded-virtual", + + # Lots of third-party libraries have unused variables. Instead of + # suppressing them individually, we just blanket suppress them here. + "-Wno-unused-variable", ] } diff --git a/remoting/remoting_host_win.gypi b/remoting/remoting_host_win.gypi index efe2df8..78952d5 100644 --- a/remoting/remoting_host_win.gypi +++ b/remoting/remoting_host_win.gypi @@ -96,6 +96,8 @@ # Source files generated by the MIDL compiler trigger warnings with # -Wincompatible-pointer-types enabled. '-Wno-incompatible-pointer-types', + # Generated code contains unused variables. + '-Wno-unused-variable', ], }, }, # end of target 'remoting_lib_ps' |