summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-22 18:56:15 +0000
committergroby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-22 18:56:15 +0000
commit5ca6ed115ae1effcad23b63ebb16b2ffb7afe25d (patch)
treed53ff709631813e3462fb364241080d61f34ed24
parentfd3238afbddfd8df99ebd807d9318fa454d26866 (diff)
downloadchromium_src-5ca6ed115ae1effcad23b63ebb16b2ffb7afe25d.zip
chromium_src-5ca6ed115ae1effcad23b63ebb16b2ffb7afe25d.tar.gz
chromium_src-5ca6ed115ae1effcad23b63ebb16b2ffb7afe25d.tar.bz2
Restrict throbber messages to SingleSuggestionView objects.
R=rsesek@chromium.org BUG=129176, 129082 TEST=Try to install the first item from suggestion list. Without this fix, that will crash. Review URL: https://chromiumcodereview.appspot.com/10417027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138305 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/ui/cocoa/web_intent_sheet_controller.mm15
1 files changed, 10 insertions, 5 deletions
diff --git a/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm b/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm
index de59640..c25b8ec 100644
--- a/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm
+++ b/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm
@@ -410,16 +410,21 @@ NSButton* CreateHyperlinkButton(NSString* title, const NSRect& frame) {
- (void)startThrobberForRow:(NSInteger)index {
for (SingleSuggestionView* row in [self subviews]) {
- [row setEnabled:NO];
- if ([row tag] == index)
- [row startThrobber];
+ if ([row isMemberOfClass:[SingleSuggestionView class]]) {
+ [row setEnabled:NO];
+ if ([row tag] == index) {
+ [row startThrobber];
+ }
+ }
}
}
- (void)stopThrobber {
for (SingleSuggestionView* row in [self subviews]) {
- [row stopThrobber];
- [row setEnabled:YES];
+ if ([row isMemberOfClass:[SingleSuggestionView class]]) {
+ [row stopThrobber];
+ [row setEnabled:YES];
+ }
}
}