diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-16 21:37:46 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-16 21:37:46 +0000 |
| commit | 604d8a062d36dadf511b5475e75e3369d0d3c5c2 (patch) | |
| tree | c672f033246db1605867793b0e4f9f89720294db | |
| parent | b2dce3b91c3ee17100c029241c0bb9c45ae71dc4 (diff) | |
| download | chromium_src-604d8a062d36dadf511b5475e75e3369d0d3c5c2.zip chromium_src-604d8a062d36dadf511b5475e75e3369d0d3c5c2.tar.gz chromium_src-604d8a062d36dadf511b5475e75e3369d0d3c5c2.tar.bz2 | |
Convert LogKeywords() into LogNumKeywords(). This avoids passing a const TemplateURLService*, which will be important once some of TemplateURLService's APIs become non-const.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9717001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127249 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/metrics/metrics_service.cc | 10 | ||||
| -rw-r--r-- | chrome/browser/metrics/metrics_service.h | 5 |
2 files changed, 6 insertions, 9 deletions
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc index b11a44b..fa74ce3 100644 --- a/chrome/browser/metrics/metrics_service.cc +++ b/chrome/browser/metrics/metrics_service.cc @@ -575,7 +575,8 @@ void MetricsService::Observe(int type, break; case chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED: - LogKeywords(content::Source<TemplateURLService>(source).ptr()); + LogKeywordCount(content::Source<TemplateURLService>( + source)->GetTemplateURLs().size()); break; case chrome::NOTIFICATION_OMNIBOX_OPENED_URL: { @@ -1532,13 +1533,10 @@ void MetricsService::LogBookmarks(BookmarkModel* model) { ScheduleNextStateSave(); } -void MetricsService::LogKeywords(const TemplateURLService* url_model) { - DCHECK(url_model); - +void MetricsService::LogKeywordCount(size_t keyword_count) { PrefService* pref = g_browser_process->local_state(); DCHECK(pref); - pref->SetInteger(prefs::kNumKeywords, - static_cast<int>(url_model->GetTemplateURLs().size())); + pref->SetInteger(prefs::kNumKeywords, static_cast<int>(keyword_count)); ScheduleNextStateSave(); } diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h index 4761f5d..ff4df36 100644 --- a/chrome/browser/metrics/metrics_service.h +++ b/chrome/browser/metrics/metrics_service.h @@ -296,9 +296,8 @@ class MetricsService : public content::NotificationObserver, const content::NotificationSource& source, const content::NotificationDetails& details); - // Logs keywords specific metrics. Keyword metrics are recorded in the - // profile specific metrics. - void LogKeywords(const TemplateURLService* url_model); + // Logs the number of keywords. + void LogKeywordCount(size_t keyword_count); // Saves plugin-related updates from the in-object buffer to Local State // for retrieval next time we send a Profile log (generally next launch). |