diff options
author | navabi@google.com <navabi@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-12 20:18:54 +0000 |
---|---|---|
committer | navabi@google.com <navabi@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-12 20:18:54 +0000 |
commit | 6135320d0331991a01834cffb3ecdfeb154b35d3 (patch) | |
tree | 024c170a1fdf1a0db9e7811f7dbe2894f52edbac | |
parent | fcbccc1ca42d3dae1be25030f578e43ec002d6b1 (diff) | |
download | chromium_src-6135320d0331991a01834cffb3ecdfeb154b35d3.zip chromium_src-6135320d0331991a01834cffb3ecdfeb154b35d3.tar.gz chromium_src-6135320d0331991a01834cffb3ecdfeb154b35d3.tar.bz2 |
Do not send alerts on slow install and make the step fail on < 15% battery.
The slow install errors were happening too often causing too many alert emails.
A few bots have had device battery problems. E.g.
http://build.chromium.org/p/chromium.perf/builders/Android%20GN
The device status step will fail when charge is < 15%, allowing devices to
recharge before running more tests on them, and thus avoiding devices turning
off and needing someone to go to the clab to restart the devices.
TBR=cmp@chromium.org
BUG=224004
Review URL: https://chromiumcodereview.appspot.com/16747007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205912 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-x | build/android/device_status_check.py | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/build/android/device_status_check.py b/build/android/device_status_check.py index 0fe0b3a..e1f8e448 100755 --- a/build/android/device_status_check.py +++ b/build/android/device_status_check.py @@ -70,21 +70,23 @@ def DeviceInfo(serial): ''] errors = [] - if battery_level < 5: + if battery_level < 15: errors += ['Device critically low in battery. Do not use for testing.'] if not setup_wizard_disabled and device_build_type != 'user': errors += ['Setup wizard not disabled. Was it provisioned correctly?'] if device_product_name == 'mantaray' and ac_power != 'true': errors += ['Mantaray device not connected to AC power.'] - if install_speed < 800: - errors += ['Device install speed too low. Do not use for testing.'] + # TODO(navabi): Insert warning once we have a better handle of what install + # speeds to expect. The following lines were causing too many alerts. + # if install_speed < 500: + # errors += ['Device install speed too low. Do not use for testing.'] # TODO(navabi): Determine if device status check step should fail on slow # install speed. The original CL caused the step to fail but was reverted # because it caused too many early failures. Determine if it was just flake. # Also, do not fail on 'Unknown' caused by offline device, because other # devices can still be used for tests. - fail_step = (battery_level == 'Unknown' or battery_level >= 5) + fail_step = (battery_level == 'Unknown' or battery_level >= 15) return device_type, device_build, '\n'.join(report), errors, fail_step |