diff options
author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-17 03:46:49 +0000 |
---|---|---|
committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-17 03:46:49 +0000 |
commit | 639fdc443d6e231c831e264dc7242305299f1451 (patch) | |
tree | aff2fc2b31f528e5ce4e71a002050eef4c877cb5 | |
parent | 1914193f05458d7645cefbe8b96303e62706de0f (diff) | |
download | chromium_src-639fdc443d6e231c831e264dc7242305299f1451.zip chromium_src-639fdc443d6e231c831e264dc7242305299f1451.tar.gz chromium_src-639fdc443d6e231c831e264dc7242305299f1451.tar.bz2 |
scythe: Delete dead code in views code.
BUG=none
Review URL: https://codereview.chromium.org/235613003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264390 0039d316-1c4b-4281-b951-d872f2087c98
36 files changed, 22 insertions, 111 deletions
diff --git a/chrome/browser/chromeos/login/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/simple_web_view_dialog.cc index 607481b..1e92bc1 100644 --- a/chrome/browser/chromeos/login/simple_web_view_dialog.cc +++ b/chrome/browser/chromeos/login/simple_web_view_dialog.cc @@ -185,7 +185,7 @@ void SimpleWebViewDialog::Init() { this, true); // Reload button. - reload_ = new ReloadButton(location_bar_, command_updater_.get()); + reload_ = new ReloadButton(command_updater_.get()); reload_->set_triggerable_event_flags(ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON); reload_->set_tag(IDC_RELOAD); diff --git a/chrome/browser/ui/libgtk2ui/gtk2_ui.h b/chrome/browser/ui/libgtk2ui/gtk2_ui.h index 0e78131..c27bcc5 100644 --- a/chrome/browser/ui/libgtk2ui/gtk2_ui.h +++ b/chrome/browser/ui/libgtk2ui/gtk2_ui.h @@ -256,9 +256,6 @@ class Gtk2UI : public views::LinuxUI { // Image cache of lazily created images. mutable ImageCache gtk_images_; - // Whether to use the Gtk2 version of the native theme. - bool use_gtk_; - DISALLOW_COPY_AND_ASSIGN(Gtk2UI); }; diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.h b/chrome/browser/ui/views/autofill/autofill_dialog_views.h index d705ee1..e84a880 100644 --- a/chrome/browser/ui/views/autofill/autofill_dialog_views.h +++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.h @@ -375,8 +375,7 @@ class AutofillDialogViews : public AutofillDialogView, DISALLOW_COPY_AND_ASSIGN(DetailsContainerView); }; - // A view that contains a suggestion (such as a known address) and a link to - // edit the suggestion. + // A view that contains a suggestion (such as a known address). class SuggestionView : public views::View { public: explicit SuggestionView(AutofillDialogViews* autofill_dialog); @@ -429,8 +428,6 @@ class AutofillDialogViews : public AutofillDialogView, views::ImageView* icon_; // The input set by ShowTextfield. ExpandingTextfield* textfield_; - // An "Edit" link that flips to editable inputs rather than suggestion text. - views::Link* edit_link_; DISALLOW_COPY_AND_ASSIGN(SuggestionView); }; diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc index 2a1567c..28862bd 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc @@ -46,7 +46,6 @@ BookmarkContextMenu::BookmarkContextMenu( parent_widget_(parent_widget), menu_(new views::MenuItemView(this)), menu_runner_(new views::MenuRunner(menu_)), - parent_node_(parent), observer_(NULL), close_on_remove_(close_on_remove) { diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h index eba85f6..7fd36ee 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h +++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h @@ -82,9 +82,6 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate, // Responsible for running the menu. scoped_ptr<views::MenuRunner> menu_runner_; - // The node we're showing the menu for. - const BookmarkNode* parent_node_; - BookmarkContextMenuObserver* observer_; // Should the menu close when a node is removed. diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc index e7decf8a..8380bc5 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc @@ -48,7 +48,6 @@ BookmarkMenuDelegate::BookmarkMenuDelegate(Browser* browser, page_navigator_(navigator), parent_(parent), menu_(NULL), - for_drop_(false), parent_menu_item_(NULL), next_menu_id_(first_menu_id), min_menu_id_(first_menu_id), diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h index cf8e2e8..b43db05 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h +++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h @@ -183,9 +183,6 @@ class BookmarkMenuDelegate : public BaseBookmarkModelObserver, // Used when a context menu is shown. scoped_ptr<BookmarkContextMenu> context_menu_; - // Is the menu being shown for a drop? - bool for_drop_; - // If non-NULL this is the |parent| passed to Init and is NOT owned by us. views::MenuItemView* parent_menu_item_; diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc index 521ebe3..338f94b 100644 --- a/chrome/browser/ui/views/create_application_shortcut_view.cc +++ b/chrome/browser/ui/views/create_application_shortcut_view.cc @@ -521,7 +521,6 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView( const extensions::Extension* app, const base::Closure& close_callback) : CreateApplicationShortcutView(profile), - app_(app), close_callback_(close_callback), weak_ptr_factory_(this) { // Required by InitControls(). diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h index 86763a8..12aa0d7 100644 --- a/chrome/browser/ui/views/create_application_shortcut_view.h +++ b/chrome/browser/ui/views/create_application_shortcut_view.h @@ -135,7 +135,6 @@ class CreateChromeApplicationShortcutView void OnShortcutInfoLoaded( const web_app::ShortcutInfo& shortcut_info); - const extensions::Extension* app_; base::Closure close_callback_; base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_; diff --git a/chrome/browser/ui/views/crypto_module_password_dialog_view.h b/chrome/browser/ui/views/crypto_module_password_dialog_view.h index 9a070cf..dbddff1 100644 --- a/chrome/browser/ui/views/crypto_module_password_dialog_view.h +++ b/chrome/browser/ui/views/crypto_module_password_dialog_view.h @@ -55,7 +55,6 @@ class CryptoModulePasswordDialogView : public views::DialogDelegateView, const std::string& slot_name, CryptoModulePasswordReason reason); - views::Label* title_label_; views::Label* reason_label_; views::Label* password_label_; views::Textfield* password_entry_; diff --git a/chrome/browser/ui/views/edit_search_engine_dialog.h b/chrome/browser/ui/views/edit_search_engine_dialog.h index a76e22b..f018254 100644 --- a/chrome/browser/ui/views/edit_search_engine_dialog.h +++ b/chrome/browser/ui/views/edit_search_engine_dialog.h @@ -71,9 +71,6 @@ class EditSearchEngineDialog : public views::TextfieldController, bool is_valid, int invalid_message_id); - // View containing the buttons, text fields ... - views::View* view_; - // Text fields. views::Textfield* title_tf_; views::Textfield* keyword_tf_; diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc index 1ed806f..c28ba8d 100644 --- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc +++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc @@ -90,11 +90,9 @@ class InstalledBubbleContent : public views::View, InstalledBubbleContent(Browser* browser, const Extension* extension, ExtensionInstalledBubble::BubbleType type, - const SkBitmap* icon, - ExtensionInstalledBubbleView* bubble) + const SkBitmap* icon) : browser_(browser), extension_id_(extension->id()), - bubble_(bubble), type_(type), flavors_(NONE), height_of_signin_promo_(0u), @@ -482,9 +480,6 @@ class InstalledBubbleContent : public views::View, // The id of the extension just installed. const std::string extension_id_; - // The ExtensionInstalledBubbleView showing us. - ExtensionInstalledBubbleView* bubble_; - // The string that contains the link text at the beginning of the sign-in // promo text. base::string16 signin_promo_link_text_; @@ -577,7 +572,7 @@ bool ExtensionInstalledBubbleView::MaybeShowNow() { SetLayoutManager(new views::FillLayout()); AddChildView(new InstalledBubbleContent( bubble_.browser(), bubble_.extension(), bubble_.type(), - &bubble_.icon(), this)); + &bubble_.icon())); views::BubbleDelegateView::CreateBubble(this)->Show(); diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index da32578..ae5737e 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -2493,7 +2493,6 @@ void BrowserView::ShowPasswordGenerationBubble( web_contents->GetRenderViewHost(), ChromePasswordManagerClient::GetManagerFromWebContents(web_contents), password_generator, - browser_.get(), GetWidget()->GetThemeProvider()); views::BubbleDelegateView::CreateBubble(bubble); diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc index 54801db..7fc6ef6 100644 --- a/chrome/browser/ui/views/location_bar/location_bar_view.cc +++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc @@ -384,7 +384,7 @@ void LocationBarView::Init() { zoom_view_->set_id(VIEW_ID_ZOOM_BUTTON); AddChildView(zoom_view_); - open_pdf_in_reader_view_ = new OpenPDFInReaderView(this); + open_pdf_in_reader_view_ = new OpenPDFInReaderView(); AddChildView(open_pdf_in_reader_view_); manage_passwords_icon_view_ = new ManagePasswordsIconView(delegate_); diff --git a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc index c003bb7..6bc9cf3 100644 --- a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc +++ b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc @@ -14,10 +14,7 @@ #include "ui/base/resource/resource_bundle.h" #include "ui/views/widget/widget.h" -OpenPDFInReaderView::OpenPDFInReaderView(LocationBarView* location_bar_view) - : location_bar_view_(location_bar_view), - bubble_(NULL), - model_(NULL) { +OpenPDFInReaderView::OpenPDFInReaderView() : bubble_(NULL), model_(NULL) { SetAccessibilityFocusable(true); SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed( IDR_OMNIBOX_PDF_ICON)); diff --git a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h index bbe9765..3bb25b0 100644 --- a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h +++ b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h @@ -8,7 +8,6 @@ #include "ui/views/controls/image_view.h" #include "ui/views/widget/widget_observer.h" -class LocationBarView; class OpenPDFInReaderBubbleView; class OpenPDFInReaderPromptDelegate; @@ -20,7 +19,7 @@ class WebContents; class OpenPDFInReaderView : public views::ImageView, public views::WidgetObserver { public: - explicit OpenPDFInReaderView(LocationBarView* location_bar_view); + OpenPDFInReaderView(); virtual ~OpenPDFInReaderView(); void Update(content::WebContents* web_contents); @@ -37,9 +36,6 @@ class OpenPDFInReaderView : public views::ImageView, // views::WidgetObserver: virtual void OnWidgetDestroying(views::Widget* widget) OVERRIDE; - // The LocationBarView hosting this view. - LocationBarView* location_bar_view_; - OpenPDFInReaderBubbleView* bubble_; // Weak pointer; owned by the PDFTabHelper of the currently active tab. diff --git a/chrome/browser/ui/views/message_center/web_notification_tray.cc b/chrome/browser/ui/views/message_center/web_notification_tray.cc index 5316f06..3db0229 100644 --- a/chrome/browser/ui/views/message_center/web_notification_tray.cc +++ b/chrome/browser/ui/views/message_center/web_notification_tray.cc @@ -128,7 +128,6 @@ WebNotificationTray::WebNotificationTray() : message_center_delegate_(NULL), status_icon_(NULL), status_icon_menu_(NULL), - message_center_visible_(false), should_update_tray_content_(true) { message_center_tray_.reset( new MessageCenterTray(this, g_browser_process->message_center())); diff --git a/chrome/browser/ui/views/message_center/web_notification_tray.h b/chrome/browser/ui/views/message_center/web_notification_tray.h index 34f0193..24dfe52 100644 --- a/chrome/browser/ui/views/message_center/web_notification_tray.h +++ b/chrome/browser/ui/views/message_center/web_notification_tray.h @@ -100,7 +100,6 @@ class WebNotificationTray : public message_center::MessageCenterTrayDelegate, StatusIcon* status_icon_; StatusIconMenuModel* status_icon_menu_; - bool message_center_visible_; scoped_ptr<MessageCenterTray> message_center_tray_; gfx::Point mouse_click_point_; diff --git a/chrome/browser/ui/views/password_generation_bubble_view.cc b/chrome/browser/ui/views/password_generation_bubble_view.cc index 73b623f..d86d3df 100644 --- a/chrome/browser/ui/views/password_generation_bubble_view.cc +++ b/chrome/browser/ui/views/password_generation_bubble_view.cc @@ -12,7 +12,6 @@ #include "components/autofill/core/browser/password_generator.h" #include "components/autofill/core/common/password_generation_util.h" #include "components/password_manager/core/browser/password_manager.h" -#include "content/public/browser/page_navigator.h" #include "content/public/browser/render_view_host.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" @@ -123,7 +122,6 @@ PasswordGenerationBubbleView::PasswordGenerationBubbleView( content::RenderViewHost* render_view_host, password_manager::PasswordManager* password_manager, autofill::PasswordGenerator* password_generator, - content::PageNavigator* navigator, ui::ThemeProvider* theme_provider) : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT), title_label_(NULL), @@ -136,7 +134,6 @@ PasswordGenerationBubbleView::PasswordGenerationBubbleView( render_view_host_(render_view_host), password_manager_(password_manager), password_generator_(password_generator), - navigator_(navigator), theme_provider_(theme_provider) {} PasswordGenerationBubbleView::~PasswordGenerationBubbleView() {} diff --git a/chrome/browser/ui/views/password_generation_bubble_view.h b/chrome/browser/ui/views/password_generation_bubble_view.h index dcfdd75..32e908f 100644 --- a/chrome/browser/ui/views/password_generation_bubble_view.h +++ b/chrome/browser/ui/views/password_generation_bubble_view.h @@ -19,7 +19,6 @@ class PasswordGenerator; } namespace content { -class PageNavigator; class RenderViewHost; } @@ -48,7 +47,6 @@ class PasswordGenerationBubbleView : public views::BubbleDelegateView, content::RenderViewHost* render_view_host, password_manager::PasswordManager* password_manager, autofill::PasswordGenerator* password_generator, - content::PageNavigator* navigator, ui::ThemeProvider* theme_provider); virtual ~PasswordGenerationBubbleView(); @@ -97,10 +95,6 @@ class PasswordGenerationBubbleView : public views::BubbleDelegateView, // Object to generate passwords. The class won't take the ownership of it. autofill::PasswordGenerator* password_generator_; - // An object used to handle page loads that originate from link clicks - // within this UI. - content::PageNavigator* navigator_; - // Theme provider used to draw the regenerate button. ui::ThemeProvider* theme_provider_; diff --git a/chrome/browser/ui/views/signed_certificate_timestamps_views.cc b/chrome/browser/ui/views/signed_certificate_timestamps_views.cc index 12c7708..89c5598 100644 --- a/chrome/browser/ui/views/signed_certificate_timestamps_views.cc +++ b/chrome/browser/ui/views/signed_certificate_timestamps_views.cc @@ -103,7 +103,8 @@ base::string16 SCTListModel::GetItemAt(int index) { SignedCertificateTimestampsViews::SignedCertificateTimestampsViews( content::WebContents* web_contents, const net::SignedCertificateTimestampAndStatusList& sct_list) - : web_contents_(web_contents), sct_info_view_(NULL), sct_list_(sct_list) { + : sct_info_view_(NULL), + sct_list_(sct_list) { WebContentsModalDialogManager* web_contents_modal_dialog_manager = WebContentsModalDialogManager::FromWebContents(web_contents); WebContentsModalDialogManagerDelegate* modal_delegate = diff --git a/chrome/browser/ui/views/signed_certificate_timestamps_views.h b/chrome/browser/ui/views/signed_certificate_timestamps_views.h index 9001558..ea2d77b 100644 --- a/chrome/browser/ui/views/signed_certificate_timestamps_views.h +++ b/chrome/browser/ui/views/signed_certificate_timestamps_views.h @@ -57,8 +57,6 @@ class SignedCertificateTimestampsViews : public views::DialogDelegateView, const content::NotificationSource& source, const content::NotificationDetails& details) OVERRIDE; - content::WebContents* web_contents_; - SignedCertificateTimestampInfoView* sct_info_view_; scoped_ptr<SCTListModel> sct_list_model_; diff --git a/chrome/browser/ui/views/status_bubble_views.cc b/chrome/browser/ui/views/status_bubble_views.cc index c2717e6..46c1cfb 100644 --- a/chrome/browser/ui/views/status_bubble_views.cc +++ b/chrome/browser/ui/views/status_bubble_views.cc @@ -128,8 +128,7 @@ class StatusBubbleViews::StatusView : public views::View { STYLE_STANDARD_RIGHT }; - StatusView(StatusBubble* status_bubble, - views::Widget* popup, + StatusView(views::Widget* popup, ui::ThemeProvider* theme_provider); virtual ~StatusView(); @@ -183,9 +182,6 @@ class StatusBubbleViews::StatusView : public views::View { scoped_ptr<StatusViewAnimation> animation_; - // Manager, owns us. - StatusBubble* status_bubble_; - // Handle to the widget that contains us. views::Widget* popup_; @@ -198,14 +194,12 @@ class StatusBubbleViews::StatusView : public views::View { DISALLOW_COPY_AND_ASSIGN(StatusView); }; -StatusBubbleViews::StatusView::StatusView(StatusBubble* status_bubble, - views::Widget* popup, +StatusBubbleViews::StatusView::StatusView(views::Widget* popup, ui::ThemeProvider* theme_provider) : state_(BUBBLE_HIDDEN), style_(STYLE_STANDARD), timer_factory_(this), animation_(new StatusViewAnimation(this, 0, 0)), - status_bubble_(status_bubble), popup_(popup), theme_service_(theme_provider) { } @@ -589,7 +583,6 @@ const int StatusBubbleViews::kShadowThickness = 1; StatusBubbleViews::StatusBubbleViews(views::View* base_view) : contains_mouse_(false), offset_(0), - opacity_(0), base_view_(base_view), view_(NULL), download_shelf_is_visible_(false), @@ -609,7 +602,7 @@ void StatusBubbleViews::Init() { popup_.reset(new views::Widget); views::Widget* frame = base_view_->GetWidget(); if (!view_) - view_ = new StatusView(this, popup_.get(), frame->GetThemeProvider()); + view_ = new StatusView(popup_.get(), frame->GetThemeProvider()); if (!expand_view_.get()) expand_view_.reset(new StatusViewExpander(this, view_)); views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP); diff --git a/chrome/browser/ui/views/status_bubble_views.h b/chrome/browser/ui/views/status_bubble_views.h index c0e835b..db9548a 100644 --- a/chrome/browser/ui/views/status_bubble_views.h +++ b/chrome/browser/ui/views/status_bubble_views.h @@ -130,7 +130,6 @@ class StatusBubbleViews : public StatusBubble { // We use a HWND for the popup so that it may float above any HWNDs in our // UI (the location bar, for example). scoped_ptr<views::Widget> popup_; - double opacity_; views::View* base_view_; StatusView* view_; diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc index 2fce6a8..07f6ec9e 100644 --- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc +++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc @@ -52,11 +52,9 @@ void ShowProfileSigninConfirmationDialog( ProfileSigninConfirmationDialogViews::ProfileSigninConfirmationDialogViews( Browser* browser, - Profile* profile, const std::string& username, ui::ProfileSigninConfirmationDelegate* delegate) : browser_(browser), - profile_(profile), username_(username), delegate_(delegate), prompt_for_new_profile_(true), @@ -73,7 +71,7 @@ void ProfileSigninConfirmationDialogViews::ShowDialog( ui::ProfileSigninConfirmationDelegate* delegate) { ProfileSigninConfirmationDialogViews* dialog = new ProfileSigninConfirmationDialogViews( - browser, profile, username, delegate); + browser, username, delegate); ui::CheckShouldPromptForNewProfile( profile, // This callback is guaranteed to be invoked, and once it is, the dialog diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h index a00335d..31e263a 100644 --- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h +++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h @@ -39,7 +39,6 @@ class ProfileSigninConfirmationDialogViews : public views::DialogDelegateView, private: ProfileSigninConfirmationDialogViews( Browser* browser, - Profile* profile, const std::string& username, ui::ProfileSigninConfirmationDelegate* delegate); virtual ~ProfileSigninConfirmationDialogViews(); @@ -75,9 +74,6 @@ class ProfileSigninConfirmationDialogViews : public views::DialogDelegateView, // Weak ptr to parent view. Browser* browser_; - // The profile being signed in. - Profile* profile_; - // The GAIA username being signed in. std::string username_; diff --git a/chrome/browser/ui/views/toolbar/reload_button.cc b/chrome/browser/ui/views/toolbar/reload_button.cc index aa09514..7adefcb 100644 --- a/chrome/browser/ui/views/toolbar/reload_button.cc +++ b/chrome/browser/ui/views/toolbar/reload_button.cc @@ -9,7 +9,6 @@ #include "chrome/browser/command_updater.h" #include "chrome/browser/search/search.h" #include "chrome/browser/ui/search/search_model.h" -#include "chrome/browser/ui/views/location_bar/location_bar_view.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -37,10 +36,8 @@ const int kReloadMenuItems[] = { // static const char ReloadButton::kViewClassName[] = "ReloadButton"; -ReloadButton::ReloadButton(LocationBarView* location_bar, - CommandUpdater* command_updater) +ReloadButton::ReloadButton(CommandUpdater* command_updater) : ToolbarButton(this, CreateMenuModel()), - location_bar_(location_bar), command_updater_(command_updater), intended_mode_(MODE_RELOAD), visible_mode_(MODE_RELOAD), diff --git a/chrome/browser/ui/views/toolbar/reload_button.h b/chrome/browser/ui/views/toolbar/reload_button.h index f3d1f5d..5cbdf42 100644 --- a/chrome/browser/ui/views/toolbar/reload_button.h +++ b/chrome/browser/ui/views/toolbar/reload_button.h @@ -13,7 +13,6 @@ #include "ui/views/controls/button/button.h" class CommandUpdater; -class LocationBarView; //////////////////////////////////////////////////////////////////////////////// // @@ -35,8 +34,7 @@ class ReloadButton : public ToolbarButton, // The button's class name. static const char kViewClassName[]; - ReloadButton(LocationBarView* location_bar, - CommandUpdater* command_updater); + explicit ReloadButton(CommandUpdater* command_updater); virtual ~ReloadButton(); // Ask for a specified button state. If |force| is true this will be applied @@ -84,8 +82,7 @@ class ReloadButton : public ToolbarButton, base::OneShotTimer<ReloadButton> double_click_timer_; base::OneShotTimer<ReloadButton> stop_to_reload_timer_; - // These may be NULL when testing. - LocationBarView* location_bar_; + // This may be NULL when testing. CommandUpdater* command_updater_; // The mode we should be in assuming no timers are running. diff --git a/chrome/browser/ui/views/toolbar/reload_button_unittest.cc b/chrome/browser/ui/views/toolbar/reload_button_unittest.cc index 6d8e257..3355ea6 100644 --- a/chrome/browser/ui/views/toolbar/reload_button_unittest.cc +++ b/chrome/browser/ui/views/toolbar/reload_button_unittest.cc @@ -29,7 +29,7 @@ class ReloadButtonTest : public testing::Test { ReloadButton reload_; }; -ReloadButtonTest::ReloadButtonTest() : reload_(NULL, NULL) { +ReloadButtonTest::ReloadButtonTest() : reload_(NULL) { // Set the timer delays to 0 so that timers will fire as soon as we tell the // message loop to run pending tasks. reload_.double_click_timer_delay_ = base::TimeDelta(); diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc index 4556ad0..a9229ec 100644 --- a/chrome/browser/ui/views/toolbar/toolbar_view.cc +++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc @@ -215,14 +215,12 @@ void ToolbarView::Init() { forward_->set_id(VIEW_ID_FORWARD_BUTTON); forward_->Init(); - // Have to create this before |reload_| as |reload_|'s constructor needs it. location_bar_ = new LocationBarView( browser_, browser_->profile(), browser_->command_controller()->command_updater(), this, display_mode_ == DISPLAYMODE_LOCATION); - reload_ = new ReloadButton(location_bar_, - browser_->command_controller()->command_updater()); + reload_ = new ReloadButton(browser_->command_controller()->command_updater()); reload_->set_triggerable_event_flags( ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON); reload_->set_tag(IDC_RELOAD); diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h index 0142889e..8bfd4a2 100644 --- a/ui/views/bubble/bubble_delegate.h +++ b/ui/views/bubble/bubble_delegate.h @@ -184,9 +184,6 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView, // Insets applied to the |anchor_view_| bounds. gfx::Insets anchor_view_insets_; - // The widget hosting the border for this bubble (non-Aura Windows only). - Widget* border_widget_; - // If true, the bubble does not take focus on display; default is false. bool use_focusless_; diff --git a/ui/views/controls/tree/tree_view.cc b/ui/views/controls/tree/tree_view.cc index bf75a65..d5a3911 100644 --- a/ui/views/controls/tree/tree_view.cc +++ b/ui/views/controls/tree/tree_view.cc @@ -79,7 +79,6 @@ TreeView::TreeView() editable_(true), controller_(NULL), root_shown_(true), - has_custom_icons_(false), row_height_(font_list_.GetHeight() + kTextVerticalPadding * 2) { SetFocusable(true); closed_icon_ = *ui::ResourceBundle::GetSharedInstance().GetImageNamed( diff --git a/ui/views/controls/tree/tree_view.h b/ui/views/controls/tree/tree_view.h index 097700a..24780fc 100644 --- a/ui/views/controls/tree/tree_view.h +++ b/ui/views/controls/tree/tree_view.h @@ -374,9 +374,6 @@ class VIEWS_EXPORT TreeView : public ui::TreeModelObserver, // Whether or not the root is shown in the tree. bool root_shown_; - // Did the model return a non-empty set of icons from GetIcons? - bool has_custom_icons_; - // Cached preferred size. gfx::Size preferred_size_; diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc index a1f41c1..688892c 100644 --- a/ui/views/controls/webview/web_dialog_view.cc +++ b/ui/views/controls/webview/web_dialog_view.cc @@ -42,7 +42,6 @@ WebDialogView::WebDialogView( WebContentsHandler* handler) : ClientView(NULL, NULL), WebDialogWebContentsDelegate(context, handler), - initialized_(false), delegate_(delegate), web_view_(new views::WebView(context)), is_attempting_close_dialog_(false), diff --git a/ui/views/controls/webview/web_dialog_view.h b/ui/views/controls/webview/web_dialog_view.h index 902aa32..b138abd 100644 --- a/ui/views/controls/webview/web_dialog_view.h +++ b/ui/views/controls/webview/web_dialog_view.h @@ -122,11 +122,6 @@ class WEBVIEW_EXPORT WebDialogView : public views::ClientView, // Initializes the contents of the dialog. void InitDialog(); - // Whether the view is initialized. That is, dialog accelerators is registered - // and FreezeUpdates property is set to prevent WM from showing the window - // until the property is removed. - bool initialized_; - // This view is a delegate to the HTML content since it needs to get notified // about when the dialog is closing. For all other actions (besides dialog // closing) we delegate to the creator of this view, which we keep track of diff --git a/ui/views/layout/grid_layout.cc b/ui/views/layout/grid_layout.cc index 9466c51..e28a1b7 100644 --- a/ui/views/layout/grid_layout.cc +++ b/ui/views/layout/grid_layout.cc @@ -162,7 +162,6 @@ class Column : public LayoutElement { GridLayout::SizeType size_type, int fixed_width, int min_width, - size_t index, bool is_padding) : LayoutElement(resize_percent), h_align_(h_align), @@ -171,7 +170,6 @@ class Column : public LayoutElement { same_size_column_(-1), fixed_width_(fixed_width), min_width_(min_width), - index_(index), is_padding_(is_padding), master_column_(NULL) {} @@ -201,9 +199,6 @@ class Column : public LayoutElement { const int fixed_width_; const int min_width_; - // Index of this column in the ColumnSet. - const size_t index_; - const bool is_padding_; // If multiple columns have their sizes linked, one is the @@ -264,10 +259,8 @@ void Column::AdjustSize(int size) { class Row : public LayoutElement { public: - Row(bool fixed_height, int height, float resize_percent, - ColumnSet* column_set) + Row(int height, float resize_percent, ColumnSet* column_set) : LayoutElement(resize_percent), - fixed_height_(fixed_height), height_(height), column_set_(column_set), max_ascent_(0), @@ -301,7 +294,6 @@ class Row : public LayoutElement { } private: - const bool fixed_height_; const int height_; // The column set used for this row; null for padding rows. ColumnSet* column_set_; @@ -422,8 +414,7 @@ void ColumnSet::AddColumn(GridLayout::Alignment h_align, int min_width, bool is_padding) { Column* column = new Column(h_align, v_align, resize_percent, size_type, - fixed_width, min_width, columns_.size(), - is_padding); + fixed_width, min_width, is_padding); columns_.push_back(column); } @@ -718,11 +709,11 @@ void GridLayout::StartRowWithPadding(float vertical_resize, int column_set_id, void GridLayout::StartRow(float vertical_resize, int column_set_id) { ColumnSet* column_set = GetColumnSet(column_set_id); DCHECK(column_set); - AddRow(new Row(false, 0, vertical_resize, column_set)); + AddRow(new Row(0, vertical_resize, column_set)); } void GridLayout::AddPaddingRow(float vertical_resize, int pixel_count) { - AddRow(new Row(true, pixel_count, vertical_resize, NULL)); + AddRow(new Row(pixel_count, vertical_resize, NULL)); } void GridLayout::SkipColumns(int col_count) { |