diff options
| author | rtenneti <rtenneti@chromium.org> | 2015-05-12 12:27:55 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-12 19:29:08 +0000 |
| commit | 6568ac2e2befdd828e4c95dd70bee14673c9e6fd (patch) | |
| tree | 26de51b22808a35dc8792a11498951182f3a7c61 | |
| parent | 9ce5394bf20f18b1413a214bef4548055c3bcb83 (diff) | |
| download | chromium_src-6568ac2e2befdd828e4c95dd70bee14673c9e6fd.zip chromium_src-6568ac2e2befdd828e4c95dd70bee14673c9e6fd.tar.gz chromium_src-6568ac2e2befdd828e4c95dd70bee14673c9e6fd.tar.bz2 | |
ThreadWatcher - enable it in CANARY channel and updated the comments to
explain why it is disabled in STABLE and UNKNOWN channels.
R=asvitkine@chromium.org
BUG=426203
Review URL: https://codereview.chromium.org/1130723005
Cr-Commit-Position: refs/heads/master@{#329458}
| -rw-r--r-- | chrome/browser/metrics/thread_watcher.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc index 10228e7..f58ce29 100644 --- a/chrome/browser/metrics/thread_watcher.cc +++ b/chrome/browser/metrics/thread_watcher.cc @@ -539,10 +539,12 @@ void ThreadWatcherList::InitializeAndStartWatching( ThreadWatcherList* thread_watcher_list = new ThreadWatcherList(); CHECK(thread_watcher_list); - // Disable ThreadWatcher in Canary channel. + // TODO(rtenneti): Because we don't generate crash dumps for ThreadWatcher in + // stable channel, disable ThreadWatcher in stable and unknown channels. We + // will also not collect histogram data in these channels until + // http://crbug.com/426203 is fixed. chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel(); - if (channel == chrome::VersionInfo::CHANNEL_CANARY || - channel == chrome::VersionInfo::CHANNEL_STABLE || + if (channel == chrome::VersionInfo::CHANNEL_STABLE || channel == chrome::VersionInfo::CHANNEL_UNKNOWN) { return; } |