summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-16 07:34:05 +0000
committersatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-03-16 07:34:05 +0000
commit65a77e405dc41d4c80ad4545eb216ffa8cff2e3c (patch)
treeb5ea3a42499936b27709b1d8ef1ab7b5df798ce3
parent387e63299ba238ea0037eabdfbcc9bc843ec1a18 (diff)
downloadchromium_src-65a77e405dc41d4c80ad4545eb216ffa8cff2e3c.zip
chromium_src-65a77e405dc41d4c80ad4545eb216ffa8cff2e3c.tar.gz
chromium_src-65a77e405dc41d4c80ad4545eb216ffa8cff2e3c.tar.bz2
Fix clang chromium-style error in r127120.
BUG=none TEST=Build chrome and run unit_tests Review URL: https://chromiumcodereview.appspot.com/9700089 Patch from Ben Chan <benchan@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127121 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/chromeos/gdata/gdata_operations.cc27
-rw-r--r--chrome/browser/chromeos/gdata/gdata_operations.h13
2 files changed, 40 insertions, 0 deletions
diff --git a/chrome/browser/chromeos/gdata/gdata_operations.cc b/chrome/browser/chromeos/gdata/gdata_operations.cc
index 402d654..74ce1c3 100644
--- a/chrome/browser/chromeos/gdata/gdata_operations.cc
+++ b/chrome/browser/chromeos/gdata/gdata_operations.cc
@@ -146,6 +146,8 @@ EntryActionOperation::EntryActionOperation(GDataOperationRegistry* registry,
document_url_(document_url) {
}
+EntryActionOperation::~EntryActionOperation() {}
+
// Overridden from UrlFetchOperation.
GURL EntryActionOperation::GetURL() const {
return AddStandardUrlParams(document_url_);
@@ -175,6 +177,8 @@ GetDataOperation::GetDataOperation(GDataOperationRegistry* registry,
: UrlFetchOperation<GetDataCallback>(registry, profile, callback) {
}
+GetDataOperation::~GetDataOperation() {}
+
void GetDataOperation::ProcessURLFetchResults(const URLFetcher* source) {
std::string data;
source->GetResponseAsString(&data);
@@ -236,6 +240,8 @@ GetDocumentsOperation::GetDocumentsOperation(GDataOperationRegistry* registry,
: GetDataOperation(registry, profile, callback) {
}
+GetDocumentsOperation::~GetDocumentsOperation() {}
+
void GetDocumentsOperation::SetUrl(const GURL& url) {
override_url_ = url;
}
@@ -256,6 +262,8 @@ GetAccountMetadataOperation::GetAccountMetadataOperation(
: GetDataOperation(registry, profile, callback) {
}
+GetAccountMetadataOperation::~GetAccountMetadataOperation() {}
+
GURL GetAccountMetadataOperation::GetURL() const {
return AddStandardUrlParams(GURL(kAccountMetadataURL));
}
@@ -273,6 +281,8 @@ DownloadFileOperation::DownloadFileOperation(
save_temp_file_ = true;
}
+DownloadFileOperation::~DownloadFileOperation() {}
+
// Overridden from UrlFetchOperation.
GURL DownloadFileOperation::GetURL() const {
return document_url_;
@@ -314,6 +324,8 @@ DeleteDocumentOperation::DeleteDocumentOperation(
: EntryActionOperation(registry, profile, callback, document_url) {
}
+DeleteDocumentOperation::~DeleteDocumentOperation() {}
+
URLFetcher::RequestType DeleteDocumentOperation::GetRequestType() const {
return URLFetcher::DELETE_REQUEST;
}
@@ -338,6 +350,8 @@ CreateDirectoryOperation::CreateDirectoryOperation(
directory_name_(directory_name) {
}
+CreateDirectoryOperation::~CreateDirectoryOperation() {}
+
GURL CreateDirectoryOperation::GetURL() const {
if (!parent_content_url_.is_empty())
return AddStandardUrlParams(parent_content_url_);
@@ -388,6 +402,8 @@ CopyDocumentOperation::CopyDocumentOperation(
new_name_(new_name) {
}
+CopyDocumentOperation::~CopyDocumentOperation() {}
+
URLFetcher::RequestType CopyDocumentOperation::GetRequestType() const {
return URLFetcher::POST;
}
@@ -427,6 +443,8 @@ RenameResourceOperation::RenameResourceOperation(
new_name_(new_name) {
}
+RenameResourceOperation::~RenameResourceOperation() {}
+
URLFetcher::RequestType RenameResourceOperation::GetRequestType() const {
return URLFetcher::PUT;
}
@@ -468,6 +486,8 @@ AddResourceToDirectoryOperation::AddResourceToDirectoryOperation(
parent_content_url_(parent_content_url) {
}
+AddResourceToDirectoryOperation::~AddResourceToDirectoryOperation() {}
+
GURL AddResourceToDirectoryOperation::GetURL() const {
if (!parent_content_url_.is_empty())
return AddStandardUrlParams(parent_content_url_);
@@ -512,6 +532,9 @@ RemoveResourceFromDirectoryOperation::RemoveResourceFromDirectoryOperation(
parent_content_url_(parent_content_url) {
}
+RemoveResourceFromDirectoryOperation::~RemoveResourceFromDirectoryOperation() {
+}
+
GURL RemoveResourceFromDirectoryOperation::GetURL() const {
std::string escaped_resource_id = net::EscapePath(resource_id_);
GURL edit_url(base::StringPrintf("%s/%s",
@@ -547,6 +570,8 @@ InitiateUploadOperation::InitiateUploadOperation(
kUploadParamConvertValue)) {
}
+InitiateUploadOperation::~InitiateUploadOperation() {}
+
GURL InitiateUploadOperation::GetURL() const {
return initiate_upload_url_;
}
@@ -621,6 +646,8 @@ ResumeUploadOperation::ResumeUploadOperation(
params_(params) {
}
+ResumeUploadOperation::~ResumeUploadOperation() {}
+
GURL ResumeUploadOperation::GetURL() const {
return params_.upload_location;
}
diff --git a/chrome/browser/chromeos/gdata/gdata_operations.h b/chrome/browser/chromeos/gdata/gdata_operations.h
index adb250c..5a51953 100644
--- a/chrome/browser/chromeos/gdata/gdata_operations.h
+++ b/chrome/browser/chromeos/gdata/gdata_operations.h
@@ -274,6 +274,7 @@ class EntryActionOperation : public UrlFetchOperation<EntryActionCallback> {
Profile* profile,
const EntryActionCallback& callback,
const GURL& document_url);
+ virtual ~EntryActionOperation();
protected:
// Overridden from UrlFetchOperation.
@@ -298,6 +299,7 @@ class GetDataOperation : public UrlFetchOperation<GetDataCallback> {
GetDataOperation(GDataOperationRegistry* registry,
Profile* profile,
const GetDataCallback& callback);
+ virtual ~GetDataOperation();
protected:
// Overridden from UrlFetchOperation.
@@ -320,6 +322,7 @@ class GetDocumentsOperation : public GetDataOperation {
GetDocumentsOperation(GDataOperationRegistry* registry,
Profile* profile,
const GetDataCallback& callback);
+ virtual ~GetDocumentsOperation();
// Sets |url| for document fetching operation. This URL should be set in use
// case when additional 'pages' of document lists are being fetched.
@@ -343,6 +346,7 @@ class GetAccountMetadataOperation : public GetDataOperation {
GetAccountMetadataOperation(GDataOperationRegistry* registry,
Profile* profile,
const GetDataCallback& callback);
+ virtual ~GetAccountMetadataOperation();
protected:
// Overridden from GetDataOperation.
@@ -361,6 +365,7 @@ class DownloadFileOperation : public UrlFetchOperation<DownloadActionCallback> {
Profile* profile,
const DownloadActionCallback& callback,
const GURL& document_url);
+ virtual ~DownloadFileOperation();
protected:
// Overridden from UrlFetchOperation.
@@ -384,6 +389,7 @@ class DeleteDocumentOperation : public EntryActionOperation {
Profile* profile,
const EntryActionCallback& callback,
const GURL& document_url);
+ virtual ~DeleteDocumentOperation();
protected:
// Overridden from EntryActionOperation.
@@ -405,6 +411,7 @@ class CreateDirectoryOperation : public GetDataOperation {
const GetDataCallback& callback,
const GURL& parent_content_url,
const FilePath::StringType& directory_name);
+ virtual ~CreateDirectoryOperation();
protected:
// Overridden from UrlFetchOperation.
@@ -432,6 +439,7 @@ class CopyDocumentOperation : public GetDataOperation {
const GetDataCallback& callback,
const GURL& document_url,
const FilePath::StringType& new_name);
+ virtual ~CopyDocumentOperation();
protected:
// Overridden from GetDataOperation.
@@ -459,6 +467,7 @@ class RenameResourceOperation : public EntryActionOperation {
const EntryActionCallback& callback,
const GURL& document_url,
const FilePath::StringType& new_name);
+ virtual ~RenameResourceOperation();
protected:
// Overridden from EntryActionOperation.
@@ -486,6 +495,7 @@ class AddResourceToDirectoryOperation : public EntryActionOperation {
const EntryActionCallback& callback,
const GURL& parent_content_url,
const GURL& document_url);
+ virtual ~AddResourceToDirectoryOperation();
protected:
// Overridden from EntryActionOperation.
@@ -514,6 +524,7 @@ class RemoveResourceFromDirectoryOperation : public EntryActionOperation {
const GURL& parent_content_url,
const GURL& document_url,
const std::string& resource_id);
+ virtual ~RemoveResourceFromDirectoryOperation();
protected:
// Overridden from EntryActionOperation.
@@ -540,6 +551,7 @@ class InitiateUploadOperation
Profile* profile,
const InitiateUploadCallback& callback,
const InitiateUploadParams& params);
+ virtual ~InitiateUploadOperation();
protected:
// Overridden from UrlFetchOperation.
@@ -570,6 +582,7 @@ class ResumeUploadOperation : public UrlFetchOperation<ResumeUploadCallback> {
Profile* profile,
const ResumeUploadCallback& callback,
const ResumeUploadParams& params);
+ virtual ~ResumeUploadOperation();
protected:
// Overridden from UrlFetchOperation.