Add undeclared virtual destructors part 5

Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.

These files were discovered using the -Wnon-virtual-dtor flag in g++.

r=jar
BUG=47469

Review URL: http://codereview.chromium.org/3080013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98

8 files changed, 28 insertions, 0 deletions

diff --git a/app/animation_container.h b/app/animation_container.h
index 467e246..806b4e1 100644
--- a/app/animation_container.h
+++ b/app/animation_container.h
@@ -33,6 +33,9 @@ class AnimationContainer : public base::RefCounted<AnimationContainer> {
 
     // Invoked when no more animations are being managed by this container.
     virtual void AnimationContainerEmpty(AnimationContainer* container) = 0;
+
+   protected:
+    virtual ~Observer() {}
   };
 
   // Interface for the elements the AnimationContainer contains. This is
diff --git a/app/menus/simple_menu_model.h b/app/menus/simple_menu_model.h
index 2e732a9..c196225 100644
--- a/app/menus/simple_menu_model.h
+++ b/app/menus/simple_menu_model.h
@@ -43,6 +43,9 @@ class SimpleMenuModel : public MenuModel {
 
     // Performs the action associated with the specified command id.
     virtual void ExecuteCommand(int command_id) = 0;
+
+   protected:
+    virtual ~Delegate() {}
   };
 
   // The Delegate can be NULL, though if it is items can't be checked or
diff --git a/app/system_monitor.h b/app/system_monitor.h
index 6525b70..e5371ac 100644
--- a/app/system_monitor.h
+++ b/app/system_monitor.h
@@ -68,6 +68,9 @@ class SystemMonitor {
 
     // Notification that the system is resuming.
     virtual void OnResume() {}
+
+   protected:
+    virtual ~PowerObserver() {}
   };
 
   // Add a new observer.
diff --git a/base/process_util.h b/base/process_util.h
index 4cb954b..dbb0f13 100644
--- a/base/process_util.h
+++ b/base/process_util.h
@@ -254,6 +254,9 @@ class ProcessFilter {
   // Returns true to indicate set-inclusion and false otherwise.  This method
   // should not have side-effects and should be idempotent.
   virtual bool Includes(const ProcessEntry& entry) const = 0;
+
+ protected:
+  virtual ~ProcessFilter() {}
 };
 
 // Returns the number of processes on the machine that are running from the
diff --git a/ipc/ipc_fuzzing_tests.cc b/ipc/ipc_fuzzing_tests.cc
index f94e170..f9340e6 100644
--- a/ipc/ipc_fuzzing_tests.cc
+++ b/ipc/ipc_fuzzing_tests.cc
@@ -374,6 +374,8 @@ class ServerMacroExTest {
  public:
   ServerMacroExTest() : unhandled_msgs_(0) {
   }
+  virtual ~ServerMacroExTest() {
+  }
   virtual bool OnMessageReceived(const IPC::Message& msg) {
     bool msg_is_ok = false;
     IPC_BEGIN_MESSAGE_MAP_EX(ServerMacroExTest, msg, msg_is_ok)
diff --git a/media/tools/omx_test/file_sink.h b/media/tools/omx_test/file_sink.h
index fb7b732..69907031 100644
--- a/media/tools/omx_test/file_sink.h
+++ b/media/tools/omx_test/file_sink.h
@@ -31,6 +31,8 @@ class FileSink {
         csc_buf_size_(0) {
   }
 
+  virtual ~FileSink() {}
+
   virtual void BufferReady(int size, uint8* buffer);
 
   // Initialize this object. Returns true if successful.
diff --git a/views/controls/combobox/combobox.h b/views/controls/combobox/combobox.h
index 2b29f6a..0b619a2 100644
--- a/views/controls/combobox/combobox.h
+++ b/views/controls/combobox/combobox.h
@@ -28,6 +28,9 @@ class Combobox : public View {
     virtual void ItemChanged(Combobox* combo_box,
                              int prev_index,
                              int new_index) = 0;
+
+   protected:
+    virtual ~Listener() {}
   };
 
   // |model| is not owned by the combo box.
diff --git a/views/focus/focus_manager.h b/views/focus/focus_manager.h
index 73cfdc8..af6f414 100644
--- a/views/focus/focus_manager.h
+++ b/views/focus/focus_manager.h
@@ -93,6 +93,9 @@ class FocusTraversable {
   // It is used when walking up the view hierarchy tree to find which view
   // should be used as the starting view for finding the next/previous view.
   virtual View* GetFocusTraversableParentView() = 0;
+
+ protected:
+  virtual ~FocusTraversable() {}
 };
 
 // This interface should be implemented by classes that want to be notified when
@@ -100,6 +103,9 @@ class FocusTraversable {
 class FocusChangeListener {
  public:
   virtual void FocusWillChange(View* focused_before, View* focused_now) = 0;
+
+ protected:
+  virtual ~FocusChangeListener() {}
 };
 
 // This interface should be implemented by classes that want to be notified when
@@ -111,6 +117,9 @@ class WidgetFocusChangeListener {
  public:
   virtual void NativeFocusWillChange(gfx::NativeView focused_before,
                                      gfx::NativeView focused_now) = 0;
+
+ protected:
+  virtual ~WidgetFocusChangeListener() {}
 };
 
 class FocusManager {