diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-24 19:24:27 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-24 19:24:27 +0000 |
| commit | 6d658f2d14ad64333ac17db550b55271c7d231d4 (patch) | |
| tree | 3d951ff8d3e3fcb3a86a3dbb67171936848a414a | |
| parent | 61a99dd8b78f552519041f4cdcdcea4d97101e88 (diff) | |
| download | chromium_src-6d658f2d14ad64333ac17db550b55271c7d231d4.zip chromium_src-6d658f2d14ad64333ac17db550b55271c7d231d4.tar.gz chromium_src-6d658f2d14ad64333ac17db550b55271c7d231d4.tar.bz2 | |
CrOS - Fix crash in file browser the second time you save a file
We were not cleaning up callbacks after the dialog closed, so it crashed with a stale "params" pointer (user data for the callback).
BUG=chromium-os:15650
TEST=Right-click Save As an image. Right-click Save As the same image again. Verify Chrome does not crash.
Review URL: http://codereview.chromium.org/7064037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86466 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/ui/views/file_manager_dialogs.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/ui/views/file_manager_dialogs.cc b/chrome/browser/ui/views/file_manager_dialogs.cc index 926ffc2..7e52189 100644 --- a/chrome/browser/ui/views/file_manager_dialogs.cc +++ b/chrome/browser/ui/views/file_manager_dialogs.cc @@ -86,6 +86,7 @@ void FileManagerDialog::ListenerDestroyed() { void FileManagerDialog::ExtensionDialogIsClosing(ExtensionDialog* dialog) { owner_window_ = NULL; + FileDialogFunction::Callback::Remove(tab_id_); } void FileManagerDialog::SelectFileImpl( |