diff options
| author | Hokein.Wu@gmail.com <Hokein.Wu@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-17 05:29:29 +0000 |
|---|---|---|
| committer | Hokein.Wu@gmail.com <Hokein.Wu@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-17 05:29:29 +0000 |
| commit | 6ecedfe137843b57de9833ee54900c922e723133 (patch) | |
| tree | 1c5300315d8785913a6b5e9e13d008a7a58b4b5a | |
| parent | 74f6025b852d5f5eaab9540840e0053a08bcece3 (diff) | |
| download | chromium_src-6ecedfe137843b57de9833ee54900c922e723133.zip chromium_src-6ecedfe137843b57de9833ee54900c922e723133.tar.gz chromium_src-6ecedfe137843b57de9833ee54900c922e723133.tar.bz2 | |
Show better error message when utility process crash trying to do intall work.
BUG=322623
Review URL: https://codereview.chromium.org/85463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241156 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/app/generated_resources.grd | 3 | ||||
| -rw-r--r-- | chrome/browser/extensions/sandboxed_unpacker.cc | 4 |
2 files changed, 6 insertions, 1 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd index 62a868e..a963087 100644 --- a/chrome/app/generated_resources.grd +++ b/chrome/app/generated_resources.grd @@ -4601,6 +4601,9 @@ Make sure you do not expose any sensitive information. <message name="IDS_EXTENSION_PACKAGE_INSTALL_ERROR" desc="Error message in case package fails to install because of some problem with the filesystem."> Could not install package: '<ph name="ERROR_CODE">$1<ex>error</ex></ph>' </message> + <message name="IDS_EXTENSION_INSTALL_PROCESS_CRASHED" desc="Error message in case package fails to install a utility process crashed."> + Could not install package because a utility process crashed. Try restarting chrome and trying again. + </message> <message name="IDS_EXTENSION_CONTAINS_PRIVATE_KEY" desc="Error message when an extension includes a file containing a private key."> This extension includes the key file '<ph name="KEY_PATH">$1<ex>relative/path/to/file.pem</ex></ph>'. You probably don't want to do that. </message> diff --git a/chrome/browser/extensions/sandboxed_unpacker.cc b/chrome/browser/extensions/sandboxed_unpacker.cc index 33478d2..1f96441 100644 --- a/chrome/browser/extensions/sandboxed_unpacker.cc +++ b/chrome/browser/extensions/sandboxed_unpacker.cc @@ -336,7 +336,9 @@ void SandboxedUnpacker::OnProcessCrashed(int exit_code) { UTILITY_PROCESS_CRASHED_WHILE_TRYING_TO_INSTALL, l10n_util::GetStringFUTF16( IDS_EXTENSION_PACKAGE_INSTALL_ERROR, - ASCIIToUTF16("UTILITY_PROCESS_CRASHED_WHILE_TRYING_TO_INSTALL"))); + ASCIIToUTF16("UTILITY_PROCESS_CRASHED_WHILE_TRYING_TO_INSTALL")) + + ASCIIToUTF16(". ") + + l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_PROCESS_CRASHED)); } void SandboxedUnpacker::StartProcessOnIOThread( |