diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 11:27:47 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 11:27:47 +0000 |
commit | 6f50481e509709864bd3294a28374ffc0a255199 (patch) | |
tree | 282d731dbf7dd7c7e3d2cb928f261a3a82430996 | |
parent | 2c7f8cf810963623e5d0f4fd6fe40ba8c96a94c8 (diff) | |
download | chromium_src-6f50481e509709864bd3294a28374ffc0a255199.zip chromium_src-6f50481e509709864bd3294a28374ffc0a255199.tar.gz chromium_src-6f50481e509709864bd3294a28374ffc0a255199.tar.bz2 |
WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0.
A recent version of Clang warns about this:
../../android_webview/native/java_browser_view_renderer_helper.cc:133:35: error: comparison of constant 0 with expression of type 'bool' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
return RegisterNativesImpl(env) >= 0;
~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
BUG=363667
Review URL: https://codereview.chromium.org/238043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264168 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | android_webview/native/aw_autofill_manager_delegate.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_contents.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_contents_client_bridge.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_form_database.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_http_auth_handler.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_pdf_exporter.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_picture.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_quota_manager_bridge_impl.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_resource.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_settings.cc | 2 | ||||
-rw-r--r-- | android_webview/native/external_video_surface_container_impl.cc | 2 | ||||
-rw-r--r-- | android_webview/native/java_browser_view_renderer_helper.cc | 2 |
12 files changed, 12 insertions, 12 deletions
diff --git a/android_webview/native/aw_autofill_manager_delegate.cc b/android_webview/native/aw_autofill_manager_delegate.cc index e1107d6..070e25e 100644 --- a/android_webview/native/aw_autofill_manager_delegate.cc +++ b/android_webview/native/aw_autofill_manager_delegate.cc @@ -200,7 +200,7 @@ void AwAutofillManagerDelegate::ShowRequestAutocompleteDialog( } bool RegisterAwAutofillManagerDelegate(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc index bde37b6..eb009e9 100644 --- a/android_webview/native/aw_contents.cc +++ b/android_webview/native/aw_contents.cc @@ -481,7 +481,7 @@ void AwContents::AddVisitedLinks(JNIEnv* env, } bool RegisterAwContents(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } namespace { diff --git a/android_webview/native/aw_contents_client_bridge.cc b/android_webview/native/aw_contents_client_bridge.cc index 3485059..5f9e299 100644 --- a/android_webview/native/aw_contents_client_bridge.cc +++ b/android_webview/native/aw_contents_client_bridge.cc @@ -207,7 +207,7 @@ void AwContentsClientBridge::CancelJsResult(JNIEnv*, jobject, int id) { } bool RegisterAwContentsClientBridge(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_form_database.cc b/android_webview/native/aw_form_database.cc index 851340e..2269d76 100644 --- a/android_webview/native/aw_form_database.cc +++ b/android_webview/native/aw_form_database.cc @@ -36,7 +36,7 @@ void ClearFormData(JNIEnv*, jclass) { } bool RegisterAwFormDatabase(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_http_auth_handler.cc b/android_webview/native/aw_http_auth_handler.cc index 8146eae..0c4fd92 100644 --- a/android_webview/native/aw_http_auth_handler.cc +++ b/android_webview/native/aw_http_auth_handler.cc @@ -74,7 +74,7 @@ AwHttpAuthHandlerBase* AwHttpAuthHandlerBase::Create( } bool RegisterAwHttpAuthHandler(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_pdf_exporter.cc b/android_webview/native/aw_pdf_exporter.cc index 7a13fd7..8da47a0 100644 --- a/android_webview/native/aw_pdf_exporter.cc +++ b/android_webview/native/aw_pdf_exporter.cc @@ -111,7 +111,7 @@ bool AwPdfExporter::IsCancelled() { } bool RegisterAwPdfExporter(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_picture.cc b/android_webview/native/aw_picture.cc index 9a7ff83..535908d 100644 --- a/android_webview/native/aw_picture.cc +++ b/android_webview/native/aw_picture.cc @@ -50,7 +50,7 @@ void AwPicture::Draw(JNIEnv* env, jobject obj, jobject canvas, } bool RegisterAwPicture(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_quota_manager_bridge_impl.cc b/android_webview/native/aw_quota_manager_bridge_impl.cc index 4821732..b066f35 100644 --- a/android_webview/native/aw_quota_manager_bridge_impl.cc +++ b/android_webview/native/aw_quota_manager_bridge_impl.cc @@ -350,7 +350,7 @@ void AwQuotaManagerBridgeImpl::QuotaUsageCallbackImpl( } bool RegisterAwQuotaManagerBridge(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/aw_resource.cc b/android_webview/native/aw_resource.cc index b110731..cf4b6f4 100644 --- a/android_webview/native/aw_resource.cc +++ b/android_webview/native/aw_resource.cc @@ -38,7 +38,7 @@ std::string GetDefaultTextEncoding() { } bool RegisterAwResource(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace AwResource diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc index cf66d4e..af18722 100644 --- a/android_webview/native/aw_settings.cc +++ b/android_webview/native/aw_settings.cc @@ -350,7 +350,7 @@ static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) { } bool RegisterAwSettings(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/external_video_surface_container_impl.cc b/android_webview/native/external_video_surface_container_impl.cc index ca9ed34..1a10ab5 100644 --- a/android_webview/native/external_video_surface_container_impl.cc +++ b/android_webview/native/external_video_surface_container_impl.cc @@ -85,7 +85,7 @@ void ExternalVideoSurfaceContainerImpl::SurfaceDestroyed( } bool RegisterExternalVideoSurfaceContainer(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } } // namespace android_webview diff --git a/android_webview/native/java_browser_view_renderer_helper.cc b/android_webview/native/java_browser_view_renderer_helper.cc index ec2866f..df4f433 100644 --- a/android_webview/native/java_browser_view_renderer_helper.cc +++ b/android_webview/native/java_browser_view_renderer_helper.cc @@ -130,7 +130,7 @@ bool JavaBrowserViewRendererHelper::RenderViaAuxilaryBitmap( } bool RegisterJavaBrowserViewRendererHelper(JNIEnv* env) { - return RegisterNativesImpl(env) >= 0; + return RegisterNativesImpl(env); } bool JavaBrowserViewRendererHelper::RasterizeIntoBitmap( |