diff options
| author | bajones@chromium.org <bajones@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-29 16:58:07 +0000 |
|---|---|---|
| committer | bajones@chromium.org <bajones@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-29 16:58:07 +0000 |
| commit | 727e6ee08dd7af44b79c01b2347af6c7b6f71dfe (patch) | |
| tree | 747db46d20820dd5343a37a378e47d9ba638068a | |
| parent | 120500434211df49a836c56922d728c9066aec56 (diff) | |
| download | chromium_src-727e6ee08dd7af44b79c01b2347af6c7b6f71dfe.zip chromium_src-727e6ee08dd7af44b79c01b2347af6c7b6f71dfe.tar.gz chromium_src-727e6ee08dd7af44b79c01b2347af6c7b6f71dfe.tar.bz2 | |
Removed a DCHECK from deprecated code that's been causing bot failures
BUG=383963
TBR=tonyg@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/421043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286224 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/renderer/page_load_histograms.cc | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc index 307fe4d..6f8d702c 100644 --- a/chrome/renderer/page_load_histograms.cc +++ b/chrome/renderer/page_load_histograms.cc @@ -534,13 +534,17 @@ void DumpDeprecatedHistograms(const WebPerformance& performance, websearch_chrome_joint_experiment_id, is_preview); } - DCHECK(commit <= first_paint); - commit_to_first_paint.reset(new TimeDelta(first_paint - commit)); - PLT_HISTOGRAM_WITH_GWS_VARIANT("PLT.CommitToFirstPaint", - *commit_to_first_paint, - came_from_websearch, - websearch_chrome_joint_experiment_id, - is_preview); + + // Conditional was previously a DCHECK. Changed due to multiple bot + // failures, listed in crbug.com/383963 + if (commit <= first_paint) { + commit_to_first_paint.reset(new TimeDelta(first_paint - commit)); + PLT_HISTOGRAM_WITH_GWS_VARIANT("PLT.CommitToFirstPaint", + *commit_to_first_paint, + came_from_websearch, + websearch_chrome_joint_experiment_id, + is_preview); + } } if (!first_paint_after_load.is_null()) { // 'first_paint_after_load' can be before 'begin' for an unknown reason. |