diff options
| author | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-21 20:44:16 +0000 |
|---|---|---|
| committer | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-21 20:44:16 +0000 |
| commit | 76328988113b8bfc1cda9efdc266213199d413ca (patch) | |
| tree | 935cb7e9638878eb094cc1973a2c53d29dfccc41 | |
| parent | 98abd85558e19788d971df47690bcb4eb4dd8d98 (diff) | |
| download | chromium_src-76328988113b8bfc1cda9efdc266213199d413ca.zip chromium_src-76328988113b8bfc1cda9efdc266213199d413ca.tar.gz chromium_src-76328988113b8bfc1cda9efdc266213199d413ca.tar.bz2 | |
Fix issue where NTP metrics for restored tabs weren't getting recorded correctly.
BUG=4668
Review URL: http://codereview.chromium.org/11356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5846 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/dom_ui/new_tab_ui.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/resources/new_tab.html | 1 |
2 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/dom_ui/new_tab_ui.cc b/chrome/browser/dom_ui/new_tab_ui.cc index 02177b1..729c9dc 100644 --- a/chrome/browser/dom_ui/new_tab_ui.cc +++ b/chrome/browser/dom_ui/new_tab_ui.cc @@ -649,10 +649,6 @@ void RecentlyClosedTabsHandler::HandleReopenTab(const Value* content) { for (TabRestoreService::Tabs::const_iterator it = tabs.begin(); it != tabs.end(); ++it) { if (it->id == session_to_restore) { - UserMetrics::RecordComputedAction( - StringPrintf(L"NTP_TabRestored%d", session_to_restore), - dom_ui_host_->profile()); - TabRestoreService* tab_restore_service = tab_restore_service_; browser->ReplaceRestoredTab( it->navigations, it->current_navigation_index); diff --git a/chrome/browser/resources/new_tab.html b/chrome/browser/resources/new_tab.html index cb205ec..8fe2429 100644 --- a/chrome/browser/resources/new_tab.html +++ b/chrome/browser/resources/new_tab.html @@ -585,6 +585,7 @@ function renderRecentlyClosedTabs(entries) { link.onclick = function(sessionId) { return function() { + chrome.send("metrics", ["NTP_TabRestored" + i]); /* This is a hack because chrome.send is hardcoded to only accept arrays of strings. */ chrome.send('reopenTab', [sessionId.toString()]); |