diff options
| author | rouslan <rouslan@chromium.org> | 2015-09-21 15:12:11 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-21 22:12:43 +0000 |
| commit | 7647c0a5f887011a4976a936326a46b956623e61 (patch) | |
| tree | 7ed0263ff2ae814c75f1ddc96efc893d24ae78a0 | |
| parent | ba54519eda6d7c9ebd3252fbdf801dec0f068873 (diff) | |
| download | chromium_src-7647c0a5f887011a4976a936326a46b956623e61.zip chromium_src-7647c0a5f887011a4976a936326a46b956623e61.tar.gz chromium_src-7647c0a5f887011a4976a936326a46b956623e61.tar.bz2 | |
Content description for settings button in keyboard accessory.
A screen reader should verbalise "settings" instead of "autofill
settings three dots" when the user taps the gear icon on the keyboard
accessory.
BUG=428087
Review URL: https://codereview.chromium.org/1357243003
Cr-Commit-Position: refs/heads/master@{#350040}
| -rw-r--r-- | build/ios/grit_whitelist.txt | 1 | ||||
| -rw-r--r-- | components/autofill/core/browser/autofill_external_delegate.cc | 7 | ||||
| -rw-r--r-- | components/autofill_strings.grdp | 3 |
3 files changed, 9 insertions, 2 deletions
diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt index 4fd126c..446ca70 100644 --- a/build/ios/grit_whitelist.txt +++ b/build/ios/grit_whitelist.txt @@ -172,6 +172,7 @@ IDS_AUTOFILL_FIELD_LABEL_PREFECTURE IDS_AUTOFILL_FIELD_LABEL_PROVINCE IDS_AUTOFILL_FIELD_LABEL_STATE IDS_AUTOFILL_FIELD_LABEL_ZIP_CODE +IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION IDS_AUTOFILL_OPTIONS_POPUP IDS_AUTOFILL_PASSWORD_FIELD_SUGGESTIONS_TITLE IDS_AUTOFILL_SCAN_CREDIT_CARD diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc index 82b7396..c9471f4 100644 --- a/components/autofill/core/browser/autofill_external_delegate.cc +++ b/components/autofill/core/browser/autofill_external_delegate.cc @@ -293,8 +293,11 @@ void AutofillExternalDelegate::ApplyAutofillOptions( } // Append the 'Chrome Autofill options' menu item; - suggestions->push_back(Suggestion( - l10n_util::GetStringUTF16(IDS_AUTOFILL_OPTIONS_POPUP))); + // TODO(rouslan): Switch on the platform in the GRD file when keyboard + // accessory becomes default on Android. + suggestions->push_back(Suggestion(l10n_util::GetStringUTF16( + IsKeyboardAccessoryEnabled() ? IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION + : IDS_AUTOFILL_OPTIONS_POPUP))); suggestions->back().frontend_id = POPUP_ITEM_ID_AUTOFILL_OPTIONS; if (IsKeyboardAccessoryEnabled()) suggestions->back().icon = base::ASCIIToUTF16("settings"); diff --git a/components/autofill_strings.grdp b/components/autofill_strings.grdp index fef78ad..916f805 100644 --- a/components/autofill_strings.grdp +++ b/components/autofill_strings.grdp @@ -126,6 +126,9 @@ Chromium Autofill settings... </message> </if> + <message name="IDS_AUTOFILL_OPTIONS_CONTENT_DESCRIPTION" desc="The text verbalised by a screen reader for the button that directs the user to the Autofill settings UI. This string is not displayed."> + settings + </message> <message name="IDS_AUTOFILL_CREDIT_CARD_NOT_SUPPORTED_BY_WALLET" desc="Message displayed to user when user entered a credit card number that is not supported by Google Payments."> This type of card is not supported by Google Payments. Please select a different card. |