diff options
author | rajendrant <rajendrant@chromium.org> | 2016-03-01 17:17:22 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-02 01:18:47 +0000 |
commit | 76abf5241c467e11324254d20de3dce30e7ee999 (patch) | |
tree | 8dd52a62899413fcab0ee8bb309414d5784ee3b9 | |
parent | fffd7f3cc2d7492e8b7d7cbd8b4958092ef74241 (diff) | |
download | chromium_src-76abf5241c467e11324254d20de3dce30e7ee999.zip chromium_src-76abf5241c467e11324254d20de3dce30e7ee999.tar.gz chromium_src-76abf5241c467e11324254d20de3dce30e7ee999.tar.bz2 |
Record the timestamp when Data reduction proxy promo screen was shown
Data Reduction Proxy promo screen on Android, could be shown during the
first run experience(FRE) or during subsequent runs if not shown in FRE.
We need to record the timestamp the promo screen was shown the last time.
BUG=588164
Review URL: https://codereview.chromium.org/1736783002
Cr-Commit-Position: refs/heads/master@{#378644}
2 files changed, 15 insertions, 7 deletions
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java index 07d980f..09fe40d 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DataReductionProxyFirstRunFragment.java @@ -63,6 +63,6 @@ public class DataReductionProxyFirstRunFragment extends FirstRunPage { @Override public void onStart() { super.onStart(); - DataReductionPromoScreen.setDisplayedDataReductionPromo(getActivity(), true); + DataReductionPromoScreen.saveDataReductionPromoDisplayed(getActivity()); } } diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java index d833820..5c91f70 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java @@ -27,7 +27,13 @@ import org.chromium.ui.widget.Toast; */ public class DataReductionPromoScreen extends Dialog implements View.OnClickListener, DialogInterface.OnDismissListener { + /** + * Key used to save whether the promo screen is shown and the time in milliseconds since epoch, + * it was shown. + */ private static final String SHARED_PREF_DISPLAYED_PROMO = "displayed_data_reduction_promo"; + private static final String SHARED_PREF_DISPLAYED_PROMO_TIME_MS = + "displayed_data_reduction_promo_time_ms"; private int mState; @@ -119,7 +125,7 @@ public class DataReductionPromoScreen extends Dialog implements View.OnClickList @Override public void onDismiss(DialogInterface dialog) { - setDisplayedDataReductionPromo(getContext(), true); + saveDataReductionPromoDisplayed(getContext()); } private void handleEnableButtonPressed() { @@ -155,14 +161,16 @@ public class DataReductionPromoScreen extends Dialog implements View.OnClickList } /** - * Sets whether the Data Reduction Proxy promo has been displayed. + * Saves shared prefs indicating that the Data Reduction Proxy promo screen has been displayed + * at the current time. * * @param context An Android context. - * @param displayed Whether the Data Reduction Proxy was displayed. */ - public static void setDisplayedDataReductionPromo(Context context, boolean displayed) { - PreferenceManager.getDefaultSharedPreferences(context).edit() - .putBoolean(SHARED_PREF_DISPLAYED_PROMO, displayed) + public static void saveDataReductionPromoDisplayed(Context context) { + PreferenceManager.getDefaultSharedPreferences(context) + .edit() + .putBoolean(SHARED_PREF_DISPLAYED_PROMO, true) + .putLong(SHARED_PREF_DISPLAYED_PROMO_TIME_MS, System.currentTimeMillis()) .apply(); } } |