diff options
| author | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-30 14:00:27 +0000 |
|---|---|---|
| committer | dpranke@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-30 14:00:27 +0000 |
| commit | 788e0ea3531339e43191c43ba4a36816355e7456 (patch) | |
| tree | 8a516e29ffbf31829631565d7fb51976e86d8ad9 | |
| parent | a8feebb366febd527512da9568487e3e70735a57 (diff) | |
| download | chromium_src-788e0ea3531339e43191c43ba4a36816355e7456.zip chromium_src-788e0ea3531339e43191c43ba4a36816355e7456.tar.gz chromium_src-788e0ea3531339e43191c43ba4a36816355e7456.tar.bz2 | |
Fix typos in num_failures_by_type for json results.
This changes a few occurrences of "Failure" -> "FAIL" and "Pass" -> "PASS"
to conform to the doc format. The existing data is not actually being
used yet, but the flakiness dashboard needs the correct values.
Also fix a typo in run_mojo_python_tests that was preventing us from
running individual tests on the command line.
R=ojan@chromium.org, viettrungluu@chromium.org, grt@chromium.org
Review URL: https://codereview.chromium.org/429013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286504 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/test/mini_installer/test_installer.py | 4 | ||||
| -rwxr-xr-x | mojo/tools/run_mojo_python_tests.py | 6 | ||||
| -rw-r--r-- | tools/telemetry/telemetry/unittest/json_results.py | 4 |
3 files changed, 7 insertions, 7 deletions
diff --git a/chrome/test/mini_installer/test_installer.py b/chrome/test/mini_installer/test_installer.py index 7a9521a..681fba8 100644 --- a/chrome/test/mini_installer/test_installer.py +++ b/chrome/test/mini_installer/test_installer.py @@ -335,8 +335,8 @@ def _FullResults(suite, result, metadata): failed_test_names = _FailedTestNames(result) full_results['num_failures_by_type'] = { - 'Failure': len(failed_test_names), - 'Pass': len(all_test_names) - len(failed_test_names), + 'FAIL': len(failed_test_names), + 'PASS': len(all_test_names) - len(failed_test_names), } full_results['tests'] = {} diff --git a/mojo/tools/run_mojo_python_tests.py b/mojo/tools/run_mojo_python_tests.py index 778a575..da9ab63 100755 --- a/mojo/tools/run_mojo_python_tests.py +++ b/mojo/tools/run_mojo_python_tests.py @@ -49,7 +49,7 @@ def main(): if pylib_dir not in sys.path: sys.path.append(pylib_dir) suite = unittest.TestSuite() - for test_name in args: + for test_name in args.tests: suite.addTests(loader.loadTestsFromName(test_name)) else: suite = loader.discover(pylib_dir, pattern='*_unittest.py') @@ -88,8 +88,8 @@ def _FullResults(suite, result, metadata): failed_test_names = _FailedTestNames(result) full_results['num_failures_by_type'] = { - 'Failure': len(failed_test_names), - 'Pass': len(all_test_names) - len(failed_test_names), + 'FAIL': len(failed_test_names), + 'PASS': len(all_test_names) - len(failed_test_names), } full_results['tests'] = {} diff --git a/tools/telemetry/telemetry/unittest/json_results.py b/tools/telemetry/telemetry/unittest/json_results.py index a886746..72c20f6 100644 --- a/tools/telemetry/telemetry/unittest/json_results.py +++ b/tools/telemetry/telemetry/unittest/json_results.py @@ -61,8 +61,8 @@ def _FullResults(suite, result, metadata): failed_test_names = _FailedTestNames(result) full_results['num_failures_by_type'] = { - 'Failure': len(failed_test_names), - 'Pass': len(all_test_names) - len(failed_test_names), + 'FAIL': len(failed_test_names), + 'PASS': len(all_test_names) - len(failed_test_names), } full_results['tests'] = {} |