diff options
| author | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 08:29:43 +0000 |
|---|---|---|
| committer | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-23 08:29:43 +0000 |
| commit | 792471320a24b12a1129f69ab7f67b95245ca9f9 (patch) | |
| tree | c7138a0501a3e1b3e1d9860af76553d7c14600f1 | |
| parent | b36547294eb520da95284d9b6ca923ffe72da60e (diff) | |
| download | chromium_src-792471320a24b12a1129f69ab7f67b95245ca9f9.zip chromium_src-792471320a24b12a1129f69ab7f67b95245ca9f9.tar.gz chromium_src-792471320a24b12a1129f69ab7f67b95245ca9f9.tar.bz2 | |
Disable "Language Settings..." context menu on OS X.
It doesn't make sense to make this open the "Language Settings" preferenes windows (like on other platforms), since that panel
isn't implemented yet - http://crbug.com/23828.
Once that bug is fixed we can decide whether it make sense to
re-enable this item or change the context menu on OS X.
BUG=34512
TEST=Right click on a text input field on OS X, Spell Checking->Language settings menu item should be disabled. On Windows the item should be enabled.
Review URL: http://codereview.chromium.org/1161003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42326 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/tab_contents/render_view_context_menu.cc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc index 4359dc5..30f7e32 100644 --- a/chrome/browser/tab_contents/render_view_context_menu.cc +++ b/chrome/browser/tab_contents/render_view_context_menu.cc @@ -742,7 +742,10 @@ bool RenderViewContextMenu::IsItemCommandEnabled(int id) const { case IDC_SPELLCHECK_SUGGESTION_4: case IDC_SPELLCHECK_MENU: case IDC_SPELLPANEL_TOGGLE: +#if !defined(OS_MACOSX) + // TODO(jeremy): re-enable - http://crbug.com/34512 . case IDS_CONTENT_CONTEXT_LANGUAGE_SETTINGS: +#endif case IDS_CONTENT_CONTEXT_VIEWFRAMEINFO: return true; @@ -750,6 +753,12 @@ bool RenderViewContextMenu::IsItemCommandEnabled(int id) const { return profile_->GetPrefs()->GetBoolean(prefs::kEnableSpellCheck); #if defined(OS_MACOSX) + // TODO(jeremy): re-enable - http://crbug.com/34512 . + case IDS_CONTENT_CONTEXT_LANGUAGE_SETTINGS: + return false; +#endif + +#if defined(OS_MACOSX) case IDC_WRITING_DIRECTION_DEFAULT: // Provided to match OS defaults. return params_.writing_direction_default & WebContextMenuData::CheckableMenuItemEnabled; |