diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-20 14:05:27 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-20 14:05:27 +0000 |
| commit | 799f9fbfa3dbb22d85f4be811e733e8809154c98 (patch) | |
| tree | 6d5dde0170cb6362df29b7193ebfc3abd75c2f4c | |
| parent | 837018e189f596c566c28a459ba52f926586288e (diff) | |
| download | chromium_src-799f9fbfa3dbb22d85f4be811e733e8809154c98.zip chromium_src-799f9fbfa3dbb22d85f4be811e733e8809154c98.tar.gz chromium_src-799f9fbfa3dbb22d85f4be811e733e8809154c98.tar.bz2 | |
Updating status on three tests:
Someone changed FindInPagePrematureEnd from DISABLED to FAILS. However, it is not expected to pass until we fix 11761 so we don't need to run it until then. Marking it back as DISABLED.
NoIncognitoPrepopulate was failing because the infrastructure was laggy (the simple act of launching a page in incognito could take up to a minute). I can no longer repro the error, so I think the problem is gone.
Back in June, ActivateLinkNavigatesPage got marked as DISABLED (because it crashed occasionally), with a bug filed against no-one, so I have no crashdump or try bot logs nor any idea what the state of it is. Marking as enabled to see if it is still a problem. It passes locally.
BUG=45594, 40948
TEST=These are tests.
Review URL: http://codereview.chromium.org/601044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59930 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/find_bar_host_browsertest.cc | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/chrome/browser/find_bar_host_browsertest.cc b/chrome/browser/find_bar_host_browsertest.cc index 0ee5f89..11c5f3e 100644 --- a/chrome/browser/find_bar_host_browsertest.cc +++ b/chrome/browser/find_bar_host_browsertest.cc @@ -502,7 +502,9 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindRestarts_Issue1155639) { } // This tests bug 11761: FindInPage terminates search prematurely. -IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FAILS_FindInPagePrematureEnd) { +// This test is not expected to pass until bug 11761 is fixed. +IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, + DISABLED_FindInPagePrematureEnd) { ASSERT_TRUE(test_server()->Start()); // First we navigate to our special focus tracking page. @@ -983,9 +985,6 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, PrepopulatePreserveLast) { // linux views. Investigate and fix. http://crbug.com/40948 #if defined(OS_LINUX) && defined(TOOLKIT_VIEWS) #define MAYBE_NoIncognitoPrepopulate DISABLED_NoIncognitoPrepopulate -#elif defined (OS_WIN) -// On windows, this test is flaky. http://crbug.com/40948 -#define MAYBE_NoIncognitoPrepopulate FLAKY_NoIncognitoPrepopulate #else #define MAYBE_NoIncognitoPrepopulate NoIncognitoPrepopulate #endif @@ -1058,15 +1057,8 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_NoIncognitoPrepopulate) { EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarTextForBrowser(browser())); } -// See http://crbug.com/45594. On Windows, it crashes sometimes. -#if defined(OS_WIN) -#define MAYBE_ActivateLinkNavigatesPage DISABLED_ActivateLinkNavigatesPage -#else -#define MAYBE_ActivateLinkNavigatesPage ActivateLinkNavigatesPage -#endif // This makes sure that dismissing the find bar with kActivateSelection works. -IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, - MAYBE_ActivateLinkNavigatesPage) { +IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) { ASSERT_TRUE(test_server()->Start()); // First we navigate to our test content. |