diff options
| author | erikchen <erikchen@chromium.org> | 2015-10-02 09:50:10 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-02 16:51:12 +0000 |
| commit | 79aaee4007cab1a17f17228ec3b55fe13105a773 (patch) | |
| tree | f91ea8f9b385958837b9c7a4eb4e1a9b82974d9b | |
| parent | 4367d520c6f3627ae6236eb5984ddb39fef2e2e7 (diff) | |
| download | chromium_src-79aaee4007cab1a17f17228ec3b55fe13105a773.zip chromium_src-79aaee4007cab1a17f17228ec3b55fe13105a773.tar.gz chromium_src-79aaee4007cab1a17f17228ec3b55fe13105a773.tar.bz2 | |
Revert of content: Temporary debugging to track down IPC related problems. (patchset #3 id:40001 of https://codereview.chromium.org/1377913002/ )
Reason for revert:
This CL was only intended to be landed for a brief period of time.
Original issue's description:
> content: Temporary debugging to track down IPC related problems.
>
> This CL is only intended to be landed for a single canary release.
>
> BUG=527588
>
> Committed: https://crrev.com/5652fd6385940e426fed4c0e6d6894903012f70b
> Cr-Commit-Position: refs/heads/master@{#351576}
TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527588
Review URL: https://codereview.chromium.org/1376533005
Cr-Commit-Position: refs/heads/master@{#352057}
| -rw-r--r-- | content/browser/loader/async_resource_handler.cc | 3 | ||||
| -rw-r--r-- | content/child/resource_dispatcher.cc | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/content/browser/loader/async_resource_handler.cc b/content/browser/loader/async_resource_handler.cc index f8e556c..2eace36 100644 --- a/content/browser/loader/async_resource_handler.cc +++ b/content/browser/loader/async_resource_handler.cc @@ -318,9 +318,6 @@ bool AsyncResourceHandler::OnReadCompleted(int bytes_read, bool* defer) { int size; if (!buffer_->ShareToProcess(filter->PeerHandle(), &handle, &size)) return false; - // TODO(erikchen): Temporary debugging to help track down crash. - // http://crbug.com/527588. - CHECK_LE(size, 512 * 1024); filter->Send(new ResourceMsg_SetDataBuffer( GetRequestID(), handle, size, filter->peer_pid())); sent_first_data_msg_ = true; diff --git a/content/child/resource_dispatcher.cc b/content/child/resource_dispatcher.cc index 5308158..ec1a1ef 100644 --- a/content/child/resource_dispatcher.cc +++ b/content/child/resource_dispatcher.cc @@ -181,9 +181,6 @@ void ResourceDispatcher::OnSetDataBuffer(int request_id, base::SharedMemoryHandle shm_handle, int shm_size, base::ProcessId renderer_pid) { - // TODO(erikchen): Temporary debugging to help track down crash. - // http://crbug.com/527588. - CHECK_LE(shm_size, 512 * 1024); TRACE_EVENT0("loader", "ResourceDispatcher::OnSetDataBuffer"); PendingRequestInfo* request_info = GetPendingRequestInfo(request_id); if (!request_info) |