summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorplundblad <plundblad@chromium.org>2015-11-23 10:16:14 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-23 18:17:15 +0000
commit7c2d5428accfe76853d8001158883c4814fa6ae2 (patch)
treed9a524cab8c1ad6318845e868af21b4f087c87d2
parentce53fc611e8530479051599011e4124c063e0a96 (diff)
downloadchromium_src-7c2d5428accfe76853d8001158883c4814fa6ae2.zip
chromium_src-7c2d5428accfe76853d8001158883c4814fa6ae2.tar.gz
chromium_src-7c2d5428accfe76853d8001158883c4814fa6ae2.tar.bz2
Workaround dependency on closure library in chromevox test utility.
This used to work because the accessibility audit library pulls in parts of the closure libray. Since it doesn't leak its internals in a newer version, this dependency problem was exposed. The underlying issue is that GEN_INCLUDES in the js test are included before closureModuleDeps, so declarations from the latter are not available when evaluating the former. Needed for https://codereview.chromium.org/1447693002/ BUG=555753 R=aboxhall@chromium.org Review URL: https://codereview.chromium.org/1472763002 Cr-Commit-Position: refs/heads/master@{#361142}
-rw-r--r--chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js6
1 files changed, 5 insertions, 1 deletions
diff --git a/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js b/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js
index b58b152..7cb837f 100644
--- a/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js
+++ b/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js
@@ -39,7 +39,11 @@ CvoxWalkerUnitTestBase.prototype = {
* Returns a new walker appropriate for the child test.
* @return {!cvox.AbstractWalker} The walker instance.
*/
- newWalker: goog.abstractMethod,
+ // Closure library is not available when this literal is evaluated, so
+ // we can't use goog.abstractMethod here.
+ newWalker: function() {
+ throw Error('newWalker not implemented.');
+ },
/**
* Makes testing much less verbose. Executes the command on the