summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-27 19:31:30 +0000
committermbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-01-27 19:31:30 +0000
commit7c47289012373753a603ff76d15c85db7a0ae436 (patch)
treeb007b95450eab29c249e9b76c6298686b7d64c69
parentf210f5dbfd0ec6b8ef4e9dc1b99af249e4f1b323 (diff)
downloadchromium_src-7c47289012373753a603ff76d15c85db7a0ae436.zip
chromium_src-7c47289012373753a603ff76d15c85db7a0ae436.tar.gz
chromium_src-7c47289012373753a603ff76d15c85db7a0ae436.tar.bz2
The server will happily propagate invalid SPDY headers, which Chrome will
reject. Strip headers with 0 length header names or 0 length header values. BUG=none TEST=none Review URL: http://codereview.chromium.org/6286012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72858 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--net/tools/flip_server/flip_in_mem_edsm_server.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/net/tools/flip_server/flip_in_mem_edsm_server.cc b/net/tools/flip_server/flip_in_mem_edsm_server.cc
index c4aeaf6..235403d 100644
--- a/net/tools/flip_server/flip_in_mem_edsm_server.cc
+++ b/net/tools/flip_server/flip_in_mem_edsm_server.cc
@@ -2075,6 +2075,11 @@ class SpdySM : public SpdyFramerVisitorInterface, public SMInterface {
headers.header_lines_begin();
hi != headers.header_lines_end();
++hi) {
+ // It is illegal to send SPDY headers with empty value or header
+ // names.
+ if (!hi->first.length() || !hi->second.length())
+ continue;
+
SpdyHeaderBlock::iterator fhi = dest.find(hi->first.as_string());
if (fhi == dest.end()) {
dest[hi->first.as_string()] = hi->second.as_string();