diff options
| author | mkearney <mkearney@chromium.org> | 2015-01-15 16:31:51 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-16 00:33:37 +0000 |
| commit | 7dbc1428fa4363ff47972c2076cd4395e05e9440 (patch) | |
| tree | f876531564fc9dcf336bd8573bf536680de02e45 | |
| parent | f9b1f3bd8064eaa8383781f9b79a2e512098bd81 (diff) | |
| download | chromium_src-7dbc1428fa4363ff47972c2076cd4395e05e9440.zip chromium_src-7dbc1428fa4363ff47972c2076cd4395e05e9440.tar.gz chromium_src-7dbc1428fa4363ff47972c2076cd4395e05e9440.tar.bz2 | |
The new left-nav wasn't showing up for the top-level parents. This is because there's a dependency between the selected item, and showing the selected item's child elements in the navigation.
Adding redirects is a quick solution. But we should tweak the logic for rendering the navigation to do this better. Created a bug to make this happen: https://code.google.com/p/chromium/issues/detail?id=449272
I also added the nativeMessaging article to chrome_sidenav.json so it's not an orphan page (and so it gets a left-side navigation).
BUG=447853
Review URL: https://codereview.chromium.org/849303003
Cr-Commit-Position: refs/heads/master@{#311775}
3 files changed, 19 insertions, 6 deletions
diff --git a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html index 2a7e861..4ff66de 100644 --- a/chrome/common/extensions/docs/templates/articles/nativeMessaging.html +++ b/chrome/common/extensions/docs/templates/articles/nativeMessaging.html @@ -1,4 +1,4 @@ -<h1>Native messaging</h1> +<h1>Native Messaging</h1> <p> Extensions and apps can exchange messages with native applications using an API that is similar to the other <a href="messaging">message passing APIs</a>. diff --git a/chrome/common/extensions/docs/templates/json/chrome_sidenav.json b/chrome/common/extensions/docs/templates/json/chrome_sidenav.json index 20550f6..8d984e0 100644 --- a/chrome/common/extensions/docs/templates/json/chrome_sidenav.json +++ b/chrome/common/extensions/docs/templates/json/chrome_sidenav.json @@ -405,6 +405,10 @@ "href": "/apps/cloudMessaging" }, { + "title": "Native Messaging", + "href": "/apps/nativeMessaging" + }, + { "title": "Rich Notifications", "href": "/apps/richNotifications" }, @@ -528,11 +532,11 @@ }, { "title": "Extensions", - "href": "/extensions/overview", + "href": "/extensions/index", "items": [ { "title": "Learn Basics", - "href": "/extensions/overview", + "href": "/extensions/index", "items": [ { "title": "Overview", @@ -602,6 +606,10 @@ "href": "/extensions/messaging" }, { + "title": "Native Messaging", + "href": "/extensions/nativeMessaging" + }, + { "title": "Migrate to Manifest 2", "href": "/extensions/tut_migration_to_manifest_v2" }, @@ -697,11 +705,11 @@ }, { "title": "Native Client", - "href": "/native-client/overview", + "href": "/native-client/index", "items": [ { "title": "Learn Basics", - "href": "/native-client/overview", + "href": "/native-client/index", "items": [ { "title": "Technical Overview", diff --git a/chrome/common/extensions/docs/templates/public/redirects.json b/chrome/common/extensions/docs/templates/public/redirects.json index 6c724a2..1a5a766 100644 --- a/chrome/common/extensions/docs/templates/public/redirects.json +++ b/chrome/common/extensions/docs/templates/public/redirects.json @@ -1,4 +1,9 @@ { "": "/home", - "apps": "/apps/about_apps" + "apps": "/apps/about_apps", + "native-client": "/native-client/index", + "extensions": "/extensions/index", + "devtools": "devtools/index", + "multidevice": "multidevice/index", + "webstore": "/webstore/index" } |