summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorleejongsoo@gmail.com <leejongsoo@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-20 17:48:12 +0000
committerleejongsoo@gmail.com <leejongsoo@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-20 17:48:12 +0000
commit82dd993f947d2a42d8aae0fae68e1e847220aa53 (patch)
treedcd60d750842ab205460b4805b04282ac78f17e6
parent3166f36df596566dd4d9402797d9903593bb8aa4 (diff)
downloadchromium_src-82dd993f947d2a42d8aae0fae68e1e847220aa53.zip
chromium_src-82dd993f947d2a42d8aae0fae68e1e847220aa53.tar.gz
chromium_src-82dd993f947d2a42d8aae0fae68e1e847220aa53.tar.bz2
Clean-up coding style
BUG=None (cleanup only, does not change behavior) Review URL: https://codereview.chromium.org/278013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271698 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--AUTHORS1
-rw-r--r--extensions/common/features/api_feature.h2
-rw-r--r--extensions/common/features/base_feature_provider.cc3
-rw-r--r--extensions/common/features/complex_feature.h1
-rw-r--r--extensions/common/features/json_feature_provider_source.cc4
-rw-r--r--extensions/common/features/json_feature_provider_source.h8
-rw-r--r--extensions/common/features/manifest_feature.h4
-rw-r--r--extensions/common/features/permission_feature.h4
8 files changed, 18 insertions, 9 deletions
diff --git a/AUTHORS b/AUTHORS
index c1e8e6c..fbf6ea2 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -171,6 +171,7 @@ Joe Thomas <mhx348@motorola.com>
Joel Stanley <joel@jms.id.au>
Johannes Rudolph <johannes.rudolph@googlemail.com>
John Yani <vanuan@gmail.com>
+Jongsoo Lee <leejongsoo@gmail.com>
Joone Hur <joone.hur@intel.com>
Jorge Villatoro <jorge@tomatocannon.com>
Joseph Gentle <josephg@gmail.com>
diff --git a/extensions/common/features/api_feature.h b/extensions/common/features/api_feature.h
index fea4c7d..1e57b8d 100644
--- a/extensions/common/features/api_feature.h
+++ b/extensions/common/features/api_feature.h
@@ -5,6 +5,8 @@
#ifndef EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
#define EXTENSIONS_COMMON_FEATURES_API_FEATURE_H_
+#include <string>
+
#include "extensions/common/features/simple_feature.h"
namespace extensions {
diff --git a/extensions/common/features/base_feature_provider.cc b/extensions/common/features/base_feature_provider.cc
index 4b03fd0..97f87be 100644
--- a/extensions/common/features/base_feature_provider.cc
+++ b/extensions/common/features/base_feature_provider.cc
@@ -5,6 +5,7 @@
#include "extensions/common/features/base_feature_provider.h"
#include <stack>
+#include <utility>
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
@@ -171,4 +172,4 @@ std::vector<Feature*> BaseFeatureProvider::GetChildren(const Feature& parent)
return result;
}
-} // namespace extensions
+} // namespace extensions
diff --git a/extensions/common/features/complex_feature.h b/extensions/common/features/complex_feature.h
index 5d12644..e71f6da 100644
--- a/extensions/common/features/complex_feature.h
+++ b/extensions/common/features/complex_feature.h
@@ -5,6 +5,7 @@
#ifndef EXTENSIONS_COMMON_FEATURES_COMPLEX_FEATURE_H_
#define EXTENSIONS_COMMON_FEATURES_COMPLEX_FEATURE_H_
+#include <set>
#include <string>
#include "base/memory/scoped_vector.h"
diff --git a/extensions/common/features/json_feature_provider_source.cc b/extensions/common/features/json_feature_provider_source.cc
index 0a46f3f8..5b9ee16 100644
--- a/extensions/common/features/json_feature_provider_source.cc
+++ b/extensions/common/features/json_feature_provider_source.cc
@@ -4,8 +4,6 @@
#include "extensions/common/features/json_feature_provider_source.h"
-#include <string>
-
#include "base/json/json_reader.h"
#include "base/logging.h"
#include "ui/base/resource/resource_bundle.h"
@@ -51,4 +49,4 @@ void JSONFeatureProviderSource::LoadJSON(int resource_id) {
dictionary_.MergeDictionary(value_as_dict.get());
}
-} // namespace
+} // namespace extensions
diff --git a/extensions/common/features/json_feature_provider_source.h b/extensions/common/features/json_feature_provider_source.h
index 506b06f..7e41cca 100644
--- a/extensions/common/features/json_feature_provider_source.h
+++ b/extensions/common/features/json_feature_provider_source.h
@@ -2,8 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef EXTENSIONS_COMMON_FEATURE_JSON_FEATURE_PROVIDER_SOURCE_H_
-#define EXTENSIONS_COMMON_FEATURE_JSON_FEATURE_PROVIDER_SOURCE_H_
+#ifndef EXTENSIONS_COMMON_FEATURES_JSON_FEATURE_PROVIDER_SOURCE_H_
+#define EXTENSIONS_COMMON_FEATURES_JSON_FEATURE_PROVIDER_SOURCE_H_
+
+#include <string>
#include "base/values.h"
@@ -34,4 +36,4 @@ class JSONFeatureProviderSource {
} // namespace extensions
-#endif // EXTENSIONS_COMMON_FEATURE_JSON_FEATURE_PROVIDER_SOURCE_H_
+#endif // EXTENSIONS_COMMON_FEATURES_JSON_FEATURE_PROVIDER_SOURCE_H_
diff --git a/extensions/common/features/manifest_feature.h b/extensions/common/features/manifest_feature.h
index 0014f3d..1c0fe0b 100644
--- a/extensions/common/features/manifest_feature.h
+++ b/extensions/common/features/manifest_feature.h
@@ -5,6 +5,8 @@
#ifndef EXTENSIONS_COMMON_FEATURES_MANIFEST_FEATURE_H_
#define EXTENSIONS_COMMON_FEATURES_MANIFEST_FEATURE_H_
+#include <string>
+
#include "extensions/common/features/simple_feature.h"
namespace extensions {
@@ -23,6 +25,6 @@ class ManifestFeature : public SimpleFeature {
virtual std::string Parse(const base::DictionaryValue* value) OVERRIDE;
};
-} // extensions
+} // namespace extensions
#endif // EXTENSIONS_COMMON_FEATURES_MANIFEST_FEATURE_H_
diff --git a/extensions/common/features/permission_feature.h b/extensions/common/features/permission_feature.h
index 0a74ff0..5916fdd 100644
--- a/extensions/common/features/permission_feature.h
+++ b/extensions/common/features/permission_feature.h
@@ -5,6 +5,8 @@
#ifndef EXTENSIONS_COMMON_FEATURES_PERMISSION_FEATURE_H_
#define EXTENSIONS_COMMON_FEATURES_PERMISSION_FEATURE_H_
+#include <string>
+
#include "extensions/common/features/simple_feature.h"
namespace extensions {
@@ -23,6 +25,6 @@ class PermissionFeature : public SimpleFeature {
virtual std::string Parse(const base::DictionaryValue* value) OVERRIDE;
};
-} // extensions
+} // namespace extensions
#endif // EXTENSIONS_COMMON_FEATURES_PERMISSION_FEATURE_H_