diff options
| author | shrikant <shrikant@chromium.org> | 2015-05-05 14:09:03 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 21:09:31 +0000 |
| commit | 832ccd5cc5904f848c0eb6a41e46b1d2cb2f92cc (patch) | |
| tree | d4306d306bc423fec44a932f252e73522f6f7189 | |
| parent | f96f43ab771a6a1b3c2ffe8fee76f7fb4a6a0691 (diff) | |
| download | chromium_src-832ccd5cc5904f848c0eb6a41e46b1d2cb2f92cc.zip chromium_src-832ccd5cc5904f848c0eb6a41e46b1d2cb2f92cc.tar.gz chromium_src-832ccd5cc5904f848c0eb6a41e46b1d2cb2f92cc.tar.bz2 | |
Replacing VerifierTraits with DummyVerifierTraits for non-kernel handles.
Current implicit assumption for VerifierTraits when it is using ActiveVerifier seems to be that these are all one category of handles, espcially kernel handles as it is hooking up CloseHandle API. HDC/Printer Handle/Device Info handle all different from kernel handles.
BUG=475872
R=cpu@chromium.org,grt@chromium.org,wfh@chromium.org,vitalybuka@chromium.org,keybuk@chromium.org, armansito@chromium.org, rpaquay@chromium.org
Review URL: https://codereview.chromium.org/1121233003
Cr-Commit-Position: refs/heads/master@{#328402}
| -rw-r--r-- | base/win/scoped_hdc.h | 2 | ||||
| -rw-r--r-- | device/bluetooth/bluetooth_low_energy_win.cc | 2 | ||||
| -rw-r--r-- | printing/backend/win_helper.h | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/base/win/scoped_hdc.h b/base/win/scoped_hdc.h index 9aead96..2452067 100644 --- a/base/win/scoped_hdc.h +++ b/base/win/scoped_hdc.h @@ -68,7 +68,7 @@ class CreateDCTraits { DISALLOW_IMPLICIT_CONSTRUCTORS(CreateDCTraits); }; -typedef GenericScopedHandle<CreateDCTraits, VerifierTraits> ScopedCreateDC; +typedef GenericScopedHandle<CreateDCTraits, DummyVerifierTraits> ScopedCreateDC; } // namespace win } // namespace base diff --git a/device/bluetooth/bluetooth_low_energy_win.cc b/device/bluetooth/bluetooth_low_energy_win.cc index 59cb437..2201268 100644 --- a/device/bluetooth/bluetooth_low_energy_win.cc +++ b/device/bluetooth/bluetooth_low_energy_win.cc @@ -49,7 +49,7 @@ class DeviceInfoSetTraits { }; typedef base::win::GenericScopedHandle<DeviceInfoSetTraits, - base::win::VerifierTraits> + base::win::DummyVerifierTraits> ScopedDeviceInfoSetHandle; bool StringToBluetoothAddress(const std::string& value, diff --git a/printing/backend/win_helper.h b/printing/backend/win_helper.h index c6665f4..fb7d20c 100644 --- a/printing/backend/win_helper.h +++ b/printing/backend/win_helper.h @@ -44,7 +44,7 @@ class PrinterHandleTraits { class ScopedPrinterHandle : public base::win::GenericScopedHandle<PrinterHandleTraits, - base::win::VerifierTraits> { + base::win::DummyVerifierTraits> { public: bool OpenPrinter(const wchar_t* printer) { HANDLE temp_handle; @@ -57,7 +57,7 @@ class ScopedPrinterHandle private: typedef base::win::GenericScopedHandle<PrinterHandleTraits, - base::win::VerifierTraits> Base; + base::win::DummyVerifierTraits> Base; }; class PrinterChangeHandleTraits { |