diff options
author | sdefresne <sdefresne@chromium.org> | 2015-09-16 05:01:28 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-16 12:01:59 +0000 |
commit | 875d078307b9c4da92f36b9d4d0d4de4a7d8c9be (patch) | |
tree | 514baf91f065ebf2df675326c93d23caf9f2fe86 | |
parent | 40b5b417c5ebcfd5e21132e361bf78658c0ef617 (diff) | |
download | chromium_src-875d078307b9c4da92f36b9d4d0d4de4a7d8c9be.zip chromium_src-875d078307b9c4da92f36b9d4d0d4de4a7d8c9be.tar.gz chromium_src-875d078307b9c4da92f36b9d4d0d4de4a7d8c9be.tar.bz2 |
Componentize PrefSyncableService and support classes.
Create components/syncable_prefs and move PrefSyncableService files,
the support code and the unit tests.
BUG=522544,522537,522536,522532,522530,522527,522526
Review URL: https://codereview.chromium.org/1305213009
Cr-Commit-Position: refs/heads/master@{#349098}
154 files changed, 353 insertions, 217 deletions
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn index 59ea9d9..cefe99b 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn @@ -291,6 +291,7 @@ source_set("browser") { "//components/safe_json", "//components/sessions", "//components/storage_monitor", + "//components/syncable_prefs", "//components/translate/content/browser", "//components/upload_list", "//components/url_matcher", @@ -1040,8 +1041,6 @@ source_set("test_support") { "password_manager/password_manager_test_base.h", "password_manager/test_password_store_service.cc", "password_manager/test_password_store_service.h", - "prefs/pref_service_mock_factory.cc", - "prefs/pref_service_mock_factory.h", "profile_resetter/profile_resetter_test_base.cc", "profile_resetter/profile_resetter_test_base.h", "search_engines/template_url_service_factory_test_util.cc", @@ -1085,6 +1084,7 @@ source_set("test_support") { "//components/invalidation/impl:test_support", "//components/password_manager/core/browser:test_support", "//components/search_engines:test_support", + "//components/syncable_prefs:test_support", "//components/user_prefs/tracked:user_prefs_tracked_test_support", "//content/test:test_support", "//chrome/app/theme:theme_resources", diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS index 73ee578..7093954 100644 --- a/chrome/browser/DEPS +++ b/chrome/browser/DEPS @@ -91,6 +91,7 @@ include_rules = [ "+components/storage_monitor", "+components/suggestions", "+components/sync_driver", + "+components/syncable_prefs", "+components/tracing", "+components/translate/content/browser", "+components/translate/content/common", diff --git a/chrome/browser/apps/drive/drive_app_mapping_unittest.cc b/chrome/browser/apps/drive/drive_app_mapping_unittest.cc index ea24a60..25777aa 100644 --- a/chrome/browser/apps/drive/drive_app_mapping_unittest.cc +++ b/chrome/browser/apps/drive/drive_app_mapping_unittest.cc @@ -6,7 +6,7 @@ #include "base/macros.h" #include "base/memory/scoped_ptr.h" -#include "chrome/test/base/testing_pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" class DriveAppMappingTest : public testing::Test { diff --git a/chrome/browser/autofill/content_autofill_driver_browsertest.cc b/chrome/browser/autofill/content_autofill_driver_browsertest.cc index 71afe9b..8d64dfb 100644 --- a/chrome/browser/autofill/content_autofill_driver_browsertest.cc +++ b/chrome/browser/autofill/content_autofill_driver_browsertest.cc @@ -9,11 +9,11 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/in_process_browser_test.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/autofill/content/browser/content_autofill_driver.h" #include "components/autofill/content/browser/content_autofill_driver_factory.h" #include "components/autofill/core/browser/autofill_manager.h" #include "components/autofill/core/browser/test_autofill_client.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/page_navigator.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc b/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc index b37ccaa..f6d5d7d 100644 --- a/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc +++ b/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc @@ -11,7 +11,6 @@ #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/bookmarks/chrome_bookmark_client.h" #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_node.h" @@ -19,6 +18,7 @@ #include "components/bookmarks/common/bookmark_pref_names.h" #include "components/bookmarks/test/bookmark_test_helpers.h" #include "components/bookmarks/test/mock_bookmark_model_observer.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "grit/components_strings.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc b/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc index 2589b77..d29ebd4 100644 --- a/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc +++ b/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc @@ -16,7 +16,6 @@ #include "chrome/browser/chromeos/preferences.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" #include "chrome/browser/extensions/api/braille_display_private/mock_braille_controller.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" @@ -26,6 +25,7 @@ #include "chrome/test/base/testing_profile.h" #include "chromeos/chromeos_switches.h" #include "chromeos/login/user_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/user_manager.h" #include "content/public/browser/notification_service.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/chromeos/customization/customization_document_unittest.cc b/chrome/browser/chromeos/customization/customization_document_unittest.cc index 256494c..35b60df 100644 --- a/chrome/browser/chromeos/customization/customization_document_unittest.cc +++ b/chrome/browser/chromeos/customization/customization_document_unittest.cc @@ -11,8 +11,6 @@ #include "chrome/browser/chromeos/net/network_portal_detector_test_impl.h" #include "chrome/browser/extensions/external_provider_impl.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/ui/app_list/app_list_syncable_service.h" #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h" #include "chrome/test/base/testing_browser_process.h" @@ -23,6 +21,8 @@ #include "chromeos/network/network_state_handler.h" #include "chromeos/system/fake_statistics_provider.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "extensions/common/extension.h" #include "extensions/common/manifest.h" diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc index 7b5b2b4..bb27bb2 100644 --- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc +++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc @@ -20,8 +20,8 @@ #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" #include "chrome/browser/chromeos/preferences.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chromeos/chromeos_switches.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/user_manager/fake_user_manager.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/aura/window.h" diff --git a/chrome/browser/chromeos/file_system_provider/registry_unittest.cc b/chrome/browser/chromeos/file_system_provider/registry_unittest.cc index 9ce453d..9665dbd 100644 --- a/chrome/browser/chromeos/file_system_provider/registry_unittest.cc +++ b/chrome/browser/chromeos/file_system_provider/registry_unittest.cc @@ -13,9 +13,9 @@ #include "chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/user_prefs/user_prefs.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/chromeos/file_system_provider/service_unittest.cc b/chrome/browser/chromeos/file_system_provider/service_unittest.cc index a84598c..6a8fe39 100644 --- a/chrome/browser/chromeos/file_system_provider/service_unittest.cc +++ b/chrome/browser/chromeos/file_system_provider/service_unittest.cc @@ -20,9 +20,9 @@ #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" #include "chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/user_prefs/user_prefs.h" #include "content/public/test/test_browser_thread_bundle.h" #include "extensions/browser/extension_registry.h" diff --git a/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc b/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc index 5251546..b347007 100644 --- a/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc +++ b/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc @@ -14,7 +14,6 @@ #include "chrome/browser/chromeos/drive/drive_integration_service.h" #include "chrome/browser/chromeos/drive/file_system_util.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" @@ -25,6 +24,7 @@ #include "components/drive/service/test_util.h" #include "components/pref_registry/pref_registry_syncable.h" #include "components/pref_registry/testing_pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/common/url_constants.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/chromeos/first_run/first_run.cc b/chrome/browser/chromeos/first_run/first_run.cc index 73264ef..bbd6c48 100644 --- a/chrome/browser/chromeos/first_run/first_run.cc +++ b/chrome/browser/chromeos/first_run/first_run.cc @@ -10,7 +10,6 @@ #include "chrome/browser/chromeos/first_run/first_run_controller.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" #include "chrome/browser/extensions/extension_service.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ui/extensions/app_launch_params.h" @@ -20,6 +19,7 @@ #include "chrome/common/pref_names.h" #include "chromeos/chromeos_switches.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/user_manager.h" #include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_registrar.h" diff --git a/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc b/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc index 8bb561e..b73f429 100644 --- a/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc +++ b/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc @@ -16,10 +16,10 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "chromeos/chromeos_switches.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/chromeos/input_method/input_method_syncer.cc b/chrome/browser/chromeos/input_method/input_method_syncer.cc index 7190476..61cccf3 100644 --- a/chrome/browser/chromeos/input_method/input_method_syncer.cc +++ b/chrome/browser/chromeos/input_method/input_method_syncer.cc @@ -14,9 +14,9 @@ #include "base/task_runner.h" #include "base/task_runner_util.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/pref_names.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "ui/base/ime/chromeos/component_extension_ime_manager.h" #include "ui/base/ime/chromeos/extension_ime_util.h" diff --git a/chrome/browser/chromeos/input_method/input_method_syncer.h b/chrome/browser/chromeos/input_method/input_method_syncer.h index 20d04fe..e01fffd 100644 --- a/chrome/browser/chromeos/input_method/input_method_syncer.h +++ b/chrome/browser/chromeos/input_method/input_method_syncer.h @@ -10,7 +10,7 @@ #include "base/memory/scoped_ptr.h" #include "base/memory/weak_ptr.h" #include "base/prefs/pref_member.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" #include "ui/base/ime/chromeos/input_method_manager.h" class PrefServiceSyncable; diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc index 9747b0f..58648ec 100644 --- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc +++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc @@ -20,9 +20,9 @@ #include "chrome/common/pref_names.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread_bundle.h" #include "crypto/scoped_test_nss_chromeos_user.h" diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc b/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc index c36f37b..bf501d1 100644 --- a/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc +++ b/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc @@ -13,9 +13,9 @@ #include "chrome/browser/chromeos/login/users/chrome_user_manager.h" #include "chrome/browser/chromeos/login/wizard_controller.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/common/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/user.h" #include "components/user_manager/user_image/default_user_images.h" #include "components/user_manager/user_manager.h" diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h b/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h index 1b34439..d2939f4 100644 --- a/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h +++ b/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h @@ -9,7 +9,7 @@ #include "base/memory/scoped_ptr.h" #include "base/observer_list.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" #include "content/public/browser/notification_observer.h" class PrefChangeRegistrar; diff --git a/chrome/browser/chromeos/login/users/multi_profile_user_controller.cc b/chrome/browser/chromeos/login/users/multi_profile_user_controller.cc index e173300..8b0a90f 100644 --- a/chrome/browser/chromeos/login/users/multi_profile_user_controller.cc +++ b/chrome/browser/chromeos/login/users/multi_profile_user_controller.cc @@ -14,9 +14,9 @@ #include "chrome/browser/chromeos/policy/policy_cert_service.h" #include "chrome/browser/chromeos/policy/policy_cert_service_factory.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/user.h" #include "components/user_manager/user_manager.h" #include "google_apis/gaia/gaia_auth_util.h" diff --git a/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc index f5701af..04c945e 100644 --- a/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc +++ b/chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc @@ -18,9 +18,9 @@ #include "chrome/common/pref_names.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/user_manager/user_manager.h" #include "content/public/test/test_browser_thread_bundle.h" #include "net/cert/x509_certificate.h" diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc index bb0b20d..0d395b5 100644 --- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc +++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc @@ -14,7 +14,6 @@ #include "chrome/browser/chromeos/net/network_portal_detector_impl.h" #include "chrome/browser/chromeos/net/network_portal_detector_test_utils.h" #include "chrome/browser/chromeos/net/network_portal_notification_controller.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/common/pref_names.h" @@ -24,6 +23,7 @@ #include "chromeos/network/portal_detector/network_portal_detector.h" #include "chromeos/network/portal_detector/network_portal_detector_strategy.h" #include "components/captive_portal/captive_portal_testing_utils.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_utils.h" #include "dbus/object_path.h" #include "net/base/net_errors.h" diff --git a/chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc b/chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc index 0d3a9eb..fa0acf2 100644 --- a/chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc +++ b/chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc @@ -19,7 +19,6 @@ #include "chrome/browser/chromeos/policy/enrollment_status_chromeos.h" #include "chrome/browser/chromeos/policy/fake_consumer_management_service.h" #include "chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/signin/signin_manager_factory.h" @@ -28,6 +27,7 @@ #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager_base.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "google_apis/gaia/google_service_auth_error.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc b/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc index 90a21b8..ef3a11a 100644 --- a/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc +++ b/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc @@ -15,14 +15,14 @@ #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/chromeos/policy/recommendation_restorer_factory.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/notification_source.h" diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc index 8790d09..59bbadb 100644 --- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc +++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc @@ -19,7 +19,6 @@ #include "chrome/browser/chromeos/policy/user_cloud_policy_token_forwarder.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/signin/signin_manager_factory.h" @@ -37,6 +36,7 @@ #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/fake_user_manager.h" #include "content/public/test/test_browser_thread_bundle.h" #include "google_apis/gaia/gaia_auth_consumer.h" diff --git a/chrome/browser/chromeos/power/power_prefs_unittest.cc b/chrome/browser/chromeos/power/power_prefs_unittest.cc index dbf34ea..9574f8c 100644 --- a/chrome/browser/chromeos/power/power_prefs_unittest.cc +++ b/chrome/browser/chromeos/power/power_prefs_unittest.cc @@ -16,19 +16,19 @@ #include "chrome/browser/chromeos/profiles/profile_helper.h" #include "chrome/browser/extensions/extension_special_storage_policy.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "chromeos/dbus/fake_power_manager_client.h" #include "chromeos/dbus/power_manager/policy.pb.h" #include "chromeos/dbus/power_policy_controller.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/notification_source.h" diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc index c601805..f938af9 100644 --- a/chrome/browser/chromeos/preferences.cc +++ b/chrome/browser/chromeos/preferences.cc @@ -27,7 +27,6 @@ #include "chrome/browser/chromeos/net/wake_on_wifi_manager.h" #include "chrome/browser/chromeos/system/input_device_settings.h" #include "chrome/browser/download/download_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" @@ -37,6 +36,7 @@ #include "components/drive/drive_pref_names.h" #include "components/feedback/tracing_manager.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/user.h" #include "content/public/browser/browser_thread.h" #include "third_party/icu/source/i18n/unicode/timezone.h" diff --git a/chrome/browser/chromeos/preferences.h b/chrome/browser/chromeos/preferences.h index 4154bc8..9a38e88 100644 --- a/chrome/browser/chromeos/preferences.h +++ b/chrome/browser/chromeos/preferences.h @@ -12,7 +12,7 @@ #include "base/prefs/pref_change_registrar.h" #include "base/prefs/pref_member.h" #include "chrome/browser/chromeos/language_preferences.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" #include "components/user_manager/user_manager.h" #include "ui/base/ime/chromeos/input_method_manager.h" diff --git a/chrome/browser/chromeos/preferences_unittest.cc b/chrome/browser/chromeos/preferences_unittest.cc index 3d391ef..7554ef2 100644 --- a/chrome/browser/chromeos/preferences_unittest.cc +++ b/chrome/browser/chromeos/preferences_unittest.cc @@ -17,9 +17,9 @@ #include "chrome/common/chrome_constants.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" #include "sync/api/attachments/attachment_id.h" diff --git a/chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc b/chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc index 7fcbe8f..200eb1e 100644 --- a/chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc +++ b/chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc @@ -12,7 +12,6 @@ #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h" #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" #include "chrome/browser/chromeos/profiles/profile_helper.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/avatar_menu.h" #include "chrome/browser/profiles/avatar_menu_observer.h" #include "chrome/browser/profiles/profile_info_cache.h" @@ -21,6 +20,7 @@ #include "chrome/common/chrome_switches.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc index 0959493..024627b 100644 --- a/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc +++ b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc @@ -15,12 +15,12 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/content_settings_rule.h" #include "components/content_settings/core/browser/content_settings_utils.h" #include "components/content_settings/core/common/content_settings_pattern.h" #include "components/content_settings/core/test/content_settings_test_utils.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "url/gurl.h" diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc index 397a5e6..3535afb 100644 --- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc +++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc @@ -19,12 +19,9 @@ #include "base/values.h" #include "chrome/browser/content_settings/content_settings_mock_observer.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/content_settings_pref.h" #include "components/content_settings/core/browser/content_settings_registry.h" @@ -34,6 +31,9 @@ #include "components/content_settings/core/common/content_settings_pattern.h" #include "components/content_settings/core/test/content_settings_test_utils.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "url/gurl.h" diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc index 29e5195..d6de1e9 100644 --- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc +++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc @@ -14,13 +14,13 @@ #include "chrome/browser/content_settings/mock_settings_observer.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/content_settings_details.h" #include "components/content_settings/core/browser/cookie_settings.h" #include "components/content_settings/core/browser/host_content_settings_map.h" #include "components/content_settings/core/browser/website_settings_info.h" #include "components/content_settings/core/browser/website_settings_registry.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread.h" #include "net/base/static_cookie_policy.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc index 61da17f..f246291 100644 --- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc +++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc @@ -11,12 +11,12 @@ #include "base/strings/utf_string_conversions.h" #include "base/synchronization/waitable_event.h" #include "chrome/browser/chrome_notification_types.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/custom_handlers/protocol_handler.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/notification_observer.h" #include "content/public/browser/notification_registrar.h" #include "content/public/browser/notification_source.h" diff --git a/chrome/browser/devtools/device/usb/android_rsa.cc b/chrome/browser/devtools/device/usb/android_rsa.cc index df804e4..a8d1f77 100644 --- a/chrome/browser/devtools/device/usb/android_rsa.cc +++ b/chrome/browser/devtools/device/usb/android_rsa.cc @@ -6,9 +6,9 @@ #include "base/base64.h" #include "base/memory/scoped_ptr.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "crypto/rsa_private_key.h" #include "crypto/signature_creator.h" #include "net/cert/asn1_util.h" diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc index 664627c..acc9bb1 100644 --- a/chrome/browser/devtools/devtools_ui_bindings.cc +++ b/chrome/browser/devtools/devtools_ui_bindings.cc @@ -17,7 +17,6 @@ #include "chrome/browser/devtools/devtools_target_impl.h" #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" #include "chrome/browser/infobars/infobar_service.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_iterator.h" @@ -31,6 +30,7 @@ #include "chrome/grit/generated_resources.h" #include "components/infobars/core/confirm_infobar_delegate.h" #include "components/infobars/core/infobar.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/ui/zoom/page_zoom.h" #include "content/public/browser/devtools_external_agent_proxy.h" #include "content/public/browser/devtools_external_agent_proxy_delegate.h" diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc index 2492589..8e617d7 100644 --- a/chrome/browser/devtools/devtools_window.cc +++ b/chrome/browser/devtools/devtools_window.cc @@ -15,7 +15,6 @@ #include "chrome/browser/certificate_viewer.h" #include "chrome/browser/file_select_helper.h" #include "chrome/browser/infobars/infobar_service.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/sessions/session_tab_helper.h" #include "chrome/browser/task_management/web_contents_tags.h" @@ -34,6 +33,7 @@ #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/ui/zoom/page_zoom.h" #include "components/ui/zoom/zoom_controller.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc index 2107730..e466de1 100644 --- a/chrome/browser/download/chrome_download_manager_delegate_unittest.cc +++ b/chrome/browser/download/chrome_download_manager_delegate_unittest.cc @@ -16,8 +16,8 @@ #include "chrome/browser/download/download_target_info.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/download_interrupt_reasons.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" diff --git a/chrome/browser/download/download_target_determiner_unittest.cc b/chrome/browser/download/download_target_determiner_unittest.cc index 53812ab..93268f3 100644 --- a/chrome/browser/download/download_target_determiner_unittest.cc +++ b/chrome/browser/download/download_target_determiner_unittest.cc @@ -22,10 +22,10 @@ #include "chrome/browser/history/history_service_factory.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/history/core/browser/history_service.h" #include "components/history/core/browser/history_types.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/download_interrupt_reasons.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/extensions/activity_log/activity_log.cc b/chrome/browser/extensions/activity_log/activity_log.cc index 346623c..7fa22ae 100644 --- a/chrome/browser/extensions/activity_log/activity_log.cc +++ b/chrome/browser/extensions/activity_log/activity_log.cc @@ -19,7 +19,6 @@ #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h" #include "chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h" #include "chrome/browser/extensions/extension_tab_util.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prerender/prerender_manager.h" #include "chrome/browser/prerender/prerender_manager_factory.h" #include "chrome/browser/profiles/profile.h" @@ -27,6 +26,7 @@ #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" #include "extensions/browser/extension_registry.h" diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc index 12bdc96..c2bc422 100644 --- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc +++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc @@ -27,11 +27,11 @@ #include "chrome/browser/extensions/event_router_forwarder.h" #include "chrome/browser/net/chrome_network_delegate.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/about_handler/about_protocol_handler.h" #include "components/content_settings/core/browser/cookie_settings.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/common/url_constants.h" #include "content/public/test/test_browser_thread_bundle.h" #include "extensions/browser/api/web_request/upload_data_presenter.h" diff --git a/chrome/browser/extensions/component_loader_unittest.cc b/chrome/browser/extensions/component_loader_unittest.cc index cfce964..ebe5392 100644 --- a/chrome/browser/extensions/component_loader_unittest.cc +++ b/chrome/browser/extensions/component_loader_unittest.cc @@ -14,9 +14,9 @@ #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "extensions/browser/extension_registry.h" #include "extensions/common/constants.h" diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc index b589392..7d92e95 100644 --- a/chrome/browser/extensions/extension_prefs_unittest.cc +++ b/chrome/browser/extensions/extension_prefs_unittest.cc @@ -15,9 +15,9 @@ #include "base/strings/stringprintf.h" #include "base/time/time.h" #include "base/values.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_paths.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "content/public/test/mock_notification_observer.h" diff --git a/chrome/browser/extensions/extension_service_test_base.cc b/chrome/browser/extensions/extension_service_test_base.cc index f89098e..e76013a 100644 --- a/chrome/browser/extensions/extension_service_test_base.cc +++ b/chrome/browser/extensions/extension_service_test_base.cc @@ -16,13 +16,13 @@ #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/browser/extensions/updater/extension_updater.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_paths.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_context.h" #include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_registry.h" diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc index 368f1af..fa027ac 100644 --- a/chrome/browser/extensions/extension_service_unittest.cc +++ b/chrome/browser/extensions/extension_service_unittest.cc @@ -66,7 +66,6 @@ #include "chrome/browser/extensions/updater/extension_updater.h" #include "chrome/browser/policy/profile_policy_connector.h" #include "chrome/browser/policy/profile_policy_connector_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/sync/profile_sync_service.h" #include "chrome/browser/sync/profile_sync_service_factory.h" #include "chrome/common/chrome_constants.h" @@ -78,10 +77,11 @@ #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/scoped_browser_locale.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/crx_file/id_util.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/dom_storage_context.h" #include "content/public/browser/gpu_data_manager.h" #include "content/public/browser/indexed_db_context.h" diff --git a/chrome/browser/extensions/external_policy_loader_unittest.cc b/chrome/browser/extensions/external_policy_loader_unittest.cc index 11e7448..22c5bb0 100644 --- a/chrome/browser/extensions/external_policy_loader_unittest.cc +++ b/chrome/browser/extensions/external_policy_loader_unittest.cc @@ -12,8 +12,8 @@ #include "chrome/browser/extensions/extension_management.h" #include "chrome/browser/extensions/external_policy_loader.h" #include "chrome/browser/extensions/external_provider_impl.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread.h" #include "extensions/browser/external_provider_interface.h" #include "extensions/browser/pref_names.h" diff --git a/chrome/browser/extensions/external_pref_loader.cc b/chrome/browser/extensions/external_pref_loader.cc index 9d9aed6..2d734dc 100644 --- a/chrome/browser/extensions/external_pref_loader.cc +++ b/chrome/browser/extensions/external_pref_loader.cc @@ -16,11 +16,11 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/defaults.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/sync/profile_sync_service_factory.h" #include "chrome/common/chrome_paths.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" using content::BrowserThread; diff --git a/chrome/browser/extensions/external_pref_loader.h b/chrome/browser/extensions/external_pref_loader.h index 7e03758..3695a0a 100644 --- a/chrome/browser/extensions/external_pref_loader.h +++ b/chrome/browser/extensions/external_pref_loader.h @@ -12,9 +12,9 @@ #include "base/scoped_observer.h" #include "base/values.h" #include "chrome/browser/extensions/external_loader.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" #include "chrome/browser/sync/profile_sync_service.h" #include "components/sync_driver/sync_service_observer.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" class PrefServiceSyncable; class Profile; diff --git a/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc b/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc index 7a5ca87..93ef499 100644 --- a/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc +++ b/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc @@ -13,7 +13,6 @@ #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h" #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/extension_service_test_base.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" @@ -29,6 +28,7 @@ #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager_base.h" #include "components/sync_driver/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/user_manager/fake_user_manager.h" #include "content/public/browser/notification_service.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc index a9773c1..58f9994 100644 --- a/chrome/browser/extensions/menu_manager_unittest.cc +++ b/chrome/browser/extensions/menu_manager_unittest.cc @@ -15,10 +15,10 @@ #include "chrome/browser/extensions/menu_manager.h" #include "chrome/browser/extensions/test_extension_prefs.h" #include "chrome/browser/extensions/test_extension_system.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/extensions/api/context_menus.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/notification_service.h" #include "content/public/common/context_menu_params.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/extensions/test_extension_prefs.cc b/chrome/browser/extensions/test_extension_prefs.cc index 7784408..0e0529e 100644 --- a/chrome/browser/extensions/test_extension_prefs.cc +++ b/chrome/browser/extensions/test_extension_prefs.cc @@ -18,12 +18,12 @@ #include "base/values.h" #include "chrome/browser/extensions/chrome_app_sorting.h" #include "chrome/browser/extensions/test_extension_system.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/common/chrome_constants.h" #include "components/crx_file/id_util.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "extensions/browser/extension_pref_store.h" #include "extensions/browser/extension_pref_value_map.h" diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc index 59052b5..837e7a9e 100644 --- a/chrome/browser/extensions/updater/extension_updater_unittest.cc +++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc @@ -34,11 +34,11 @@ #include "chrome/browser/extensions/updater/chrome_extension_downloader_factory.h" #include "chrome/browser/extensions/updater/extension_updater.h" #include "chrome/browser/google/google_brand.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "components/crx_file/id_util.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/update_client/update_query_params.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_observer.h" diff --git a/chrome/browser/font_family_cache_unittest.cc b/chrome/browser/font_family_cache_unittest.cc index 0470b27..c11471c 100644 --- a/chrome/browser/font_family_cache_unittest.cc +++ b/chrome/browser/font_family_cache_unittest.cc @@ -5,8 +5,8 @@ #include "chrome/browser/font_family_cache.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/invalidation/invalidator_storage_unittest.cc b/chrome/browser/invalidation/invalidator_storage_unittest.cc index d37588b..815e221 100644 --- a/chrome/browser/invalidation/invalidator_storage_unittest.cc +++ b/chrome/browser/invalidation/invalidator_storage_unittest.cc @@ -6,8 +6,8 @@ #include "base/prefs/pref_service.h" #include "base/strings/string_util.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/invalidation/impl/unacked_invalidation_set_test_util.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" namespace invalidation { diff --git a/chrome/browser/net/chrome_network_delegate_unittest.cc b/chrome/browser/net/chrome_network_delegate_unittest.cc index ea7b8ca..07dac2b 100644 --- a/chrome/browser/net/chrome_network_delegate_unittest.cc +++ b/chrome/browser/net/chrome_network_delegate_unittest.cc @@ -16,11 +16,11 @@ #include "chrome/browser/net/safe_search_util.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/content_settings/core/browser/cookie_settings.h" #include "components/content_settings/core/common/pref_names.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/resource_request_info.h" #include "content/public/common/content_switches.h" #include "content/public/common/resource_type.h" diff --git a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc index 466cc6c..70037c5 100644 --- a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc +++ b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc @@ -11,13 +11,13 @@ #include "base/prefs/testing_pref_store.h" #include "base/values.h" #include "chrome/browser/prefs/command_line_pref_store.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/host_content_settings_map.h" #include "components/content_settings/core/common/content_settings.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread.h" #include "net/socket/ssl_client_socket.h" #include "net/ssl/ssl_config_service.h" diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc index b138c7a..7ea0bb7 100644 --- a/chrome/browser/notifications/extension_welcome_notification.cc +++ b/chrome/browser/notifications/extension_welcome_notification.cc @@ -13,7 +13,6 @@ #include "base/thread_task_runner_handle.h" #include "chrome/browser/browser_process.h" #include "chrome/browser/notifications/notification.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser_navigator.h" @@ -21,6 +20,7 @@ #include "chrome/common/url_constants.h" #include "chrome/grit/generated_resources.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "grit/theme_resources.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" diff --git a/chrome/browser/notifications/extension_welcome_notification.h b/chrome/browser/notifications/extension_welcome_notification.h index 8a46fb9..00bc40c 100644 --- a/chrome/browser/notifications/extension_welcome_notification.h +++ b/chrome/browser/notifications/extension_welcome_notification.h @@ -10,8 +10,8 @@ #include "base/memory/scoped_ptr.h" #include "base/prefs/pref_member.h" #include "base/timer/timer.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" #include "components/keyed_service/core/keyed_service.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" #include "ui/message_center/notifier_settings.h" namespace base { diff --git a/chrome/browser/notifications/extension_welcome_notification_unittest.cc b/chrome/browser/notifications/extension_welcome_notification_unittest.cc index 4197303..85826c3 100644 --- a/chrome/browser/notifications/extension_welcome_notification_unittest.cc +++ b/chrome/browser/notifications/extension_welcome_notification_unittest.cc @@ -16,9 +16,9 @@ #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "sync/api/fake_sync_change_processor.h" #include "sync/api/sync_error_factory_mock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc index 7772ba5..a9b07df 100644 --- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc +++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc @@ -15,7 +15,6 @@ #include "chrome/browser/sync/profile_sync_service_mock.h" #include "chrome/common/channel_info.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/autofill/content/common/autofill_messages.h" #include "components/password_manager/content/browser/password_manager_internals_service_factory.h" @@ -26,6 +25,7 @@ #include "components/password_manager/core/common/credential_manager_types.h" #include "components/password_manager/core/common/password_manager_pref_names.h" #include "components/password_manager/core/common/password_manager_switches.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/version_info/version_info.h" #include "content/public/browser/browser_context.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc index 7a6aa61..cac736a 100644 --- a/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc +++ b/chrome/browser/password_manager/password_store_proxy_mac_unittest.cc @@ -11,12 +11,12 @@ #include "chrome/browser/password_manager/password_store_mac.h" #include "chrome/browser/password_manager/password_store_mac_internal.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/os_crypt/os_crypt.h" #include "components/password_manager/core/browser/login_database.h" #include "components/password_manager/core/browser/password_manager_test_utils.h" #include "components/password_manager/core/browser/password_store_consumer.h" #include "components/password_manager/core/common/password_manager_pref_names.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread_bundle.h" #include "crypto/mock_apple_keychain.h" diff --git a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc index 6d85e97..6bd1987 100644 --- a/chrome/browser/plugins/plugin_info_message_filter_unittest.cc +++ b/chrome/browser/plugins/plugin_info_message_filter_unittest.cc @@ -12,9 +12,9 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/common/pref_names.h" #include "chrome/common/render_messages.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/content_settings/core/browser/host_content_settings_map.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/plugin_service.h" #include "content/public/browser/plugin_service_filter.h" #include "content/public/browser/render_process_host.h" diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc index 6473b1e..bd3fd0a 100644 --- a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc +++ b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc @@ -23,7 +23,6 @@ #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/browser/signin/test_signin_client_builder.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/policy/core/browser/browser_policy_connector.h" #include "components/policy/core/common/cloud/cloud_external_data_manager.h" @@ -36,6 +35,7 @@ #include "components/signin/core/browser/fake_account_fetcher_service.h" #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_context.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_service.h" diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc index 0e55d16..4b5f8b5 100644 --- a/chrome/browser/prefs/browser_prefs.cc +++ b/chrome/browser/prefs/browser_prefs.cc @@ -43,7 +43,6 @@ #include "chrome/browser/plugins/plugin_finder.h" #include "chrome/browser/prefs/chrome_pref_service_factory.h" #include "chrome/browser/prefs/incognito_mode_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/session_startup_pref.h" #include "chrome/browser/profiles/chrome_version_service.h" #include "chrome/browser/profiles/profile.h" @@ -87,6 +86,7 @@ #include "components/rappor/rappor_service.h" #include "components/search_engines/template_url_prepopulate_data.h" #include "components/sync_driver/sync_prefs.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/translate/core/browser/translate_prefs.h" #include "components/variations/service/variations_service.h" #include "components/web_resource/promo_resource_service.h" diff --git a/chrome/browser/prefs/chrome_pref_model_associator_client.h b/chrome/browser/prefs/chrome_pref_model_associator_client.h index a841506..3895aea 100644 --- a/chrome/browser/prefs/chrome_pref_model_associator_client.h +++ b/chrome/browser/prefs/chrome_pref_model_associator_client.h @@ -8,7 +8,7 @@ #include <string> #include "base/macros.h" -#include "chrome/browser/prefs/pref_model_associator_client.h" +#include "components/syncable_prefs/pref_model_associator_client.h" namespace base { template <typename T> diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc index 92dd281..c1935c9 100644 --- a/chrome/browser/prefs/chrome_pref_service_factory.cc +++ b/chrome/browser/prefs/chrome_pref_service_factory.cc @@ -27,9 +27,6 @@ #include "chrome/browser/browser_process.h" #include "chrome/browser/prefs/chrome_pref_model_associator_client.h" #include "chrome/browser/prefs/command_line_pref_store.h" -#include "chrome/browser/prefs/pref_model_associator.h" -#include "chrome/browser/prefs/pref_service_syncable.h" -#include "chrome/browser/prefs/pref_service_syncable_factory.h" #include "chrome/browser/prefs/profile_pref_store_manager.h" #include "chrome/browser/profiles/file_path_verifier_win.h" #include "chrome/browser/profiles/profile.h" @@ -45,6 +42,9 @@ #include "components/search_engines/default_search_pref_migration.h" #include "components/search_engines/search_engines_pref_names.h" #include "components/sync_driver/pref_names.h" +#include "components/syncable_prefs/pref_model_associator.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable_factory.h" #include "components/user_prefs/tracked/pref_names.h" #include "content/public/browser/browser_context.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc index 49a0a7b..4f8ec87 100644 --- a/chrome/browser/prefs/chrome_pref_service_unittest.cc +++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc @@ -13,16 +13,16 @@ #include "base/values.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/browser/prefs/command_line_pref_store.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/policy/core/browser/configuration_policy_pref_store.h" #include "components/policy/core/common/mock_configuration_policy_provider.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/common/web_preferences.h" #include "content/public/test/test_renderer_host.h" #include "ui/base/test/data/resource.h" diff --git a/chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc b/chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc index c28d78c..eff0459 100644 --- a/chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc +++ b/chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc @@ -11,9 +11,9 @@ #include "base/prefs/pref_registry_simple.h" #include "base/prefs/pref_service.h" #include "chrome/browser/prefs/command_line_pref_store.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" #include "chrome/common/chrome_switches.h" #include "components/proxy_config/pref_proxy_config_tracker_impl.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" #include "net/proxy/proxy_config_service_common_unittest.h" #include "url/gurl.h" diff --git a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc index ccbb489..3f45d4ee 100644 --- a/chrome/browser/prefs/incognito_mode_prefs_unittest.cc +++ b/chrome/browser/prefs/incognito_mode_prefs_unittest.cc @@ -5,7 +5,7 @@ #include "chrome/browser/prefs/incognito_mode_prefs.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" class IncognitoModePrefsTest : public testing::Test { diff --git a/chrome/browser/prefs/pref_functional_browsertest.cc b/chrome/browser/prefs/pref_functional_browsertest.cc index 877ffe9..0127db2 100644 --- a/chrome/browser/prefs/pref_functional_browsertest.cc +++ b/chrome/browser/prefs/pref_functional_browsertest.cc @@ -7,7 +7,6 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/download/download_prefs.h" #include "chrome/browser/net/prediction_options.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" @@ -20,6 +19,7 @@ #include "components/content_settings/core/browser/website_settings_info.h" #include "components/content_settings/core/browser/website_settings_registry.h" #include "components/content_settings/core/common/content_settings_types.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/web_contents.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/download_test_observer.h" diff --git a/chrome/browser/prefs/pref_metrics_service.cc b/chrome/browser/prefs/pref_metrics_service.cc index 1caea54..644bc27 100644 --- a/chrome/browser/prefs/pref_metrics_service.cc +++ b/chrome/browser/prefs/pref_metrics_service.cc @@ -11,10 +11,8 @@ #include "base/prefs/pref_service.h" #include "base/strings/string_number_conversions.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/prefs/session_startup_pref.h" -#include "chrome/browser/prefs/synced_pref_change_registrar.h" #include "chrome/browser/profiles/incognito_helpers.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/search_engines/template_url_service_factory.h" @@ -24,6 +22,8 @@ #include "components/keyed_service/content/browser_context_dependency_manager.h" #include "components/rappor/rappor_utils.h" #include "components/search_engines/template_url_prepopulate_data.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/synced_pref_change_registrar.h" #include "content/public/browser/browser_url_handler.h" #include "crypto/hmac.h" #include "net/base/registry_controlled_domains/registry_controlled_domain.h" diff --git a/chrome/browser/prefs/pref_metrics_service.h b/chrome/browser/prefs/pref_metrics_service.h index cab53e1..eb1c508 100644 --- a/chrome/browser/prefs/pref_metrics_service.h +++ b/chrome/browser/prefs/pref_metrics_service.h @@ -11,10 +11,10 @@ #include "base/memory/scoped_ptr.h" #include "base/memory/singleton.h" #include "base/memory/weak_ptr.h" -#include "chrome/browser/prefs/synced_pref_change_registrar.h" #include "chrome/browser/profiles/profile.h" #include "components/keyed_service/content/browser_context_keyed_service_factory.h" #include "components/keyed_service/core/keyed_service.h" +#include "components/syncable_prefs/synced_pref_change_registrar.h" class PrefRegistrySimple; diff --git a/chrome/browser/prefs/pref_service_syncable_util.cc b/chrome/browser/prefs/pref_service_syncable_util.cc index eac0df9..1beb4308 100644 --- a/chrome/browser/prefs/pref_service_syncable_util.cc +++ b/chrome/browser/prefs/pref_service_syncable_util.cc @@ -8,9 +8,9 @@ #include "base/logging.h" #include "build/build_config.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/common/pref_names.h" +#include "components/syncable_prefs/pref_service_syncable.h" #if defined(OS_ANDROID) || defined(OS_IOS) #include "components/proxy_config/proxy_config_pref_names.h" diff --git a/chrome/browser/prefs/proxy_policy_unittest.cc b/chrome/browser/prefs/proxy_policy_unittest.cc index 0bb5d35..5ec8013 100644 --- a/chrome/browser/prefs/proxy_policy_unittest.cc +++ b/chrome/browser/prefs/proxy_policy_unittest.cc @@ -10,8 +10,6 @@ #include "chrome/browser/browser_process.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/browser/prefs/command_line_pref_store.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/common/chrome_switches.h" #include "components/policy/core/common/external_data_fetcher.h" #include "components/policy/core/common/mock_configuration_policy_provider.h" @@ -20,6 +18,8 @@ #include "components/pref_registry/pref_registry_syncable.h" #include "components/proxy_config/proxy_config_dictionary.h" #include "components/proxy_config/proxy_config_pref_names.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "policy/policy_constants.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/prefs/session_startup_pref_unittest.cc b/chrome/browser/prefs/session_startup_pref_unittest.cc index 06dc1bf..a2f2713 100644 --- a/chrome/browser/prefs/session_startup_pref_unittest.cc +++ b/chrome/browser/prefs/session_startup_pref_unittest.cc @@ -4,8 +4,8 @@ #include "chrome/browser/prefs/session_startup_pref.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc index 3264a9e..29942ba 100644 --- a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc +++ b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc @@ -9,12 +9,12 @@ #include "base/time/time.h" #include "base/values.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" -#include "chrome/browser/prefs/synced_pref_change_registrar.h" #include "chrome/browser/ui/browser.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/in_process_browser_test.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/synced_pref_change_registrar.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_utils.h" #include "sync/api/attachments/attachment_id.h" #include "sync/api/fake_sync_change_processor.h" diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc index ed618e2..293dcfc 100644 --- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc +++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc @@ -21,9 +21,9 @@ #include "chrome/common/pref_names.h" #include "chrome/common/service_messages.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc index 768c431..3cf6828 100644 --- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc +++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc @@ -34,9 +34,9 @@ #include "chrome/test/base/test_launcher_utils.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_io_thread_state.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/notification_service.h" #include "content/public/common/content_paths.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc b/chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc index 303f030..9214100 100644 --- a/chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc +++ b/chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc @@ -31,11 +31,11 @@ #include "chrome/browser/ui/global_error/global_error_service.h" #include "chrome/browser/ui/global_error/global_error_service_factory.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/default_search_manager.h" #include "components/search_engines/template_url_prepopulate_data.h" #include "components/search_engines/template_url_service.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/notification_service.h" #include "net/http/http_response_headers.h" #include "net/url_request/test_url_fetcher_factory.h" diff --git a/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc b/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc index a818494..873ce05 100644 --- a/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc +++ b/chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc @@ -22,9 +22,9 @@ #include "chrome/browser/profile_resetter/jtl_instructions.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/variations/variations_associated_data.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/profiles/gaia_info_update_service_unittest.cc b/chrome/browser/profiles/gaia_info_update_service_unittest.cc index 2a812cd..3d741bd 100644 --- a/chrome/browser/profiles/gaia_info_update_service_unittest.cc +++ b/chrome/browser/profiles/gaia_info_update_service_unittest.cc @@ -7,7 +7,6 @@ #include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_downloader.h" #include "chrome/browser/profiles/profile_info_cache.h" #include "chrome/browser/profiles/profile_info_cache_unittest.h" @@ -21,6 +20,7 @@ #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/signin/core/browser/account_tracker_service.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "testing/gmock/include/gmock/gmock.h" #include "ui/gfx/image/image.h" #include "ui/gfx/image/image_unittest_util.h" diff --git a/chrome/browser/profiles/off_the_record_profile_impl.cc b/chrome/browser/profiles/off_the_record_profile_impl.cc index 9d9876a..ce1ad8e 100644 --- a/chrome/browser/profiles/off_the_record_profile_impl.cc +++ b/chrome/browser/profiles/off_the_record_profile_impl.cc @@ -28,7 +28,6 @@ #include "chrome/browser/plugins/chrome_plugin_service_filter.h" #include "chrome/browser/plugins/plugin_prefs.h" #include "chrome/browser/prefs/incognito_mode_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ssl/chrome_ssl_host_state_delegate.h" @@ -42,6 +41,7 @@ #include "components/content_settings/core/browser/host_content_settings_map.h" #include "components/keyed_service/content/browser_context_dependency_manager.h" #include "components/proxy_config/pref_proxy_config_tracker.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/ui/zoom/zoom_event_manager.h" #include "components/user_prefs/user_prefs.h" #include "content/public/browser/browser_thread.h" diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc index 296751fd..6f41813 100644 --- a/chrome/browser/profiles/profile_impl.cc +++ b/chrome/browser/profiles/profile_impl.cc @@ -51,7 +51,6 @@ #include "chrome/browser/policy/profile_policy_connector_factory.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/browser/prefs/chrome_pref_service_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/prerender/prerender_manager_factory.h" #include "chrome/browser/profiles/bookmark_model_loaded_observer.h" @@ -89,6 +88,7 @@ #include "components/pref_registry/pref_registry_syncable.h" #include "components/proxy_config/pref_proxy_config_tracker.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/ui/zoom/zoom_event_manager.h" #include "components/url_formatter/url_fixer.h" #include "components/user_prefs/tracked/tracked_preference_validation_delegate.h" diff --git a/chrome/browser/profiles/profile_info_cache_unittest.cc b/chrome/browser/profiles/profile_info_cache_unittest.cc index 8bb17c4..d6e7b53 100644 --- a/chrome/browser/profiles/profile_info_cache_unittest.cc +++ b/chrome/browser/profiles/profile_info_cache_unittest.cc @@ -13,7 +13,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_avatar_downloader.h" #include "chrome/browser/profiles/profile_avatar_icon_util.h" #include "chrome/browser/profiles/profile_info_cache.h" @@ -23,6 +22,7 @@ #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" #include "components/signin/core/common/profile_management_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" #include "third_party/skia/include/core/SkBitmap.h" diff --git a/chrome/browser/profiles/profile_list_desktop_unittest.cc b/chrome/browser/profiles/profile_list_desktop_unittest.cc index 0844dd9..bd79226 100644 --- a/chrome/browser/profiles/profile_list_desktop_unittest.cc +++ b/chrome/browser/profiles/profile_list_desktop_unittest.cc @@ -11,7 +11,6 @@ #include "base/metrics/field_trial.h" #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/avatar_menu_observer.h" #include "chrome/browser/profiles/profile_info_cache.h" #include "chrome/browser/profiles/profiles_state.h" @@ -19,6 +18,7 @@ #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/signin/core/common/profile_management_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/l10n/l10n_util.h" diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc index 601086f..ba50384 100644 --- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc +++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc @@ -24,9 +24,9 @@ #include "chrome/common/pref_names.h" #include "chrome/common/safe_browsing/csd.pb.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "net/url_request/url_request_context_getter.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc index 4000fae..af77ab1 100644 --- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc +++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc @@ -28,7 +28,6 @@ #include "chrome/common/pref_names.h" #include "chrome/common/safe_browsing/csd.pb.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/history/content/browser/content_visit_delegate.h" @@ -39,6 +38,7 @@ #include "components/history/core/browser/history_constants.h" #include "components/history/core/browser/history_database_params.h" #include "components/history/core/browser/history_service.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc index 2e98760..87a92dc 100644 --- a/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc +++ b/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc @@ -24,7 +24,6 @@ #include "chrome/browser/safe_browsing/test_database_manager.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/history/content/browser/content_visit_delegate.h" @@ -34,6 +33,7 @@ #include "components/history/core/browser/history_service.h" #include "components/history/core/browser/history_types.h" #include "components/keyed_service/core/service_access_type.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/resource_request_info.h" #include "content/public/common/resource_type.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc index 055ef58..0627189 100644 --- a/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc +++ b/chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc @@ -13,10 +13,10 @@ #include "base/win/registry.h" #include "chrome/browser/prefs/browser_prefs.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" namespace safe_browsing { diff --git a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc index 9862d31..c714c27 100644 --- a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc +++ b/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc @@ -13,8 +13,6 @@ #include "base/thread_task_runner_handle.h" #include "base/values.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" -#include "chrome/browser/prefs/pref_service_syncable_factory.h" #include "chrome/browser/safe_browsing/incident_reporting/incident.h" #include "chrome/browser/safe_browsing/incident_reporting/platform_state_store.h" #include "chrome/common/pref_names.h" @@ -22,6 +20,8 @@ #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable_factory.h" #include "testing/gtest/include/gtest/gtest.h" #if defined(OS_WIN) diff --git a/chrome/browser/search_engines/search_provider_install_data_unittest.cc b/chrome/browser/search_engines/search_provider_install_data_unittest.cc index 8a72aee..3abdf06 100644 --- a/chrome/browser/search_engines/search_provider_install_data_unittest.cc +++ b/chrome/browser/search_engines/search_provider_install_data_unittest.cc @@ -13,11 +13,11 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/search_engines/search_provider_install_data.h" #include "chrome/browser/search_engines/template_url_service_test_util.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/search_terms_data.h" #include "components/search_engines/template_url.h" #include "components/search_engines/template_url_service.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/mock_render_process_host.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/search_engines/template_url_service_factory_test_util.cc b/chrome/browser/search_engines/template_url_service_factory_test_util.cc index b4bba85..c0d50d7 100644 --- a/chrome/browser/search_engines/template_url_service_factory_test_util.cc +++ b/chrome/browser/search_engines/template_url_service_factory_test_util.cc @@ -6,10 +6,10 @@ #include "base/run_loop.h" #include "chrome/browser/search_engines/template_url_service_factory.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/default_search_pref_test_util.h" #include "components/search_engines/template_url_service.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" TemplateURLServiceFactoryTestUtil::TemplateURLServiceFactoryTestUtil( TestingProfile* profile) diff --git a/chrome/browser/search_engines/template_url_service_test_util.cc b/chrome/browser/search_engines/template_url_service_test_util.cc index 2829f69..608cc6a 100644 --- a/chrome/browser/search_engines/template_url_service_test_util.cc +++ b/chrome/browser/search_engines/template_url_service_test_util.cc @@ -8,13 +8,13 @@ #include "base/thread_task_runner_handle.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/search_engines/chrome_template_url_service_client.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/default_search_pref_test_util.h" #include "components/search_engines/keyword_table.h" #include "components/search_engines/keyword_web_data_service.h" #include "components/search_engines/template_url_service.h" #include "components/search_engines/testing_search_terms_data.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/webdata/common/web_database_service.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/signin/account_reconcilor_unittest.cc b/chrome/browser/signin/account_reconcilor_unittest.cc index 3b17a24..6c89dc0 100644 --- a/chrome/browser/signin/account_reconcilor_unittest.cc +++ b/chrome/browser/signin/account_reconcilor_unittest.cc @@ -9,7 +9,6 @@ #include "base/test/histogram_tester.h" #include "base/time/time.h" #include "build/build_config.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/account_reconcilor_factory.h" #include "chrome/browser/signin/account_tracker_service_factory.h" #include "chrome/browser/signin/chrome_signin_client_factory.h" @@ -32,6 +31,7 @@ #include "components/signin/core/browser/test_signin_client.h" #include "components/signin/core/common/profile_management_switches.h" #include "components/signin/core/common/signin_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "google_apis/gaia/fake_oauth2_token_service_delegate.h" #include "google_apis/gaia/gaia_constants.h" diff --git a/chrome/browser/signin/cross_device_promo_factory.cc b/chrome/browser/signin/cross_device_promo_factory.cc index 6b8d34a..c1fd7d6 100644 --- a/chrome/browser/signin/cross_device_promo_factory.cc +++ b/chrome/browser/signin/cross_device_promo_factory.cc @@ -5,7 +5,6 @@ #include "chrome/browser/signin/cross_device_promo_factory.h" #include "base/prefs/pref_service.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/signin/chrome_signin_client_factory.h" #include "chrome/browser/signin/cross_device_promo.h" @@ -15,6 +14,7 @@ #include "components/keyed_service/content/browser_context_dependency_manager.h" #include "components/pref_registry/pref_registry_syncable.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "google_apis/gaia/gaia_constants.h" CrossDevicePromoFactory::CrossDevicePromoFactory() diff --git a/chrome/browser/signin/cross_device_promo_unittest.cc b/chrome/browser/signin/cross_device_promo_unittest.cc index fb2827d..aa7b51b 100644 --- a/chrome/browser/signin/cross_device_promo_unittest.cc +++ b/chrome/browser/signin/cross_device_promo_unittest.cc @@ -8,7 +8,6 @@ #include "base/run_loop.h" #include "base/test/histogram_tester.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/chrome_signin_client_factory.h" #include "chrome/browser/signin/cross_device_promo_factory.h" #include "chrome/browser/signin/fake_gaia_cookie_manager_service.h" @@ -18,12 +17,13 @@ #include "chrome/browser/signin/test_signin_client_builder.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/signin/core/browser/signin_manager.h" #include "components/signin/core/browser/signin_metrics.h" #include "components/signin/core/browser/test_signin_client.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/variations/entropy_provider.h" #include "components/variations/variations_associated_data.h" #include "content/public/test/test_browser_thread_bundle.h" diff --git a/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc b/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc index 8c8ccaa..ffd15e0 100644 --- a/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc +++ b/chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc @@ -18,11 +18,11 @@ #include "chrome/browser/signin/easy_unlock_service_regular.h" #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chromeos/dbus/dbus_thread_manager.h" #include "chromeos/dbus/fake_power_manager_client.h" #include "components/signin/core/browser/signin_manager_base.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "device/bluetooth/bluetooth_adapter_factory.h" #include "device/bluetooth/test/mock_bluetooth_adapter.h" diff --git a/chrome/browser/signin/local_auth_unittest.cc b/chrome/browser/signin/local_auth_unittest.cc index a675290..e647cce 100644 --- a/chrome/browser/signin/local_auth_unittest.cc +++ b/chrome/browser/signin/local_auth_unittest.cc @@ -8,10 +8,10 @@ #include "base/prefs/pref_service.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/os_crypt/os_crypt.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/signin/signin_global_error_unittest.cc b/chrome/browser/signin/signin_global_error_unittest.cc index 783aa31..dfd1cf0 100644 --- a/chrome/browser/signin/signin_global_error_unittest.cc +++ b/chrome/browser/signin/signin_global_error_unittest.cc @@ -8,7 +8,6 @@ #include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" #include "base/test/histogram_tester.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_info_cache.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/profiles/profile_metrics.h" @@ -27,6 +26,7 @@ #include "components/signin/core/browser/fake_auth_status_provider.h" #include "components/signin/core/browser/signin_error_controller.h" #include "components/signin/core/browser/signin_manager.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc b/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc index b9a8ab2e..8c6c64b 100644 --- a/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc +++ b/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc @@ -16,8 +16,8 @@ #include "chrome/browser/supervised_user/legacy/supervised_user_sync_service.h" #include "chrome/browser/supervised_user/legacy/supervised_user_sync_service_factory.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_utils.h" #include "google_apis/gaia/google_service_auth_error.h" diff --git a/chrome/browser/sync/chrome_sync_client.cc b/chrome/browser/sync/chrome_sync_client.cc index 4347890..e697e4c 100644 --- a/chrome/browser/sync/chrome_sync_client.cc +++ b/chrome/browser/sync/chrome_sync_client.cc @@ -9,7 +9,6 @@ #include "chrome/browser/dom_distiller/dom_distiller_service_factory.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/password_manager/password_store_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/search_engines/template_url_service_factory.h" @@ -28,6 +27,7 @@ #include "components/dom_distiller/core/dom_distiller_service.h" #include "components/history/core/browser/history_service.h" #include "components/password_manager/core/browser/password_store.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/browser_thread.h" #if defined(ENABLE_APP_LIST) diff --git a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc index 3723793..88d4e4a 100644 --- a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc +++ b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc @@ -14,7 +14,6 @@ #include "base/test/test_timeouts.h" #include "chrome/browser/chrome_notification_types.h" #include "chrome/browser/invalidation/profile_invalidation_provider_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" @@ -25,6 +24,7 @@ #include "components/sync_driver/device_info.h" #include "components/sync_driver/sync_frontend.h" #include "components/sync_driver/sync_prefs.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/notification_service.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc index 89499f6..318f894 100644 --- a/chrome/browser/sync/profile_sync_service.cc +++ b/chrome/browser/sync/profile_sync_service.cc @@ -33,7 +33,6 @@ #include "chrome/browser/net/chrome_cookie_notification_details.h" #include "chrome/browser/password_manager/password_store_factory.h" #include "chrome/browser/prefs/chrome_pref_service_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/signin/about_signin_internals_factory.h" #include "chrome/browser/signin/chrome_signin_client_factory.h" @@ -80,6 +79,7 @@ #include "components/sync_driver/sync_util.h" #include "components/sync_driver/system_encryptor.h" #include "components/sync_driver/user_selectable_sync_type.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/version_info/version_info_values.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/notification_details.h" diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc index 90a7711..34235af 100644 --- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc @@ -22,7 +22,6 @@ #include "base/synchronization/waitable_event.h" #include "base/time/time.h" #include "chrome/browser/autofill/personal_data_manager_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/account_tracker_service_factory.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" @@ -51,6 +50,7 @@ #include "components/signin/core/browser/signin_manager.h" #include "components/sync_driver/data_type_controller.h" #include "components/sync_driver/fake_sync_client.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "components/webdata/common/web_database.h" #include "components/webdata_services/web_data_service_test_util.h" #include "content/public/test/test_browser_thread.h" diff --git a/chrome/browser/sync/profile_sync_service_startup_unittest.cc b/chrome/browser/sync/profile_sync_service_startup_unittest.cc index 8ddccd5..b4defd9 100644 --- a/chrome/browser/sync/profile_sync_service_startup_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_startup_unittest.cc @@ -6,7 +6,6 @@ #include "base/memory/scoped_ptr.h" #include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/account_tracker_service_factory.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/fake_signin_manager_builder.h" @@ -30,6 +29,7 @@ #include "components/sync_driver/data_type_manager_mock.h" #include "components/sync_driver/pref_names.h" #include "components/sync_driver/sync_prefs.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" #include "google_apis/gaia/gaia_auth_consumer.h" diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc index d59e7a7..76f6faf 100644 --- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc @@ -22,7 +22,6 @@ #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/invalidation/fake_invalidation_service.h" #include "chrome/browser/invalidation/profile_invalidation_provider_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/account_tracker_service_factory.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" @@ -54,6 +53,7 @@ #include "components/signin/core/browser/signin_manager.h" #include "components/sync_driver/data_type_error_handler_mock.h" #include "components/sync_driver/glue/typed_url_model_associator.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/notification_service.h" #include "google_apis/gaia/gaia_constants.h" #include "sync/internal_api/public/read_node.h" diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc index 64f8127..f9532c4 100644 --- a/chrome/browser/sync/profile_sync_service_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_unittest.cc @@ -27,7 +27,6 @@ #include "chrome/common/pref_names.h" #include "chrome/grit/generated_resources.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/invalidation/impl/profile_invalidation_provider.h" @@ -45,6 +44,7 @@ #include "components/sync_driver/sync_prefs.h" #include "components/sync_driver/sync_service_observer.h" #include "components/sync_driver/sync_util.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/version_info/version_info_values.h" #include "content/public/test/test_browser_thread_bundle.h" #include "google_apis/gaia/gaia_constants.h" diff --git a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc index 51b3afb..d24bfa3 100644 --- a/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc +++ b/chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc @@ -13,10 +13,10 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/sync/profile_sync_service_mock.h" #include "chrome/browser/ui/app_list/app_list_test_util.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/suggestions/proto/suggestions.pb.h" #include "components/suggestions/suggestions_store.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/app_list/search_result.h" diff --git a/chrome/browser/ui/app_list/speech_auth_helper_unittest.cc b/chrome/browser/ui/app_list/speech_auth_helper_unittest.cc index 2ff97b6..0b06c18 100644 --- a/chrome/browser/ui/app_list/speech_auth_helper_unittest.cc +++ b/chrome/browser/ui/app_list/speech_auth_helper_unittest.cc @@ -9,7 +9,6 @@ #include "base/memory/scoped_ptr.h" #include "base/strings/utf_string_conversions.h" #include "base/test/simple_test_clock.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" #include "chrome/browser/signin/signin_manager_factory.h" @@ -19,6 +18,7 @@ #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" #include "components/signin/core/browser/signin_manager_base.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "google_apis/gaia/google_service_auth_error.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc index 2882397..806e26f 100644 --- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc +++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc @@ -32,7 +32,6 @@ #include "chrome/browser/extensions/extension_util.h" #include "chrome/browser/extensions/launch_util.h" #include "chrome/browser/prefs/incognito_mode_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" @@ -69,6 +68,7 @@ #include "chrome/common/url_constants.h" #include "chrome/grit/generated_resources.h" #include "components/favicon/content/content_favicon_driver.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/web_contents.h" #include "extensions/browser/extension_prefs.h" diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h index 525c2c1..0c48e45 100644 --- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h +++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h @@ -26,11 +26,11 @@ #include "base/memory/scoped_vector.h" #include "base/prefs/pref_change_registrar.h" #include "chrome/browser/extensions/app_icon_loader.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" #include "chrome/browser/ui/ash/app_sync_ui_state_observer.h" #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h" #include "chrome/browser/ui/ash/launcher/chrome_launcher_types.h" #include "chrome/browser/ui/extensions/extension_enable_flow_delegate.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" #include "extensions/browser/extension_registry_observer.h" #include "extensions/common/constants.h" #include "ui/aura/window_observer.h" diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc index 370a08a..e10c952 100644 --- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc +++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc @@ -37,8 +37,8 @@ #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/browser_with_test_window_test.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/web_contents.h" #include "extensions/common/extension.h" #include "extensions/common/manifest_constants.h" diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc index fa3dea4..1b5a723 100644 --- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc @@ -15,11 +15,11 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/bookmarks/bookmark_utils.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_node.h" #include "components/bookmarks/test/bookmark_test_helpers.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/browser/page_navigator.h" #include "content/public/test/test_browser_thread.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc index 074cae5..32ad377 100644 --- a/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc +++ b/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc @@ -6,7 +6,6 @@ #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/defaults.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/search/search.h" #include "chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h" @@ -15,6 +14,7 @@ #include "chrome/browser/ui/webui/ntp/new_tab_ui.h" #include "chrome/common/pref_names.h" #include "components/bookmarks/browser/bookmark_model.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/browser/navigation_entry.h" #include "content/public/browser/web_contents.h" diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm index 6c47aaa..3d97538 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm @@ -26,11 +26,11 @@ #import "chrome/browser/ui/cocoa/view_resizer_pong.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_utils.h" #include "components/bookmarks/test/bookmark_test_helpers.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" #import "testing/gtest_mac.h" #include "testing/platform_test.h" diff --git a/chrome/browser/ui/cocoa/cocoa_profile_test.mm b/chrome/browser/ui/cocoa/cocoa_profile_test.mm index 10b9269..de1f9cc 100644 --- a/chrome/browser/ui/cocoa/cocoa_profile_test.mm +++ b/chrome/browser/ui/cocoa/cocoa_profile_test.mm @@ -9,7 +9,6 @@ #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/search_engines/template_url_service_factory.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" @@ -19,6 +18,7 @@ #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/test/bookmark_test_helpers.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" CocoaProfileTest::CocoaProfileTest() diff --git a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm index efd6934..ad410bc 100644 --- a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm @@ -9,7 +9,6 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/search_engines/template_url_service_factory.h" #include "chrome/browser/supervised_user/supervised_user_service.h" #include "chrome/browser/supervised_user/supervised_user_service_factory.h" @@ -24,6 +23,7 @@ #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/test/bookmark_test_helpers.h" #include "components/signin/core/common/profile_management_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" class AvatarIconControllerTest : public CocoaProfileTest { public: diff --git a/chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm index 475e5e8..79fbcf3 100644 --- a/chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm @@ -9,7 +9,6 @@ #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_pump_mac.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/avatar_menu.h" #include "chrome/browser/profiles/avatar_menu_observer.h" #include "chrome/browser/profiles/profile_info_cache.h" @@ -17,6 +16,7 @@ #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile_manager.h" #include "components/signin/core/common/profile_management_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest_mac.h" #import "ui/base/cocoa/controls/hyperlink_button_cell.h" diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm index bbc867c..3a9969ee 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm @@ -10,7 +10,6 @@ #include "base/memory/scoped_ptr.h" #include "base/strings/sys_string_conversions.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/avatar_menu.h" #include "chrome/browser/profiles/profile_info_cache.h" #include "chrome/browser/services/gcm/fake_gcm_profile_service.h" @@ -31,6 +30,7 @@ #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" #include "components/signin/core/common/profile_management_switches.h" +#include "components/syncable_prefs/pref_service_syncable.h" const std::string kGaiaId = "gaiaid-user@gmail.com"; const std::string kEmail = "user@gmail.com"; diff --git a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm index 6d70168..98f0dc7 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm @@ -8,7 +8,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/threading/thread_restrictions.h" #include "chrome/browser/browser_process.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/cocoa/cocoa_profile_test.h" @@ -17,6 +16,7 @@ #include "chrome/grit/generated_resources.h" #include "chrome/test/base/test_browser_window.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "testing/gtest_mac.h" #include "ui/base/l10n/l10n_util_mac.h" diff --git a/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc b/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc index 382c20d..4bfa749 100644 --- a/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc +++ b/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc @@ -9,10 +9,10 @@ #include "chrome/browser/search_engines/template_url_service_factory_test_util.h" #include "chrome/browser/ui/search_engines/keyword_editor_controller.h" #include "chrome/browser/ui/search_engines/template_url_table_model.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/template_url.h" #include "components/search_engines/template_url_service.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/base/models/table_model_observer.h" diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc index 8fac6c7..71dc298 100644 --- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc +++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc @@ -22,12 +22,12 @@ #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/test/bookmark_test_helpers.h" #include "components/history/core/browser/history_service.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc index 21469d3..218c3ab 100644 --- a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc +++ b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc @@ -18,8 +18,8 @@ #include "chrome/test/base/menu_model_test.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_io_thread_state.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" namespace { diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc index 0006892..4f2647c 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc @@ -18,12 +18,12 @@ #include "chrome/test/base/browser_with_test_window_test.h" #include "chrome/test/base/scoped_testing_local_state.h" #include "chrome/test/base/testing_browser_process.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/test/bookmark_test_helpers.h" #include "components/search_engines/search_terms_data.h" #include "components/search_engines/template_url_service.h" #include "components/search_engines/template_url_service_client.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "ui/views/controls/button/label_button.h" #include "ui/views/controls/button/menu_button.h" diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index c71d727..06a5ff0 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -2275,23 +2275,12 @@ 'browser/prefs/incognito_mode_prefs.h', 'browser/prefs/pref_metrics_service.cc', 'browser/prefs/pref_metrics_service.h', - 'browser/prefs/pref_model_associator.cc', - 'browser/prefs/pref_model_associator.h', - 'browser/prefs/pref_model_associator_client.h', - 'browser/prefs/pref_service_syncable.cc', - 'browser/prefs/pref_service_syncable.h', - 'browser/prefs/pref_service_syncable_factory.cc', - 'browser/prefs/pref_service_syncable_factory.h', - 'browser/prefs/pref_service_syncable_observer.h', 'browser/prefs/pref_service_syncable_util.cc', 'browser/prefs/pref_service_syncable_util.h', 'browser/prefs/profile_pref_store_manager.cc', 'browser/prefs/profile_pref_store_manager.h', 'browser/prefs/session_startup_pref.cc', 'browser/prefs/session_startup_pref.h', - 'browser/prefs/synced_pref_change_registrar.cc', - 'browser/prefs/synced_pref_change_registrar.h', - 'browser/prefs/synced_pref_observer.h', ], # Used both when (enable_basic_printing==1 or enable_print_preview==1). 'chrome_browser_printing_basic_sources': [ @@ -3263,6 +3252,7 @@ '../components/components.gyp:safe_json', '../components/components.gyp:sessions_content', '../components/components.gyp:storage_monitor', + '../components/components.gyp:syncable_prefs', '../components/components.gyp:translate_content_browser', '../components/components.gyp:upload_list', '../components/components.gyp:url_matcher', diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index 7069f69..7e2cc0a 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -178,8 +178,6 @@ 'browser/prefs/command_line_pref_store_proxy_unittest.cc', 'browser/prefs/command_line_pref_store_unittest.cc', 'browser/prefs/incognito_mode_prefs_unittest.cc', - 'browser/prefs/pref_model_associator_unittest.cc', - 'browser/prefs/pref_service_syncable_unittest.cc', 'browser/prefs/profile_pref_store_manager_unittest.cc', 'browser/prefs/session_startup_pref_unittest.cc', 'browser/prerender/prerender_history_unittest.cc', @@ -1665,6 +1663,7 @@ '../components/components.gyp:search_engines_test_support', '../components/components.gyp:signin_core_browser_test_support', '../components/components.gyp:sync_driver_test_support', + '../components/components.gyp:syncable_prefs_test_support', '../components/components.gyp:update_client_test_support', '../components/components.gyp:user_prefs_tracked_test_support', '../components/components.gyp:wallpaper', @@ -1738,8 +1737,6 @@ 'browser/password_manager/password_manager_test_base.h', 'browser/password_manager/test_password_store_service.cc', 'browser/password_manager/test_password_store_service.h', - 'browser/prefs/pref_service_mock_factory.cc', - 'browser/prefs/pref_service_mock_factory.h', 'browser/profile_resetter/profile_resetter_test_base.cc', 'browser/profile_resetter/profile_resetter_test_base.h', 'browser/search_engines/template_url_service_factory_test_util.cc', @@ -1835,8 +1832,6 @@ 'test/base/testing_browser_process_platform_part.h', 'test/base/testing_io_thread_state.cc', 'test/base/testing_io_thread_state.h', - 'test/base/testing_pref_service_syncable.cc', - 'test/base/testing_pref_service_syncable.h', 'test/base/testing_profile.cc', 'test/base/testing_profile.h', 'test/base/testing_profile_manager.cc', @@ -2165,6 +2160,7 @@ '../base/base.gyp:test_support_base', '../components/components_resources.gyp:components_resources', '../components/components.gyp:content_settings_core_test_support', + '../components/components.gyp:syncable_prefs_test_support', '../content/content_shell_and_tests.gyp:test_support_content', '../content/content.gyp:content_app_both', '../crypto/crypto.gyp:crypto_test_support', diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn index 352145c..f2c1d01 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn @@ -68,8 +68,6 @@ source_set("test_support") { "base/testing_browser_process_platform_part.h", "base/testing_io_thread_state.cc", "base/testing_io_thread_state.h", - "base/testing_pref_service_syncable.cc", - "base/testing_pref_service_syncable.h", "base/testing_profile.cc", "base/testing_profile.h", "base/testing_profile_manager.cc", @@ -119,6 +117,7 @@ source_set("test_support") { "//components/search_engines:test_support", "//components/signin/core/browser:test_support", "//components/sync_driver:test_support", + "//components/syncable_prefs:test_support", "//components/update_client:test_support", "//content/public/app:both", "//ui/gfx:test_support", diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc index a221ed8..7f7c2af 100644 --- a/chrome/test/base/testing_profile.cc +++ b/chrome/test/base/testing_profile.cc @@ -32,7 +32,6 @@ #include "chrome/browser/policy/profile_policy_connector.h" #include "chrome/browser/policy/profile_policy_connector_factory.h" #include "chrome/browser/prefs/browser_prefs.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/prerender/prerender_manager.h" #include "chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h" @@ -47,7 +46,6 @@ #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/history_index_restore_observer.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/autofill/core/browser/webdata/autofill_webdata_service.h" #include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/common/bookmark_constants.h" @@ -67,6 +65,8 @@ #include "components/omnibox/browser/in_memory_url_index.h" #include "components/policy/core/common/policy_service.h" #include "components/proxy_config/pref_proxy_config_tracker.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "components/ui/zoom/zoom_event_manager.h" #include "components/user_prefs/user_prefs.h" #include "components/webdata_services/web_data_service_wrapper.h" diff --git a/chrome/test/base/testing_profile_manager.cc b/chrome/test/base/testing_profile_manager.cc index 0ae9f99..6964623 100644 --- a/chrome/test/base/testing_profile_manager.cc +++ b/chrome/test/base/testing_profile_manager.cc @@ -6,11 +6,11 @@ #include "base/memory/ref_counted.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "chrome/browser/profiles/profile_info_cache.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/common/chrome_constants.h" #include "chrome/test/base/testing_browser_process.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" #if defined(OS_CHROMEOS) diff --git a/components/BUILD.gn b/components/BUILD.gn index 124014b..61b2d16 100644 --- a/components/BUILD.gn +++ b/components/BUILD.gn @@ -107,6 +107,7 @@ group("all_components") { "//components/startup_metric_utils", "//components/strings", "//components/sync_driver", + "//components/syncable_prefs", "//components/tracing", "//components/tracing:startup_tracing", "//components/translate/content/browser", @@ -363,6 +364,7 @@ test("components_unittests") { "//components/signin/core/browser:unit_tests", "//components/suggestions:unit_tests", "//components/sync_driver:unit_tests", + "//components/syncable_prefs:unit_tests", "//components/translate/core/browser:unit_tests", "//components/translate/core/common:unit_tests", "//components/translate/core/language_detection:unit_tests", diff --git a/components/components.gyp b/components/components.gyp index b2ab95e..91815d7 100644 --- a/components/components.gyp +++ b/components/components.gyp @@ -75,6 +75,7 @@ 'startup_metric_utils.gypi', 'suggestions.gypi', 'sync_driver.gypi', + 'syncable_prefs.gypi', 'toolbar.gypi', 'translate.gypi', 'ui_zoom.gypi', diff --git a/components/components_tests.gyp b/components/components_tests.gyp index ddf6ba2..1e0c661 100644 --- a/components/components_tests.gyp +++ b/components/components_tests.gyp @@ -647,6 +647,10 @@ 'sync_driver/tab_node_pool_unittest.cc', 'sync_driver/ui_data_type_controller_unittest.cc', ], + 'syncable_prefs_unittest_sources': [ + 'syncable_prefs/pref_model_associator_unittest.cc', + 'syncable_prefs/pref_service_syncable_unittest.cc', + ], 'tracing_unittest_sources': [ 'tracing/trace_config_file_unittest.cc', ], @@ -836,6 +840,7 @@ '<@(signin_unittest_sources)', '<@(suggestions_unittest_sources)', '<@(sync_driver_unittest_sources)', + '<@(syncable_prefs_unittest_sources)', '<@(translate_unittest_sources)', '<@(undo_unittest_sources)', '<@(update_client_unittest_sources)', @@ -952,6 +957,7 @@ 'components.gyp:signin_core_browser_test_support', 'components.gyp:suggestions', 'components.gyp:sync_driver_test_support', + 'components.gyp:syncable_prefs_test_support', 'components.gyp:translate_core_browser', 'components.gyp:translate_core_common', 'components.gyp:translate_core_language_detection', diff --git a/components/search_engines/DEPS b/components/search_engines/DEPS index d03a920..14d2fa2 100644 --- a/components/search_engines/DEPS +++ b/components/search_engines/DEPS @@ -25,8 +25,8 @@ specific_include_rules = { "!chrome/browser/history/history_service_factory.h", "!chrome/browser/search_engines/template_url_service_test_util.h", "!chrome/common/chrome_paths.h", - "!chrome/test/base/testing_pref_service_syncable.h", "!chrome/test/base/testing_profile.h", + "!components/syncable_prefs/testing_pref_service_syncable.h", "!content/public/test/test_browser_thread_bundle.h", ], } diff --git a/components/search_engines/template_url_service_sync_unittest.cc b/components/search_engines/template_url_service_sync_unittest.cc index d411256..b2ae9aa 100644 --- a/components/search_engines/template_url_service_sync_unittest.cc +++ b/components/search_engines/template_url_service_sync_unittest.cc @@ -9,7 +9,6 @@ #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chrome/browser/search_engines/template_url_service_test_util.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "chrome/test/base/testing_profile.h" #include "components/search_engines/search_engines_pref_names.h" #include "components/search_engines/search_terms_data.h" @@ -17,6 +16,7 @@ #include "components/search_engines/template_url_prepopulate_data.h" #include "components/search_engines/template_url_service.h" #include "components/search_engines/template_url_service_client.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "content/public/test/test_browser_thread_bundle.h" #include "net/base/net_util.h" #include "sync/api/sync_change_processor_wrapper_for_test.h" diff --git a/components/syncable_prefs.gypi b/components/syncable_prefs.gypi new file mode 100644 index 0000000..7e143a1 --- /dev/null +++ b/components/syncable_prefs.gypi @@ -0,0 +1,61 @@ +# Copyright 2015 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +{ + 'targets': [ + { + # GN version: //components/syncable_prefs + 'target_name': 'syncable_prefs', + 'type': 'static_library', + 'dependencies': [ + '../base/base.gyp:base', + '../base/base.gyp:base_prefs', + '../sync/sync.gyp:sync', + 'pref_registry', + ], + 'include_dirs': [ + '..', + ], + 'sources': [ + 'syncable_prefs/pref_model_associator.cc', + 'syncable_prefs/pref_model_associator.h', + 'syncable_prefs/pref_model_associator_client.h', + 'syncable_prefs/pref_service_syncable.cc', + 'syncable_prefs/pref_service_syncable.h', + 'syncable_prefs/pref_service_syncable_factory.cc', + 'syncable_prefs/pref_service_syncable_factory.h', + 'syncable_prefs/pref_service_syncable_observer.h', + 'syncable_prefs/synced_pref_change_registrar.cc', + 'syncable_prefs/synced_pref_change_registrar.h', + 'syncable_prefs/synced_pref_observer.h', + ], + 'conditions': [ + ['configuration_policy==1', { + 'dependencies': [ + 'policy_component_browser', + 'policy_component_common', + ], + }], + ], + }, + { + # GN version: //components/syncable_prefs:test_support + 'target_name': 'syncable_prefs_test_support', + 'type': 'static_library', + 'dependencies': [ + '../testing/gtest.gyp:gtest', + 'syncable_prefs', + ], + 'include_dirs': [ + '..', + ], + 'sources': [ + 'syncable_prefs/pref_service_mock_factory.cc', + 'syncable_prefs/pref_service_mock_factory.h', + 'syncable_prefs/testing_pref_service_syncable.cc', + 'syncable_prefs/testing_pref_service_syncable.h', + ], + }, + ], +} diff --git a/components/syncable_prefs/BUILD.gn b/components/syncable_prefs/BUILD.gn new file mode 100644 index 0000000..7d0ceda --- /dev/null +++ b/components/syncable_prefs/BUILD.gn @@ -0,0 +1,65 @@ +# Copyright 2015 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import("//build/config/features.gni") + +source_set("syncable_prefs") { + sources = [ + "pref_model_associator.cc", + "pref_model_associator.h", + "pref_model_associator_client.h", + "pref_service_syncable.cc", + "pref_service_syncable.h", + "pref_service_syncable_factory.cc", + "pref_service_syncable_factory.h", + "pref_service_syncable_observer.h", + "synced_pref_change_registrar.cc", + "synced_pref_change_registrar.h", + "synced_pref_observer.h", + ] + + deps = [ + "//base", + "//base:prefs", + "//components/pref_registry", + "//sync", + ] + + if (enable_configuration_policy) { + deps += [ + "//components/policy:policy_component_browser", + "//components/policy:policy_component_common", + ] + } +} + +source_set("test_support") { + testonly = true + sources = [ + "pref_service_mock_factory.cc", + "pref_service_mock_factory.h", + "testing_pref_service_syncable.cc", + "testing_pref_service_syncable.h", + ] + + deps = [ + "//testing/gtest", + ":syncable_prefs", + ] +} + +source_set("unit_tests") { + testonly = true + sources = [ + "pref_model_associator_unittest.cc", + "pref_service_syncable_unittest.cc", + ] + + deps = [ + ":syncable_prefs", + ":test_support", + "//testing/gtest", + "//sync:test_support_sync_api", + ] +} diff --git a/components/syncable_prefs/DEPS b/components/syncable_prefs/DEPS new file mode 100644 index 0000000..2d2851d --- /dev/null +++ b/components/syncable_prefs/DEPS @@ -0,0 +1,11 @@ +include_rules = [ + "+components/policy/core/browser", + "+components/policy/core/common", + "+components/pref_registry", + "+sync", + + # syncable_prefs can be used on all platforms, including iOS. Do not allow + # platform-specific dependencies. + "-content", + "-ios", +] diff --git a/components/syncable_prefs/OWNERS b/components/syncable_prefs/OWNERS new file mode 100644 index 0000000..2d87038 --- /dev/null +++ b/components/syncable_prefs/OWNERS @@ -0,0 +1,4 @@ +battre@chromium.org +bauerb@chromium.org +gab@chromium.org +pam@chromium.org diff --git a/chrome/browser/prefs/pref_model_associator.cc b/components/syncable_prefs/pref_model_associator.cc index 4e09261..b4448f3 100644 --- a/chrome/browser/prefs/pref_model_associator.cc +++ b/components/syncable_prefs/pref_model_associator.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/pref_model_associator.h" +#include "components/syncable_prefs/pref_model_associator.h" #include "base/auto_reset.h" #include "base/json/json_reader.h" @@ -13,8 +13,8 @@ #include "base/stl_util.h" #include "base/strings/utf_string_conversions.h" #include "base/values.h" -#include "chrome/browser/prefs/pref_model_associator_client.h" -#include "chrome/browser/prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_model_associator_client.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "sync/api/sync_change.h" #include "sync/api/sync_error_factory.h" #include "sync/protocol/preference_specifics.pb.h" diff --git a/chrome/browser/prefs/pref_model_associator.h b/components/syncable_prefs/pref_model_associator.h index 114540d..09f63e6 100644 --- a/chrome/browser/prefs/pref_model_associator.h +++ b/components/syncable_prefs/pref_model_associator.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_ -#define CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_H_ #include <map> #include <set> @@ -15,7 +15,7 @@ #include "base/gtest_prod_util.h" #include "base/observer_list.h" #include "base/threading/non_thread_safe.h" -#include "chrome/browser/prefs/synced_pref_observer.h" +#include "components/syncable_prefs/synced_pref_observer.h" #include "sync/api/sync_data.h" #include "sync/api/syncable_service.h" @@ -197,4 +197,4 @@ class PrefModelAssociator DISALLOW_COPY_AND_ASSIGN(PrefModelAssociator); }; -#endif // CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_H_ diff --git a/chrome/browser/prefs/pref_model_associator_client.h b/components/syncable_prefs/pref_model_associator_client.h index ce944a6..923d5d1 100644 --- a/chrome/browser/prefs/pref_model_associator_client.h +++ b/components/syncable_prefs/pref_model_associator_client.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ -#define CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ #include <string> @@ -42,4 +42,4 @@ class PrefModelAssociatorClient { DISALLOW_COPY_AND_ASSIGN(PrefModelAssociatorClient); }; -#endif // CHROME_BROWSER_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_MODEL_ASSOCIATOR_CLIENT_H_ diff --git a/chrome/browser/prefs/pref_model_associator_unittest.cc b/components/syncable_prefs/pref_model_associator_unittest.cc index 6be14e2..75e90ff 100644 --- a/chrome/browser/prefs/pref_model_associator_unittest.cc +++ b/components/syncable_prefs/pref_model_associator_unittest.cc @@ -7,10 +7,10 @@ #include "base/memory/scoped_ptr.h" #include "base/prefs/scoped_user_pref_update.h" #include "base/values.h" -#include "chrome/browser/prefs/pref_model_associator.h" -#include "chrome/browser/prefs/pref_model_associator_client.h" -#include "chrome/browser/prefs/pref_service_mock_factory.h" -#include "chrome/browser/prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_model_associator.h" +#include "components/syncable_prefs/pref_model_associator_client.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "testing/gtest/include/gtest/gtest.h" namespace { diff --git a/chrome/browser/prefs/pref_service_mock_factory.cc b/components/syncable_prefs/pref_service_mock_factory.cc index 2bad841..c176b50 100644 --- a/chrome/browser/prefs/pref_service_mock_factory.cc +++ b/components/syncable_prefs/pref_service_mock_factory.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/pref_service_mock_factory.h" +#include "components/syncable_prefs/pref_service_mock_factory.h" #include "base/prefs/testing_pref_store.h" diff --git a/chrome/browser/prefs/pref_service_mock_factory.h b/components/syncable_prefs/pref_service_mock_factory.h index ab9bc26..0ea6e10 100644 --- a/chrome/browser/prefs/pref_service_mock_factory.h +++ b/components/syncable_prefs/pref_service_mock_factory.h @@ -2,10 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ -#define CHROME_BROWSER_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ -#include "chrome/browser/prefs/pref_service_syncable_factory.h" +#include "components/syncable_prefs/pref_service_syncable_factory.h" // A helper that allows convenient building of custom PrefServices in tests. class PrefServiceMockFactory : public PrefServiceSyncableFactory { @@ -17,4 +17,4 @@ class PrefServiceMockFactory : public PrefServiceSyncableFactory { DISALLOW_COPY_AND_ASSIGN(PrefServiceMockFactory); }; -#endif // CHROME_BROWSER_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_MOCK_FACTORY_H_ diff --git a/chrome/browser/prefs/pref_service_syncable.cc b/components/syncable_prefs/pref_service_syncable.cc index 5f29e66..46f7ec7 100644 --- a/chrome/browser/prefs/pref_service_syncable.cc +++ b/components/syncable_prefs/pref_service_syncable.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "base/bind.h" #include "base/callback.h" @@ -14,9 +14,9 @@ #include "base/prefs/pref_value_store.h" #include "base/strings/string_number_conversions.h" #include "base/value_conversions.h" -#include "chrome/browser/prefs/pref_model_associator.h" -#include "chrome/browser/prefs/pref_service_syncable_observer.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_model_associator.h" +#include "components/syncable_prefs/pref_service_syncable_observer.h" PrefServiceSyncable::PrefServiceSyncable( PrefNotifierImpl* pref_notifier, diff --git a/chrome/browser/prefs/pref_service_syncable.h b/components/syncable_prefs/pref_service_syncable.h index 222a570..b3cfe84 100644 --- a/chrome/browser/prefs/pref_service_syncable.h +++ b/components/syncable_prefs/pref_service_syncable.h @@ -2,16 +2,16 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_H_ -#define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_H_ #include <vector> #include "base/callback_forward.h" #include "base/prefs/pref_service.h" -#include "chrome/browser/prefs/pref_model_associator.h" -#include "chrome/browser/prefs/synced_pref_observer.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_model_associator.h" +#include "components/syncable_prefs/synced_pref_observer.h" class PrefModelAssociatorClient; class PrefServiceSyncableObserver; @@ -109,4 +109,4 @@ class PrefServiceSyncable : public PrefService { DISALLOW_COPY_AND_ASSIGN(PrefServiceSyncable); }; -#endif // CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_H_ diff --git a/chrome/browser/prefs/pref_service_syncable_factory.cc b/components/syncable_prefs/pref_service_syncable_factory.cc index d21996c..4e3ae2d 100644 --- a/chrome/browser/prefs/pref_service_syncable_factory.cc +++ b/components/syncable_prefs/pref_service_syncable_factory.cc @@ -2,14 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/pref_service_syncable_factory.h" +#include "components/syncable_prefs/pref_service_syncable_factory.h" #include "base/prefs/default_pref_store.h" #include "base/prefs/pref_notifier_impl.h" #include "base/prefs/pref_value_store.h" #include "base/trace_event/trace_event.h" -#include "chrome/browser/prefs/pref_service_syncable.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #if defined(ENABLE_CONFIGURATION_POLICY) #include "components/policy/core/browser/browser_policy_connector.h" diff --git a/chrome/browser/prefs/pref_service_syncable_factory.h b/components/syncable_prefs/pref_service_syncable_factory.h index 0b33f25..9896831 100644 --- a/chrome/browser/prefs/pref_service_syncable_factory.h +++ b/components/syncable_prefs/pref_service_syncable_factory.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ -#define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ #include "base/prefs/pref_service_factory.h" @@ -51,4 +51,4 @@ class PrefServiceSyncableFactory : public base::PrefServiceFactory { DISALLOW_COPY_AND_ASSIGN(PrefServiceSyncableFactory); }; -#endif // CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_FACTORY_H_ diff --git a/chrome/browser/prefs/pref_service_syncable_observer.h b/components/syncable_prefs/pref_service_syncable_observer.h index 821c6a6..ba32463 100644 --- a/chrome/browser/prefs/pref_service_syncable_observer.h +++ b/components/syncable_prefs/pref_service_syncable_observer.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ -#define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ +#define COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ class PrefServiceSyncableObserver { public: @@ -14,4 +14,4 @@ class PrefServiceSyncableObserver { virtual ~PrefServiceSyncableObserver() {} }; -#endif // CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_PREF_SERVICE_SYNCABLE_OBSERVER_H_ diff --git a/chrome/browser/prefs/pref_service_syncable_unittest.cc b/components/syncable_prefs/pref_service_syncable_unittest.cc index 763b456..013e611 100644 --- a/chrome/browser/prefs/pref_service_syncable_unittest.cc +++ b/components/syncable_prefs/pref_service_syncable_unittest.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" #include "base/json/json_reader.h" #include "base/json/json_string_value_serializer.h" @@ -10,10 +10,10 @@ #include "base/message_loop/message_loop.h" #include "base/prefs/scoped_user_pref_update.h" #include "base/strings/utf_string_conversions.h" -#include "chrome/browser/prefs/pref_model_associator.h" -#include "chrome/browser/prefs/pref_model_associator_client.h" -#include "chrome/test/base/testing_pref_service_syncable.h" #include "components/pref_registry/pref_registry_syncable.h" +#include "components/syncable_prefs/pref_model_associator.h" +#include "components/syncable_prefs/pref_model_associator_client.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "sync/api/attachments/attachment_id.h" #include "sync/api/sync_change.h" #include "sync/api/sync_data.h" diff --git a/chrome/browser/prefs/synced_pref_change_registrar.cc b/components/syncable_prefs/synced_pref_change_registrar.cc index 1438d21..96602ba 100644 --- a/chrome/browser/prefs/synced_pref_change_registrar.cc +++ b/components/syncable_prefs/synced_pref_change_registrar.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/browser/prefs/synced_pref_change_registrar.h" +#include "components/syncable_prefs/synced_pref_change_registrar.h" #include "base/bind.h" diff --git a/chrome/browser/prefs/synced_pref_change_registrar.h b/components/syncable_prefs/synced_pref_change_registrar.h index 66d6bc5..8e06cd1 100644 --- a/chrome/browser/prefs/synced_pref_change_registrar.h +++ b/components/syncable_prefs/synced_pref_change_registrar.h @@ -2,15 +2,15 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ -#define CHROME_BROWSER_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ +#define COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ #include <map> #include <string> #include "base/callback.h" -#include "chrome/browser/prefs/pref_service_syncable.h" -#include "chrome/browser/prefs/synced_pref_observer.h" +#include "components/syncable_prefs/pref_service_syncable.h" +#include "components/syncable_prefs/synced_pref_observer.h" // Manages the registration of one or more SyncedPrefObservers on a // PrefServiceSyncable. This is modeled after base::PrefChangeRegistrar, and @@ -53,4 +53,4 @@ class SyncedPrefChangeRegistrar : public SyncedPrefObserver { DISALLOW_COPY_AND_ASSIGN(SyncedPrefChangeRegistrar); }; -#endif // CHROME_BROWSER_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_CHANGE_REGISTRAR_H_ diff --git a/chrome/browser/prefs/synced_pref_observer.h b/components/syncable_prefs/synced_pref_observer.h index 332e588..4377eb4 100644 --- a/chrome/browser/prefs/synced_pref_observer.h +++ b/components/syncable_prefs/synced_pref_observer.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_BROWSER_PREFS_SYNCED_PREF_OBSERVER_H_ -#define CHROME_BROWSER_PREFS_SYNCED_PREF_OBSERVER_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_OBSERVER_H_ +#define COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_OBSERVER_H_ #include <string> @@ -12,4 +12,4 @@ class SyncedPrefObserver { virtual void OnSyncedPrefChanged(const std::string& path, bool from_sync) = 0; }; -#endif // CHROME_BROWSER_PREFS_SYNCED_PREF_OBSERVER_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_SYNCED_PREF_OBSERVER_H_ diff --git a/chrome/test/base/testing_pref_service_syncable.cc b/components/syncable_prefs/testing_pref_service_syncable.cc index 86ffee8..81e71fb 100644 --- a/chrome/test/base/testing_pref_service_syncable.cc +++ b/components/syncable_prefs/testing_pref_service_syncable.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/test/base/testing_pref_service_syncable.h" +#include "components/syncable_prefs/testing_pref_service_syncable.h" #include "base/bind.h" #include "base/prefs/pref_notifier_impl.h" diff --git a/chrome/test/base/testing_pref_service_syncable.h b/components/syncable_prefs/testing_pref_service_syncable.h index 4db95d9..440b417 100644 --- a/chrome/test/base/testing_pref_service_syncable.h +++ b/components/syncable_prefs/testing_pref_service_syncable.h @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_TEST_BASE_TESTING_PREF_SERVICE_SYNCABLE_H_ -#define CHROME_TEST_BASE_TESTING_PREF_SERVICE_SYNCABLE_H_ +#ifndef COMPONENTS_SYNCABLE_PREFS_TESTING_PREF_SERVICE_SYNCABLE_H_ +#define COMPONENTS_SYNCABLE_PREFS_TESTING_PREF_SERVICE_SYNCABLE_H_ #include "base/basictypes.h" #include "base/prefs/testing_pref_service.h" -#include "chrome/browser/prefs/pref_service_syncable.h" +#include "components/syncable_prefs/pref_service_syncable.h" class PrefModelAssociatorClient; @@ -47,5 +47,5 @@ TestingPrefServiceBase<PrefServiceSyncable, user_prefs::PrefRegistrySyncable>:: user_prefs::PrefRegistrySyncable* pref_registry, PrefNotifierImpl* pref_notifier); -#endif // CHROME_TEST_BASE_TESTING_PREF_SERVICE_SYNCABLE_H_ +#endif // COMPONENTS_SYNCABLE_PREFS_TESTING_PREF_SERVICE_SYNCABLE_H_ |