diff options
| author | adamk <adamk@chromium.org> | 2016-03-07 13:11:53 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-07 21:12:55 +0000 |
| commit | 8ab4acafc5a378ea754be3caec9da13473059e82 (patch) | |
| tree | 45c6ae3b6bb37d761b473a55920534610da769b2 | |
| parent | 1795b2fc9c3585607950db5bc8d8ed8aa4f0171b (diff) | |
| download | chromium_src-8ab4acafc5a378ea754be3caec9da13473059e82.zip chromium_src-8ab4acafc5a378ea754be3caec9da13473059e82.tar.gz chromium_src-8ab4acafc5a378ea754be3caec9da13473059e82.tar.bz2 | |
Rebaseline inspector tests for ES2015 Function.name
Most of these are fine as-is after rebaselining. Only the tests with
extra "get"/"set" prefixes are the ones that need more work to have
nice output with the new ES2015 world.
BUG=588803
Review URL: https://codereview.chromium.org/1766773002
Cr-Commit-Position: refs/heads/master@{#379642}
9 files changed, 34 insertions, 43 deletions
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 6021bc5..113c53e 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1292,15 +1292,6 @@ crbug.com/558574 [ Win7 ] fast/text/emphasis.html [ Failure ] crbug.com/574196 fast/js/mozilla/strict/13.1.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/console/alert-toString-exception.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/console/console-eval-scoped.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/console/console-format-es6.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/console/console-object-constructor-name.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/runtime/runtime-getProperties.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/sources/debugger-frameworks/frameworks-jquery.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/sources/debugger-ui/function-details.html [ NeedsManualRebaseline ] -crbug.com/588803 inspector/sources/debugger-ui/function-generator-details.html [ NeedsManualRebaseline ] - crbug.com/568867 [ Win Debug ] transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ] crbug.com/568867 [ Win Debug ] transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [ Failure ] diff --git a/third_party/WebKit/LayoutTests/inspector/console/alert-toString-exception-expected.txt b/third_party/WebKit/LayoutTests/inspector/console/alert-toString-exception-expected.txt index b2251a6..b13fa7b 100644 --- a/third_party/WebKit/LayoutTests/inspector/console/alert-toString-exception-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/console/alert-toString-exception-expected.txt @@ -3,5 +3,5 @@ CONSOLE ERROR: line 6: Uncaught Exception in toString(). Test that browser won't crash if inspector is opened for a page that fails to convert alert() argument to string. The test passes if it doesn't crash. Bug 60541 Page reloaded. -alert-toString-exception.html:6 Uncaught Exception in toString().alert.toString @ alert-toString-exception.html:6(anonymous function) @ alert-toString-exception.html:6 +alert-toString-exception.html:6 Uncaught Exception in toString().toString @ alert-toString-exception.html:6(anonymous function) @ alert-toString-exception.html:6 diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped-expected.txt b/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped-expected.txt index 0208a3f..02042e7 100644 --- a/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/console/console-eval-scoped-expected.txt @@ -21,7 +21,7 @@ Running: testConsoleEvalObject enumerable : true get : { className : "Function" - description : "function getter() { }" + description : "function get getter() { }" objectId : <string> type : "function" } @@ -41,7 +41,7 @@ Running: testConsoleEvalObject name : "setter" set : { className : "Function" - description : "function setter(_) { }" + description : "function set setter(_) { }" objectId : <string> type : "function" } diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt b/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt index 05b5249..10717ee4 100644 --- a/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt @@ -50,7 +50,7 @@ Symbol(a) console-format-es6.html:11 Object {a: Symbol(), Symbol(a): 2} a: Symbol() getter: (...) - get getter: getter() + get getter: get getter() Symbol(a): 2 __proto__: Object console-format-es6.html:12 [Object] @@ -61,7 +61,7 @@ globals[3] Object {a: Symbol(), Symbol(a): 2} a: Symbol() getter: (...) - get getter: getter() + get getter: get getter() Symbol(a): 2 __proto__: Object console-format-es6.html:11 Map {Object {a: Symbol(), Symbol(a): 2} => Object {foo: 1}} diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-object-constructor-name-expected.txt b/third_party/WebKit/LayoutTests/inspector/console/console-object-constructor-name-expected.txt index 3301d61..25eb402 100644 --- a/third_party/WebKit/LayoutTests/inspector/console/console-object-constructor-name-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/console/console-object-constructor-name-expected.txt @@ -5,5 +5,5 @@ Tests that the name of the function invoked as object constructor will be displa console-object-constructor-name.html:12 Parent console-object-constructor-name.html:13 Child -console-object-constructor-name.html:14 outer.inner +console-object-constructor-name.html:14 inner diff --git a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt b/third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt index 338d884..5a92b89 100644 --- a/third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt @@ -7,14 +7,14 @@ Running: testGetterAndSetter { enumerable : true getter : { - description : "function () { return 1; }" + description : "function get foo() { return 1; }" objectId : <string> type : "function" } isOwn : true name : "foo" setter : { - description : "function (value) { }" + description : "function set foo(value) { }" objectId : <string> type : "function" } @@ -27,7 +27,7 @@ Running: testGetterOnly { enumerable : true getter : { - description : "function () { return 1; }" + description : "function get foo() { return 1; }" objectId : <string> type : "function" } diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt index 719ce49..1112589 100644 --- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-jquery-expected.txt @@ -12,31 +12,31 @@ Executing StepInto... Executing StepInto... Call stack: 0) onEachScript (frameworks-jquery.html:39) - * 1) m.extend.each (jquery-1.11.1.min.js:2) - * 2) m.fn.m.each (jquery-1.11.1.min.js:2) + * 1) each (jquery-1.11.1.min.js:2) + * 2) each (jquery-1.11.1.min.js:2) 3) testFunction (frameworks-jquery.html:18) Executing StepInto... Executing StepInto... Call stack: 0) onEachScript (frameworks-jquery.html:39) - * 1) m.extend.each (jquery-1.11.1.min.js:2) - * 2) m.fn.m.each (jquery-1.11.1.min.js:2) + * 1) each (jquery-1.11.1.min.js:2) + * 2) each (jquery-1.11.1.min.js:2) 3) testFunction (frameworks-jquery.html:18) Executing StepOver... Executing StepOver... Call stack: 0) onEachScript (frameworks-jquery.html:39) - * 1) m.extend.each (jquery-1.11.1.min.js:2) - * 2) m.fn.m.each (jquery-1.11.1.min.js:2) + * 1) each (jquery-1.11.1.min.js:2) + * 2) each (jquery-1.11.1.min.js:2) 3) testFunction (frameworks-jquery.html:18) Executing StepOut... Call stack: 0) onEachScript (frameworks-jquery.html:39) - * 1) m.extend.each (jquery-1.11.1.min.js:2) - * 2) m.fn.m.each (jquery-1.11.1.min.js:2) + * 1) each (jquery-1.11.1.min.js:2) + * 2) each (jquery-1.11.1.min.js:2) 3) testFunction (frameworks-jquery.html:18) Executing StepOut... @@ -46,38 +46,38 @@ Call stack: Executing StepInto... Call stack: 0) onTestEvent1 (frameworks-jquery.html:24) - * 1) m.event.dispatch (jquery-1.11.1.min.js:3) + * 1) dispatch (jquery-1.11.1.min.js:3) * 2) r.handle (jquery-1.11.1.min.js:3) - * 3) m.event.trigger (jquery-1.11.1.min.js:3) + * 3) trigger (jquery-1.11.1.min.js:3) * 4) (jquery-1.11.1.min.js:3) - * 5) m.extend.each (jquery-1.11.1.min.js:2) - * 6) m.fn.m.each (jquery-1.11.1.min.js:2) - * 7) m.fn.extend.trigger (jquery-1.11.1.min.js:3) + * 5) each (jquery-1.11.1.min.js:2) + * 6) each (jquery-1.11.1.min.js:2) + * 7) trigger (jquery-1.11.1.min.js:3) 8) testFunction (frameworks-jquery.html:19) Executing StepOut... Call stack: 0) onTestEvent2 (frameworks-jquery.html:29) - * 1) m.event.dispatch (jquery-1.11.1.min.js:3) + * 1) dispatch (jquery-1.11.1.min.js:3) * 2) r.handle (jquery-1.11.1.min.js:3) - * 3) m.event.trigger (jquery-1.11.1.min.js:3) + * 3) trigger (jquery-1.11.1.min.js:3) * 4) (jquery-1.11.1.min.js:3) - * 5) m.extend.each (jquery-1.11.1.min.js:2) - * 6) m.fn.m.each (jquery-1.11.1.min.js:2) - * 7) m.fn.extend.trigger (jquery-1.11.1.min.js:3) + * 5) each (jquery-1.11.1.min.js:2) + * 6) each (jquery-1.11.1.min.js:2) + * 7) trigger (jquery-1.11.1.min.js:3) 8) testFunction (frameworks-jquery.html:19) Executing StepOver... Executing StepOver... Call stack: 0) onTestEvent3 (frameworks-jquery.html:34) - * 1) m.event.dispatch (jquery-1.11.1.min.js:3) + * 1) dispatch (jquery-1.11.1.min.js:3) * 2) r.handle (jquery-1.11.1.min.js:3) - * 3) m.event.trigger (jquery-1.11.1.min.js:3) + * 3) trigger (jquery-1.11.1.min.js:3) * 4) (jquery-1.11.1.min.js:3) - * 5) m.extend.each (jquery-1.11.1.min.js:2) - * 6) m.fn.m.each (jquery-1.11.1.min.js:2) - * 7) m.fn.extend.trigger (jquery-1.11.1.min.js:3) + * 5) each (jquery-1.11.1.min.js:2) + * 6) each (jquery-1.11.1.min.js:2) + * 7) trigger (jquery-1.11.1.min.js:3) 8) testFunction (frameworks-jquery.html:19) diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt index 805f304..0c6e642 100644 --- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-details-expected.txt @@ -27,7 +27,7 @@ Function details: lineNumber: 16 columnNumber: 15 scriptId is valid: true -functionName: obj.m +functionName: m isGenerator: false scopeChain #0: global; <global object properties omitted> diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt index 4e8ca17..e043b9d 100644 --- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt +++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/function-generator-details-expected.txt @@ -27,7 +27,7 @@ status: closed Running: testIterObjGenerator iterObjGenerator: type = object, subtype = generator -functionName: "obj.generator" +functionName: "generator" lineNumber: 25 columnNumber: 8 scriptId is valid: true |
