Track profile creation type better by making it a param to AvatarMenuModel::AddNewProfile().

The ADD_NEW_USER_ICON metric previously got lost in http://crrev.com/174177.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/11640023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174445 0039d316-1c4b-4281-b951-d872f2087c98

6 files changed, 8 insertions, 7 deletions

diff --git a/chrome/browser/profiles/avatar_menu_model.cc b/chrome/browser/profiles/avatar_menu_model.cc
index fef6aec..d6e1418e 100644
--- a/chrome/browser/profiles/avatar_menu_model.cc
+++ b/chrome/browser/profiles/avatar_menu_model.cc
@@ -117,7 +117,7 @@ void AvatarMenuModel::EditProfile(size_t index) {
   chrome::ShowSettingsSubPage(browser, page);
 }
 
-void AvatarMenuModel::AddNewProfile() {
+void AvatarMenuModel::AddNewProfile(ProfileMetrics::ProfileAdd type) {
   Browser* browser = browser_;
   if (!browser) {
     const Browser::CreateParams params(ProfileManager::GetLastUsedProfile(),
@@ -125,6 +125,7 @@ void AvatarMenuModel::AddNewProfile() {
     browser = new Browser(params);
   }
   chrome::ShowSettingsSubPage(browser, chrome::kCreateProfileSubPage);
+  ProfileMetrics::LogProfileAddNewUser(type);
 }
 
 size_t AvatarMenuModel::GetNumberOfItems() {
diff --git a/chrome/browser/profiles/avatar_menu_model.h b/chrome/browser/profiles/avatar_menu_model.h
index d76f876..965913d 100644
--- a/chrome/browser/profiles/avatar_menu_model.h
+++ b/chrome/browser/profiles/avatar_menu_model.h
@@ -10,6 +10,7 @@
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/string16.h"
+#include "chrome/browser/profiles/profile_metrics.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/gfx/image/image.h"
@@ -66,7 +67,7 @@ class AvatarMenuModel : public content::NotificationObserver {
   // an item.
   void EditProfile(size_t index);
   // Creates a new profile.
-  void AddNewProfile();
+  void AddNewProfile(ProfileMetrics::ProfileAdd type);
 
   // Gets the number of profiles.
   size_t GetNumberOfItems();
diff --git a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm
index 2b97611..69d0d45 100644
--- a/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm
@@ -71,7 +71,7 @@ const CGFloat kLabelInset = 49.0;
 }
 
 - (IBAction)newProfile:(id)sender {
-  model_->AddNewProfile();
+  model_->AddNewProfile(ProfileMetrics::ADD_NEW_USER_ICON);
 }
 
 - (IBAction)switchToProfile:(id)sender {
diff --git a/chrome/browser/ui/cocoa/profile_menu_controller.mm b/chrome/browser/ui/cocoa/profile_menu_controller.mm
index 919dd52..17e7e0e 100644
--- a/chrome/browser/ui/cocoa/profile_menu_controller.mm
+++ b/chrome/browser/ui/cocoa/profile_menu_controller.mm
@@ -99,8 +99,7 @@ class Observer : public chrome::BrowserListObserver,
 }
 
 - (IBAction)newProfile:(id)sender {
-  model_->AddNewProfile();
-  ProfileMetrics::LogProfileAddNewUser(ProfileMetrics::ADD_NEW_USER_MENU);
+  model_->AddNewProfile(ProfileMetrics::ADD_NEW_USER_MENU);
 }
 
 - (BOOL)insertItemsIntoMenu:(NSMenu*)menu
diff --git a/chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc b/chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc
index d45cf5d..1e95a45 100644
--- a/chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc
@@ -117,7 +117,7 @@ void AvatarMenuBubbleGtk::OnSizeRequest(GtkWidget* widget,
 void AvatarMenuBubbleGtk::OnNewProfileLinkClicked(GtkWidget* link) {
   if (!bubble_)
     return;
-  avatar_menu_model_->AddNewProfile();
+  avatar_menu_model_->AddNewProfile(ProfileMetrics::ADD_NEW_USER_ICON);
   CloseBubble();
 }
 
diff --git a/chrome/browser/ui/views/avatar_menu_bubble_view.cc b/chrome/browser/ui/views/avatar_menu_bubble_view.cc
index ee8638d..f3665bd 100644
--- a/chrome/browser/ui/views/avatar_menu_bubble_view.cc
+++ b/chrome/browser/ui/views/avatar_menu_bubble_view.cc
@@ -496,7 +496,7 @@ void AvatarMenuBubbleView::ButtonPressed(views::Button* sender,
 
 void AvatarMenuBubbleView::LinkClicked(views::Link* source, int event_flags) {
   if (source == add_profile_link_) {
-    avatar_menu_model_->AddNewProfile();
+    avatar_menu_model_->AddNewProfile(ProfileMetrics::ADD_NEW_USER_ICON);
     return;
   }