diff options
author | tfarina <tfarina@chromium.org> | 2014-10-23 10:46:11 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-23 17:46:55 +0000 |
commit | 8f4aae2cb156bd96e8b7fcb3948ae9bc5da27573 (patch) | |
tree | 0dd41f067a7bee249322f7ff59f9340acb4d1259 | |
parent | a0458670a47098dc18fdcdac2ecdfdbfc552eb66 (diff) | |
download | chromium_src-8f4aae2cb156bd96e8b7fcb3948ae9bc5da27573.zip chromium_src-8f4aae2cb156bd96e8b7fcb3948ae9bc5da27573.tar.gz chromium_src-8f4aae2cb156bd96e8b7fcb3948ae9bc5da27573.tar.bz2 |
bookmarks: Move bookmark_test_helpers.h into 'bookmarks' namespace.
BUG=370433
TEST=components_unittests, unit_tests
R=sky@chromium.org
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/651753003
Cr-Commit-Position: refs/heads/master@{#300911}
41 files changed, 125 insertions, 120 deletions
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc b/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc index 095bbe7..acf48d8 100644 --- a/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc +++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc @@ -64,7 +64,7 @@ class PartnerBookmarksShimTest : public testing::Test { profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); } virtual void TearDown() override { diff --git a/chrome/browser/autocomplete/history_quick_provider_unittest.cc b/chrome/browser/autocomplete/history_quick_provider_unittest.cc index 4d9bc36..f67d0dd 100644 --- a/chrome/browser/autocomplete/history_quick_provider_unittest.cc +++ b/chrome/browser/autocomplete/history_quick_provider_unittest.cc @@ -184,7 +184,7 @@ void HistoryQuickProviderTest::SetUp() { profile_.reset(new TestingProfile()); ASSERT_TRUE(profile_->CreateHistoryService(true, false)); profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(profile_.get())); profile_->BlockUntilHistoryIndexIsRefreshed(); history_service_ = diff --git a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc index cc9da03..ec3eb52 100644 --- a/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc +++ b/chrome/browser/bookmarks/bookmark_html_writer_unittest.cc @@ -150,7 +150,7 @@ TEST_F(BookmarkHTMLWriterTest, Test) { profile.CreateBookmarkModel(true); BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); // Create test PNG representing favicon for url1. SkBitmap bitmap; diff --git a/chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc b/chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc index 59a4aab..de4b23e 100644 --- a/chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc +++ b/chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc @@ -53,7 +53,7 @@ class ChromeBookmarkClientTest : public testing::Test { void ResetModel() { profile_.CreateBookmarkModel(false); model_ = BookmarkModelFactory::GetForProfile(&profile_); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); model_->AddObserver(&observer_); client_ = ChromeBookmarkClientFactory::GetForProfile(&profile_); DCHECK(client_); diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc index 17d88fc..d9ca974 100644 --- a/chrome/browser/browser_commands_unittest.cc +++ b/chrome/browser/browser_commands_unittest.cc @@ -140,7 +140,7 @@ TEST_F(BrowserCommandsTest, BookmarkCurrentPage) { profile()->CreateBookmarkModel(true); BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); // Navigate to a url. GURL url1("http://foo/1"); diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc index a146048..2eee449 100644 --- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc +++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc @@ -32,7 +32,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile); ChromeBookmarkClient* client = ChromeBookmarkClientFactory::GetForProfile(profile); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); base::ListValue list; base::DictionaryValue* node = new base::DictionaryValue(); @@ -56,7 +56,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BookmarkManagerEditDisabled) { // Provide some testing data here, since bookmark editing will be disabled // within the extension. BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); const BookmarkNode* bar = model->bookmark_bar_node(); const BookmarkNode* folder = model->AddFolder(bar, 0, base::ASCIIToUTF16("Folder")); diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc index 0852e68..2982099 100644 --- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc +++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc @@ -35,7 +35,7 @@ class ExtensionBookmarksTest : public testing::Test { profile_.CreateBookmarkModel(false); model_ = BookmarkModelFactory::GetForProfile(&profile_); client_ = ChromeBookmarkClientFactory::GetForProfile(&profile_); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); node_ = model_->AddURL(model_->other_node(), 0, base::ASCIIToUTF16("Digg"), GURL("http://www.reddit.com")); diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc index 56b75e7..815ba10 100644 --- a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc +++ b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc @@ -28,7 +28,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile); ChromeBookmarkClient* client = ChromeBookmarkClientFactory::GetForProfile(profile); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); base::ListValue list; base::DictionaryValue* node = new base::DictionaryValue(); diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc index bd9af90..2438a5e 100644 --- a/chrome/browser/extensions/lazy_background_page_apitest.cc +++ b/chrome/browser/extensions/lazy_background_page_apitest.cc @@ -385,7 +385,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, DISABLED_IncognitoSplitMode) { page2_complete(incognito_browser->profile()); BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(browser()->profile()); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); const BookmarkNode* parent = bookmark_model->bookmark_bar_node(); bookmark_model->AddURL( parent, 0, base::ASCIIToUTF16("Title"), GURL("about:blank")); @@ -503,7 +503,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, EventDispatchToTab) { // Send an event by making a bookmark. BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(browser()->profile()); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); bookmarks::AddIfNotBookmarked(bookmark_model, GURL("http://www.google.com"), base::UTF8ToUTF16("Google")); diff --git a/chrome/browser/history/android/android_history_provider_service_unittest.cc b/chrome/browser/history/android/android_history_provider_service_unittest.cc index 949bb4c..e2f7ccc 100644 --- a/chrome/browser/history/android/android_history_provider_service_unittest.cc +++ b/chrome/browser/history/android/android_history_provider_service_unittest.cc @@ -54,7 +54,7 @@ class AndroidHistoryProviderServiceTest : public testing::Test { chrome::kInitialProfile); testing_profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(testing_profile_)); ASSERT_TRUE(testing_profile_->CreateHistoryService(true, false)); service_.reset(new AndroidHistoryProviderService(testing_profile_)); diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc index e5cac63..5fa1567 100644 --- a/chrome/browser/history/android/android_provider_backend_unittest.cc +++ b/chrome/browser/history/android/android_provider_backend_unittest.cc @@ -145,7 +145,7 @@ class AndroidProviderBackendTest : public testing::Test { bookmark_model_ = BookmarkModelFactory::GetForProfile(testing_profile); history_client_ = ChromeHistoryClientFactory::GetForProfile(testing_profile); - test::WaitForBookmarkModelToLoad(bookmark_model_); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_); ASSERT_TRUE(bookmark_model_); // Get the BookmarkModel from LastUsedProfile, this is the same way that diff --git a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc index 7ed29f8..55fcd8a 100644 --- a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc +++ b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc @@ -47,7 +47,7 @@ class BookmarkModelSQLHandlerTest : public testing::Test { // Create the BookmarkModel that doesn't need to invoke load(). testing_profile->CreateBookmarkModel(true); bookmark_model_ = BookmarkModelFactory::GetForProfile(testing_profile); - test::WaitForBookmarkModelToLoad(bookmark_model_); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_); ASSERT_TRUE(bookmark_model_); // Get the BookmarkModel from LastUsedProfile, this is the same way that // how the BookmarkModelSQLHandler gets the BookmarkModel. diff --git a/chrome/browser/history/android/sqlite_cursor_unittest.cc b/chrome/browser/history/android/sqlite_cursor_unittest.cc index 9559cf7..6660fd9 100644 --- a/chrome/browser/history/android/sqlite_cursor_unittest.cc +++ b/chrome/browser/history/android/sqlite_cursor_unittest.cc @@ -65,7 +65,7 @@ class SQLiteCursorTest : public testing::Test, chrome::kInitialProfile); testing_profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(testing_profile_)); testing_profile_->CreateFaviconService(); diff --git a/chrome/browser/history/in_memory_url_index_unittest.cc b/chrome/browser/history/in_memory_url_index_unittest.cc index a2d638c..941a94d 100644 --- a/chrome/browser/history/in_memory_url_index_unittest.cc +++ b/chrome/browser/history/in_memory_url_index_unittest.cc @@ -203,7 +203,7 @@ void InMemoryURLIndexTest::SetUp() { // We cannot access the database until the backend has been loaded. ASSERT_TRUE(profile_.CreateHistoryService(true, false)); profile_.CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(&profile_)); profile_.BlockUntilHistoryProcessesPendingRequests(); profile_.BlockUntilHistoryIndexIsRefreshed(); diff --git a/chrome/browser/importer/profile_writer_unittest.cc b/chrome/browser/importer/profile_writer_unittest.cc index afe24e6..f132772 100644 --- a/chrome/browser/importer/profile_writer_unittest.cc +++ b/chrome/browser/importer/profile_writer_unittest.cc @@ -141,7 +141,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksWithMultiProfile) { BookmarkModel* bookmark_model2 = BookmarkModelFactory::GetForProfile(&profile2); - test::WaitForBookmarkModelToLoad(bookmark_model2); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model2); bookmarks::AddIfNotBookmarked( bookmark_model2, GURL("http://www.bing.com"), base::ASCIIToUTF16("Bing")); TestingProfile profile1; @@ -150,7 +150,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksWithMultiProfile) { CreateImportedBookmarksEntries(); BookmarkModel* bookmark_model1 = BookmarkModelFactory::GetForProfile(&profile1); - test::WaitForBookmarkModelToLoad(bookmark_model1); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model1); scoped_refptr<TestProfileWriter> profile_writer( new TestProfileWriter(&profile1)); @@ -174,7 +174,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksAfterWritingDataTwice) { CreateImportedBookmarksEntries(); BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(&profile); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); scoped_refptr<TestProfileWriter> profile_writer( new TestProfileWriter(&profile)); diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc index 5468d20..7f01963 100644 --- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc @@ -124,7 +124,7 @@ class SyncBookmarkDataTypeControllerTest : public testing::Test { bookmark_model_ = static_cast<BookmarkModel*>( BookmarkModelFactory::GetInstance()->SetTestingFactoryAndUse( &profile_, BuildBookmarkModel)); - test::WaitForBookmarkModelToLoad(bookmark_model_); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_); } else { bookmark_model_ = static_cast<BookmarkModel*>( BookmarkModelFactory::GetInstance()->SetTestingFactoryAndUse( @@ -205,7 +205,7 @@ TEST_F(SyncBookmarkDataTypeControllerTest, StartBookmarkModelNotReady) { profile_.GetIOTaskRunner(), content::BrowserThread::GetMessageLoopProxyForThread( content::BrowserThread::UI)); - test::WaitForBookmarkModelToLoad(bookmark_model_); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_); EXPECT_EQ(DataTypeController::MODEL_LOADED, bookmark_dtc_->state()); bookmark_dtc_->StartAssociating( diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc index bd7a38c..071efe9 100644 --- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc +++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc @@ -274,7 +274,7 @@ class FakeServerChange { class ExtensiveChangesBookmarkModelObserver : public BaseBookmarkModelObserver { public: - explicit ExtensiveChangesBookmarkModelObserver() + ExtensiveChangesBookmarkModelObserver() : started_count_(0), completed_count_at_started_(0), completed_count_(0) {} @@ -399,7 +399,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test { bool delete_bookmarks = load == DELETE_EXISTING_STORAGE; profile_.CreateBookmarkModel(delete_bookmarks); model_ = BookmarkModelFactory::GetForProfile(&profile_); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); // This noticeably speeds up the unit tests that request it. if (save == DONT_SAVE_TO_STORAGE) model_->ClearStore(); diff --git a/chrome/browser/sync/test/integration/sync_test.cc b/chrome/browser/sync/test/integration/sync_test.cc index dc27dc4..729bc7e 100644 --- a/chrome/browser/sync/test/integration/sync_test.cc +++ b/chrome/browser/sync/test/integration/sync_test.cc @@ -350,7 +350,7 @@ bool SyncTest::SetupClients() { // Create the verifier profile. verifier_ = MakeProfile(FILE_PATH_LITERAL("Verifier")); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(verifier())); ui_test_utils::WaitForHistoryToLoad(HistoryServiceFactory::GetForProfile( verifier(), Profile::EXPLICIT_ACCESS)); @@ -395,7 +395,7 @@ void SyncTest::InitializeInstance(int index) { << index << "."; InitializeInvalidations(index); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(GetProfile(index))); ui_test_utils::WaitForHistoryToLoad(HistoryServiceFactory::GetForProfile( GetProfile(index), Profile::EXPLICIT_ACCESS)); diff --git a/chrome/browser/ui/bookmarks/bookmark_browsertest.cc b/chrome/browser/ui/bookmarks/bookmark_browsertest.cc index b96c0b1..035f7e0 100644 --- a/chrome/browser/ui/bookmarks/bookmark_browsertest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_browsertest.cc @@ -80,7 +80,7 @@ class BookmarkBrowsertest : public InProcessBrowserTest { BookmarkModel* WaitForBookmarkModel(Profile* profile) { BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); return bookmark_model; } diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc index 3394688..86388e1 100644 --- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc +++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc @@ -55,7 +55,7 @@ class BookmarkContextMenuControllerTest : public testing::Test { profile_ = builder.Build(); profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); AddTestData(model_); } @@ -245,7 +245,7 @@ TEST_F(BookmarkContextMenuControllerTest, DisableIncognito) { incognito->CreateBookmarkModel(true); BookmarkModel* model = BookmarkModelFactory::GetForProfile(incognito); - test::WaitForBookmarkModelToLoad(model); + bookmarks::test::WaitForBookmarkModelToLoad(model); AddTestData(model); std::vector<const BookmarkNode*> nodes; diff --git a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc index 7d0c389..afc0f0a 100644 --- a/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc +++ b/chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc @@ -69,7 +69,7 @@ RecentlyUsedFoldersComboModelTest::RecentlyUsedFoldersComboModelTest() void RecentlyUsedFoldersComboModelTest::SetUp() { profile_.reset(new TestingProfile()); profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad(GetModel()); + bookmarks::test::WaitForBookmarkModelToLoad(GetModel()); } void RecentlyUsedFoldersComboModelTest::TearDown() { diff --git a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm index c6cab32..cf8e64c 100644 --- a/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm +++ b/chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm @@ -67,7 +67,7 @@ void BookmarkAppleScriptTest::SetUp() { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string modelString("a f1:[ b d c ] d f2:[ e f g ] h "); - test::AddNodesFromModelString(model, root, modelString); + bookmarks::test::AddNodesFromModelString(model, root, modelString); bookmarkBar_.reset([[BookmarkFolderAppleScript alloc] initWithBookmarkNode:model->bookmark_bar_node()]); } diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm index 2a7eff4..65a4353 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm @@ -1265,10 +1265,10 @@ TEST_F(BookmarkBarControllerTest, TestFolderButtons) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b 4f:[ 4f1b 4f2b ] "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model and that we do not have a folder controller. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); EXPECT_FALSE([bar_ folderController]); @@ -1484,10 +1484,10 @@ TEST_F(BookmarkBarControllerTest, MoveRemoveAddButtons) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Remember how many buttons are showing. @@ -1562,7 +1562,7 @@ TEST_F(BookmarkBarControllerTest, LastBookmarkResizeBehavior) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); [bar_ frameDidChange]; // The default font changed between OSX Mavericks and OSX Yosemite, so this @@ -1594,7 +1594,7 @@ TEST_F(BookmarkBarControllerTest, BookmarksWithAppsPageShortcut) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); [bar_ frameDidChange]; // Apps page shortcut button should be visible. @@ -1815,10 +1815,10 @@ TEST_F(BookmarkBarControllerDragDropTest, DragMoveBarBookmarkToOffTheSide) { "3bWithLongName 4bWithLongName 5bWithLongName 6bWithLongName " "7bWithLongName 8bWithLongName 9bWithLongName 10bWithLongName " "11bWithLongName 12bWithLongName 13b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Insure that the off-the-side is not showing. @@ -1867,16 +1867,16 @@ TEST_F(BookmarkBarControllerDragDropTest, DragOffTheSideToOther) { "11bWithLongName 12bWithLongName 13bWithLongName 14bWithLongName " "15bWithLongName 16bWithLongName 17bWithLongName 18bWithLongName " "19bWithLongName 20bWithLongName "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); const BookmarkNode* other = model->other_node(); const std::string other_string("1other 2other 3other "); - test::AddNodesFromModelString(model, other, other_string); + bookmarks::test::AddNodesFromModelString(model, other, other_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); - std::string actualOtherString = test::ModelStringFromNode(other); + std::string actualOtherString = bookmarks::test::ModelStringFromNode(other); EXPECT_EQ(other_string, actualOtherString); // Insure that the off-the-side is showing. @@ -1920,16 +1920,16 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkData) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); const BookmarkNode* other = model->other_node(); const std::string other_string("O1b O2b O3f:[ O3f1b O3f2f ] " "O4f:[ O4f1b O4f2f ] 05b "); - test::AddNodesFromModelString(model, other, other_string); + bookmarks::test::AddNodesFromModelString(model, other, other_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); - actual = test::ModelStringFromNode(other); + actual = bookmarks::test::ModelStringFromNode(other); EXPECT_EQ(other_string, actual); // Remember the little ones. @@ -1951,7 +1951,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkData) { // Verify the model. const std::string expected("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] O3f:[ O3f1b O3f2f ] 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); oldChildCount = newChildCount; @@ -1971,7 +1971,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkData) { const std::string expected1("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b O4f:[ O4f1b O4f2f ] ] O3f:[ O3f1b O3f2f ] " "3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected1, actual); } @@ -1980,10 +1980,10 @@ TEST_F(BookmarkBarControllerDragDropTest, AddURLs) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); // Remember the children. @@ -2003,7 +2003,7 @@ TEST_F(BookmarkBarControllerDragDropTest, AddURLs) { // Verify the model. const std::string expected("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] SiteA SiteB 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); } @@ -2011,10 +2011,10 @@ TEST_F(BookmarkBarControllerDragDropTest, ControllerForNode) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Find the main bar controller. @@ -2027,7 +2027,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DropPositionIndicator) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b 2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Hide the apps shortcut. profile()->GetPrefs()->SetBoolean( @@ -2035,7 +2035,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DropPositionIndicator) { ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]); // Validate initial model. - std::string actualModel = test::ModelStringFromNode(root); + std::string actualModel = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModel); // Test a series of points starting at the right edge of the bar. @@ -2102,10 +2102,10 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkDataToTrash) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); int oldChildCount = root->child_count(); @@ -2122,7 +2122,7 @@ TEST_F(BookmarkBarControllerDragDropTest, DragBookmarkDataToTrash) { // Verify the model. const std::string expected("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); // Verify that the other bookmark folder can't be deleted. diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm index 4b9c3ac..b5b7bbc 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm @@ -729,10 +729,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToFolder) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu and drag in a button from the bar. @@ -761,7 +761,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToFolder) { const std::string expected_string("2f:[ 2f1b 1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ " "4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - EXPECT_EQ(expected_string, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root)); // Verify the window still appears by looking for its controller. EXPECT_TRUE([bar_ folderController]); @@ -792,7 +792,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToFolder) { [bar_ dragButton:draggedButton to:[targetButton left] copy:NO]; - EXPECT_EQ(model_string, test::ModelStringFromNode(root)); + EXPECT_EQ(model_string, bookmarks::test::ModelStringFromNode(root)); // Don't check the folder window since it's not supposed to be showing. } @@ -802,10 +802,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragCopyBarBookmarkToFolder) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu and copy in a button from the bar. @@ -833,7 +833,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragCopyBarBookmarkToFolder) { const std::string expected_1("1b 2f:[ 2f1b 1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ " "4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - EXPECT_EQ(expected_1, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_1, bookmarks::test::ModelStringFromNode(root)); // Gather the new frames. NSRect newToFolderFrame = [toFolder frame]; @@ -857,7 +857,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragCopyBarBookmarkToFolder) { const std::string expected_2("1b 2f:[ 2f1b 1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 1b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ " "4f2f1b 4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - EXPECT_EQ(expected_2, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_2, bookmarks::test::ModelStringFromNode(root)); } TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToSubfolder) { @@ -866,10 +866,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToSubfolder) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu and a subfolder menu. @@ -907,7 +907,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveBarBookmarkToSubfolder) { const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ " "4f2f1b 4f2f2b 4f2f3b 5b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] "); - EXPECT_EQ(expected_string, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root)); // Check button spacing. [folderController validateMenuSpacing]; @@ -931,10 +931,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveWithinFolder) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu. @@ -961,7 +961,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveWithinFolder) { const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 4f:[ 4f2f:[ 4f2f1b 4f2f2b 4f2f3b ] " "4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - EXPECT_EQ(expected_string, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root)); // The window should not have gone away. EXPECT_TRUE([bar_ folderController]); @@ -980,10 +980,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragParentOntoChild) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu. @@ -1005,7 +1005,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragParentOntoChild) { to:[targetButton top] copy:NO]; // The model should not have changed. - EXPECT_EQ(model_string, test::ModelStringFromNode(root)); + EXPECT_EQ(model_string, bookmarks::test::ModelStringFromNode(root)); // Check button spacing. [folderController validateMenuSpacing]; @@ -1017,10 +1017,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveChildToParent) { const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f:[ 4f2f1b " "4f2f2b 4f2f3b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu and a subfolder menu. @@ -1053,7 +1053,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragMoveChildToParent) { const std::string expected_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4f:[ 4f1f:[ 4f1f1b 4f1f2b 4f1f3b ] 4f2f3b 4f2f:[ " "4f2f1b 4f2f2b ] 4f3f:[ 4f3f1b 4f3f2b 4f3f3b ] ] 5b "); - EXPECT_EQ(expected_string, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root)); // Check button spacing. [folderController validateMenuSpacing]; @@ -1068,10 +1068,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragWindowResizing) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string( "a b:[ b1 b2 b3 ] reallyReallyLongBookmarkName c "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu. @@ -1097,7 +1097,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragWindowResizing) { // Verify the model change. const std::string expected_string( "a b:[ b1 reallyReallyLongBookmarkName b2 b3 ] c "); - EXPECT_EQ(expected_string, test::ModelStringFromNode(root)); + EXPECT_EQ(expected_string, bookmarks::test::ModelStringFromNode(root)); // Verify the window grew. Just test a reasonable width gain. CGFloat newWidth = NSWidth([toWindow frame]); EXPECT_LT(oldWidth + 30.0, newWidth); @@ -1107,10 +1107,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, MoveRemoveAddButtons) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b 2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Pop up a folder menu. @@ -1207,10 +1207,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, ControllerForNode) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Find the main bar controller. @@ -1242,10 +1242,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, MenuSizingAndScrollArrows) { BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2b 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); const BookmarkNode* parent = model->bookmark_bar_node(); @@ -1406,16 +1406,16 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkData) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); const BookmarkNode* other = model->other_node(); const std::string other_string("O1b O2b O3f:[ O3f1b O3f2f ] " "O4f:[ O4f1b O4f2f ] 05b "); - test::AddNodesFromModelString(model, other, other_string); + bookmarks::test::AddNodesFromModelString(model, other, other_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); - actual = test::ModelStringFromNode(other); + actual = bookmarks::test::ModelStringFromNode(other); EXPECT_EQ(other_string, actual); // Pop open a folder. @@ -1440,7 +1440,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkData) { // Verify the model. const std::string expected("1b 2f:[ O3f:[ O3f1b O3f2f ] 2f1b 2f2f:[ 2f2f1b " "2f2f2b 2f2f3b ] 2f3b ] 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); // Now drag over a folder button. @@ -1456,7 +1456,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkData) { const std::string expectedA("1b 2f:[ O3f:[ O3f1b O3f2f ] 2f1b 2f2f:[ " "2f2f1b 2f2f2b 2f2f3b O4f:[ O4f1b O4f2f ] ] " "2f3b ] 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expectedA, actual); // Check button spacing. @@ -1468,10 +1468,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkDataToTrash) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); const BookmarkNode* folderNode = root->GetChild(1); @@ -1499,7 +1499,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DragBookmarkDataToTrash) { // Verify the model. const std::string expected("1b 2f:[ 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); // Check button spacing. @@ -1511,10 +1511,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, AddURLs) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); // Pop open a folder. @@ -1544,7 +1544,7 @@ TEST_F(BookmarkBarFolderControllerMenuTest, AddURLs) { // Verify the model. const std::string expected("1b 2f:[ SiteA SiteB 2f1b 2f2f:[ 2f2f1b 2f2f2b " "2f2f3b ] 2f3b ] 3b 4b "); - actual = test::ModelStringFromNode(root); + actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(expected, actual); // Check button spacing. @@ -1556,10 +1556,10 @@ TEST_F(BookmarkBarFolderControllerMenuTest, DropPositionIndicator) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b 2f2f3b ] " "2f3b ] 3b 4b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actual = test::ModelStringFromNode(root); + std::string actual = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actual); // Pop open the folder. @@ -1615,10 +1615,10 @@ TEST_F(BookmarkBarFolderControllerClosingTest, DeleteClosesFolder) { const BookmarkNode* root = model->bookmark_bar_node(); const std::string model_string("1b 2f:[ 2f1b 2f2f:[ 2f2f1b 2f2f2b ] " "2f3b ] 3b "); - test::AddNodesFromModelString(model, root, model_string); + bookmarks::test::AddNodesFromModelString(model, root, model_string); // Validate initial model. - std::string actualModelString = test::ModelStringFromNode(root); + std::string actualModelString = bookmarks::test::ModelStringFromNode(root); EXPECT_EQ(model_string, actualModelString); // Open the folder menu and submenu. diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm index b16fc59..38b507f 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm @@ -158,7 +158,7 @@ TEST_F(BookmarkBarFolderViewTest, BookmarkButtonDragAndDropAcrossProfiles) { TestingProfile* other_profile = testing_profile_manager()->CreateTestingProfile("other"); other_profile->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(other_profile)); mock_controller_.reset(GetMockController( diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm index 21b0466..4e18604 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm @@ -257,7 +257,7 @@ TEST_F(BookmarkBarViewTest, BookmarkButtonDragAndDropAcrossProfiles) { BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile()); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); const BookmarkNode* node = bookmark_model->AddURL(bookmark_model->bookmark_bar_node(), diff --git a/chrome/browser/ui/cocoa/cocoa_profile_test.mm b/chrome/browser/ui/cocoa/cocoa_profile_test.mm index 87f757c..87de045 100644 --- a/chrome/browser/ui/cocoa/cocoa_profile_test.mm +++ b/chrome/browser/ui/cocoa/cocoa_profile_test.mm @@ -60,7 +60,7 @@ void CocoaProfileTest::SetUp() { profile_, &AutocompleteClassifierFactory::BuildInstanceFor); profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(profile_)); browser_.reset(CreateBrowser()); diff --git a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm index 36a6496..86eeda0 100644 --- a/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm +++ b/chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm @@ -109,7 +109,7 @@ TEST_F(AvatarIconControllerTest, SupervisedUserLabel) { AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse( profile, &AutocompleteClassifierFactory::BuildInstanceFor); profile->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(profile)); Browser* browser = diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm index 083b23d..fe3666c 100644 --- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm +++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm @@ -58,7 +58,7 @@ class ViewIDTest : public InProcessBrowserTest { BookmarkModelFactory::GetForProfile(browser()->profile()); if (bookmark_model) { if (!bookmark_model->loaded()) - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); bookmarks::AddIfNotBookmarked(bookmark_model, GURL(url::kAboutBlankURL), diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc index 227ddac..4a0f5c1 100644 --- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc +++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc @@ -291,7 +291,7 @@ class OmniboxViewTest : public InProcessBrowserTest, BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile); ASSERT_TRUE(bookmark_model); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); GURL url(entry.url); // Add everything in order of time. We don't want to have a time that diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc index 105cdf5..7eca802 100644 --- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc +++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc @@ -140,7 +140,7 @@ class ProfileSigninConfirmationHelperTest : public testing::Test { // Initialize the services we check. profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); ASSERT_TRUE(profile_->CreateHistoryService(true, false)); #if defined(ENABLE_EXTENSIONS) extensions::TestExtensionSystem* system = diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc index 197f926..08f27c9 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc @@ -264,7 +264,7 @@ class BookmarkBarViewEventTestBase : public ViewEventTestBase { profile_.reset(new TestingProfile()); profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); profile_->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, true); Browser::CreateParams native_params(profile_.get(), diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc index e05f822..14609fb 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc @@ -63,7 +63,7 @@ class BookmarkBarViewTest : public BrowserWithTestWindowTest { // BookmarkBarView. void CreateBookmarkModelAndBookmarkBarView() { profile()->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad( + bookmarks::test::WaitForBookmarkModelToLoad( BookmarkModelFactory::GetForProfile(profile())); CreateBookmarkBarView(); } diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc index 9ac3e9f..e4d4c0d 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc @@ -31,7 +31,7 @@ class BookmarkBubbleViewTest : public BrowserWithTestWindowTest { profile()->CreateBookmarkModel(true); BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile()); - test::WaitForBookmarkModelToLoad(bookmark_model); + bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model); bookmarks::AddIfNotBookmarked( bookmark_model, GURL(kTestBookmarkURL), base::string16()); diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc index 4d8a382..06f2794 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc @@ -69,7 +69,7 @@ class BookmarkContextMenuTest : public testing::Test { profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); AddTestData(); } diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc index 9ab145e..6f74b09 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc @@ -40,7 +40,7 @@ class BookmarkEditorViewTest : public testing::Test { profile_->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile_.get()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); AddTestData(); } diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc index d1329c1..aa9a559 100644 --- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc +++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate_unittest.cc @@ -28,7 +28,7 @@ class BookmarkMenuDelegateTest : public BrowserWithTestWindowTest { profile()->CreateBookmarkModel(true); model_ = BookmarkModelFactory::GetForProfile(profile()); - test::WaitForBookmarkModelToLoad(model_); + bookmarks::test::WaitForBookmarkModelToLoad(model_); AddTestData(); } diff --git a/chrome/browser/undo/bookmark_undo_service_test.cc b/chrome/browser/undo/bookmark_undo_service_test.cc index 9d5fa3c..54976e7 100644 --- a/chrome/browser/undo/bookmark_undo_service_test.cc +++ b/chrome/browser/undo/bookmark_undo_service_test.cc @@ -39,7 +39,7 @@ BookmarkUndoServiceTest::BookmarkUndoServiceTest() {} void BookmarkUndoServiceTest::SetUp() { profile_.reset(new TestingProfile); profile_->CreateBookmarkModel(true); - test::WaitForBookmarkModelToLoad(GetModel()); + bookmarks::test::WaitForBookmarkModelToLoad(GetModel()); } BookmarkModel* BookmarkUndoServiceTest::GetModel() { diff --git a/components/bookmarks/test/bookmark_test_helpers.cc b/components/bookmarks/test/bookmark_test_helpers.cc index de4a899..a8c6d94 100644 --- a/components/bookmarks/test/bookmark_test_helpers.cc +++ b/components/bookmarks/test/bookmark_test_helpers.cc @@ -14,6 +14,9 @@ #include "components/bookmarks/browser/bookmark_model.h" #include "url/gurl.h" +namespace bookmarks { +namespace test { + namespace { // BookmarkLoadObserver is used when blocking until the BookmarkModel finishes @@ -92,8 +95,6 @@ std::string::size_type AddNodesFromString(BookmarkModel* model, } // namespace -namespace test { - void WaitForBookmarkModelToLoad(BookmarkModel* model) { if (model->loaded()) return; @@ -136,3 +137,4 @@ void AddNodesFromModelString(BookmarkModel* model, } } // namespace test +} // namespace bookmarks diff --git a/components/bookmarks/test/bookmark_test_helpers.h b/components/bookmarks/test/bookmark_test_helpers.h index cd107dd..a75609e 100644 --- a/components/bookmarks/test/bookmark_test_helpers.h +++ b/components/bookmarks/test/bookmark_test_helpers.h @@ -10,6 +10,7 @@ class BookmarkModel; class BookmarkNode; +namespace bookmarks { namespace test { // Blocks until |model| finishes loading. @@ -40,6 +41,8 @@ std::string ModelStringFromNode(const BookmarkNode* node); void AddNodesFromModelString(BookmarkModel* model, const BookmarkNode* node, const std::string& model_string); + } // namespace test +} // namespace bookmarks #endif // COMPONENTS_BOOKMARKS_TEST_BOOKMARK_TEST_HELPERS_H_ diff --git a/components/policy/core/browser/managed_bookmarks_tracker_unittest.cc b/components/policy/core/browser/managed_bookmarks_tracker_unittest.cc index 5903e05..295e8b5 100644 --- a/components/policy/core/browser/managed_bookmarks_tracker_unittest.cc +++ b/components/policy/core/browser/managed_bookmarks_tracker_unittest.cc @@ -66,7 +66,7 @@ class ManagedBookmarksTrackerTest : public testing::Test { base::FilePath(), base::MessageLoopProxy::current(), base::MessageLoopProxy::current()); - test::WaitForBookmarkModelToLoad(model_.get()); + bookmarks::test::WaitForBookmarkModelToLoad(model_.get()); Mock::VerifyAndClearExpectations(&observer_); ASSERT_EQ(1u, client_.extra_nodes().size()); |