diff options
| author | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-06 02:07:18 +0000 |
|---|---|---|
| committer | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-06 02:07:18 +0000 |
| commit | 8fbd29a24d5e7238dc240190a978bc5ce7a2a7ec (patch) | |
| tree | e0f9cac3e1293b06270379f516859aa240f6254b | |
| parent | d78923e85abdcc5acf479371668370754f05e0bd (diff) | |
| download | chromium_src-8fbd29a24d5e7238dc240190a978bc5ce7a2a7ec.zip chromium_src-8fbd29a24d5e7238dc240190a978bc5ce7a2a7ec.tar.gz chromium_src-8fbd29a24d5e7238dc240190a978bc5ce7a2a7ec.tar.bz2 | |
Avoid rebuilding remoting host every time gyp runs
Previously CLSID for COM classes used in chromoting host on windows were
random, generated every time gyp runs. As result the targets that depend
on it had to be rebuilt even when there are no code changes. Changed
remoting.gyp to generate stable CLSID as a hash of the current version
number.
BUG=332679
Review URL: https://codereview.chromium.org/146623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249218 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | remoting/remoting.gyp | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp index 713ee4c..da3a51f 100644 --- a/remoting/remoting.gyp +++ b/remoting/remoting.gyp @@ -59,16 +59,17 @@ ['OS=="win"', { 'host_plugin_extension': 'dll', 'host_plugin_prefix': '', - # Use auto-generated CLSIDs to make sure that the newly installed COM - # classes will be used during/after upgrade even if there are old - # instances running already. - # The parameter at the end is ignored, but needed to make sure that the - # script will be invoked separately for each CLSID. Otherwise GYP will - # reuse the value returned by the first invocation of the script. + + # Each CLSID is a hash of the current version string salted with an + # arbitrary GUID. This ensures that the newly installed COM classes will + # be used during/after upgrade even if there are old instances running + # already. + # The IDs are not random to avoid rebuilding host when it's not + # necessary. 'daemon_controller_clsid': - '<!(python -c "import uuid; print uuid.uuid4()" 1)', + '<!(python -c "import uuid; print uuid.uuid5(uuid.UUID(\'655bd819-c08c-4b04-80c2-f160739ff6ef\'), \'<(version_full)\')")', 'rdp_desktop_session_clsid': - '<!(python -c "import uuid; print uuid.uuid4()" 2)', + '<!(python -c "import uuid; print uuid.uuid5(uuid.UUID(\'6a7699f0-ee43-43e7-aa30-a6738f9bd470\'), \'<(version_full)\')")', }], ], 'remoting_locales': [ |