diff options
author | dcheng <dcheng@chromium.org> | 2014-10-17 10:56:26 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-17 17:57:33 +0000 |
commit | 923ac874a9cddf888f3ceb902bc9e5aa1445567e (patch) | |
tree | 1b60880f3322b31abca145508a3e066e28ee2b60 | |
parent | b3f40a948849af08a3ecec7743f1e2ee40e61e6d (diff) | |
download | chromium_src-923ac874a9cddf888f3ceb902bc9e5aa1445567e.zip chromium_src-923ac874a9cddf888f3ceb902bc9e5aa1445567e.tar.gz chromium_src-923ac874a9cddf888f3ceb902bc9e5aa1445567e.tar.bz2 |
Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.
BUG=423621
Review URL: https://codereview.chromium.org/663563002
Cr-Commit-Position: refs/heads/master@{#300128}
19 files changed, 39 insertions, 50 deletions
diff --git a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc index ef0c3ed..db393f9 100644 --- a/content/browser/android/in_process/synchronous_compositor_factory_impl.cc +++ b/content/browser/android/in_process/synchronous_compositor_factory_impl.cc @@ -181,7 +181,7 @@ SynchronousCompositorFactoryImpl::CreateOutputSurface( scoped_ptr<SynchronousCompositorOutputSurface> output_surface( new SynchronousCompositorOutputSurface(routing_id, frame_swap_message_queue)); - return output_surface.PassAs<cc::OutputSurface>(); + return output_surface.Pass(); } InputHandlerManagerClient* diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc index 1b91c8c..c0b20b9 100644 --- a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc +++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc @@ -460,8 +460,7 @@ void GinJavaBridgeDispatcherHost::OnInvokeMethod( pending_replies_[render_frame_host] = reply_msg; scoped_refptr<GinJavaMethodInvocationHelper> result = new GinJavaMethodInvocationHelper( - make_scoped_ptr(new GinJavaBoundObjectDelegate(object)) - .PassAs<GinJavaMethodInvocationHelper::ObjectDelegate>(), + make_scoped_ptr(new GinJavaBoundObjectDelegate(object)), method_name, arguments); result->Init(this); diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc index c286b6f..b917df6 100644 --- a/content/browser/compositor/gpu_process_transport_factory.cc +++ b/content/browser/compositor/gpu_process_transport_factory.cc @@ -207,7 +207,7 @@ scoped_ptr<cc::OutputSurface> GpuProcessTransportFactory::CreateOutputSurface( display_client->set_surface_output_surface(output_surface.get()); output_surface->set_display_client(display_client.get()); data->display_client = display_client.Pass(); - return output_surface.PassAs<cc::OutputSurface>(); + return output_surface.Pass(); } if (!context_provider.get()) { @@ -216,14 +216,12 @@ scoped_ptr<cc::OutputSurface> GpuProcessTransportFactory::CreateOutputSurface( " compositing with browser threaded compositing. Aborting."; } - scoped_ptr<SoftwareBrowserCompositorOutputSurface> surface( - new SoftwareBrowserCompositorOutputSurface( - output_surface_proxy_, - CreateSoftwareOutputDevice(compositor), - per_compositor_data_[compositor]->surface_id, - &output_surface_map_, - compositor->vsync_manager())); - return surface.PassAs<cc::OutputSurface>(); + return make_scoped_ptr(new SoftwareBrowserCompositorOutputSurface( + output_surface_proxy_, + CreateSoftwareOutputDevice(compositor), + per_compositor_data_[compositor]->surface_id, + &output_surface_map_, + compositor->vsync_manager())); } scoped_ptr<BrowserCompositorOutputSurface> surface; @@ -249,7 +247,7 @@ scoped_ptr<cc::OutputSurface> GpuProcessTransportFactory::CreateOutputSurface( if (data->reflector.get()) data->reflector->ReattachToOutputSurfaceFromMainThread(surface.get()); - return surface.PassAs<cc::OutputSurface>(); + return surface.Pass(); } scoped_refptr<ui::Reflector> GpuProcessTransportFactory::CreateReflector( diff --git a/content/browser/download/download_browsertest.cc b/content/browser/download/download_browsertest.cc index e21ae27..d516d9a 100644 --- a/content/browser/download/download_browsertest.cc +++ b/content/browser/download/download_browsertest.cc @@ -522,7 +522,7 @@ scoped_ptr<net::test_server::HttpResponse> HandleRequestAndSendRedirectResponse( response->set_code(net::HTTP_FOUND); response->AddCustomHeader("Location", target_url.spec()); } - return response.PassAs<net::test_server::HttpResponse>(); + return response.Pass(); } // Creates a request handler for EmbeddedTestServer that responds with a HTTP @@ -546,7 +546,7 @@ scoped_ptr<net::test_server::HttpResponse> HandleRequestAndSendBasicResponse( response->set_content_type(content_type); response->set_content(body); } - return response.PassAs<net::test_server::HttpResponse>(); + return response.Pass(); } // Creates a request handler for an EmbeddedTestServer that response with an diff --git a/content/browser/download/download_file_unittest.cc b/content/browser/download/download_file_unittest.cc index 76cdaaf..40f4fad 100644 --- a/content/browser/download/download_file_unittest.cc +++ b/content/browser/download/download_file_unittest.cc @@ -182,7 +182,7 @@ class DownloadFileTest : public testing::Test { net::BoundNetLog(), observer_factory_.GetWeakPtr())); download_file_impl->SetClientGuid("12345678-ABCD-1234-DCBA-123456789ABC"); - download_file_ = download_file_impl.PassAs<DownloadFile>(); + download_file_ = download_file_impl.Pass(); EXPECT_CALL(*input_stream_, Read(_, _)) .WillOnce(Return(ByteStreamReader::STREAM_EMPTY)) diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc index f1c0521..af2f25e 100644 --- a/content/browser/frame_host/render_frame_host_impl.cc +++ b/content/browser/frame_host/render_frame_host_impl.cc @@ -1010,10 +1010,7 @@ void RenderFrameHostImpl::OnShowDesktopNotification( base::Closure cancel_callback; GetContentClient()->browser()->ShowDesktopNotification( - params, - this, - delegate.PassAs<DesktopNotificationDelegate>(), - &cancel_callback); + params, this, delegate.Pass(), &cancel_callback); cancel_notification_callbacks_[notification_id] = cancel_callback; } diff --git a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc index 58c1211..a3feef7 100644 --- a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc +++ b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc @@ -139,7 +139,7 @@ void BrowserGpuMemoryBufferManager::GpuMemoryBufferCreatedOnIO( scoped_ptr<GpuMemoryBufferImpl> buffer) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); - request->result = buffer.PassAs<gfx::GpuMemoryBuffer>(); + request->result = buffer.Pass(); request->event.Signal(); } diff --git a/content/browser/indexed_db/indexed_db_backing_store.cc b/content/browser/indexed_db/indexed_db_backing_store.cc index 4c25385..4bbf2f0 100644 --- a/content/browser/indexed_db/indexed_db_backing_store.cc +++ b/content/browser/indexed_db/indexed_db_backing_store.cc @@ -3781,7 +3781,7 @@ IndexedDBBackingStore::OpenObjectStoreCursor( if (!cursor->FirstSeek(s)) return scoped_ptr<IndexedDBBackingStore::Cursor>(); - return cursor.PassAs<IndexedDBBackingStore::Cursor>(); + return cursor.Pass(); } scoped_ptr<IndexedDBBackingStore::Cursor> @@ -3808,7 +3808,7 @@ IndexedDBBackingStore::OpenObjectStoreKeyCursor( if (!cursor->FirstSeek(s)) return scoped_ptr<IndexedDBBackingStore::Cursor>(); - return cursor.PassAs<IndexedDBBackingStore::Cursor>(); + return cursor.Pass(); } scoped_ptr<IndexedDBBackingStore::Cursor> @@ -3837,7 +3837,7 @@ IndexedDBBackingStore::OpenIndexKeyCursor( if (!cursor->FirstSeek(s)) return scoped_ptr<IndexedDBBackingStore::Cursor>(); - return cursor.PassAs<IndexedDBBackingStore::Cursor>(); + return cursor.Pass(); } scoped_ptr<IndexedDBBackingStore::Cursor> @@ -3865,7 +3865,7 @@ IndexedDBBackingStore::OpenIndexCursor( if (!cursor->FirstSeek(s)) return scoped_ptr<IndexedDBBackingStore::Cursor>(); - return cursor.PassAs<IndexedDBBackingStore::Cursor>(); + return cursor.Pass(); } IndexedDBBackingStore::Transaction::Transaction( diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc index 2d51ecf..10dbc01 100644 --- a/content/browser/indexed_db/indexed_db_browsertest.cc +++ b/content/browser/indexed_db/indexed_db_browsertest.cc @@ -504,7 +504,7 @@ static scoped_ptr<net::test_server::HttpResponse> CorruptDBRequestHandler( scoped_ptr<net::test_server::BasicHttpResponse> http_response( new net::test_server::BasicHttpResponse); http_response->set_code(net::HTTP_OK); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } else if (request_path == "fail" && !request_query.empty()) { FailClass failure_class = FAIL_CLASS_NOTHING; FailMethod failure_method = FAIL_METHOD_NOTHING; @@ -568,7 +568,7 @@ static scoped_ptr<net::test_server::HttpResponse> CorruptDBRequestHandler( scoped_ptr<net::test_server::BasicHttpResponse> http_response( new net::test_server::BasicHttpResponse); http_response->set_code(net::HTTP_OK); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } // A request for a test resource @@ -581,7 +581,7 @@ static scoped_ptr<net::test_server::HttpResponse> CorruptDBRequestHandler( if (!base::ReadFileToString(resourcePath, &file_contents)) return scoped_ptr<net::test_server::HttpResponse>(); http_response->set_content(file_contents); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } } // namespace diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.cc b/content/browser/indexed_db/leveldb/leveldb_transaction.cc index 26e2b94..a9e7109 100644 --- a/content/browser/indexed_db/leveldb/leveldb_transaction.cc +++ b/content/browser/indexed_db/leveldb/leveldb_transaction.cc @@ -121,7 +121,7 @@ void LevelDBTransaction::Rollback() { } scoped_ptr<LevelDBIterator> LevelDBTransaction::CreateIterator() { - return TransactionIterator::Create(this).PassAs<LevelDBIterator>(); + return TransactionIterator::Create(this); } scoped_ptr<LevelDBTransaction::DataIterator> diff --git a/content/browser/loader/resource_dispatcher_host_browsertest.cc b/content/browser/loader/resource_dispatcher_host_browsertest.cc index 1ef6fd3..5f41e548 100644 --- a/content/browser/loader/resource_dispatcher_host_browsertest.cc +++ b/content/browser/loader/resource_dispatcher_host_browsertest.cc @@ -271,7 +271,7 @@ scoped_ptr<net::test_server::HttpResponse> NoContentResponseHandler( scoped_ptr<net::test_server::BasicHttpResponse> http_response( new net::test_server::BasicHttpResponse); http_response->set_code(net::HTTP_NO_CONTENT); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } } // namespace @@ -450,7 +450,7 @@ scoped_ptr<net::test_server::HttpResponse> HandleRedirectRequest( http_response->set_code(net::HTTP_FOUND); http_response->AddCustomHeader( "Location", request.relative_url.substr(request_path.length())); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } } // namespace diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc index 4b0637d..50f5068 100644 --- a/content/browser/loader/resource_dispatcher_host_impl.cc +++ b/content/browser/loader/resource_dispatcher_host_impl.cc @@ -748,7 +748,7 @@ ResourceDispatcherHostImpl::MaybeInterceptAsStream(net::URLRequest* request, stream_info->response_headers = new net::HttpResponseHeaders(response->head.headers->raw_headers()); delegate_->OnStreamCreated(request, stream_info.Pass()); - return handler.PassAs<ResourceHandler>(); + return handler.Pass(); } ResourceDispatcherHostLoginDelegate* diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc index 099a98c..50e1835 100644 --- a/content/browser/loader/resource_loader_unittest.cc +++ b/content/browser/loader/resource_loader_unittest.cc @@ -304,7 +304,7 @@ class ResourceLoaderTest : public testing::Test, virtual scoped_ptr<ResourceHandler> WrapResourceHandler( scoped_ptr<ResourceHandlerStub> leaf_handler, net::URLRequest* request) { - return leaf_handler.PassAs<ResourceHandler>(); + return leaf_handler.Pass(); } virtual void SetUp() override { @@ -377,8 +377,7 @@ TEST_F(ResourceLoaderTest, ClientCertStoreLookup) { // Ownership of the |test_store| is about to be turned over to ResourceLoader. // We need to keep raw pointer copies to access these objects later. ClientCertStoreStub* raw_ptr_to_store = test_store.get(); - resource_context_.SetClientCertStore( - test_store.PassAs<net::ClientCertStore>()); + resource_context_.SetClientCertStore(test_store.Pass()); // Prepare a dummy certificate request. scoped_refptr<net::SSLCertRequestInfo> cert_request_info( @@ -523,14 +522,13 @@ class ResourceLoaderRedirectToFileTest : public ResourceLoaderTest { // Inject them into the handler. scoped_ptr<RedirectToFileResourceHandler> handler( - new RedirectToFileResourceHandler( - leaf_handler.PassAs<ResourceHandler>(), request)); + new RedirectToFileResourceHandler(leaf_handler.Pass(), request)); redirect_to_file_resource_handler_ = handler.get(); handler->SetCreateTemporaryFileStreamFunctionForTesting( base::Bind(&ResourceLoaderRedirectToFileTest::PostCallback, base::Unretained(this), - base::Passed(file_stream.PassAs<net::FileStream>()))); - return handler.PassAs<ResourceHandler>(); + base::Passed(&file_stream))); + return handler.Pass(); } private: diff --git a/content/browser/loader/resource_scheduler.cc b/content/browser/loader/resource_scheduler.cc index 8d4f889..4f38802 100644 --- a/content/browser/loader/resource_scheduler.cc +++ b/content/browser/loader/resource_scheduler.cc @@ -772,12 +772,12 @@ scoped_ptr<ResourceThrottle> ResourceScheduler::ScheduleRequest( // 3. The tab is closed while a RequestResource IPC is in flight. unowned_requests_.insert(request.get()); request->Start(); - return request.PassAs<ResourceThrottle>(); + return request.Pass(); } Client* client = it->second; client->ScheduleRequest(url_request, request.get()); - return request.PassAs<ResourceThrottle>(); + return request.Pass(); } void ResourceScheduler::RemoveRequest(ScheduledResourceRequest* request) { diff --git a/content/browser/media/capture/desktop_capture_device_aura_unittest.cc b/content/browser/media/capture/desktop_capture_device_aura_unittest.cc index 0adc708..81cbd15 100644 --- a/content/browser/media/capture/desktop_capture_device_aura_unittest.cc +++ b/content/browser/media/capture/desktop_capture_device_aura_unittest.cc @@ -115,8 +115,7 @@ TEST_F(DesktopCaptureDeviceAuraTest, StartAndStop) { capture_params.requested_format.frame_size.SetSize(640, 480); capture_params.requested_format.frame_rate = kFrameRate; capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420; - capture_device->AllocateAndStart( - capture_params, client.PassAs<media::VideoCaptureDevice::Client>()); + capture_device->AllocateAndStart(capture_params, client.Pass()); capture_device->StopAndDeAllocate(); } diff --git a/content/browser/media/capture/desktop_capture_device_unittest.cc b/content/browser/media/capture/desktop_capture_device_unittest.cc index 5b38fd7..883fdc4 100644 --- a/content/browser/media/capture/desktop_capture_device_unittest.cc +++ b/content/browser/media/capture/desktop_capture_device_unittest.cc @@ -175,8 +175,7 @@ TEST_F(DesktopCaptureDeviceTest, MAYBE_Capture) { capture_params.requested_format.frame_size.SetSize(640, 480); capture_params.requested_format.frame_rate = kFrameRate; capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420; - capture_device_->AllocateAndStart( - capture_params, client.PassAs<media::VideoCaptureDevice::Client>()); + capture_device_->AllocateAndStart(capture_params, client.Pass()); EXPECT_TRUE(done_event.TimedWait(TestTimeouts::action_max_timeout())); capture_device_->StopAndDeAllocate(); @@ -212,8 +211,7 @@ TEST_F(DesktopCaptureDeviceTest, ScreenResolutionChangeConstantResolution) { capture_params.requested_format.frame_rate = kFrameRate; capture_params.requested_format.pixel_format = media::PIXEL_FORMAT_I420; - capture_device_->AllocateAndStart( - capture_params, client.PassAs<media::VideoCaptureDevice::Client>()); + capture_device_->AllocateAndStart(capture_params, client.Pass()); // Capture at least two frames, to ensure that the source frame size has // changed while capturing. diff --git a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc index 23cf426..42faca1 100644 --- a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc +++ b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc @@ -402,7 +402,7 @@ class StubClientObserver { virtual ~StubClientObserver() {} scoped_ptr<media::VideoCaptureDevice::Client> PassClient() { - return client_.PassAs<media::VideoCaptureDevice::Client>(); + return client_.Pass(); } void QuitIfConditionMet(SkColor color) { diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc index b0d4dd0..fe0a76e 100644 --- a/content/browser/service_worker/service_worker_browsertest.cc +++ b/content/browser/service_worker/service_worker_browsertest.cc @@ -180,7 +180,7 @@ scoped_ptr<net::test_server::HttpResponse> VerifyServiceWorkerHeaderInRequest( scoped_ptr<net::test_server::BasicHttpResponse> http_response( new net::test_server::BasicHttpResponse()); http_response->set_content_type("text/javascript"); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } // The ImportsBustMemcache test requires that the imported script diff --git a/content/browser/session_history_browsertest.cc b/content/browser/session_history_browsertest.cc index 9e2bb66..9831759 100644 --- a/content/browser/session_history_browsertest.cc +++ b/content/browser/session_history_browsertest.cc @@ -38,7 +38,7 @@ scoped_ptr<net::test_server::HttpResponse> HandleEchoTitleRequest( base::StringPrintf( "<html><head><title>%s</title></head></html>", request.content.c_str())); - return http_response.PassAs<net::test_server::HttpResponse>(); + return http_response.Pass(); } } // namespace |