summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-20 14:42:41 +0000
committerpfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-20 14:42:41 +0000
commit92d728a8054f5728b16bda78ae81e089d08045c8 (patch)
tree643ad4983c49b4c41df4527835afffebaf05f844
parent7b1f90d097b0368ca1f84ed190157629dda6d0c0 (diff)
downloadchromium_src-92d728a8054f5728b16bda78ae81e089d08045c8.zip
chromium_src-92d728a8054f5728b16bda78ae81e089d08045c8.tar.gz
chromium_src-92d728a8054f5728b16bda78ae81e089d08045c8.tar.bz2
DevTools: remember variable tree expansion state while debugging.
BUG=17233 Review URL: http://codereview.chromium.org/155770 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21074 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/glue/devtools/js/debugger_agent.js24
-rw-r--r--webkit/glue/devtools/js/devtools.js4
2 files changed, 24 insertions, 4 deletions
diff --git a/webkit/glue/devtools/js/debugger_agent.js b/webkit/glue/devtools/js/debugger_agent.js
index 2fed562..9badf9c 100644
--- a/webkit/glue/devtools/js/debugger_agent.js
+++ b/webkit/glue/devtools/js/debugger_agent.js
@@ -1280,6 +1280,30 @@ devtools.CallFrame.getVariablesInScopeAsync = function(callFrame, callback) {
/**
+ * 'Static' expanded properties container shared among callframes.
+ */
+devtools.CallFrame.expandedProperties_ = {};
+
+
+/**
+ * Overrides _expandedProperties accessor for auto-expand.
+ */
+devtools.CallFrame.prototype.__defineGetter__('_expandedProperties',
+ function() {
+ return devtools.CallFrame.expandedProperties_;
+});
+
+
+/**
+ * Overrides _expandedProperties accessor for auto-expand.
+ */
+devtools.CallFrame.prototype.__defineSetter__('_expandedProperties',
+ function(newValue) {
+ devtools.CallFrame.expandedProperties_ = newValue;
+});
+
+
+/**
* JSON based commands sent to v8 debugger.
* @param {string} command Name of the command to execute.
* @param {Object} opt_arguments Command-specific arguments map.
diff --git a/webkit/glue/devtools/js/devtools.js b/webkit/glue/devtools/js/devtools.js
index eaf97f4..1099776 100644
--- a/webkit/glue/devtools/js/devtools.js
+++ b/webkit/glue/devtools/js/devtools.js
@@ -613,10 +613,6 @@ WebInspector.ScopeChainSidebarPane.prototype.update = function(callFrame) {
return;
}
- if (!callFrame._expandedProperties) {
- callFrame._expandedProperties = {};
- }
-
var scopeChain = callFrame.scopeChain;
var ScopeType = devtools.DebuggerAgent.ScopeType;
for (var i = 0; i < scopeChain.length; ++i) {