summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjbroman@chromium.org <jbroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-27 21:52:51 +0000
committerjbroman@chromium.org <jbroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-27 21:52:51 +0000
commit968644f430b4d4eb94a313c3bbdcba5dab754d3b (patch)
treeff35011e1111ca515474d815945bd83aacc7a152
parent4ba8eb3cbdaa1880cfb8def22ca9bf3c2757f2fc (diff)
downloadchromium_src-968644f430b4d4eb94a313c3bbdcba5dab754d3b.zip
chromium_src-968644f430b4d4eb94a313c3bbdcba5dab754d3b.tar.gz
chromium_src-968644f430b4d4eb94a313c3bbdcba5dab754d3b.tar.bz2
Remove Chromium plumbing for fixed-position-creates-stacking-context
This is a no-op since over a month ago: https://codereview.chromium.org/206463009/ So it's probably safe to remove the Chromium code which plumbs this preference around before Blink drops it on the floor. After this lands, WebSettings::setFixedPositionCreatesStackingContext can be removed entirely. BUG=354688 Review URL: https://codereview.chromium.org/289973008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273045 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--build/ios/grit_whitelist.txt2
-rw-r--r--chrome/app/generated_resources.grd6
-rw-r--r--chrome/browser/about_flags.cc9
-rw-r--r--content/browser/renderer_host/render_view_host_impl.cc3
-rw-r--r--content/public/common/common_param_traits_macros.h1
-rw-r--r--content/public/common/content_switches.cc6
-rw-r--r--content/public/common/content_switches.h2
-rw-r--r--content/renderer/web_preferences.cc3
-rw-r--r--content/shell/common/webkit_test_helpers.cc1
-rw-r--r--webkit/common/webpreferences.cc1
-rw-r--r--webkit/common/webpreferences.h1
11 files changed, 0 insertions, 35 deletions
diff --git a/build/ios/grit_whitelist.txt b/build/ios/grit_whitelist.txt
index 499267a..6174648 100644
--- a/build/ios/grit_whitelist.txt
+++ b/build/ios/grit_whitelist.txt
@@ -489,8 +489,6 @@ IDS_FLAGS_EXPERIMENTAL_WEB_PLATFORM_FEATURES_DESCRIPTION
IDS_FLAGS_EXPERIMENTAL_WEB_PLATFORM_FEATURES_NAME
IDS_FLAGS_EXTENSIONS_ON_CHROME_URLS_DESCRIPTION
IDS_FLAGS_EXTENSIONS_ON_CHROME_URLS_NAME
-IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_DESCRIPTION
-IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_NAME
IDS_FLAGS_FORCE_ACCELERATED_OVERFLOW_SCROLL_MODE_DESCRIPTION
IDS_FLAGS_FORCE_ACCELERATED_OVERFLOW_SCROLL_MODE_NAME
IDS_FLAGS_FORCE_HIGH_DPI_DESCRIPTION
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 9139dca..138064a 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -5751,12 +5751,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
Enabling this option prevents web sites from accessing the WebAudio API.
</message>
</if>
- <message name="IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_NAME" desc="Name of the 'Fixed position creates stacking context' lab.">
- Fixed position elements create stacking contexts.
- </message>
- <message name="IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_DESCRIPTION" desc="Description for the flag to make fixed position elements create stacking contexts.">
- Enabling this option makes all fixed position elements create new CSS stacking contexts.
- </message>
<message name="IDS_FLAGS_COMPOSITING_FOR_FIXED_POSITION_NAME" desc="Name of the 'Compositing for fixed position elements' lab.">
Compositing for fixed position elements.
</message>
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index c9c0d4a..8a2e2ad 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -576,15 +576,6 @@ const Experiment kExperiments[] = {
},
#endif
{
- "fixed-position-creates-stacking-context",
- IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_NAME,
- IDS_FLAGS_FIXED_POSITION_CREATES_STACKING_CONTEXT_DESCRIPTION,
- kOsAll,
- ENABLE_DISABLE_VALUE_TYPE(
- switches::kEnableFixedPositionCreatesStackingContext,
- switches::kDisableFixedPositionCreatesStackingContext)
- },
- {
"enable-compositing-for-fixed-position",
IDS_FLAGS_COMPOSITING_FOR_FIXED_POSITION_NAME,
IDS_FLAGS_COMPOSITING_FOR_FIXED_POSITION_DESCRIPTION,
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 334181b..ccd90c4 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -462,9 +462,6 @@ WebPreferences RenderViewHostImpl::GetWebkitPrefs(const GURL& url) {
prefs.is_online = !net::NetworkChangeNotifier::IsOffline();
- prefs.fixed_position_creates_stacking_context = !command_line.HasSwitch(
- switches::kDisableFixedPositionCreatesStackingContext);
-
prefs.gesture_tap_highlight_enabled = !command_line.HasSwitch(
switches::kDisableGestureTapHighlight);
diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h
index 98c5a3b..86245ab 100644
--- a/content/public/common/common_param_traits_macros.h
+++ b/content/public/common/common_param_traits_macros.h
@@ -162,7 +162,6 @@ IPC_STRUCT_TRAITS_BEGIN(WebPreferences)
IPC_STRUCT_TRAITS_MEMBER(device_supports_mouse)
IPC_STRUCT_TRAITS_MEMBER(touch_adjustment_enabled)
IPC_STRUCT_TRAITS_MEMBER(pointer_events_max_touch_points)
- IPC_STRUCT_TRAITS_MEMBER(fixed_position_creates_stacking_context)
IPC_STRUCT_TRAITS_MEMBER(sync_xhr_in_documents_enabled)
IPC_STRUCT_TRAITS_MEMBER(deferred_image_decoding_enabled)
IPC_STRUCT_TRAITS_MEMBER(should_respect_image_orientation)
diff --git a/content/public/common/content_switches.cc b/content/public/common/content_switches.cc
index c9d2266..522629f 100644
--- a/content/public/common/content_switches.cc
+++ b/content/public/common/content_switches.cc
@@ -152,9 +152,6 @@ const char kDisableFileSystem[] = "disable-file-system";
// Disables sending filters (SkImageFilter objects) between processes over IPC
const char kDisableFiltersOverIPC[] = "disable-filters-over-ipc";
-const char kDisableFixedPositionCreatesStackingContext[]
- = "disable-fixed-position-creates-stacking-context";
-
// Disable 3D inside of flapper.
const char kDisableFlash3d[] = "disable-flash-3d";
@@ -399,9 +396,6 @@ const char kEnableFileCookies[] = "enable-file-cookies";
// Enable the fast text autosizing implementation.
const char kEnableFastTextAutosizing[] = "enable-fast-text-autosizing";
-const char kEnableFixedPositionCreatesStackingContext[]
- = "enable-fixed-position-creates-stacking-context";
-
// Enable Gesture Tap Highlight
const char kEnableGestureTapHighlight[] = "enable-gesture-tap-highlight";
diff --git a/content/public/common/content_switches.h b/content/public/common/content_switches.h
index 9816ce1..c24ee38 100644
--- a/content/public/common/content_switches.h
+++ b/content/public/common/content_switches.h
@@ -53,7 +53,6 @@ CONTENT_EXPORT extern const char kDisableExperimentalWebGL[];
CONTENT_EXPORT extern const char kDisableFastTextAutosizing[];
CONTENT_EXPORT extern const char kDisableFileSystem[];
CONTENT_EXPORT extern const char kDisableFiltersOverIPC[];
-CONTENT_EXPORT extern const char kDisableFixedPositionCreatesStackingContext[];
CONTENT_EXPORT extern const char kDisableFlash3d[];
CONTENT_EXPORT extern const char kDisableFlashStage3d[];
CONTENT_EXPORT extern const char kDisableGestureTapHighlight[];
@@ -117,7 +116,6 @@ CONTENT_EXPORT extern const char kEnableExperimentalCanvasFeatures[];
CONTENT_EXPORT extern const char kEnableExperimentalWebPlatformFeatures[];
CONTENT_EXPORT extern const char kEnableFastTextAutosizing[];
CONTENT_EXPORT extern const char kEnableFileCookies[];
-CONTENT_EXPORT extern const char kEnableFixedPositionCreatesStackingContext[];
CONTENT_EXPORT extern const char kEnableGestureTapHighlight[];
extern const char kEnableGpuClientTracing[];
CONTENT_EXPORT extern const char kEnableGpuRasterization[];
diff --git a/content/renderer/web_preferences.cc b/content/renderer/web_preferences.cc
index 26636f1..3500236 100644
--- a/content/renderer/web_preferences.cc
+++ b/content/renderer/web_preferences.cc
@@ -263,9 +263,6 @@ void ApplyWebPreferences(const WebPreferences& prefs, WebView* web_view) {
settings->setDeviceSupportsMouse(prefs.device_supports_mouse);
settings->setEnableTouchAdjustment(prefs.touch_adjustment_enabled);
- settings->setFixedPositionCreatesStackingContext(
- prefs.fixed_position_creates_stacking_context);
-
settings->setDeferredImageDecodingEnabled(
prefs.deferred_image_decoding_enabled);
settings->setShouldRespectImageOrientation(
diff --git a/content/shell/common/webkit_test_helpers.cc b/content/shell/common/webkit_test_helpers.cc
index 2f85496..91c1285 100644
--- a/content/shell/common/webkit_test_helpers.cc
+++ b/content/shell/common/webkit_test_helpers.cc
@@ -103,7 +103,6 @@ void ApplyLayoutTestDefaultPreferences(WebPreferences* prefs) {
command_line.HasSwitch(switches::kForceCompositingMode);
prefs->accelerated_compositing_for_video_enabled = false;
prefs->mock_scrollbars_enabled = false;
- prefs->fixed_position_creates_stacking_context = false;
prefs->smart_insert_delete_enabled = true;
prefs->minimum_accelerated_2d_canvas_size = 0;
#if defined(OS_ANDROID)
diff --git a/webkit/common/webpreferences.cc b/webkit/common/webpreferences.cc
index e18cd28..5cadc26 100644
--- a/webkit/common/webpreferences.cc
+++ b/webkit/common/webpreferences.cc
@@ -82,7 +82,6 @@ WebPreferences::WebPreferences()
device_supports_mouse(true),
touch_adjustment_enabled(true),
pointer_events_max_touch_points(0),
- fixed_position_creates_stacking_context(false),
sync_xhr_in_documents_enabled(true),
deferred_image_decoding_enabled(false),
should_respect_image_orientation(false),
diff --git a/webkit/common/webpreferences.h b/webkit/common/webpreferences.h
index f5dc458..2a01e96 100644
--- a/webkit/common/webpreferences.h
+++ b/webkit/common/webpreferences.h
@@ -131,7 +131,6 @@ struct WEBKIT_COMMON_EXPORT WebPreferences {
bool device_supports_mouse;
bool touch_adjustment_enabled;
int pointer_events_max_touch_points;
- bool fixed_position_creates_stacking_context;
bool sync_xhr_in_documents_enabled;
bool deferred_image_decoding_enabled;
bool should_respect_image_orientation;