diff options
author | r.karu <r.karu@samsung.com> | 2016-01-06 06:08:30 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-06 14:09:25 +0000 |
commit | 97260304e8db087e6641164a5539ed04b2bfb104 (patch) | |
tree | 49d14391b4cbe1f51dbca307d0b111063ac2b4fe | |
parent | 6d78097232f127f67d86c758225f12204629636c (diff) | |
download | chromium_src-97260304e8db087e6641164a5539ed04b2bfb104.zip chromium_src-97260304e8db087e6641164a5539ed04b2bfb104.tar.gz chromium_src-97260304e8db087e6641164a5539ed04b2bfb104.tar.bz2 |
[Predictor CleanUp] Remove unused variables from Predictor class APIs.
|local_state| no longer being used in Predictor. So it is safe to remove.
BUG=573994
Review URL: https://codereview.chromium.org/1558983002
Cr-Commit-Position: refs/heads/master@{#367818}
-rw-r--r-- | AUTHORS | 1 | ||||
-rw-r--r-- | chrome/browser/net/predictor.cc | 8 | ||||
-rw-r--r-- | chrome/browser/net/predictor.h | 12 | ||||
-rw-r--r-- | chrome/browser/profiles/profile_impl.cc | 1 | ||||
-rw-r--r-- | chrome/browser/profiles/profile_impl_io_data.cc | 3 | ||||
-rw-r--r-- | chrome/browser/profiles/profile_impl_io_data.h | 1 |
6 files changed, 8 insertions, 18 deletions
@@ -481,6 +481,7 @@ Ramkumar Ramachandra <artagnon@gmail.com> Ramya Vadlamudi <ramya.v@samsung.com> Randy Posynick <randy.posynick@gmail.com> Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> +Raveendra Karu <r.karu@samsung.com> Ravi Phaneendra Kasibhatla <r.kasibhatla@samsung.com> Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc index 799fa1a..ee5278c 100644 --- a/chrome/browser/net/predictor.cc +++ b/chrome/browser/net/predictor.cc @@ -188,7 +188,6 @@ void Predictor::RegisterProfilePrefs( // --------------------- Start UI methods. ------------------------------------ void Predictor::InitNetworkPredictor(PrefService* user_prefs, - PrefService* local_state, IOThread* io_thread, net::URLRequestContextGetter* getter, ProfileIOData* profile_io_data) { @@ -198,7 +197,7 @@ void Predictor::InitNetworkPredictor(PrefService* user_prefs, url_request_context_getter_ = getter; // Gather the list of hostnames to prefetch on startup. - UrlList urls = GetPredictedUrlListAtStartup(user_prefs, local_state); + UrlList urls = GetPredictedUrlListAtStartup(user_prefs); base::ListValue* referral_list = static_cast<base::ListValue*>(user_prefs->GetList( @@ -314,9 +313,7 @@ void Predictor::PreconnectUrlAndSubresources(const GURL& url, PredictFrameSubresources(url.GetWithEmptyPath(), first_party_for_cookies); } -UrlList Predictor::GetPredictedUrlListAtStartup( - PrefService* user_prefs, - PrefService* local_state) { +UrlList Predictor::GetPredictedUrlListAtStartup(PrefService* user_prefs) { DCHECK_CURRENTLY_ON(BrowserThread::UI); UrlList urls; // Recall list of URLs we learned about during last session. @@ -1299,7 +1296,6 @@ GURL Predictor::CanonicalizeUrl(const GURL& url) { void SimplePredictor::InitNetworkPredictor( PrefService* user_prefs, - PrefService* local_state, IOThread* io_thread, net::URLRequestContextGetter* getter, ProfileIOData* profile_io_data) { diff --git a/chrome/browser/net/predictor.h b/chrome/browser/net/predictor.h index 5f26701..53ea632 100644 --- a/chrome/browser/net/predictor.h +++ b/chrome/browser/net/predictor.h @@ -19,16 +19,15 @@ #ifndef CHROME_BROWSER_NET_PREDICTOR_H_ #define CHROME_BROWSER_NET_PREDICTOR_H_ +#include <stddef.h> +#include <stdint.h> + #include <map> #include <queue> #include <set> #include <string> #include <vector> -#include <stddef.h> - -#include <stdint.h> - #include "base/gtest_prod_util.h" #include "base/macros.h" #include "base/memory/scoped_ptr.h" @@ -137,7 +136,6 @@ class Predictor { // ------------- Start UI thread methods. virtual void InitNetworkPredictor(PrefService* user_prefs, - PrefService* local_state, IOThread* io_thread, net::URLRequestContextGetter* getter, ProfileIOData* profile_io_data); @@ -151,8 +149,7 @@ class Predictor { void PreconnectUrlAndSubresources(const GURL& url, const GURL& first_party_for_cookies); - static UrlList GetPredictedUrlListAtStartup(PrefService* user_prefs, - PrefService* local_state); + static UrlList GetPredictedUrlListAtStartup(PrefService* user_prefs); static void set_max_queueing_delay(int max_queueing_delay_ms); @@ -610,7 +607,6 @@ class SimplePredictor : public Predictor { : Predictor(preconnect_enabled, predictor_enabled) {} ~SimplePredictor() override {} void InitNetworkPredictor(PrefService* user_prefs, - PrefService* local_state, IOThread* io_thread, net::URLRequestContextGetter* getter, ProfileIOData* profile_io_data) override; diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc index c077e60..8503328 100644 --- a/chrome/browser/profiles/profile_impl.cc +++ b/chrome/browser/profiles/profile_impl.cc @@ -919,7 +919,6 @@ net::URLRequestContextGetter* ProfileImpl::CreateRequestContext( content::URLRequestInterceptorScopedVector request_interceptors) { return io_data_.CreateMainRequestContextGetter( protocol_handlers, std::move(request_interceptors), - g_browser_process->local_state(), g_browser_process->io_thread()) .get(); } diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc index 9667bdb..0cfe7e8 100644 --- a/chrome/browser/profiles/profile_impl_io_data.cc +++ b/chrome/browser/profiles/profile_impl_io_data.cc @@ -5,6 +5,7 @@ #include "chrome/browser/profiles/profile_impl_io_data.h" #include <set> +#include <string> #include <utility> #include "base/bind.h" @@ -223,7 +224,6 @@ scoped_refptr<ChromeURLRequestContextGetter> ProfileImplIOData::Handle::CreateMainRequestContextGetter( content::ProtocolHandlerMap* protocol_handlers, content::URLRequestInterceptorScopedVector request_interceptors, - PrefService* local_state, IOThread* io_thread) const { DCHECK_CURRENTLY_ON(BrowserThread::UI); LazyInitialize(); @@ -233,7 +233,6 @@ ProfileImplIOData::Handle::CreateMainRequestContextGetter( io_data_->predictor_ ->InitNetworkPredictor(profile_->GetPrefs(), - local_state, io_thread, main_request_context_getter_.get(), io_data_); diff --git a/chrome/browser/profiles/profile_impl_io_data.h b/chrome/browser/profiles/profile_impl_io_data.h index b924856..4647499 100644 --- a/chrome/browser/profiles/profile_impl_io_data.h +++ b/chrome/browser/profiles/profile_impl_io_data.h @@ -76,7 +76,6 @@ class ProfileImplIOData : public ProfileIOData { scoped_refptr<ChromeURLRequestContextGetter> CreateMainRequestContextGetter( content::ProtocolHandlerMap* protocol_handlers, content::URLRequestInterceptorScopedVector request_interceptors, - PrefService* local_state, IOThread* io_thread) const; scoped_refptr<ChromeURLRequestContextGetter> CreateIsolatedAppRequestContextGetter( |