summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-03 19:19:13 +0000
committerdglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-03 19:19:13 +0000
commit97cdd4667b961cf865047d0bc764764a7c199ce7 (patch)
tree161cef631ce9150c87082e3051387986070ea6f5
parent305968695d43301ac5e05979f15064e6a94d095c (diff)
downloadchromium_src-97cdd4667b961cf865047d0bc764764a7c199ce7.zip
chromium_src-97cdd4667b961cf865047d0bc764764a7c199ce7.tar.gz
chromium_src-97cdd4667b961cf865047d0bc764764a7c199ce7.tar.bz2
Add "File Bug" link to flakiness dashboard to ease filing new layout test regression bugs.
R=arv TEST=none BUG=none Review URL: http://codereview.chromium.org/563020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37997 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/tools/layout_tests/flakiness_dashboard.html19
1 files changed, 18 insertions, 1 deletions
diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html
index dc17c80..9269551 100644
--- a/webkit/tools/layout_tests/flakiness_dashboard.html
+++ b/webkit/tools/layout_tests/flakiness_dashboard.html
@@ -228,6 +228,10 @@
right: 0;
z-index: 1;
}
+ .file-bug {
+ font-weight: bold;
+ font-size: 11px;
+ }
</style>
<script src="dashboards/dashboard_base.js"></script>
@@ -1342,6 +1346,18 @@
function selectContents(element) {
window.getSelection().selectAllChildren(element);
}
+
+ function getCreateBugHTML(test) {
+ var symptom = test.isFlaky ? 'flaky' : 'failing';
+ var title = 'Layout Test ' + test.test + ' is ' + symptom;
+ var description = 'The following layout test is ' + symptom + ' on ' +
+ '[insert platform]\n\n' + test.test + '\n\nProbable cause:\n\n' +
+ '[insert probable cause]';
+ return bugUrlPrefix + 'code.google.com/p/chromium/issues/entry?' +
+ 'template=Layout%20Test%20Failure&summary=' +
+ encodeURIComponent(title) + '&comment=' +
+ encodeURIComponent(description) + '" class="file-bug">FILE BUG</a>';
+ }
function getHTMLForSingleTestRow(test, opt_isCrossBuilderView) {
if (!opt_isCrossBuilderView && shouldHideTest(test)) {
@@ -1364,7 +1380,8 @@
// TODO(ojan): If a test is a chrome/ or a pending/ test, point to
// src.chromium.org instead of trac.webkit.org.
'"><td class=test-link>' + testCellHTML +
- '</td><td class=options-container>' + test.bugsHTML +
+ '</td><td class=options-container>' +
+ (test.bugsHTML ? test.bugsHTML : getCreateBugHTML(test)) +
'</td><td class=options-container>' + test.modifiersHTML +
'</td><td class=options-container>' + test.expectationsHTML +
'</td><td>' + test.missing +