Linux: improve KDE proxy settings parsing and add unit tests for it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/176056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25320 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 419 insertions, 59 deletions

diff --git a/net/proxy/proxy_config_service_linux.cc b/net/proxy/proxy_config_service_linux.cc
index a3a9993..44e1cd7 100644
--- a/net/proxy/proxy_config_service_linux.cc
+++ b/net/proxy/proxy_config_service_linux.cc
@@ -266,7 +266,7 @@ class GConfSettingGetterImplGConf
     return true;
   }
 
-  MessageLoop* GetNotificationLoop() {
+  virtual MessageLoop* GetNotificationLoop() {
     return loop_;
   }
 
@@ -481,7 +481,7 @@ class GConfSettingGetterImplKDE
         MessageLoopForIO::WATCH_READ, &inotify_watcher_, this);
   }
 
-  MessageLoop* GetNotificationLoop() {
+  virtual MessageLoop* GetNotificationLoop() {
     return file_loop_;
   }
 
@@ -542,7 +542,7 @@ class GConfSettingGetterImplKDE
     string_table_[prefix + "host"] = value;
   }
 
-  void AddKDESetting(std::string key, const char* value) {
+  void AddKDESetting(const std::string& key, const std::string& value) {
     // The astute reader may notice that there is no mention of SOCKS
     // here. That's because KDE handles socks is a strange way, and we
     // don't support it. Rather than just a setting for the SOCKS server,
@@ -584,7 +584,7 @@ class GConfSettingGetterImplKDE
       // We count "true" or any nonzero number as true, otherwise false.
       // Note that if the value is not actually numeric StringToInt()
       // will return 0, which we count as false.
-      reversed_exception_ = !strcmp(value, "true") || StringToInt(value);
+      reversed_exception_ = value == "true" || StringToInt(value);
     } else if (key == "NoProxyFor") {
       std::vector<std::string> exceptions;
       StringTokenizer tk(value, ",");
@@ -654,11 +654,8 @@ class GConfSettingGetterImplKDE
     ResetCachedSettings();
     bool in_proxy_settings = false;
     bool line_too_long = false;
-    char line[512];
-    // feof() and ferror() only tell you if you have hit EOF or an error
-    // after you try to read some data that encounters that condition. So,
-    // the initialize statement of this loop is the same as the update
-    // statement. We need to start out each iteration with fgets().
+    char line[BUFFER_SIZE];
+    // fgets() will return NULL on EOF or error.
     while (fgets(line, sizeof(line), input.get())) {
       // fgets() guarantees the line will be properly terminated.
       size_t length = strlen(line);
@@ -687,26 +684,36 @@ class GConfSettingGetterImplKDE
         in_proxy_settings = !strncmp(line, "[Proxy Settings]", 16);
       } else if (in_proxy_settings) {
         // A regular line, in the (a?) proxy settings section.
-        char* value = strchr(line, '=');
-        if (!value)
+        char* split = strchr(line, '=');
+        // Skip this line if it does not contain an = sign.
+        if (!split)
           continue;
-        // The length of the value name.
-        length = value - line;
-        if (!length)
+        // Split the line on the = and advance |split|.
+        *(split++) = 0;
+        std::string key = line;
+        std::string value = split;
+        TrimWhitespaceASCII(key, TRIM_ALL, &key);
+        TrimWhitespaceASCII(value, TRIM_ALL, &value);
+        // Skip this line if the key name is empty.
+        if (key.empty())
           continue;
         // Is the value name localized?
-        if (line[length - 1] == ']') {
-          // Find the matching '['.
-          for (; length && line[length - 1] != '['; --length);
-          if (!length)
+        if (key[key.length() - 1] == ']') {
+          // Find the matching bracket.
+          length = key.rfind('[');
+          // Skip this line if the localization indicator is malformed.
+          if (length == std::string::npos)
             continue;
           // Trim the localization indicator off.
-          line[length - 1] = '\0';
+          key.resize(length);
+          // Remove any resulting trailing whitespace.
+          TrimWhitespaceASCII(key, TRIM_TRAILING, &key);
+          // Skip this line if the key name is now empty.
+          if (key.empty())
+            continue;
         }
-        // Split the string on the = sign, and advance |value| to the value.
-        *(value++) = '\0';
         // Now fill in the tables.
-        AddKDESetting(line, value);
+        AddKDESetting(key, value);
       }
     }
     if (ferror(input.get()))
@@ -1112,6 +1119,11 @@ ProxyConfigServiceLinux::ProxyConfigServiceLinux()
 }
 
 ProxyConfigServiceLinux::ProxyConfigServiceLinux(
+    base::EnvironmentVariableGetter* env_var_getter)
+    : delegate_(new Delegate(env_var_getter)) {
+}
+
+ProxyConfigServiceLinux::ProxyConfigServiceLinux(
     base::EnvironmentVariableGetter* env_var_getter,
     GConfSettingGetter* gconf_getter)
     : delegate_(new Delegate(env_var_getter, gconf_getter)) {
diff --git a/net/proxy/proxy_config_service_linux.h b/net/proxy/proxy_config_service_linux.h
index 1da3749..0c5ee4e 100644
--- a/net/proxy/proxy_config_service_linux.h
+++ b/net/proxy/proxy_config_service_linux.h
@@ -29,6 +29,10 @@ class ProxyConfigServiceLinux : public ProxyConfigService {
 
   class GConfSettingGetter {
    public:
+    // Buffer size used in some implementations of this class when reading
+    // files. Defined here so unit tests can construct worst-case inputs.
+    static const size_t BUFFER_SIZE = 512;
+
     virtual ~GConfSettingGetter() {}
 
     // Initializes the class: obtains a gconf client, or simulates one, in
@@ -194,7 +198,9 @@ class ProxyConfigServiceLinux : public ProxyConfigService {
 
   // Usual constructor
   ProxyConfigServiceLinux();
-  // For testing: takes alternate gconf and env var getter implementations.
+  // For testing: take alternate gconf and env var getter implementations.
+  explicit ProxyConfigServiceLinux(
+      base::EnvironmentVariableGetter* env_var_getter);
   ProxyConfigServiceLinux(base::EnvironmentVariableGetter* env_var_getter,
                           GConfSettingGetter* gconf_getter);
 
diff --git a/net/proxy/proxy_config_service_linux_unittest.cc b/net/proxy/proxy_config_service_linux_unittest.cc
index a83694c..4eed20f 100644
--- a/net/proxy/proxy_config_service_linux_unittest.cc
+++ b/net/proxy/proxy_config_service_linux_unittest.cc
@@ -8,6 +8,8 @@
 
 #include "net/proxy/proxy_config_service_linux.h"
 
+#include "base/file_path.h"
+#include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/task.h"
@@ -17,6 +19,7 @@
 #include "net/proxy/proxy_config_service_common_unittest.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
 
 namespace net {
 namespace {
@@ -26,7 +29,7 @@ namespace {
 struct EnvVarValues {
   // The strange capitalization is so that the field matches the
   // environment variable name exactly.
-  const char *DESKTOP_SESSION, *GNOME_DESKTOP_SESSION_ID, *KDE_FULL_SESSION,
+  const char *DESKTOP_SESSION, *KDE_HOME,
       *auto_proxy, *all_proxy,
       *http_proxy, *https_proxy, *ftp_proxy,
       *SOCKS_SERVER, *SOCKS_VERSION,
@@ -79,8 +82,7 @@ class MockEnvironmentVariableGetter : public base::EnvironmentVariableGetter {
   MockEnvironmentVariableGetter() {
 #define ENTRY(x) table.settings[#x] = &values.x
     ENTRY(DESKTOP_SESSION);
-    ENTRY(GNOME_DESKTOP_SESSION_ID);
-    ENTRY(KDE_FULL_SESSION);
+    ENTRY(KDE_HOME);
     ENTRY(auto_proxy);
     ENTRY(all_proxy);
     ENTRY(http_proxy);
@@ -226,6 +228,7 @@ class MockGConfSettingGetter
 // Some code duplicated from proxy_script_fetcher_unittest.cc.
 class SynchConfigGetter {
  public:
+  // Takes ownership of |config_service|.
   explicit SynchConfigGetter(net::ProxyConfigServiceLinux* config_service)
       : event_(false, false),
         io_thread_("IO_Thread"),
@@ -242,7 +245,10 @@ class SynchConfigGetter {
   }
 
   ~SynchConfigGetter() {
-    // Cleanup the IO thread.
+    // Let the config service post a destroy message to the IO thread
+    // before cleaning up that thread.
+    delete config_service_;
+    // Clean up the IO thread.
     io_thread_.message_loop()->PostTask(FROM_HERE, NewRunnableMethod(
         this, &SynchConfigGetter::Cleanup));
     Wait();
@@ -255,6 +261,7 @@ class SynchConfigGetter {
     MessageLoop* file_loop = io_thread_.message_loop();
     DCHECK_EQ(MessageLoop::TYPE_IO, file_loop->type());
     config_service_->Reset();
+    // We pass the mock IO thread as both the IO and file threads.
     config_service_->SetupAndFetchInitialConfig(
         MessageLoop::current(), io_thread_.message_loop(),
         static_cast<MessageLoopForIO*>(file_loop));
@@ -312,16 +319,42 @@ void RunnableMethodTraits<SynchConfigGetter>::ReleaseCallee(
 
 namespace net {
 
+// This test fixture is only really needed for the KDEConfigParser test case,
+// but all the test cases with the same prefix ("ProxyConfigServiceLinuxTest")
+// must use the same test fixture class (also "ProxyConfigServiceLinuxTest").
+class ProxyConfigServiceLinuxTest : public PlatformTest {
+ protected:
+  virtual void SetUp() {
+    PlatformTest::SetUp();
+    // Set up a temporary KDE home directory.
+    std::string prefix("ProxyConfigServiceLinuxTest_kde_home");
+    file_util::CreateNewTempDirectory(prefix, &kde_home_);
+    FilePath path = kde_home_.Append(FILE_PATH_LITERAL("share"));
+    file_util::CreateDirectory(path);
+    path = path.Append(FILE_PATH_LITERAL("config"));
+    file_util::CreateDirectory(path);
+    kioslaverc_ = path.Append(FILE_PATH_LITERAL("kioslaverc"));
+  }
+
+  virtual void TearDown() {
+    // Delete the temporary KDE home directory.
+    file_util::Delete(kde_home_, true);
+    PlatformTest::TearDown();
+  }
+
+  FilePath kde_home_;
+  FilePath kioslaverc_;
+};
+
 // Builds an identifier for each test in an array.
 #define TEST_DESC(desc) StringPrintf("at line %d <%s>", __LINE__, desc)
 
-TEST(ProxyConfigServiceLinuxTest, BasicGConfTest) {
+TEST_F(ProxyConfigServiceLinuxTest, BasicGConfTest) {
   MockEnvironmentVariableGetter* env_getter =
       new MockEnvironmentVariableGetter;
   MockGConfSettingGetter* gconf_getter = new MockGConfSettingGetter;
-  ProxyConfigServiceLinux service(env_getter, gconf_getter);
-  // This env var indicates we are running Gnome and should consult gconf.
-  env_getter->values.GNOME_DESKTOP_SESSION_ID = "defined";
+  SynchConfigGetter sync_config_getter(
+      new ProxyConfigServiceLinux(env_getter, gconf_getter));
 
   std::vector<std::string> empty_ignores;
 
@@ -559,8 +592,6 @@ TEST(ProxyConfigServiceLinuxTest, BasicGConfTest) {
     },
   };
 
-  SynchConfigGetter sync_config_getter(&service);
-
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
     SCOPED_TRACE(StringPrintf("Test[%d] %s", i, tests[i].description.c_str()));
     ProxyConfig config;
@@ -577,11 +608,12 @@ TEST(ProxyConfigServiceLinuxTest, BasicGConfTest) {
   }
 }
 
-TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
+TEST_F(ProxyConfigServiceLinuxTest, BasicEnvTest) {
   MockEnvironmentVariableGetter* env_getter =
       new MockEnvironmentVariableGetter;
   MockGConfSettingGetter* gconf_getter = new MockGConfSettingGetter;
-  ProxyConfigServiceLinux service(env_getter, gconf_getter);
+  SynchConfigGetter sync_config_getter(
+      new ProxyConfigServiceLinux(env_getter, gconf_getter));
 
   // Inspired from proxy_config_service_win_unittest.cc.
   const struct {
@@ -601,7 +633,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("No proxying"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         NULL,  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -620,8 +653,9 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Auto detect"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
-        "",  // auto_proxy
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
+        "",    // auto_proxy
         NULL,  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
         NULL, NULL,  // SOCKS
@@ -639,7 +673,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Valid PAC url"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         "http://wpad/wpad.dat",  // auto_proxy
         NULL,  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -658,7 +693,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Invalid PAC url"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         "wpad.dat",  // auto_proxy
         NULL,  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -677,7 +713,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Single-host in proxy list"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "www.google.com",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -696,7 +733,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Single-host, different port"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "www.google.com:99",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -715,7 +753,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Tolerate a scheme"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "http://www.google.com:99",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -734,10 +773,11 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("Per-scheme proxy rules"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         NULL,  // all_proxy
-        "www.google.com:80", "www.foo.com:110", "ftpfoo.com:121",  // per-proto
+        "www.google.com:80", "www.foo.com:110", "ftp.foo.com:121",  // per-proto
         NULL, NULL,  // SOCKS
         NULL,  // no_proxy
       },
@@ -746,7 +786,7 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
       false,                                   // auto_detect
       GURL(),                                  // pac_url
       MakeProxyPerSchemeRules("www.google.com", "www.foo.com:110",
-                              "ftpfoo.com:121"),
+                              "ftp.foo.com:121"),
       "",                                      // proxy_bypass_list
       false,                                   // bypass_local_names
     },
@@ -754,7 +794,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("socks"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -773,7 +814,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("socks5"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -792,7 +834,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("socks default port"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "",  // all_proxy
         NULL, NULL, NULL,  // per-proto proxies
@@ -811,7 +854,8 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     {
       TEST_DESC("bypass"),
       { // Input.
-        NULL, NULL, NULL,  // *DESKTOP*
+        NULL,  // DESKTOP_SESSION
+        NULL,  // KDE_HOME
         NULL,  // auto_proxy
         "www.google.com",  // all_proxy
         NULL, NULL, NULL,  // per-proto
@@ -828,8 +872,6 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
     },
   };
 
-  SynchConfigGetter sync_config_getter(&service);
-
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
     SCOPED_TRACE(StringPrintf("Test[%d] %s", i, tests[i].description.c_str()));
     ProxyConfig config;
@@ -846,16 +888,14 @@ TEST(ProxyConfigServiceLinuxTest, BasicEnvTest) {
   }
 }
 
-TEST(ProxyConfigServiceLinuxTest, GconfNotification) {
+TEST_F(ProxyConfigServiceLinuxTest, GconfNotification) {
   MockEnvironmentVariableGetter* env_getter =
       new MockEnvironmentVariableGetter;
   MockGConfSettingGetter* gconf_getter = new MockGConfSettingGetter;
-  ProxyConfigServiceLinux service(env_getter, gconf_getter);
+  ProxyConfigServiceLinux* service =
+      new ProxyConfigServiceLinux(env_getter, gconf_getter);
+  SynchConfigGetter sync_config_getter(service);
   ProxyConfig config;
-  SynchConfigGetter sync_config_getter(&service);
-
-  // Use gconf configuration.
-  env_getter->values.GNOME_DESKTOP_SESSION_ID = "defined";
 
   // Start with no proxy.
   gconf_getter->values.mode = "none";
@@ -866,9 +906,311 @@ TEST(ProxyConfigServiceLinuxTest, GconfNotification) {
   // Now set to auto-detect.
   gconf_getter->values.mode = "auto";
   // Simulate gconf notification callback.
-  service.OnCheckProxyConfigSettings();
+  service->OnCheckProxyConfigSettings();
   sync_config_getter.SyncGetProxyConfig(&config);
   EXPECT_TRUE(config.auto_detect);
 }
 
+TEST_F(ProxyConfigServiceLinuxTest, KDEConfigParser) {
+  MockEnvironmentVariableGetter* env_getter =
+      new MockEnvironmentVariableGetter;
+  // Force the KDE getter to be used and tell it where the test is.
+  env_getter->values.DESKTOP_SESSION = "kde";
+  env_getter->values.KDE_HOME = kde_home_.value().c_str();
+  SynchConfigGetter sync_config_getter(new ProxyConfigServiceLinux(env_getter));
+
+  // One of the tests below needs a worst-case long line prefix. We build it
+  // programmatically so that it will always be the right size.
+  std::string long_line;
+  size_t limit = ProxyConfigServiceLinux::GConfSettingGetter::BUFFER_SIZE - 1;
+  for (size_t i = 0; i < limit; ++i)
+    long_line += "-";
+
+  // Inspired from proxy_config_service_win_unittest.cc.
+  const struct {
+    // Short description to identify the test
+    std::string description;
+
+    // Input.
+    std::string kioslaverc;
+
+    // Expected outputs (fields of the ProxyConfig).
+    bool auto_detect;
+    GURL pac_url;
+    ProxyConfig::ProxyRules proxy_rules;
+    const char* proxy_bypass_list;  // newline separated
+    bool bypass_local_names;
+  } tests[] = {
+    {
+      TEST_DESC("No proxying"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=0\n",
+
+      // Expected result.
+      false,                      // auto_detect
+      GURL(),                     // pac_url
+      ProxyConfig::ProxyRules(),  // proxy_rules
+      "",                         // proxy_bypass_list
+      false,                      // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Auto detect"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=3\n",
+
+      // Expected result.
+      true,                       // auto_detect
+      GURL(),                     // pac_url
+      ProxyConfig::ProxyRules(),  // proxy_rules
+      "",                         // proxy_bypass_list
+      false,                      // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Valid PAC url"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=2\n"
+          "Proxy Config Script=http://wpad/wpad.dat\n",
+
+      // Expected result.
+      false,                         // auto_detect
+      GURL("http://wpad/wpad.dat"),  // pac_url
+      ProxyConfig::ProxyRules(),     // proxy_rules
+      "",                            // proxy_bypass_list
+      false,                         // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Per-scheme proxy rules"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "httpsProxy=www.foo.com\nftpProxy=ftp.foo.com\n",
+
+      // Expected result.
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "www.foo.com",
+                              "ftp.foo.com"),  // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Only HTTP proxy specified"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\n"
+          "httpProxy=www.google.com\n",
+
+      // Expected result.
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Only HTTP proxy specified, different port"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\n"
+          "httpProxy=www.google.com:88\n",
+
+      // Expected result.
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com:88",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Bypass *.google.com"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=*.google.com\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "*.google.com\n",                        // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Bypass *.google.com and *.kde.org"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=*.google.com,*.kde.org\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "*.google.com\n*.kde.org\n",             // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Ignore bypass list with ReversedException"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=*.google.com\nReversedException=true\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Allow trailing whitespace after boolean value"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "NoProxyFor=*.google.com\nReversedException=true  \n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Ignore settings outside [Proxy Settings]"),
+
+      // Input.
+      "httpsProxy=www.foo.com\n[Proxy Settings]\nProxyType=1\n"
+          "httpProxy=www.google.com\n[Other Section]\nftpProxy=ftp.foo.com\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Handle CRLF line endings"),
+
+      // Input.
+      "[Proxy Settings]\r\nProxyType=1\r\nhttpProxy=www.google.com\r\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Handle blank lines and mixed line endings"),
+
+      // Input.
+      "[Proxy Settings]\r\n\nProxyType=1\n\r\nhttpProxy=www.google.com\n\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Handle localized settings"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType[$e]=1\nhttpProxy[$e]=www.google.com\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", ""),         // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Ignore malformed localized settings"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType=1\nhttpProxy=www.google.com\n"
+          "httpsProxy$e]=www.foo.com\nftpProxy=ftp.foo.com\n",
+
+      false,                                   // auto_detect
+      GURL(),                                  // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", "ftp.foo.com"),  // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Handle strange whitespace"),
+
+      // Input.
+      "[Proxy Settings]\nProxyType [$e] =2\n"
+          "  Proxy Config Script =  http:// foo\n",
+
+      false,                                   // auto_detect
+      GURL("http:// foo"),                     // pac_url
+      ProxyConfig::ProxyRules(),               // proxy_rules
+      "",                                      // proxy_bypass_list
+      false,                                   // bypass_local_names
+    },
+
+    {
+      TEST_DESC("Ignore all of a line which is too long"),
+
+      // Input.
+      std::string("[Proxy Settings]\nProxyType=1\nftpProxy=ftp.foo.com\n") +
+          long_line + "httpsProxy=www.foo.com\nhttpProxy=www.google.com\n",
+
+      false,                                       // auto_detect
+      GURL(),                                      // pac_url
+      MakeProxyPerSchemeRules("www.google.com",
+                              "", "ftp.foo.com"),  // proxy_rules
+      "",                                          // proxy_bypass_list
+      false,                                       // bypass_local_names
+    },
+  };
+
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
+    SCOPED_TRACE(StringPrintf("Test[%d] %s", i, tests[i].description.c_str()));
+    ProxyConfig config;
+    // Overwrite the kioslaverc file.
+    file_util::WriteFile(kioslaverc_, tests[i].kioslaverc.c_str(),
+                         tests[i].kioslaverc.length());
+    sync_config_getter.SetupAndInitialFetch();
+    sync_config_getter.SyncGetProxyConfig(&config);
+
+    EXPECT_EQ(tests[i].auto_detect, config.auto_detect);
+    EXPECT_EQ(tests[i].pac_url, config.pac_url);
+    EXPECT_EQ(tests[i].proxy_bypass_list,
+              FlattenProxyBypass(config.proxy_bypass));
+    EXPECT_EQ(tests[i].bypass_local_names, config.proxy_bypass_local_names);
+    EXPECT_EQ(tests[i].proxy_rules, config.proxy_rules);
+  }
+}
+
 }  // namespace net