summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormichaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-13 03:39:02 +0000
committermichaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-13 03:39:02 +0000
commit9decd75f992e532b8bb5bc205d58dddab739277b (patch)
tree3610c0b8424d2da87eb74cc035a482a978babf40
parent2f076b0b0e2c7f9a02174aeeda67abceb567388e (diff)
downloadchromium_src-9decd75f992e532b8bb5bc205d58dddab739277b.zip
chromium_src-9decd75f992e532b8bb5bc205d58dddab739277b.tar.gz
chromium_src-9decd75f992e532b8bb5bc205d58dddab739277b.tar.bz2
Revert 194082 "url: Copy 'googleurl_unittests' target from 'url_..."
It's failing consistedly Win Builder (dbg) like this... 42>CustomBuild: 42> TEMPORARY: Copying url_unittests to googleurl_unittests 42> 'stat.S_IWUSR' is not recognized as an internal or external command, 42> operable program or batch file. 42>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error MSB6006: "cmd.exe" exited with code 255. 42> 42>Build FAILED. ... and i want to go home now. > url: Copy 'googleurl_unittests' target from 'url_unittests'. > > To not break the buildbot, this creates a fake target that copies url_unittests > to googleurl_unittests as temporary scaffolding. > > BUG=229660 > R=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14013003 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/14239004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194086 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--url/url.gyp95
1 files changed, 17 insertions, 78 deletions
diff --git a/url/url.gyp b/url/url.gyp
index 5fb317c..2359d8f 100644
--- a/url/url.gyp
+++ b/url/url.gyp
@@ -56,25 +56,23 @@
'FULL_FILESYSTEM_URL_SUPPORT=1',
],
'conditions': [
- ['component=="shared_library"',
- {
+ ['component=="shared_library"', {
+ 'defines': [
+ 'GURL_DLL',
+ 'GURL_IMPLEMENTATION=1',
+ ],
+ 'direct_dependent_settings': {
'defines': [
'GURL_DLL',
- 'GURL_IMPLEMENTATION=1',
],
- 'direct_dependent_settings': {
- 'defines': [
- 'GURL_DLL',
- ],
- },
- }
- ],
+ },
+ }],
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [4267, ],
},
{
- 'target_name': 'url_unittests',
+ 'target_name': 'googleurl_unittests',
'type': 'executable',
'dependencies': [
'url',
@@ -94,77 +92,18 @@
'FULL_FILESYSTEM_URL_SUPPORT=1',
],
'conditions': [
- ['os_posix==1 and OS!="mac" and OS!="ios"',
- {
- 'conditions': [
- ['linux_use_tcmalloc==1',
- {
- 'dependencies': [
- '../base/allocator/allocator.gyp:allocator',
- ],
- }
+ ['os_posix==1 and OS!="mac" and OS!="ios"', {
+ 'conditions': [
+ ['linux_use_tcmalloc==1', {
+ 'dependencies': [
+ '../base/allocator/allocator.gyp:allocator',
],
- ],
- }
- ],
+ }],
+ ],
+ }],
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [4267, ],
},
- {
- 'target_name': 'googleurl_unittests',
- 'type': 'none',
- 'dependencies': [
- 'url_unittests',
- ],
- 'conditions': [
- ['OS != "ios"',
- {
- 'actions': [
- {
- 'message': 'TEMPORARY: Copying url_unittests to googleurl_unittests',
- 'variables': {
- 'url_copy_target': '<(PRODUCT_DIR)/url_unittests<(EXECUTABLE_SUFFIX)',
- 'url_copy_dest': '<(PRODUCT_DIR)/googleurl_unittests<(EXECUTABLE_SUFFIX)',
- },
- 'inputs': ['<(url_copy_target)'],
- 'outputs': ['<(url_copy_dest)'],
- 'action_name': 'TEMP_copy_url_unittests',
- 'action': [
- 'python', '-c',
- 'import os, shutil, stat; ' \
- 'shutil.copyfile(\'<(url_copy_target)\', \'<(url_copy_dest)\'); ' \
- 'os.chmod(\'<(url_copy_dest)\', ' \
- 'stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)'
- ],
- },
- ],
- }
- ],
- ['OS == "ios"',
- {
- 'actions': [
- {
- 'message': 'TEMPORARY: Copying url_unittests to googleurl_unittests',
- 'variables': {
- 'url_copy_target': '<(PRODUCT_DIR)/url_unittests.app/url_unittests',
- 'url_copy_dest': '<(PRODUCT_DIR)/googleurl_unittests.app/googleurl_unittests',
- },
- 'inputs': ['<(url_copy_target)'],
- 'outputs': ['<(url_copy_dest)'],
- 'action_name': 'TEMP_copy_url_unittests',
- 'action': [
- 'python', '-c',
- 'import os, shutil, stat; ' \
- 'shutil.copyfile(\'<(url_copy_target)\', \'<(url_copy_dest)\'); ' \
- 'os.chmod(\'<(url_copy_dest)\', ' \
- 'stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)'
- ],
- },
- ],
- }
- ]
- ],
- },
],
}