diff options
| author | suderman@chromium.org <suderman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-21 05:37:12 +0000 |
|---|---|---|
| committer | suderman@chromium.org <suderman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-21 05:37:12 +0000 |
| commit | a023b8f96264fe1ca9ba0759020f307367451142 (patch) | |
| tree | 0463f7cf42dcd02825397eaddfeaaf87d022d254 | |
| parent | 0d364a9edbb5bb6412365749eb0118dc4072ddd7 (diff) | |
| download | chromium_src-a023b8f96264fe1ca9ba0759020f307367451142.zip chromium_src-a023b8f96264fe1ca9ba0759020f307367451142.tar.gz chromium_src-a023b8f96264fe1ca9ba0759020f307367451142.tar.bz2 | |
Removed Media.TimetoPipelineStarted histogram metrics as it was no longer providing a useful metric.
Changes
pipeline.cc - removed logging information and everything related to creation_time_
pipeline.h - removed creation_time_
histograms.xml - Media.PipelineStarted was marked as obsolete
BUG=245831
Review URL: https://codereview.chromium.org/343713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278932 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | media/base/pipeline.cc | 10 | ||||
| -rw-r--r-- | media/base/pipeline.h | 4 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 3 |
3 files changed, 4 insertions, 13 deletions
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc index 2884c38..ca015a7 100644 --- a/media/base/pipeline.cc +++ b/media/base/pipeline.cc @@ -50,8 +50,7 @@ Pipeline::Pipeline( text_ended_(false), audio_buffering_state_(BUFFERING_HAVE_NOTHING), video_buffering_state_(BUFFERING_HAVE_NOTHING), - demuxer_(NULL), - creation_time_(default_tick_clock_.NowTicks()) { + demuxer_(NULL) { media_log_->AddEvent(media_log_->CreatePipelineStateChangedEvent(kCreated)); media_log_->AddEvent( media_log_->CreateEvent(MediaLogEvent::PIPELINE_CREATED)); @@ -190,13 +189,6 @@ void Pipeline::SetErrorForTesting(PipelineStatus status) { } void Pipeline::SetState(State next_state) { - if (state_ != kPlaying && next_state == kPlaying && - !creation_time_.is_null()) { - UMA_HISTOGRAM_TIMES("Media.TimeToPipelineStarted", - default_tick_clock_.NowTicks() - creation_time_); - creation_time_ = base::TimeTicks(); - } - DVLOG(1) << GetStateString(state_) << " -> " << GetStateString(next_state); state_ = next_state; diff --git a/media/base/pipeline.h b/media/base/pipeline.h index b40cd3c..dab0255 100644 --- a/media/base/pipeline.h +++ b/media/base/pipeline.h @@ -426,10 +426,6 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost { PipelineStatistics statistics_; - // Time of pipeline creation; is non-zero only until the pipeline first - // reaches "kStarted", at which point it is used & zeroed out. - base::TimeTicks creation_time_; - scoped_ptr<SerialRunner> pending_callbacks_; base::ThreadChecker thread_checker_; diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index f480a43..4722179 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -10201,6 +10201,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. </histogram> <histogram name="Media.TimeToPipelineStarted" units="ms"> + <obsolete> + Removed from code 2014/6/18. + </obsolete> <owner>scherkus@chromium.org</owner> <summary> Time in milliseconds from HTML5 media pipeline creation to playing event. |