summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorthestig <thestig@chromium.org>2016-01-04 13:18:17 -0800
committerCommit bot <commit-bot@chromium.org>2016-01-04 21:19:27 +0000
commita45c0ddbd45a6a38f7a71d29304ceb8eb0a63222 (patch)
tree3a5fefb652d3a76a20e6f51680d3d84d67a35357
parent3bedcdc7ad86115836141f91ffd7fa331d07e2a1 (diff)
downloadchromium_src-a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222.zip
chromium_src-a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222.tar.gz
chromium_src-a45c0ddbd45a6a38f7a71d29304ceb8eb0a63222.tar.bz2
Simplify PDFiumEngine::GetFlattenedPrintData().
Review URL: https://codereview.chromium.org/1549013003 Cr-Commit-Position: refs/heads/master@{#367370}
-rw-r--r--pdf/pdfium/pdfium_engine.cc22
1 files changed, 5 insertions, 17 deletions
diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
index b049a14..ccee61a 100644
--- a/pdf/pdfium/pdfium_engine.cc
+++ b/pdf/pdfium/pdfium_engine.cc
@@ -1445,29 +1445,17 @@ pp::Buffer_Dev PDFiumEngine::PrintPagesAsRasterPDF(
}
pp::Buffer_Dev PDFiumEngine::GetFlattenedPrintData(const FPDF_DOCUMENT& doc) {
+ pp::Buffer_Dev buffer;
int page_count = FPDF_GetPageCount(doc);
- bool flatten_succeeded = true;
for (int i = 0; i < page_count; ++i) {
FPDF_PAGE page = FPDF_LoadPage(doc, i);
DCHECK(page);
- if (page) {
- int flatten_ret = FPDFPage_Flatten(page, FLAT_PRINT);
- FPDF_ClosePage(page);
- if (flatten_ret == FLATTEN_FAIL) {
- flatten_succeeded = false;
- break;
- }
- } else {
- flatten_succeeded = false;
- break;
- }
- }
- if (!flatten_succeeded) {
- FPDF_CloseDocument(doc);
- return pp::Buffer_Dev();
+ int flatten_ret = FPDFPage_Flatten(page, FLAT_PRINT);
+ FPDF_ClosePage(page);
+ if (flatten_ret == FLATTEN_FAIL)
+ return buffer;
}
- pp::Buffer_Dev buffer;
PDFiumMemBufferFileWrite output_file_write;
if (FPDF_SaveAsCopy(doc, &output_file_write, 0)) {
buffer = pp::Buffer_Dev(